Passed
Pull Request — master (#4596)
by
unknown
07:11
created
sources/tools.queries.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('tools') === false) {
71 71
     // Not allowed page
72 72
     $session->set('system-error_code', ERR_NOT_ALLOWED);
73
-    include $SETTINGS['cpassman_dir'] . '/error.php';
73
+    include $SETTINGS['cpassman_dir'].'/error.php';
74 74
     exit;
75 75
 }
76 76
 
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
         // Get PT_USER info
336 336
         $userInfo = DB::queryFirstRow(
337 337
             'SELECT pw, public_key, private_key, login, name
338
-            FROM ' . prefixTable('users') . '
338
+            FROM ' . prefixTable('users').'
339 339
             WHERE id = %i',
340 340
             TP_USER_ID
341 341
         );
@@ -372,8 +372,8 @@  discard block
 block discarded – undo
372 372
         // Get one itemKey from current user
373 373
         $currentUserKey = DB::queryFirstRow(
374 374
             'SELECT ski.share_key, ski.increment_id AS increment_id, l.id_user
375
-            FROM ' . prefixTable('sharekeys_items') . ' AS ski
376
-            INNER JOIN ' . prefixTable('log_items') . ' AS l ON ski.object_id = l.id_item
375
+            FROM ' . prefixTable('sharekeys_items').' AS ski
376
+            INNER JOIN ' . prefixTable('log_items').' AS l ON ski.object_id = l.id_item
377 377
             WHERE ski.user_id = %i
378 378
             ORDER BY RAND()
379 379
             LIMIT 1',
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
                 echo  prepareExchangedData(
393 393
                     array(
394 394
                         'error' => true,
395
-                        'message' => 'No issue found, normal process should work. This process is now finished. (item id : ' . $currentUserKey['increment_id'] . ')',
395
+                        'message' => 'No issue found, normal process should work. This process is now finished. (item id : '.$currentUserKey['increment_id'].')',
396 396
                     ),
397 397
                     'encode'
398 398
                 );
@@ -452,7 +452,7 @@  discard block
 block discarded – undo
452 452
         // Get user info
453 453
         $userInfo = DB::queryFirstRow(
454 454
             'SELECT public_key, private_key
455
-            FROM ' . prefixTable('users') . '
455
+            FROM ' . prefixTable('users').'
456 456
             WHERE id = %i',
457 457
             $userId
458 458
         );
@@ -475,8 +475,8 @@  discard block
 block discarded – undo
475 475
         // Get one itemKey from current user
476 476
         $currentUserKey = DB::queryFirstRow(
477 477
             'SELECT ski.share_key, ski.increment_id AS increment_id, l.id_user
478
-            FROM ' . prefixTable('sharekeys_items') . ' AS ski
479
-            INNER JOIN ' . prefixTable('log_items') . ' AS l ON ski.object_id = l.id_item
478
+            FROM ' . prefixTable('sharekeys_items').' AS ski
479
+            INNER JOIN ' . prefixTable('log_items').' AS l ON ski.object_id = l.id_item
480 480
             WHERE ski.user_id = %i
481 481
             ORDER BY RAND()
482 482
             LIMIT 1',
@@ -514,8 +514,8 @@  discard block
 block discarded – undo
514 514
                 // Get number of users to treat
515 515
                 DB::query(
516 516
                     'SELECT i.id 
517
-                    FROM ' . prefixTable('items') . ' AS i
518
-                    INNER JOIN ' . prefixTable('sharekeys_items') . ' AS si ON i.id = si.object_id
517
+                    FROM ' . prefixTable('items').' AS i
518
+                    INNER JOIN ' . prefixTable('sharekeys_items').' AS si ON i.id = si.object_id
519 519
                     WHERE i.perso = %i AND si.user_id = %i;',
520 520
                     0,
521 521
                     $userId
@@ -597,11 +597,11 @@  discard block
 block discarded – undo
597 597
             // Loop on items
598 598
             $rows = DB::query(
599 599
                 'SELECT si.object_id AS object_id, si.share_key AS share_key, i.pw AS pw, si.increment_id as increment_id
600
-                FROM ' . prefixTable('sharekeys_items') . ' AS si
601
-                INNER JOIN ' . prefixTable('items') . ' AS i ON (i.id = si.object_id)
600
+                FROM ' . prefixTable('sharekeys_items').' AS si
601
+                INNER JOIN ' . prefixTable('items').' AS i ON (i.id = si.object_id)
602 602
                 WHERE si.user_id = %i
603 603
                 ORDER BY si.increment_id ASC
604
-                LIMIT ' . $startIndex . ', ' . $limit,
604
+                LIMIT ' . $startIndex.', '.$limit,
605 605
                 $userId
606 606
             );        
607 607
             
@@ -625,7 +625,7 @@  discard block
 block discarded – undo
625 625
                     // It will be updated if already exists
626 626
                     $currentTPUserKey = DB::queryFirstRow(
627 627
                         'SELECT increment_id, user_id, share_key
628
-                        FROM ' . prefixTable('sharekeys_items') . '
628
+                        FROM ' . prefixTable('sharekeys_items').'
629 629
                         WHERE object_id = %i AND user_id = %i',
630 630
                         $record['object_id'],
631 631
                         TP_USER_ID
@@ -661,7 +661,7 @@  discard block
 block discarded – undo
661 661
             DB::commit();
662 662
         } catch (Exception $e) {
663 663
             DB::rollback();
664
-            error_log("Teampass - Error: Keys treatment: " . $e->getMessage());
664
+            error_log("Teampass - Error: Keys treatment: ".$e->getMessage());
665 665
         }
666 666
 
667 667
         $nextIndex = (int) $startIndex + (int) $limit;
@@ -717,7 +717,7 @@  discard block
 block discarded – undo
717 717
             // Get PT_USER info
718 718
             DB::queryFirstRow(
719 719
                 'SELECT operation_code
720
-                FROM ' . prefixTable('sharekeys_backup') . '
720
+                FROM ' . prefixTable('sharekeys_backup').'
721 721
                 WHERE operation_code = %s',
722 722
                 $operationCode
723 723
             );
@@ -727,7 +727,7 @@  discard block
 block discarded – undo
727 727
                 // using increment_id_value in order to update the correct record
728 728
                 $rows = DB::query(
729 729
                     'SELECT *
730
-                    FROM ' . prefixTable('sharekeys_backup') . '
730
+                    FROM ' . prefixTable('sharekeys_backup').'
731 731
                     WHERE operation_code = %s',
732 732
                     $operationCode
733 733
                 );
@@ -746,7 +746,7 @@  discard block
 block discarded – undo
746 746
 
747 747
                 // Delete all sharekeys for this operation
748 748
                 DB::query(
749
-                    'DELETE FROM ' . prefixTable('sharekeys_backup') . '
749
+                    'DELETE FROM '.prefixTable('sharekeys_backup').'
750 750
                     WHERE operation_code = %i',
751 751
                     $operationCode
752 752
                 );
@@ -809,7 +809,7 @@  discard block
 block discarded – undo
809 809
             // Get operation info
810 810
             DB::query(
811 811
                 'SELECT operation_code
812
-                FROM ' . prefixTable('sharekeys_backup') . '
812
+                FROM ' . prefixTable('sharekeys_backup').'
813 813
                 WHERE operation_code = %s',
814 814
                 $operationCode
815 815
             );
@@ -818,7 +818,7 @@  discard block
 block discarded – undo
818 818
             if ($nbKeys > 0) {
819 819
                 // Delete all sharekeys for this operation
820 820
                 DB::query(
821
-                    'DELETE FROM ' . prefixTable('sharekeys_backup') . '
821
+                    'DELETE FROM '.prefixTable('sharekeys_backup').'
822 822
                     WHERE operation_code = %s',
823 823
                     $operationCode
824 824
                 );
Please login to merge, or discard this patch.
sources/users.logs.datatable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 ) {
76 76
     // Not allowed page
77 77
     $session->set('system-error_code', ERR_NOT_ALLOWED);
78
-    include $SETTINGS['cpassman_dir'] . '/error.php';
78
+    include $SETTINGS['cpassman_dir'].'/error.php';
79 79
     exit;
80 80
 }
81 81
 
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     if (isset($order['column']) && preg_match('#^(asc|desc)$#i', $order['dir'])) {
146 146
         $columnIndex = $order['column'];
147 147
         $dir = $inputData['dir'];
148
-        $sOrder .= $aColumns[$columnIndex] . ' ' . $dir . ', ';
148
+        $sOrder .= $aColumns[$columnIndex].' '.$dir.', ';
149 149
     }
150 150
 
151 151
     $sOrder = substr_replace($sOrder, '', -2);
Please login to merge, or discard this patch.
sources/folders.class.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
         $parentComplexity = $this->checkComplexityLevel($parentFolderData, $complexity, $parent_id);
86 86
         if (isset($parentComplexity ['error']) && $parentComplexity['error'] === true) {
87
-            return $this->errorResponse($this->lang->get('error_folder_complexity_lower_than_top_folder') . " [<b>{$this->settings['TP_PW_COMPLEXITY'][$parentComplexity['valeur']][1]}</b>]");
87
+            return $this->errorResponse($this->lang->get('error_folder_complexity_lower_than_top_folder')." [<b>{$this->settings['TP_PW_COMPLEXITY'][$parentComplexity['valeur']][1]}</b>]");
88 88
         }
89 89
 
90 90
         return $this->createFolder($params, array_merge($parentFolderData, $parentComplexity));
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
         ) {
138 138
             DB::query(
139 139
                 'SELECT *
140
-                FROM ' . prefixTable('nested_tree') . '
140
+                FROM ' . prefixTable('nested_tree').'
141 141
                 WHERE title = %s AND personal_folder = 0',
142 142
                 $title
143 143
             );
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
         //check if parent folder is personal
162 162
         $data = DB::queryfirstrow(
163 163
             'SELECT personal_folder, bloquer_creation, bloquer_modification
164
-            FROM ' . prefixTable('nested_tree') . '
164
+            FROM ' . prefixTable('nested_tree').'
165 165
             WHERE id = %i',
166 166
             $parent_id
167 167
         );
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
             // get complexity level for this folder
201 201
             $data = DB::queryfirstrow(
202 202
                 'SELECT valeur
203
-                FROM ' . prefixTable('misc') . '
203
+                FROM ' . prefixTable('misc').'
204 204
                 WHERE intitule = %i AND type = %s',
205 205
                 $parent_id,
206 206
                 'complex'
@@ -251,11 +251,11 @@  discard block
 block discarded – undo
251 251
      */
252 252
     private function canCreateFolder($isPersonal, $user_is_admin, $user_is_manager, $user_can_manage_all_users, $user_can_create_root_folder)
253 253
     {
254
-        return (int)$isPersonal === 1 ||
255
-            (int)$user_is_admin === 1 ||
256
-            ((int)$user_is_manager === 1 || (int)$user_can_manage_all_users === 1) ||
254
+        return (int) $isPersonal === 1 ||
255
+            (int) $user_is_admin === 1 ||
256
+            ((int) $user_is_manager === 1 || (int) $user_can_manage_all_users === 1) ||
257 257
             ($this->settings['enable_user_can_create_folders'] ?? false) ||
258
-            ((int)$user_can_create_root_folder === 1);
258
+            ((int) $user_can_create_root_folder === 1);
259 259
     }
260 260
 
261 261
     /**
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
         $path = '';
336 336
         $tree_path = $tree->getPath(0, false);
337 337
         foreach ($tree_path as $fld) {
338
-            $path .= empty($path) ? $fld->title : '/' . $fld->title;
338
+            $path .= empty($path) ? $fld->title : '/'.$fld->title;
339 339
         }
340 340
 
341 341
         $new_json = [
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
             "is_visible_active" => 0,
350 350
         ];
351 351
 
352
-        $cache_tree = DB::queryFirstRow('SELECT increment_id, folders, visible_folders FROM ' . prefixTable('cache_tree') . ' WHERE user_id = %i', (int)$user_id);
352
+        $cache_tree = DB::queryFirstRow('SELECT increment_id, folders, visible_folders FROM '.prefixTable('cache_tree').' WHERE user_id = %i', (int) $user_id);
353 353
 
354 354
         if (empty($cache_tree)) {
355 355
             DB::insert(prefixTable('cache_tree'), [
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
                 'folders' => json_encode($folders),
370 370
                 'visible_folders' => json_encode($visible_folders),
371 371
                 'timestamp' => time(),
372
-            ], 'increment_id = %i', (int)$cache_tree['increment_id']);
372
+            ], 'increment_id = %i', (int) $cache_tree['increment_id']);
373 373
         }
374 374
     }
375 375
 
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
     private function manageFolderPermissions($parent_id, $newId, $user_roles, $access_rights, $user_is_admin)
380 380
     {
381 381
         if ($parent_id !== 0 && $this->settings['subfolder_rights_as_parent'] ?? false) {
382
-            $rows = DB::query('SELECT role_id, type FROM ' . prefixTable('roles_values') . ' WHERE folder_id = %i', $parent_id);
382
+            $rows = DB::query('SELECT role_id, type FROM '.prefixTable('roles_values').' WHERE folder_id = %i', $parent_id);
383 383
             foreach ($rows as $record) {
384 384
                 DB::insert(prefixTable('roles_values'), [
385 385
                     'role_id' => $record['role_id'],
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
                     'type' => $record['type'],
388 388
                 ]);
389 389
             }
390
-        } elseif ((int)$user_is_admin !== 1) {
390
+        } elseif ((int) $user_is_admin !== 1) {
391 391
             foreach (array_unique(explode(';', $user_roles)) as $role) {
392 392
                 if (!empty($role)) {
393 393
                     DB::insert(prefixTable('roles_values'), [
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
      */
406 406
     private function copyCustomFieldsCategories($parent_id, $newId)
407 407
     {
408
-        $rows = DB::query('SELECT id_category FROM ' . prefixTable('categories_folders') . ' WHERE id_folder = %i', $parent_id);
408
+        $rows = DB::query('SELECT id_category FROM '.prefixTable('categories_folders').' WHERE id_folder = %i', $parent_id);
409 409
         foreach ($rows as $record) {
410 410
             DB::insert(prefixTable('categories_folders'), [
411 411
                 'id_category' => $record['id_category'],
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
             // Search for existing job
431 431
             $count = DB::queryFirstRow(
432 432
                 'SELECT COUNT(*) AS count
433
-                FROM ' . prefixTable('background_tasks') . '
433
+                FROM ' . prefixTable('background_tasks').'
434 434
                 WHERE is_in_progress = %i AND process_type = %s AND arguments = %s',
435 435
                 0,
436 436
                 'user_build_cache_tree',
@@ -464,7 +464,7 @@  discard block
 block discarded – undo
464 464
         return [
465 465
             'error' => true,
466 466
             'message' => $message,
467
-            'newId' => '' . $newIdSuffix,
467
+            'newId' => ''.$newIdSuffix,
468 468
         ];
469 469
     }
470 470
 }
Please login to merge, or discard this patch.