nilsteampassnet / TeamPass

includes/libraries/Authentication/TwoFactorAuth/Providers/Qr/QRServerProvider.php

Doc Comments +3 added lines

@@ -51,6 +51,9 @@
         return $this->getContent($this->getUrl($qrtext, $size));
     }
     
+    /**
+     * @param string $value
+     */
     private function decodeColor($value) 
     {
         return vsprintf('%d-%d-%d', sscanf($value, "%02x%02x%02x"));

Braces +3 added lines, -2 removed lines

@@ -14,8 +14,9 @@
 
     function __construct($verifyssl = false, $errorcorrectionlevel = 'L', $margin = 4, $qzone = 1, $bgcolor = 'ffffff', $color = '000000', $format = 'png') 
     {
-        if (!is_bool($verifyssl))
-            throw new QRException('VerifySSL must be bool');
+        if (!is_bool($verifyssl)) {
+                    throw new QRException('VerifySSL must be bool');
+        }
 
         $this->verifyssl = $verifyssl;
         

includes/libraries/Authentication/TwoFactorAuth/TwoFactorAuth.php

Doc Comments +1 added lines

@@ -139,6 +139,7 @@
 
     /**
      * Get data-uri of QRCode
+     * @param string $label
      */
     public function getQRCodeImageAsDataUri($label, $secret, $size = 200)
     {

Braces +49 added lines, -31 removed lines

@@ -26,17 +26,20 @@ 
     function __construct($issuer = null, $digits = 6, $period = 30, $algorithm = 'sha1', IQRCodeProvider $qrcodeprovider = null, IRNGProvider $rngprovider = null, ITimeProvider $timeprovider = null)
     {
         $this->issuer = $issuer;
-        if (!is_int($digits) || $digits <= 0)
-            throw new TwoFactorAuthException('Digits must be int > 0');
+        if (!is_int($digits) || $digits <= 0) {
+                    throw new TwoFactorAuthException('Digits must be int > 0');
+        }
         $this->digits = $digits;
 
-        if (!is_int($period) || $period <= 0)
-            throw new TwoFactorAuthException('Period must be int > 0');
+        if (!is_int($period) || $period <= 0) {
+                    throw new TwoFactorAuthException('Period must be int > 0');
+        }
         $this->period = $period;
 
         $algorithm = strtolower(trim($algorithm));
-        if (!in_array($algorithm, self::$_supportedalgos))
-            throw new TwoFactorAuthException('Unsupported algorithm: ' . $algorithm);
+        if (!in_array($algorithm, self::$_supportedalgos)) {
+                    throw new TwoFactorAuthException('Unsupported algorithm: ' . $algorithm);
+        }
         $this->algorithm = $algorithm;
         $this->qrcodeprovider = $qrcodeprovider;
         $this->rngprovider = $rngprovider;
@@ -54,11 +57,14 @@ 
         $secret = '';
         $bytes = ceil($bits / 5);   //We use 5 bits of each byte (since we have a 32-character 'alphabet' / BASE32)
         $rngprovider = $this->getRngprovider();
-        if ($requirecryptosecure && !$rngprovider->isCryptographicallySecure())
-            throw new TwoFactorAuthException('RNG provider is not cryptographically secure');
+        if ($requirecryptosecure && !$rngprovider->isCryptographicallySecure()) {
+                    throw new TwoFactorAuthException('RNG provider is not cryptographically secure');
+        }
         $rnd = $rngprovider->getRandomBytes($bytes);
-        for ($i = 0; $i < $bytes; $i++)
-            $secret .= self::$_base32[ord($rnd[$i]) & 31];  //Mask out left 3 bits for 0-31 values
+        for ($i = 0; $i < $bytes; $i++) {
+                    $secret .= self::$_base32[ord($rnd[$i]) & 31];
+        }
+        //Mask out left 3 bits for 0-31 values
         return $secret;
     }
 
@@ -87,8 +93,9 @@ 
         $timetamp = $this->getTime($time);
 
         // To keep safe from timing-attachs we iterate *all* possible codes even though we already may have verified a code is correct
-        for ($i = -$discrepancy; $i <= $discrepancy; $i++)
-            $result |= $this->codeEquals($this->getCode($secret, $timetamp + ($i * $this->period)), $code);
+        for ($i = -$discrepancy; $i <= $discrepancy; $i++) {
+                    $result |= $this->codeEquals($this->getCode($secret, $timetamp + ($i * $this->period)), $code);
+        }
 
         return (bool)$result;
     }
@@ -104,8 +111,9 @@ 
         // we don't leak information about the difference of the two strings.
         if (strlen($safe)===strlen($user)) {
             $result = 0;
-            for ($i = 0; $i < strlen($safe); $i++)
-                $result |= (ord($safe[$i]) ^ ord($user[$i]));
+            for ($i = 0; $i < strlen($safe); $i++) {
+                            $result |= (ord($safe[$i]) ^ ord($user[$i]));
+            }
             return $result === 0;
         }
         return false;
@@ -116,8 +124,9 @@ 
      */
     public function getQRCodeImageAsDataUri($label, $secret, $size = 200)
     {
-        if (!is_int($size) || $size <= 0)
-            throw new TwoFactorAuthException('Size must be int > 0');
+        if (!is_int($size) || $size <= 0) {
+                    throw new TwoFactorAuthException('Size must be int > 0');
+        }
 
         $qrcodeprovider = $this->getQrCodeProvider();
         return 'data:'
@@ -131,26 +140,30 @@ 
      */
     public function ensureCorrectTime(array $timeproviders = null, $leniency = 5)
     {
-        if ($timeproviders != null && !is_array($timeproviders))
-            throw new TwoFactorAuthException('No timeproviders specified');
+        if ($timeproviders != null && !is_array($timeproviders)) {
+                    throw new TwoFactorAuthException('No timeproviders specified');
+        }
 
-        if ($timeproviders == null)
-            $timeproviders = array(
+        if ($timeproviders == null) {
+                    $timeproviders = array(
                 new Providers\Time\ConvertUnixTimeDotComTimeProvider(),
                 new Providers\Time\HttpTimeProvider()
             );
+        }
 
         // Get default time provider
         $timeprovider = $this->getTimeProvider();
 
         // Iterate specified time providers
         foreach ($timeproviders as $t) {
-            if (!($t instanceof ITimeProvider))
-                throw new TwoFactorAuthException('Object does not implement ITimeProvider');
+            if (!($t instanceof ITimeProvider)) {
+                            throw new TwoFactorAuthException('Object does not implement ITimeProvider');
+            }
 
             // Get time from default time provider and compare to specific time provider and throw if time difference is more than specified number of seconds leniency
-            if (abs($timeprovider->getTime() - $t->getTime()) > $leniency)
-                throw new TwoFactorAuthException(sprintf('Time for timeprovider is off by more than %d seconds when compared to %s', $leniency, get_class($t)));
+            if (abs($timeprovider->getTime() - $t->getTime()) > $leniency) {
+                            throw new TwoFactorAuthException(sprintf('Time for timeprovider is off by more than %d seconds when compared to %s', $leniency, get_class($t)));
+            }
         }
     }
 
@@ -179,23 +192,28 @@ 
 
     private function base32Decode($value)
     {
-        if (strlen($value)==0) return '';
+        if (strlen($value)==0) {
+            return '';
+        }
 
-        if (preg_match('/[^'.preg_quote(self::$_base32dict).']/', $value) !== 0)
-            throw new TwoFactorAuthException('Invalid base32 string');
+        if (preg_match('/[^'.preg_quote(self::$_base32dict).']/', $value) !== 0) {
+                    throw new TwoFactorAuthException('Invalid base32 string');
+        }
 
         $buffer = '';
         foreach (str_split($value) as $char)
         {
-            if ($char !== '=')
-                $buffer .= str_pad(decbin(self::$_base32lookup[$char]), 5, 0, STR_PAD_LEFT);
+            if ($char !== '=') {
+                            $buffer .= str_pad(decbin(self::$_base32lookup[$char]), 5, 0, STR_PAD_LEFT);
+            }
         }
         $length = strlen($buffer);
         $blocks = trim(chunk_split(substr($buffer, 0, $length - ($length % 8)), 8, ' '));
 
         $output = '';
-        foreach (explode(' ', $blocks) as $block)
-            $output .= chr(bindec(str_pad($block, 8, 0, STR_PAD_RIGHT)));
+        foreach (explode(' ', $blocks) as $block) {
+                    $output .= chr(bindec(str_pad($block, 8, 0, STR_PAD_RIGHT)));
+        }
         return $output;
     }
 

includes/libraries/Email/Phpmailer/class.pop3.php

Doc Comments +1 added lines, -1 removed lines

@@ -200,7 +200,7 @@
      * Connect to a POP3 server.
      * @access public
      * @param string $host
-     * @param integer|boolean $port
+     * @param integer $port
      * @param integer $tval
      * @return boolean
      */

includes/libraries/protect/AntiXSS/AntiXSS.php

Doc Comments +1 added lines, -1 removed lines

@@ -1912,7 +1912,7 @@
   /**
    * @param string $str
    *
-   * @return mixed
+   * @return string
    */
   private function _do($str)
   {

includes/libraries/protect/AntiXSS/UTF8.php

Doc Comments +8 added lines, -8 removed lines

@@ -2821,7 +2821,7 @@ 
   /**
    * Check if the input is binary... (is look like a hack).
    *
-   * @param mixed $input
+   * @param string $input
    *
    * @return bool
    */
@@ -5795,7 +5795,7 @@ 
    * @link http://php.net/manual/en/function.mb-strrpos.php
    *
    * @param string     $haystack  <p>The string being checked, for the last occurrence of needle</p>
-   * @param string|int $needle    <p>The string to find in haystack.<br />Or a code point as int.</p>
+   * @param string $needle    <p>The string to find in haystack.<br />Or a code point as int.</p>
    * @param int        $offset    [optional] <p>May be specified to begin searching an arbitrary number of characters
    *                              into the string. Negative values will stop searching at an arbitrary point prior to
    *                              the end of the string.
@@ -6296,7 +6296,7 @@ 
    * @param string  $encoding  [optional] <p>Default is UTF-8</p>
    * @param boolean $cleanUtf8 [optional] <p>Remove non UTF-8 chars from the string.</p>
    *
-   * @return string|false <p>The portion of <i>str</i> specified by the <i>offset</i> and
+   * @return string <p>The portion of <i>str</i> specified by the <i>offset</i> and
    *                      <i>length</i> parameters.</p><p>If <i>str</i> is shorter than <i>offset</i>
    *                      characters long, <b>FALSE</b> will be returned.</p>
    */
@@ -6630,16 +6630,16 @@ 
    *
    * source: https://gist.github.com/stemar/8287074
    *
-   * @param string|string[] $str              <p>The input string or an array of stings.</p>
-   * @param string|string[] $replacement      <p>The replacement string or an array of stings.</p>
-   * @param int|int[]       $offset           <p>
+   * @param string $str              <p>The input string or an array of stings.</p>
+   * @param string $replacement      <p>The replacement string or an array of stings.</p>
+   * @param integer       $offset           <p>
    *                                          If start is positive, the replacing will begin at the start'th offset
    *                                          into string.
    *                                          <br /><br />
    *                                          If start is negative, the replacing will begin at the start'th character
    *                                          from the end of string.
    *                                          </p>
-   * @param int|int[]|void  $length           [optional] <p>If given and is positive, it represents the length of the
+   * @param integer  $length           [optional] <p>If given and is positive, it represents the length of the
    *                                          portion of string which is to be replaced. If it is negative, it
    *                                          represents the number of characters from the end of string at which to
    *                                          stop replacing. If it is not given, then it will default to strlen(
@@ -7079,7 +7079,7 @@ 
    * case.</li>
    * </ul>
    *
-   * @param string|string[] $str                    <p>Any string or array.</p>
+   * @param string $str                    <p>Any string or array.</p>
    * @param bool            $decodeHtmlEntityToUtf8 <p>Set to true, if you need to decode html-entities.</p>
    *
    * @return string|string[] <p>The UTF-8 encoded string.</p>

install/js/crypt/aes.class.php

Doc Comments -1 removed lines

@@ -90,7 +90,6 @@
     }
 
     /**
-     * @param integer $Nb
      */
     private static function mixColumns($s) {   // combine bytes of each col of state S [é5.1.3]
     for ($c = 0; $c < 4; $c++) {

includes/libraries/Tree/NestedTree/NestedTree.php

Doc Comments -2 removed lines

@@ -174,7 +174,6 @@ 
      * Fetch the children of a node, or if no node is specified, fetch the
      * top level items.
      *
-     * @param int  $id          The ID of the node to fetch child data for.
      * @param bool $includeSelf Whether or not to include the passed node in the
      *                                  the results.
      * @return array The children of the passed node
@@ -441,7 +440,6 @@ 
      *                              be able to update the data in it
      * @param int     $folder_id    The ID of the current node to process
      * @param int     $fld_level    The nlevel to assign to the current node
-     * @param int     $n_tally      A reference to the running tally for the n-value
      * @param integer $n
      */
     public function generateTreeData(&$arr, $folder_id, $fld_level, &$n_tally)

includes/libraries/Authentication/TwoFactorAuth/Providers/Rng/MCryptRNGProvider.php

Braces +3 added lines, -2 removed lines

@@ -13,8 +13,9 @@
     
     public function getRandomBytes($bytecount) {
         $result = mcrypt_create_iv($bytecount, $this->source);
-        if ($result === false)
-            throw new \RNGException('mcrypt_create_iv returned an invalid value');
+        if ($result === false) {
+                    throw new \RNGException('mcrypt_create_iv returned an invalid value');
+        }
         return $result;
     }
     

includes/libraries/Authentication/TwoFactorAuth/Providers/Rng/HashRNGProvider.php

Braces +3 added lines, -2 removed lines

@@ -8,8 +8,9 @@
     
     function __construct($algorithm = 'sha256' ) {
         $algos = array_values(hash_algos());
-        if (!in_array($algorithm, $algos, true))
-            throw new \RNGException('Unsupported algorithm specified');
+        if (!in_array($algorithm, $algos, true)) {
+                    throw new \RNGException('Unsupported algorithm specified');
+        }
         $this->algorithm = $algorithm;
     }