nilsteampassnet / TeamPass

sources/main.functions.php

Braces +24 added lines, -11 removed lines

@@ -2366,7 +2366,9 @@ 
 function encryptUserObjectKey(string $key, string $publicKey): string
 {
     // Empty password
-    if (empty($key)) return '';
+    if (empty($key)) {
+        return '';
+    }
 
     // Sanitize
     $antiXss = new AntiXSS();
@@ -2515,7 +2517,9 @@ 
         ];
     }
 
-    if (WIP) error_log('DEBUG: File image url -> '.filter_var($safeFilePath, FILTER_SANITIZE_URL));
+    if (WIP) {
+        error_log('DEBUG: File image url -> '.filter_var($safeFilePath, FILTER_SANITIZE_URL));
+    }
 
     // Decrypt file content and return
     return base64_encode($cipher->decrypt($ciphertext));
@@ -2650,7 +2654,9 @@ 
         foreach ($users as $user) {
             // Insert in DB the new object key for this item by user
             if (count($objectKeyArray) === 0) {
-                if (WIP === true) error_log('TEAMPASS Debug - storeUsersShareKey case1 - ' . $object_name . ' - ' . $post_object_id . ' - ' . $user['id'] . ' - ' . $objectKey);
+                if (WIP === true) {
+                    error_log('TEAMPASS Debug - storeUsersShareKey case1 - ' . $object_name . ' - ' . $post_object_id . ' - ' . $user['id'] . ' - ' . $objectKey);
+                }
                 DB::insert(
                     $object_name,
                     [
@@ -2664,7 +2670,9 @@ 
                 );
             } else {
                 foreach ($objectKeyArray as $object) {
-                    if (WIP === true) error_log('TEAMPASS Debug - storeUsersShareKey case2 - ' . $object_name . ' - ' . $object['objectId'] . ' - ' . $user['id'] . ' - ' . $object['objectKey']);
+                    if (WIP === true) {
+                        error_log('TEAMPASS Debug - storeUsersShareKey case2 - ' . $object_name . ' - ' . $object['objectId'] . ' - ' . $user['id'] . ' - ' . $object['objectKey']);
+                    }
                     DB::insert(
                         $object_name,
                         [
@@ -3990,7 +3998,9 @@ 
         $taskName = [$taskName];
     }
     foreach($taskName as $task) {
-        if (WIP === true) error_log('createTaskForItem - task: '.$task);
+        if (WIP === true) {
+            error_log('createTaskForItem - task: '.$task);
+        }
         switch ($task) {
             case 'item_password':
                 
@@ -4421,19 +4431,22 @@ 
 
             // Organisation name (removed username@ and .tld)
             $domain = explode('.', $emailParts[1]);
-            if (count($domain) > 1)
-                $forbiddenWords[] = $domain[0];
+            if (count($domain) > 1) {
+                            $forbiddenWords[] = $domain[0];
+            }
         }
     }
 
     // Search forbidden words in password
     foreach ($forbiddenWords as $word) {
-        if (empty($word))
-            continue;
+        if (empty($word)) {
+                    continue;
+        }
 
         // Stop if forbidden word found in password
-        if (stripos($password, $word) !== false)
-            return false;
+        if (stripos($password, $word) !== false) {
+                    return false;
+        }
     }
 
     // Get password complexity

sources/folders.class.php

Braces +6 added lines, -4 removed lines

@@ -112,8 +112,9 @@ 
      */
     private function isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin, $user_can_create_root_folder)
     {
-        if ($parent_id == 0 && $user_can_create_root_folder == true)
-	    return true;
+        if ($parent_id == 0 && $user_can_create_root_folder == true) {
+        	    return true;
+        }
 
         if (in_array($parent_id, $user_accessible_folders) === false
             && (int) $user_is_admin !== 1
@@ -438,8 +439,9 @@ 
             )['count'];
 
             // Don't insert duplicates
-            if ($count > 0)
-                continue;
+            if ($count > 0) {
+                            continue;
+            }
 
             // Insert new background task
             DB::insert(

sources/items.queries.php

Braces +21 added lines, -8 removed lines

@@ -1228,7 +1228,9 @@ 
                 );
 
                 // Create a task to create sharekeys for users
-                if (WIP=== true) error_log('createTaskForItem - new password for this item - '.$post_password ." -- ". $pw);
+                if (WIP=== true) {
+                    error_log('createTaskForItem - new password for this item - '.$post_password ." -- ". $pw);
+                }
                 $tasksToBePerformed = ['item_password'];
                 $encryptionTaskIsRequested = true;
             } else {
@@ -1548,7 +1550,9 @@ 
 
             // create a task for all fields updated
             if ($encryptionTaskIsRequested === true) {
-                if (WIP === true) error_log('createTaskForItem - '.print_r($tasksToBePerformed, true));
+                if (WIP === true) {
+                    error_log('createTaskForItem - '.print_r($tasksToBePerformed, true));
+                }
                 createTaskForItem(
                     'item_update_create_keys',
                     array_unique($tasksToBePerformed),
@@ -2055,7 +2059,9 @@ 
                 $inputData['itemId']
             );
             foreach ($rows as $record) {
-                if ($record['raison'] === NULL) continue;
+                if ($record['raison'] === NULL) {
+                    continue;
+                }
                 $reason = explode(':', $record['raison']);
                 if (count($reason) > 0) {
                     $sentence = date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['date']) . ' - '
@@ -4571,7 +4577,9 @@ 
                 $inputData['itemId']
             );
             
-            if (WIP === true) error_log('Existing edition locks: '.DB::count());
+            if (WIP === true) {
+                error_log('Existing edition locks: '.DB::count());
+            }
 
             // Check if item has no edition lock
             if ((int) DB::count() > 0 ) {
@@ -4584,7 +4592,9 @@ 
                 } else {
                     $delay = EDITION_LOCK_PERIOD; // One day delay
                 }
-                if (WIP === true) error_log('delay: ' . $delay);
+                if (WIP === true) {
+                    error_log('delay: ' . $delay);
+                }
 
                 // We remove old edition locks if delay is expired meaning more than 1 day long
                 if (round(abs(time() - $dataTmp['timestamp']),0) > $delay) {
@@ -4592,7 +4602,9 @@ 
                     // In this case, delete edition lock and possible ongoing processes
                     // and continue editing this time
                     // We coonsidere if the most recent item is still locked then all other locks can be removed
-                    if (WIP === true)  error_log('Delay is expired, removing old locks');
+                    if (WIP === true) {
+                        error_log('Delay is expired, removing old locks');
+                    }
                     foreach ($dataItemEditionLocks as $itemEditionLock) {
                         // delete lock
                         DB::delete(
@@ -4859,8 +4871,9 @@ 
                 $ids = $tree->getDescendants($folder['id'], true, false, true);
 
                 // This folder is owned by user
-                if (in_array($inputData['folderId'], $ids))
-                    $accessLevel = 30;
+                if (in_array($inputData['folderId'], $ids)) {
+                                    $accessLevel = 30;
+                }
             }
         }
 

_things/delete_background_tasks___items_handler.php

Braces +15 added lines, -6 removed lines

@@ -83,7 +83,9 @@ 
 
 if (DB::count() > 0) {
     // handle tasks inside this process
-    if (WIP === true) error_log("Process in progress: ".$process_to_perform['increment_id']);
+    if (WIP === true) {
+        error_log("Process in progress: ".$process_to_perform['increment_id']);
+    }
     handleTask(
         $process_to_perform['increment_id'],
         json_decode($process_to_perform['arguments'], true),
@@ -100,7 +102,9 @@ 
     );
     
     if (DB::count() > 0) {
-        if (WIP === true) error_log("New process ta start: ".$process_to_perform['increment_id']);
+        if (WIP === true) {
+            error_log("New process ta start: ".$process_to_perform['increment_id']);
+        }
         // update DB - started_at
         DB::update(
             prefixTable('background_tasks'),
@@ -153,8 +157,9 @@ 
         );
 
         // No more tasks, exit
-        if ($process_to_perform !== 1)
-            break;
+        if ($process_to_perform !== 1) {
+                    break;
+        }
 
         // Run next task
         $process = new Symfony\Component\Process\Process([
@@ -331,7 +336,9 @@ 
     if ($args['step'] === 'create_users_files_key') {
         // Loop on all files for this item
         // and encrypt them for each user
-        if (WIP === true) provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+        if (WIP === true) {
+            provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+        }
         foreach($args['files_keys'] as $file) {
             storeUsersShareKey(
                 prefixTable('sharekeys_items'),
@@ -347,7 +354,9 @@ 
     } elseif ($args['step'] === 'create_users_fields_key') {
         // Loop on all encrypted fields for this item
         // and encrypt them for each user
-        if (WIP === true) provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+        if (WIP === true) {
+            provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+        }
         foreach($args['fields_keys'] as $field) {
             storeUsersShareKey(
                 prefixTable('sharekeys_fields'),

_things/delete_background_tasks___user_task.php

Braces +3 added lines, -2 removed lines

@@ -77,8 +77,9 @@
     );
 
     // No more pending user_build_cache_tree tasks
-    if (DB::count() === 0)
-        exit;
+    if (DB::count() === 0) {
+            exit;
+    }
 
     // get email properties
     $arguments = json_decode($record['arguments'], true);

_things/delete_background_tasks___items_handler_subtask.php

Braces +6 added lines, -2 removed lines

@@ -74,7 +74,9 @@ 
 if ($args['step'] === 'create_users_files_key') {
     // Loop on all files for this item
     // and encrypt them for each user
-    if (WIP === true) provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+    if (WIP === true) {
+        provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+    }
     foreach($args['files_keys'] as $file) {
         storeUsersShareKey(
             prefixTable('sharekeys_items'),
@@ -91,7 +93,9 @@ 
 } elseif ($args['step'] === 'create_users_fields_key') {
     // Loop on all encrypted fields for this item
     // and encrypt them for each user
-    if (WIP === true) provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+    if (WIP === true) {
+        provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+    }
     foreach($args['fields_keys'] as $field) {
         storeUsersShareKey(
             prefixTable('sharekeys_fields'),

scripts/traits/UserHandlerTrait.php

Braces +9 added lines, -3 removed lines

@@ -54,13 +54,17 @@ 
         );
     
         if (empty($subtasks)) {
-            if (LOG_TASKS=== true) $this->logger->log("No subtask was found for task {$this->taskId}");
+            if (LOG_TASKS=== true) {
+                $this->logger->log("No subtask was found for task {$this->taskId}");
+            }
             return;
         }
     
         // Process each subtask
         foreach ($subtasks as $subtask) {
-            if (LOG_TASKS=== true) $this->logger->log("Processing subtask {$subtask['increment_id']} for task {$this->taskId}");
+            if (LOG_TASKS=== true) {
+                $this->logger->log("Processing subtask {$subtask['increment_id']} for task {$this->taskId}");
+            }
             $this->processGenerateUserKeysSubtask($subtask, $arguments);
         }
     
@@ -97,7 +101,9 @@ 
                 $subtask['increment_id']
             );
             
-            if (LOG_TASKS=== true) $this->logger->log("Subtask is in progress: ".$taskData['step'], 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log("Subtask is in progress: ".$taskData['step'], 'INFO');
+            }
             switch ($taskData['step'] ?? '') {
                 case 'step0':
                     $this->generateNewUserStep0($arguments);

scripts/traits/ItemHandlerTrait.php

Braces +9 added lines, -3 removed lines

@@ -29,7 +29,9 @@ 
 trait ItemHandlerTrait {    
 
     private function generateUserPasswordKeys($arguments) {
-        if (LOG_TASKS=== true) $this->logger->log('Processing generateUserPasswordKeys : '.print_r($arguments, true), 'DEBUG');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Processing generateUserPasswordKeys : '.print_r($arguments, true), 'DEBUG');
+        }
         // Generate keys for user passwords   
         storeUsersShareKey(
             prefixTable('sharekeys_items'),
@@ -49,7 +51,9 @@ 
      * @param array $taskData
      */
     private function generateUserFileKeys($taskData) {    
-        if (LOG_TASKS=== true) $this->logger->log('Processing generateUserFileKeys : '.print_r($taskData, true), 'DEBUG');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Processing generateUserFileKeys : '.print_r($taskData, true), 'DEBUG');
+        }
         foreach($taskData['files_keys'] as $file) {
             storeUsersShareKey(
                 prefixTable('sharekeys_files'),
@@ -70,7 +74,9 @@ 
      * @param array $arguments
      */
     private function generateUserFieldKeys($arguments) {
-        if (LOG_TASKS=== true) $this->logger->log('Processing generateUserFieldKeys : '.print_r($arguments, true), 'DEBUG');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Processing generateUserFieldKeys : '.print_r($arguments, true), 'DEBUG');
+        }
         foreach($arguments['fields_keys'] as $field) {
             $this->logger->log('Processing generateUserFieldKeys for: ' . $field['object_id'], 'DEBUG');
             storeUsersShareKey(

scripts/background_tasks___handler.php

Braces +18 added lines, -6 removed lines

@@ -55,7 +55,9 @@ 
     public function processBackgroundTasks() {
         // Prevent multiple concurrent executions
         if (!$this->acquireProcessLock()) {
-            if (LOG_TASKS=== true) $this->logger->log('Process already running', 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Process already running', 'INFO');
+            }
             return false;
         }
 
@@ -64,7 +66,9 @@ 
             $this->processTaskBatches();
             $this->performMaintenanceTasks();
         } catch (Exception $e) {
-            if (LOG_TASKS=== true) $this->logger->log('Task processing error: ' . $e->getMessage(), 'ERROR');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Task processing error: ' . $e->getMessage(), 'ERROR');
+            }
         } finally {
             $this->releaseProcessLock();
         }
@@ -131,7 +135,9 @@ 
         
         // Check if the maximum number of parallel tasks is reached
         if ($runningTasks >= $this->maxParallelTasks) {
-            if (LOG_TASKS=== true) $this->logger->log('Wait ... '.$runningTasks.' out of '.$this->maxParallelTasks.' are already running ', 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Wait ... '.$runningTasks.' out of '.$this->maxParallelTasks.' are already running ', 'INFO');
+            }
             return;
         }
 
@@ -149,7 +155,9 @@ 
         );
 
         foreach ($tasks as $task) {
-            if (LOG_TASKS=== true) $this->logger->log('Launching '.$task['increment_id'], 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Launching '.$task['increment_id'], 'INFO');
+            }
             $this->processIndividualTask($task);
         }
     }
@@ -160,7 +168,9 @@ 
      * @param array $task The task to process.
      */
     private function processIndividualTask(array $task) {
-        if (LOG_TASKS=== true)  $this->logger->log('Processing task: ' . print_r($task, true), 'INFO');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Processing task: ' . print_r($task, true), 'INFO');
+        }
 
         // Store progress in the database        
         DB::update(
@@ -275,7 +285,9 @@ 
             $taskIds
         );
     
-        if (LOG_TASKS=== true) $this->logger->log('Old finished tasks cleaned: ' . count($taskIds), 'INFO');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Old finished tasks cleaned: ' . count($taskIds), 'INFO');
+        }
     }
 }