Passed
Pull Request — master (#4682)
by Nils
06:11
created
api/Controller/Api/FolderController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
                     $arrFolders = $folderModel->getFoldersInfo(explode(",", $userData['folders_list']));
49 49
                     $responseData = json_encode($arrFolders);
50 50
                 } catch (Error $e) {
51
-                    $strErrorDesc = $e->getMessage() . ' Something went wrong! Please contact support.3';
51
+                    $strErrorDesc = $e->getMessage().' Something went wrong! Please contact support.3';
52 52
                     $strErrorHeader = 'HTTP/1.1 500 Internal Server Error';
53 53
                 }
54 54
             }
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
                         
122 122
                         $responseData = json_encode($arrFolder);
123 123
                     } catch (Error $e) {
124
-                        $strErrorDesc = $e->getMessage() . ' Something went wrong! Please contact support.1';
124
+                        $strErrorDesc = $e->getMessage().' Something went wrong! Please contact support.1';
125 125
                         $strErrorHeader = 'HTTP/1.1 500 Internal Server Error';
126 126
                     }
127 127
                 }
Please login to merge, or discard this patch.
scripts/background_tasks___do_calculation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     // get count of Items in this folder
75 75
     $get = DB::queryfirstrow(
76 76
         'SELECT count(*) as num_results
77
-        FROM ' . prefixTable('items') . '
77
+        FROM ' . prefixTable('items').'
78 78
         WHERE inactif = %i AND id_tree = %i',
79 79
         0,
80 80
         $child->id
@@ -83,14 +83,14 @@  discard block
 block discarded – undo
83 83
     $ret[$child->id]['id'] = $child->id;
84 84
 
85 85
     // get number of subfolders
86
-    $nodeDescendants =$tree->getDescendants($child->id, false, false, true);
86
+    $nodeDescendants = $tree->getDescendants($child->id, false, false, true);
87 87
     $ret[$child->id]['subfoldersCount'] = count($nodeDescendants);
88 88
 
89 89
     // get items number in subfolders
90 90
     if (count($nodeDescendants) > 0) {
91 91
         $get = DB::queryfirstrow(
92 92
             'SELECT count(*) as num_results
93
-            FROM ' . prefixTable('items') . '
93
+            FROM ' . prefixTable('items').'
94 94
             WHERE inactif = %i AND id_tree IN (%l)',
95 95
             0,
96 96
             implode(',', $nodeDescendants)
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
     // Get item key
139 139
     $itemKey = DB::queryFirstRow(
140 140
         'SELECT share_key
141
-        FROM ' . prefixTable('sharekeys_items') . '
141
+        FROM ' . prefixTable('sharekeys_items').'
142 142
         WHERE user_id = %i AND object_id = %i',
143 143
         TP_USER_ID,
144 144
         $item['itemId']
Please login to merge, or discard this patch.
pages/api.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('api') === false) {
72 72
     // Not allowed page
73 73
     $session->set('system-error_code', ERR_NOT_ALLOWED);
74
-    include $SETTINGS['cpassman_dir'] . '/error.php';
74
+    include $SETTINGS['cpassman_dir'].'/error.php';
75 75
     exit;
76 76
 }
77 77
 
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
                                     <?php
159 159
                                     $rowsKeys = DB::query(
160 160
                                         'SELECT *
161
-                                        FROM ' . prefixTable('api') . '
161
+                                        FROM ' . prefixTable('api').'
162 162
                                         WHERE type = %s
163 163
                                         ORDER BY timestamp ASC',
164 164
                                         'key'
@@ -181,15 +181,15 @@  discard block
 block discarded – undo
181 181
                                             <?php
182 182
                                             foreach ($rowsKeys as $key) {
183 183
                                                 echo '
184
-                                                    <tr data-id="' . $key['increment_id'] . '">
185
-                                                    <td width="50px"><i class="fas fa-trash infotip pointer delete-api-key" title="' . $lang->get('del_button') . '"></i></td>
186
-                                                    <td><span class="edit-api-key pointer">' . $key['label'] . '</span></td>
187
-                                                    <td>' . $key['value']. '</td>   
188
-                                                    <td><i class="fas '.((int) $key['enabled'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="enabled" data-increment-id="' . $key['increment_id'] . '"></i></td>
189
-                                                    <td><i class="fas '.((int) $key['allowed_to_create'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_create" data-increment-id="' . $key['increment_id'] . '"></i></td>
190
-                                                    <td><i class="fas '.((int) $key['allowed_to_read'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_read" data-increment-id="' . $key['increment_id'] . '"></i></td>
191
-                                                    <td><i class="fas '.((int) $key['allowed_to_update'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_update" data-increment-id="' . $key['increment_id'] . '"></i></td>
192
-                                                    <td><i class="fas '.((int) $key['allowed_to_delete'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_delete" data-increment-id="' . $key['increment_id'] . '"></i></td>                   
184
+                                                    <tr data-id="' . $key['increment_id'].'">
185
+                                                    <td width="50px"><i class="fas fa-trash infotip pointer delete-api-key" title="' . $lang->get('del_button').'"></i></td>
186
+                                                    <td><span class="edit-api-key pointer">' . $key['label'].'</span></td>
187
+                                                    <td>' . $key['value'].'</td>   
188
+                                                    <td><i class="fas '.((int) $key['enabled'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="enabled" data-increment-id="'.$key['increment_id'].'"></i></td>
189
+                                                    <td><i class="fas '.((int) $key['allowed_to_create'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_create" data-increment-id="'.$key['increment_id'].'"></i></td>
190
+                                                    <td><i class="fas '.((int) $key['allowed_to_read'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_read" data-increment-id="'.$key['increment_id'].'"></i></td>
191
+                                                    <td><i class="fas '.((int) $key['allowed_to_update'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_update" data-increment-id="'.$key['increment_id'].'"></i></td>
192
+                                                    <td><i class="fas '.((int) $key['allowed_to_delete'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_delete" data-increment-id="'.$key['increment_id'].'"></i></td>                   
193 193
                                                 </tr>';
194 194
                                             } ?>
195 195
                                         </tbody>
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
                                 <div class="col-12 mt-4" id="table-api-ip">
225 225
                                     <?php
226 226
                                     $rowsIps = DB::query(
227
-                                                'SELECT increment_id, label, timestamp value FROM ' . prefixTable('api') . '
227
+                                                'SELECT increment_id, label, timestamp value FROM '.prefixTable('api').'
228 228
                                                 WHERE type = %s
229 229
                                                 ORDER BY timestamp ASC',
230 230
                                                 'ip'
@@ -242,10 +242,10 @@  discard block
 block discarded – undo
242 242
                                             <?php
243 243
                                             foreach ($rowsIps as $ip) {
244 244
                                                 echo '
245
-                                                <tr data-id="' . $ip['increment_id'] . '">
246
-                                                    <td width="50px"><i class="fas fa-trash infotip pointer delete-api-ip" title="' . $lang->get('del_button') . '"></i></td>
247
-                                                    <td><span class="edit-api-ip pointer" data-field="label">' . $ip['label'] . '</span></td>
248
-                                                    <td><span class="edit-api-ip pointer" data-field="value">' . $ip['value'] . '</span></td>
245
+                                                <tr data-id="' . $ip['increment_id'].'">
246
+                                                    <td width="50px"><i class="fas fa-trash infotip pointer delete-api-ip" title="' . $lang->get('del_button').'"></i></td>
247
+                                                    <td><span class="edit-api-ip pointer" data-field="label">' . $ip['label'].'</span></td>
248
+                                                    <td><span class="edit-api-ip pointer" data-field="value">' . $ip['value'].'</span></td>
249 249
                                                 </tr>';
250 250
                                             } ?>
251 251
                                         </tbody>
@@ -281,8 +281,8 @@  discard block
 block discarded – undo
281 281
                                     <?php
282 282
                                     $rowsKeys = DB::query(
283 283
                                         'SELECT a.*, u.name, u.lastname, u.login
284
-                                        FROM ' . prefixTable('api') . ' AS a
285
-                                        INNER JOIN ' . prefixTable('users') . ' AS u ON a.user_id = u.id
284
+                                        FROM ' . prefixTable('api').' AS a
285
+                                        INNER JOIN ' . prefixTable('users').' AS u ON a.user_id = u.id
286 286
                                         WHERE a.type = %s
287 287
                                         ORDER BY u.login ASC',
288 288
                                         'user'
@@ -303,13 +303,13 @@  discard block
 block discarded – undo
303 303
                                             <?php
304 304
                                             foreach ($rowsKeys as $key) {
305 305
                                                 echo '
306
-                                                    <tr data-id="' . $key['increment_id'] . '">
307
-                                                    <td>' . $key['name'] . ' ' . $key['lastname'] . ' (<i>'.$key['login'].'</i>)</td>
308
-                                                    <td><i class="fas '.((int) $key['enabled'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="enabled" data-increment-id="' . $key['increment_id'] . '"></i></td>
309
-                                                    <td><i class="fas '.((int) $key['allowed_to_create'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_create" data-increment-id="' . $key['increment_id'] . '"></i></td>
310
-                                                    <td><i class="fas '.((int) $key['allowed_to_read'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_read" data-increment-id="' . $key['increment_id'] . '"></i></td>
311
-                                                    <td><i class="fas '.((int) $key['allowed_to_update'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_update" data-increment-id="' . $key['increment_id'] . '"></i></td>
312
-                                                    <td><i class="fas '.((int) $key['allowed_to_delete'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_delete" data-increment-id="' . $key['increment_id'] . '"></i></td>
306
+                                                    <tr data-id="' . $key['increment_id'].'">
307
+                                                    <td>' . $key['name'].' '.$key['lastname'].' (<i>'.$key['login'].'</i>)</td>
308
+                                                    <td><i class="fas '.((int) $key['enabled'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="enabled" data-increment-id="'.$key['increment_id'].'"></i></td>
309
+                                                    <td><i class="fas '.((int) $key['allowed_to_create'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_create" data-increment-id="'.$key['increment_id'].'"></i></td>
310
+                                                    <td><i class="fas '.((int) $key['allowed_to_read'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_read" data-increment-id="'.$key['increment_id'].'"></i></td>
311
+                                                    <td><i class="fas '.((int) $key['allowed_to_update'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_update" data-increment-id="'.$key['increment_id'].'"></i></td>
312
+                                                    <td><i class="fas '.((int) $key['allowed_to_delete'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_delete" data-increment-id="'.$key['increment_id'].'"></i></td>
313 313
                                                 </tr>';
314 314
                                             } ?>
315 315
                                         </tbody>
Please login to merge, or discard this patch.
pages/tools.js.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('tools') === false) {
73 73
     // Not allowed page
74 74
     $session->set('system-error_code', ERR_NOT_ALLOWED);
75
-    include $SETTINGS['cpassman_dir'] . '/error.php';
75
+    include $SETTINGS['cpassman_dir'].'/error.php';
76 76
     exit;
77 77
 }
78 78
 ?>
Please login to merge, or discard this patch.
pages/tools.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('tools') === false) {
70 70
     // Not allowed page
71 71
     $session->set('system-error_code', ERR_NOT_ALLOWED);
72
-    include $SETTINGS['cpassman_dir'] . '/error.php';
72
+    include $SETTINGS['cpassman_dir'].'/error.php';
73 73
     exit;
74 74
 }
75 75
 
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
                             </div>
131 131
 <?php                            
132 132
 // Check if table  exists
133
-$tableExists = DB::queryFirstField('SHOW TABLES LIKE %s', 'teampass_items_v2');;
133
+$tableExists = DB::queryFirstField('SHOW TABLES LIKE %s', 'teampass_items_v2'); ;
134 134
 if (is_null($tableExists) === true) {
135 135
     echo '
136 136
                             <div class="alert alert-warning" role="warning"><i class="fas fa-lightbulb mr-2"></i>'.$lang->get('table_not_exists').'</div>';
Please login to merge, or discard this patch.
sources/find.queries.php 1 patch
Spacing   +44 added lines, -44 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 ) {
74 74
     // Not allowed page
75 75
     $session->set('system-error_code', ERR_NOT_ALLOWED);
76
-    include $SETTINGS['cpassman_dir'] . '/error.php';
76
+    include $SETTINGS['cpassman_dir'].'/error.php';
77 77
     exit;
78 78
 }
79 79
 
@@ -92,12 +92,12 @@  discard block
 block discarded – undo
92 92
 if (null === $session->get('user-accessible_folders')
93 93
     || empty($session->get('user-accessible_folders')) === true
94 94
 ) {
95
-    echo '{"sEcho": ' . $request->query->filter('sEcho', FILTER_SANITIZE_NUMBER_INT) . ' ,"iTotalRecords": "0", "iTotalDisplayRecords": "0", "aaData": [] }';
95
+    echo '{"sEcho": '.$request->query->filter('sEcho', FILTER_SANITIZE_NUMBER_INT).' ,"iTotalRecords": "0", "iTotalDisplayRecords": "0", "aaData": [] }';
96 96
     exit;
97 97
 }
98 98
 
99 99
 //Columns name
100
-$aColumns = ['c.id', 'c.label', 'c.login', 'c.description', 'c.tags', 'c.id_tree', 'c.folder', 'c.login', 'c.url', 'ci.data'];//
100
+$aColumns = ['c.id', 'c.label', 'c.login', 'c.description', 'c.tags', 'c.id_tree', 'c.folder', 'c.login', 'c.url', 'ci.data']; //
101 101
 $aSortTypes = ['ASC', 'DESC'];
102 102
 //init SQL variables
103 103
 $sOrder = $sLimit = $sWhere = '';
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 
118 118
 //Get current user "personal folder" ID
119 119
 $row = DB::query(
120
-    'SELECT id FROM ' . prefixTable('nested_tree') . ' WHERE title = %i',
120
+    'SELECT id FROM '.prefixTable('nested_tree').' WHERE title = %i',
121 121
     intval($session->get('user-id'))
122 122
 );
123 123
 //get list of personal folders
@@ -126,20 +126,20 @@  discard block
 block discarded – undo
126 126
 $listPf = '';
127 127
 if (empty($row['id']) === false) {
128 128
     $rows = DB::query(
129
-        'SELECT id FROM ' . prefixTable('nested_tree') . '
129
+        'SELECT id FROM '.prefixTable('nested_tree').'
130 130
         WHERE personal_folder = 1 AND NOT parent_id = %i AND NOT title = %i',
131 131
         filter_var($row['id'], FILTER_SANITIZE_NUMBER_INT),
132 132
         filter_var($session->get('user-id'), FILTER_SANITIZE_NUMBER_INT)
133 133
     );
134 134
     foreach ($rows as $record) {
135
-        if (! in_array($record['id'], $arrayPf)) {
135
+        if (!in_array($record['id'], $arrayPf)) {
136 136
             //build an array of personal folders ids
137 137
             array_push($arrayPf, $record['id']);
138 138
             //build also a string with those ids
139 139
             if (empty($listPf)) {
140 140
                 $listPf = $record['id'];
141 141
             } else {
142
-                $listPf .= ', ' . $record['id'];
142
+                $listPf .= ', '.$record['id'];
143 143
             }
144 144
         }
145 145
     }
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 //Paging
150 150
 $sLimit = '';
151 151
 if (null !== $request->query->get('start') && $request->query->get('length') !== '-1') {
152
-    $sLimit = 'LIMIT ' . $request->query->filter('start', null, FILTER_SANITIZE_NUMBER_INT) . ', ' . $request->query->filter('length', null, FILTER_SANITIZE_NUMBER_INT) . '';
152
+    $sLimit = 'LIMIT '.$request->query->filter('start', null, FILTER_SANITIZE_NUMBER_INT).', '.$request->query->filter('length', null, FILTER_SANITIZE_NUMBER_INT).'';
153 153
 }
154 154
 
155 155
 //Ordering
@@ -163,8 +163,8 @@  discard block
 block discarded – undo
163 163
     }
164 164
     $sOrder = 'ORDER BY  ';
165 165
     if ($orderParam[0]['column'] >= 0) {
166
-        $sOrder .= '' . $aColumns[filter_var($orderParam[0]['column'], FILTER_SANITIZE_NUMBER_INT)] . ' '
167
-                . filter_var($orderParam[0]['dir'], FILTER_SANITIZE_FULL_SPECIAL_CHARS) . ', ';
166
+        $sOrder .= ''.$aColumns[filter_var($orderParam[0]['column'], FILTER_SANITIZE_NUMBER_INT)].' '
167
+                . filter_var($orderParam[0]['dir'], FILTER_SANITIZE_FULL_SPECIAL_CHARS).', ';
168 168
     }
169 169
 
170 170
     $sOrder = substr_replace($sOrder, '', -2);
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
         $sOrder = '';
173 173
     }
174 174
 } else {
175
-    $sOrder = 'ORDER BY ' . $aColumns[1] . ' ASC';
175
+    $sOrder = 'ORDER BY '.$aColumns[1].' ASC';
176 176
 }
177 177
 
178 178
 // Define criteria
@@ -196,9 +196,9 @@  discard block
 block discarded – undo
196 196
 if (empty($search_criteria) === false) {
197 197
     $sWhere .= ' AND (';
198 198
     for ($i = 0; $i < count($aColumns); ++$i) {
199
-        $sWhere .= $aColumns[$i] . ' LIKE %ss_' . $i . ' OR ';
199
+        $sWhere .= $aColumns[$i].' LIKE %ss_'.$i.' OR ';
200 200
     }
201
-    $sWhere = substr_replace((string) $sWhere, '', -3) . ') ';
201
+    $sWhere = substr_replace((string) $sWhere, '', -3).') ';
202 202
     $crit = [
203 203
         'idtree' => array_unique($folders),
204 204
         '0' => $search_criteria,
@@ -238,16 +238,16 @@  discard block
 block discarded – undo
238 238
     if (empty($sWhere) === false) {
239 239
         $sWhere .= ' AND ';
240 240
     }
241
-    $sWhere = 'WHERE ' . $sWhere . 'c.id_tree NOT IN %ls_pf ';
241
+    $sWhere = 'WHERE '.$sWhere.'c.id_tree NOT IN %ls_pf ';
242 242
 } else {
243
-    $sWhere = 'WHERE ' . $sWhere;
243
+    $sWhere = 'WHERE '.$sWhere;
244 244
 }
245 245
 
246 246
 // Do queries
247 247
 DB::query(
248 248
     "SELECT c.id
249
-    FROM " . prefixTable('cache') . " AS c
250
-    LEFT JOIN " . prefixTable('categories_items') . " AS ci ON (ci.item_id = c.id)
249
+    FROM " . prefixTable('cache')." AS c
250
+    LEFT JOIN " . prefixTable('categories_items')." AS ci ON (ci.item_id = c.id)
251 251
     {$sWhere}
252 252
     {$sOrder}",
253 253
     $crit
@@ -255,9 +255,9 @@  discard block
 block discarded – undo
255 255
 $iTotal = DB::count();
256 256
 $rows = DB::query(
257 257
     "SELECT c.*, ci.data, i.item_key
258
-    FROM " . prefixTable('cache') . " AS c
259
-    LEFT JOIN " . prefixTable('categories_items') . " AS ci ON (ci.item_id = c.id)
260
-    INNER JOIN " . prefixTable('items') . " AS i ON (i.id = c.id)
258
+    FROM " . prefixTable('cache')." AS c
259
+    LEFT JOIN " . prefixTable('categories_items')." AS ci ON (ci.item_id = c.id)
260
+    INNER JOIN " . prefixTable('items')." AS i ON (i.id = c.id)
261 261
     {$sWhere}
262 262
     {$sOrder}
263 263
     {$sLimit}",
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
 if (null === $request->query->get('type')) {
283 283
     $sOutput = '{';
284 284
     if (null !== $request->query->get('draw')) {
285
-        $sOutput .= '"draw": ' . $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
285
+        $sOutput .= '"draw": '.$request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
286 286
     }
287 287
     $sOutput .= '"data": [';
288 288
     $sOutputConst = '';
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
             foreach (explode(';', $session->get('user-roles')) as $role) {
300 300
                 //db::debugmode(true);
301 301
                 $access = DB::queryFirstRow(
302
-                    'SELECT type FROM ' . prefixTable('roles_values') . ' WHERE role_id = %i AND folder_id = %i',
302
+                    'SELECT type FROM '.prefixTable('roles_values').' WHERE role_id = %i AND folder_id = %i',
303 303
                     $role,
304 304
                     $record['id_tree']
305 305
                 );
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
             }
320 320
             $accessLevel = count($arrTmp) > 0 ? min($arrTmp) : $accessLevel;
321 321
             if ($accessLevel === 0) {
322
-                $checkbox = '<input type=\"checkbox\" value=\"0\" class=\"mass_op_cb\" data-id=\"' . $record['id'] . '\">';
322
+                $checkbox = '<input type=\"checkbox\" value=\"0\" class=\"mass_op_cb\" data-id=\"'.$record['id'].'\">';
323 323
             }
324 324
 
325 325
             if ((int) $accessLevel === 0) {
@@ -359,22 +359,22 @@  discard block
 block discarded – undo
359 359
             if (empty($restrictedTo)) {
360 360
                 $restrictedTo = $session->get('user-id');
361 361
             } else {
362
-                $restrictedTo .= ',' . $session->get('user-id');
362
+                $restrictedTo .= ','.$session->get('user-id');
363 363
             }
364 364
         }
365 365
         
366 366
         //col1
367
-        $sOutputItem .= '"<i class=\"fa fa-external-link-alt infotip mr-2\" title=\"' . $lang->get('open_url_link') . '\" onClick=\"window.location.href=&#039;index.php?page=items&amp;group=' . $record['id_tree'] . '&amp;id=' . $record['id'] . '&#039;\" style=\"cursor:pointer;\"></i>' .
368
-        '<i class=\"fa fa-eye infotip mr-2 item-detail\" title=\"' . stripslashes($lang->get('see_item_title')) . '\" data-id=\"' . $record['id'] . '\" data-perso=\"' . $record['perso'] . '\" data-tree-id=\"' . $record['id_tree'] . '\" data-expired=\"' . $expired . '\" data-restricted-to=\"' . $restrictedTo . '\" data-rights=\"' . $right . '\" style=\"cursor:pointer;\"></i>' . $checkbox . '",' ;
367
+        $sOutputItem .= '"<i class=\"fa fa-external-link-alt infotip mr-2\" title=\"'.$lang->get('open_url_link').'\" onClick=\"window.location.href=&#039;index.php?page=items&amp;group='.$record['id_tree'].'&amp;id='.$record['id'].'&#039;\" style=\"cursor:pointer;\"></i>'.
368
+        '<i class=\"fa fa-eye infotip mr-2 item-detail\" title=\"'.stripslashes($lang->get('see_item_title')).'\" data-id=\"'.$record['id'].'\" data-perso=\"'.$record['perso'].'\" data-tree-id=\"'.$record['id_tree'].'\" data-expired=\"'.$expired.'\" data-restricted-to=\"'.$restrictedTo.'\" data-rights=\"'.$right.'\" style=\"cursor:pointer;\"></i>'.$checkbox.'",';
369 369
         //col2
370
-        $sOutputItem .= '"'.base64_encode('<span id=\"item_label-' . $record['id'] . '\">' . (str_replace("\\", "&#92;", (string) $record['label'])) . '</span>').'", ';   // replace backslash #3015
370
+        $sOutputItem .= '"'.base64_encode('<span id=\"item_label-'.$record['id'].'\">'.(str_replace("\\", "&#92;", (string) $record['label'])).'</span>').'", '; // replace backslash #3015
371 371
         //col3
372
-        $sOutputItem .= '"' . base64_encode(str_replace('&amp;', '&', htmlspecialchars(stripslashes((string) $record['login']), ENT_QUOTES))) . '", ';
372
+        $sOutputItem .= '"'.base64_encode(str_replace('&amp;', '&', htmlspecialchars(stripslashes((string) $record['login']), ENT_QUOTES))).'", ';
373 373
         //col4
374 374
         //get restriction from ROles
375 375
         $restrictedToRole = false;
376 376
         $rTmp = DB::queryFirstColumn(
377
-            'SELECT role_id FROM ' . prefixTable('restriction_to_roles') . ' WHERE item_id = %i',
377
+            'SELECT role_id FROM '.prefixTable('restriction_to_roles').' WHERE item_id = %i',
378 378
             $record['id']
379 379
         );
380 380
         // We considere here that if user has at least one group similar to the object ones
@@ -392,14 +392,14 @@  discard block
 block discarded – undo
392 392
         } else {
393 393
             $txt = str_replace(['\n', '<br />', '\\'], [' ', ' ', '', ' '], strip_tags($record['description']));
394 394
             if (strlen($txt) > 50) {
395
-                $sOutputItem .= '"' . base64_encode(substr(stripslashes(preg_replace('~/<[\/]{0,1}[^>]*>\//|[ \t]/~', '', $txt)), 0, 50)) . '", ';
395
+                $sOutputItem .= '"'.base64_encode(substr(stripslashes(preg_replace('~/<[\/]{0,1}[^>]*>\//|[ \t]/~', '', $txt)), 0, 50)).'", ';
396 396
             } else {
397
-                $sOutputItem .= '"' . base64_encode(stripslashes(preg_replace('~/<[^>]*>|[ \t]/~', '', $txt))) . '", ';
397
+                $sOutputItem .= '"'.base64_encode(stripslashes(preg_replace('~/<[^>]*>|[ \t]/~', '', $txt))).'", ';
398 398
             }
399 399
         }
400 400
 
401 401
         //col5 - TAGS
402
-        $sOutputItem .= '"' . base64_encode(htmlspecialchars(stripslashes((string) $record['tags']), ENT_QUOTES)) . '", ';
402
+        $sOutputItem .= '"'.base64_encode(htmlspecialchars(stripslashes((string) $record['tags']), ENT_QUOTES)).'", ';
403 403
         // col6 - URL
404 404
         if ($record['url'] !== '0') {
405 405
             $sOutputItem .= '"'.htmlspecialchars(filter_var($record['url'], FILTER_SANITIZE_URL)).'", ';
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
408 408
         }
409 409
 
410 410
         //col7 - Prepare the Treegrid
411
-        $sOutputItem .= '"' . base64_encode(stripslashes((string) $record['folder'])) . '"';
411
+        $sOutputItem .= '"'.base64_encode(stripslashes((string) $record['folder'])).'"';
412 412
         //Finish the line
413 413
         //$sOutputItem .= '], ';
414 414
         if ($getItemInList === true) {
@@ -417,17 +417,17 @@  discard block
 block discarded – undo
417 417
             --$iTotal;
418 418
         }
419 419
     }
420
-    if (! empty($sOutputConst)) {
420
+    if (!empty($sOutputConst)) {
421 421
         $sOutput .= substr_replace($sOutputConst, '', -2);
422 422
     }
423 423
     $sOutput .= '], ';
424
-    $sOutput .= '"recordsTotal": ' . $iTotal . ', ';
425
-    $sOutput .= '"recordsFiltered": ' . $iTotal . ' }';
424
+    $sOutput .= '"recordsTotal": '.$iTotal.', ';
425
+    $sOutput .= '"recordsFiltered": '.$iTotal.' }';
426 426
     // file deepcode ignore XSS: data is secured
427 427
     echo ($sOutput);
428 428
 } elseif (null !== $request->query->get('type') && ($request->query->get('type') === 'search_for_items' || $request->query->get('type') === 'search_for_items_with_tags')) {
429 429
     include_once 'main.functions.php';
430
-    include_once $SETTINGS['cpassman_dir'] . '/includes/language/' . $session->get('user-language') . '.php';
430
+    include_once $SETTINGS['cpassman_dir'].'/includes/language/'.$session->get('user-language').'.php';
431 431
 
432 432
     $arr_data = [];
433 433
     foreach ($rows as $record) {
@@ -436,7 +436,7 @@  discard block
 block discarded – undo
436 436
         $arr_data[$record['id']]['tree_id'] = (int) $record['id_tree'];
437 437
         $arr_data[$record['id']]['label'] = (string) $record['label'];
438 438
         $arr_data[$record['id']]['desc'] = (string) strip_tags(explode('<br>', $record['description'])[0]);
439
-        $arr_data[$record['id']]['folder'] = (string)$record['folder'];
439
+        $arr_data[$record['id']]['folder'] = (string) $record['folder'];
440 440
         $arr_data[$record['id']]['login'] = (string) strtr($record['login'], '"', '&quot;');
441 441
         $arr_data[$record['id']]['item_key'] = (string) $record['item_key'];
442 442
         $arr_data[$record['id']]['link'] = (string) $record['url'] !== '0' && empty($record['url']) === false ? filter_var($record['url'], FILTER_SANITIZE_URL) : '';
@@ -449,7 +449,7 @@  discard block
 block discarded – undo
449 449
 
450 450
         // Anyone can modify?
451 451
         $tmp = DB::queryfirstrow(
452
-            'SELECT anyone_can_modify FROM ' . prefixTable('items') . ' WHERE id = %i',
452
+            'SELECT anyone_can_modify FROM '.prefixTable('items').' WHERE id = %i',
453 453
             $record['id']
454 454
         );
455 455
         if (count($tmp) > 0) {
@@ -480,7 +480,7 @@  discard block
 block discarded – undo
480 480
         // => récupérer un tableau contenant les roles associés à cet ID (a partir table restriction_to_roles)
481 481
         $user_is_included_in_role = 0;
482 482
         $roles = DB::query(
483
-            'SELECT role_id FROM ' . prefixTable('restriction_to_roles') . ' WHERE item_id=%i',
483
+            'SELECT role_id FROM '.prefixTable('restriction_to_roles').' WHERE item_id=%i',
484 484
             $record['id']
485 485
         );
486 486
         if (count($roles) > 0) {
@@ -503,7 +503,7 @@  discard block
 block discarded – undo
503 503
             if (empty($restrictedTo)) {
504 504
                 $restrictedTo = $session->get('user-id');
505 505
             } else {
506
-                $restrictedTo .= ',' . $session->get('user-id');
506
+                $restrictedTo .= ','.$session->get('user-id');
507 507
             }
508 508
         }
509 509
 
@@ -601,7 +601,7 @@  discard block
 block discarded – undo
601 601
             $arrTmp = [];
602 602
             foreach (explode(';', $session->get('user-roles')) as $role) {
603 603
                 $access = DB::queryFirstRow(
604
-                    'SELECT type FROM ' . prefixTable('roles_values') . ' WHERE role_id = %i AND folder_id = %i',
604
+                    'SELECT type FROM '.prefixTable('roles_values').' WHERE role_id = %i AND folder_id = %i',
605 605
                     $role,
606 606
                     $record['id_tree']
607 607
                 );
@@ -652,8 +652,8 @@  discard block
 block discarded – undo
652 652
         ) {
653 653
             $data_item = DB::queryFirstRow(
654 654
                 'SELECT i.pw AS pw, s.share_key AS share_key
655
-                FROM ' . prefixTable('items') . ' AS i
656
-                INNER JOIN ' . prefixTable('sharekeys_items') . ' AS s ON (s.object_id = i.id)
655
+                FROM ' . prefixTable('items').' AS i
656
+                INNER JOIN ' . prefixTable('sharekeys_items').' AS s ON (s.object_id = i.id)
657 657
                 WHERE i.id = %i AND s.user_id = %i',
658 658
                 $record['id'],
659 659
                 $session->get('user-id')
Please login to merge, or discard this patch.
pages/favourites.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
     || (int) $session_user_admin === 1) {
73 73
     // Not allowed page
74 74
     $session->set('system-error_code', ERR_NOT_ALLOWED);
75
-    include $SETTINGS['cpassman_dir'] . '/error.php';
75
+    include $SETTINGS['cpassman_dir'].'/error.php';
76 76
     exit;
77 77
 }
78 78
 
@@ -125,12 +125,12 @@  discard block
 block discarded – undo
125 125
                             if (empty($fav) === false) {
126 126
                                 $data = DB::queryFirstRow(
127 127
                                     'SELECT i.label, i.description, i.id, i.id_tree, t.title
128
-                                    FROM ' . prefixTable('items') . ' as i
129
-                                    INNER JOIN ' . prefixTable('nested_tree') . ' as t ON (t.id = i.id_tree)
128
+                                    FROM ' . prefixTable('items').' as i
129
+                                    INNER JOIN ' . prefixTable('nested_tree').' as t ON (t.id = i.id_tree)
130 130
                                     WHERE i.id = %i',
131 131
                                     $fav
132 132
                                 );
133
-                                if (! empty($data['label'])) {
133
+                                if (!empty($data['label'])) {
134 134
                                     ?>
135 135
                                     <tr>
136 136
                                         <td>
Please login to merge, or discard this patch.
pages/export.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 ) {
70 70
     // Not allowed page
71 71
     $session->set('system-error_code', ERR_NOT_ALLOWED);
72
-    include $SETTINGS['cpassman_dir'] . '/error.php';
72
+    include $SETTINGS['cpassman_dir'].'/error.php';
73 73
     exit;
74 74
 }
75 75
 
Please login to merge, or discard this patch.
pages/items.js.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('items') === false) {
73 73
     // Not allowed page
74 74
     $session->set('system-error_code', ERR_NOT_ALLOWED);
75
-    include $SETTINGS['cpassman_dir'] . '/error.php';
75
+    include $SETTINGS['cpassman_dir'].'/error.php';
76 76
     exit;
77 77
 }
78 78
 
@@ -1030,7 +1030,7 @@  discard block
 block discarded – undo
1030 1030
             //
1031 1031
         } else if ($(this).data('item-action') === 'link') {
1032 1032
             // Add link to clipboard.
1033
-            navigator.clipboard.writeText("<?php echo $SETTINGS['cpassman_url'];?>/index.php?page=items&group="+store.get('teampassItem').folderId+"&id="+store.get('teampassItem').id);
1033
+            navigator.clipboard.writeText("<?php echo $SETTINGS['cpassman_url']; ?>/index.php?page=items&group="+store.get('teampassItem').folderId+"&id="+store.get('teampassItem').id);
1034 1034
 
1035 1035
             // Display message.
1036 1036
             toastr.remove();
@@ -2649,7 +2649,7 @@  discard block
 block discarded – undo
2649 2649
                 progress: "#form-item-password-strength",
2650 2650
                 score: "#form-item-password-strength"
2651 2651
             },
2652
-            scores: [<?php echo TP_PW_STRENGTH_1;?>, <?php echo TP_PW_STRENGTH_2;?>, <?php echo TP_PW_STRENGTH_3;?>, <?php echo TP_PW_STRENGTH_4;?>, <?php echo TP_PW_STRENGTH_5;?>],
2652
+            scores: [<?php echo TP_PW_STRENGTH_1; ?>, <?php echo TP_PW_STRENGTH_2; ?>, <?php echo TP_PW_STRENGTH_3; ?>, <?php echo TP_PW_STRENGTH_4; ?>, <?php echo TP_PW_STRENGTH_5; ?>],
2653 2653
         },
2654 2654
         i18n : {
2655 2655
             t: function (key) {
@@ -2676,7 +2676,7 @@  discard block
 block discarded – undo
2676 2676
     <?php
2677 2677
     $max_file_size = '';
2678 2678
     if (strrpos($SETTINGS['upload_maxfilesize'], 'mb') === false) {
2679
-        $max_file_size = $SETTINGS['upload_maxfilesize'] . 'mb';
2679
+        $max_file_size = $SETTINGS['upload_maxfilesize'].'mb';
2680 2680
     } else {
2681 2681
         $max_file_size = $SETTINGS['upload_maxfilesize'];
2682 2682
     }
@@ -4723,7 +4723,7 @@  discard block
 block discarded – undo
4723 4723
 
4724 4724
                             // Show passwords inputs and form
4725 4725
                             $('#dialog-ldap-user-change-password-info')
4726
-                                .html('<i class="icon fa-solid fa-info mr-2"></i><?php echo $lang->get('ldap_user_has_changed_his_password');?>')
4726
+                                .html('<i class="icon fa-solid fa-info mr-2"></i><?php echo $lang->get('ldap_user_has_changed_his_password'); ?>')
4727 4727
                                 .removeClass('hidden');
4728 4728
                             $('#dialog-ldap-user-change-password').removeClass('hidden');
4729 4729
                         } else if (data.error_type !== 'undefined') {
@@ -4742,7 +4742,7 @@  discard block
 block discarded – undo
4742 4742
 
4743 4743
                                 // Show passwords inputs and form
4744 4744
                                 $('#dialog-ldap-user-change-password-info')
4745
-                                    .html('<i class="icon fa-solid fa-info mr-2"></i><?php echo $lang->get('ldap_user_has_changed_his_password');?>')
4745
+                                    .html('<i class="icon fa-solid fa-info mr-2"></i><?php echo $lang->get('ldap_user_has_changed_his_password'); ?>')
4746 4746
                                     .removeClass('hidden');
4747 4747
                                 $('#dialog-ldap-user-change-password').removeClass('hidden');
4748 4748
                             });
Please login to merge, or discard this patch.