Passed
Branch code_review (3a90db)
by Nils
27:18 queued 02:44
created
pages/search.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('search') === false) {
66 66
     // Not allowed page
67 67
     $session->set('system-error_code', ERR_NOT_ALLOWED);
68
-    include $SETTINGS['cpassman_dir'] . '/error.php';
68
+    include $SETTINGS['cpassman_dir'].'/error.php';
69 69
     exit;
70 70
 }
71 71
 
Please login to merge, or discard this patch.
pages/fields.js.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('fields') === false) {
68 68
     // Not allowed page
69 69
     $session->set('system-error_code', ERR_NOT_ALLOWED);
70
-    include $SETTINGS['cpassman_dir'] . '/error.php';
70
+    include $SETTINGS['cpassman_dir'].'/error.php';
71 71
     exit;
72 72
 }
73 73
 ?>
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
             if (parseInt($(this).data('category')) === parseInt(selectedCategory)) {
164 164
                 fields.push({
165 165
                     id: $(this).data('order'),
166
-                    text: '<?php echo $lang->get('before') . ' '; ?>' + $(this).find('td:eq(1)').text()
166
+                    text: '<?php echo $lang->get('before').' '; ?>' + $(this).find('td:eq(1)').text()
167 167
                 });
168 168
             }
169 169
         });
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
                 if ($(this).data('category') === categoryId) {
570 570
                     fields.push({
571 571
                         id: $(this).data('order'),
572
-                        text: '<?php echo $lang->get('before') . ' '; ?>' + $(this).find('td:eq(1)').text()
572
+                        text: '<?php echo $lang->get('before').' '; ?>' + $(this).find('td:eq(1)').text()
573 573
                     });
574 574
                 }
575 575
             });
@@ -736,7 +736,7 @@  discard block
 block discarded – undo
736 736
                                     '</tr>';
737 737
 
738 738
                                 // Prepare list of categories for Form
739
-                                categoriesList += '<option value="' + categoryId + '"><?php echo $lang->get('before') . ' '; ?>' + val.title + '</option>';
739
+                                categoriesList += '<option value="' + categoryId + '"><?php echo $lang->get('before').' '; ?>' + val.title + '</option>';
740 740
 
741 741
                                 positionCategory += 1;
742 742
                             } else {
Please login to merge, or discard this patch.
pages/export.js.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('export') === false) {
69 69
     // Not allowed page
70 70
     $session->set('system-error_code', ERR_NOT_ALLOWED);
71
-    include $SETTINGS['cpassman_dir'] . '/error.php';
71
+    include $SETTINGS['cpassman_dir'].'/error.php';
72 72
     exit;
73 73
 }
74 74
 ?>
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
                 progress: "#export-password-strength",
192 192
                 score: "#export-password-strength"
193 193
             },
194
-            scores: [<?php echo TP_PW_STRENGTH_1;?>, <?php echo TP_PW_STRENGTH_2;?>, <?php echo TP_PW_STRENGTH_3;?>, <?php echo TP_PW_STRENGTH_4;?>, <?php echo TP_PW_STRENGTH_5;?>],
194
+            scores: [<?php echo TP_PW_STRENGTH_1; ?>, <?php echo TP_PW_STRENGTH_2; ?>, <?php echo TP_PW_STRENGTH_3; ?>, <?php echo TP_PW_STRENGTH_4; ?>, <?php echo TP_PW_STRENGTH_5; ?>],
195 195
         },
196 196
         i18n : {
197 197
             t: function (key) {
Please login to merge, or discard this patch.
pages/roles.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('roles') === false) {
67 67
     // Not allowed page
68 68
     $session->set('system-error_code', ERR_NOT_ALLOWED);
69
-    include $SETTINGS['cpassman_dir'] . '/error.php';
69
+    include $SETTINGS['cpassman_dir'].'/error.php';
70 70
     exit;
71 71
 }
72 72
 
@@ -127,17 +127,17 @@  discard block
 block discarded – undo
127 127
                                 $arrUserRoles = array_filter($session->get('user-roles_array'));
128 128
                                 $where = '';
129 129
                                 if (count($arrUserRoles) > 0 && (int) $session->get('user-admin') !== 1) {
130
-                                    $where = ' WHERE id IN (' . implode(',', $arrUserRoles) . ')';
130
+                                    $where = ' WHERE id IN ('.implode(',', $arrUserRoles).')';
131 131
                                 }
132
-                                $rows = DB::query('SELECT * FROM ' . prefixTable('roles_title') . $where);
132
+                                $rows = DB::query('SELECT * FROM '.prefixTable('roles_title').$where);
133 133
                                 foreach ($rows as $reccord) {
134 134
                                     echo '
135
-                                    <option value="' . $reccord['id'] . '"
136
-                                        data-complexity-text="' . addslashes(TP_PW_COMPLEXITY[$reccord['complexity']][1]) . '"
137
-                                        data-complexity-icon="' . TP_PW_COMPLEXITY[$reccord['complexity']][2] . '"
138
-                                        data-complexity="' . TP_PW_COMPLEXITY[$reccord['complexity']][0] . '"
139
-                                        data-allow-edit-all="' . $reccord['allow_pw_change'] . '">'.
140
-                                        $reccord['title'] . '</option>';
135
+                                    <option value="' . $reccord['id'].'"
136
+                                        data-complexity-text="' . addslashes(TP_PW_COMPLEXITY[$reccord['complexity']][1]).'"
137
+                                        data-complexity-icon="' . TP_PW_COMPLEXITY[$reccord['complexity']][2].'"
138
+                                        data-complexity="' . TP_PW_COMPLEXITY[$reccord['complexity']][0].'"
139
+                                        data-allow-edit-all="' . $reccord['allow_pw_change'].'">'.
140
+                                        $reccord['title'].'</option>';
141 141
                                 }
142 142
                                 ?>
143 143
                             </select>
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
                                         <?php
159 159
                                         foreach (TP_PW_COMPLEXITY as $entry) {
160 160
                                             echo '
161
-                                        <option value="' . $entry[0] . '">' . addslashes($entry[1]) . '</option>';
161
+                                        <option value="' . $entry[0].'">'.addslashes($entry[1]).'</option>';
162 162
                                         }
163 163
                                         ?>
164 164
                                     </select>
Please login to merge, or discard this patch.
pages/options.js.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('options') === false) {
69 69
     // Not allowed page
70 70
     $session->set('system-error_code', ERR_NOT_ALLOWED);
71
-    include $SETTINGS['cpassman_dir'] . '/error.php';
71
+    include $SETTINGS['cpassman_dir'].'/error.php';
72 72
     exit;
73 73
 }
74 74
 ?>
Please login to merge, or discard this patch.
pages/utilities.renewal.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('utilities.renewal') === false) {
65 65
     // Not allowed page
66 66
     $session->set('system-error_code', ERR_NOT_ALLOWED);
67
-    include $SETTINGS['cpassman_dir'] . '/error.php';
67
+    include $SETTINGS['cpassman_dir'].'/error.php';
68 68
     exit;
69 69
 }
70 70
 
Please login to merge, or discard this patch.
pages/search.js.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('search') === false) {
72 72
     // Not allowed page
73 73
     $session->set('system-error_code', ERR_NOT_ALLOWED);
74
-    include $SETTINGS['cpassman_dir'] . '/error.php';
74
+    include $SETTINGS['cpassman_dir'].'/error.php';
75 75
     exit;
76 76
 }
77 77
 $var = [];
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
  * Certain components of this file may be under different licenses. For
23 23
  * details, see the `licenses` directory or individual file headers.
24 24
  * ---
25
-  * @file      search.js.php
25
+ * @file      search.js.php
26 26
  * @author    Nils Laumaillé ([email protected])
27 27
  * @copyright 2009-2024 Teampass.net
28 28
  * @license   GPL-3.0
Please login to merge, or discard this patch.
pages/roles.js.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('roles') === false) {
68 68
     // Not allowed page
69 69
     $session->set('system-error_code', ERR_NOT_ALLOWED);
70
-    include $SETTINGS['cpassman_dir'] . '/error.php';
70
+    include $SETTINGS['cpassman_dir'].'/error.php';
71 71
     exit;
72 72
 }
73 73
 ?>
Please login to merge, or discard this patch.
pages/folders.js.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('folders') === false) {
68 68
     // Not allowed page
69 69
     $session->set('system-error_code', ERR_NOT_ALLOWED);
70
-    include $SETTINGS['cpassman_dir'] . '/error.php';
70
+    include $SETTINGS['cpassman_dir'].'/error.php';
71 71
     exit;
72 72
 }
73 73
 ?>
@@ -697,14 +697,14 @@  discard block
 block discarded – undo
697 697
             '<label><?php echo $lang->get('icon'); ?></label>' +
698 698
             '<input type="text" class="form-control form-folder-control purify" id="folder-edit-icon" data-field="icon" value="'+folderIcon+'">' +
699 699
             '<small class="form-text text-muted">' +
700
-            '<?php echo $lang->get('fontawesome_icon_tip'); ?><a href="<?php echo FONTAWESOME_URL;?>" target="_blank"><i class="fas fa-external-link-alt ml-1"></i></a>' +
700
+            '<?php echo $lang->get('fontawesome_icon_tip'); ?><a href="<?php echo FONTAWESOME_URL; ?>" target="_blank"><i class="fas fa-external-link-alt ml-1"></i></a>' +
701 701
             '</small>' +
702 702
             '</div>' +
703 703
             '<div class="form-group ml-2">' +
704 704
             '<label><?php echo $lang->get('icon_on_selection'); ?></label>' +
705 705
             '<input type="text" class="form-control form-folder-control purify" id="folder-edit-icon-selected" data-field="iconSelected" value="'+folderIconSelection+'">' +
706 706
             '<small class="form-text text-muted">' +
707
-            '<?php echo $lang->get('fontawesome_icon_tip'); ?><a href="<?php echo FONTAWESOME_URL;?>" target="_blank"><i class="fas fa-external-link-alt ml-1"></i></a>' +
707
+            '<?php echo $lang->get('fontawesome_icon_tip'); ?><a href="<?php echo FONTAWESOME_URL; ?>" target="_blank"><i class="fas fa-external-link-alt ml-1"></i></a>' +
708 708
             '</small>' +
709 709
             '</div>' +
710 710
             '<div class="form-group ml-2" id="folder-rights-tuned">' +
Please login to merge, or discard this patch.