View GitHub Repository TeamPass

Schedule Inspection
Subscribe
Passed
Branch — code_review (3a90db)
by Nils
27:18 queued 02:44
created
Status
Category
Toggle Patches
pages/statistics.js.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -67,7 +67,7 @@
 
 block discarded – undo
67 67 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('statistics') === false) {
68 68 
     // Not allowed page
69 69 
     $session->set('system-error_code', ERR_NOT_ALLOWED);
70 
-    include $SETTINGS['cpassman_dir'] . '/error.php';
70 
+    include $SETTINGS['cpassman_dir'].'/error.php';
71 71 
     exit;
72 72 
 }
73 73 
 ?>
Please login to merge, or discard this patch.
pages/utilities.database.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -64,7 +64,7 @@
 
 block discarded – undo
64 64 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('utilities.database') === false) {
65 65 
     // Not allowed page
66 66 
     $session->set('system-error_code', ERR_NOT_ALLOWED);
67 
-    include $SETTINGS['cpassman_dir'] . '/error.php';
67 
+    include $SETTINGS['cpassman_dir'].'/error.php';
68 68 
     exit;
69 69 
 }
70 70
Please login to merge, or discard this patch.
pages/utilities.database.js.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -70,7 +70,7 @@
 
 block discarded – undo
70 70 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('utilities.database') === false) {
71 71 
     // Not allowed page
72 72 
     $session->set('system-error_code', ERR_NOT_ALLOWED);
73 
-    include $SETTINGS['cpassman_dir'] . '/error.php';
73 
+    include $SETTINGS['cpassman_dir'].'/error.php';
74 74 
     exit;
75 75 
 }
76 76 
 ?>
Please login to merge, or discard this patch.
pages/favorites.js.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -68,7 +68,7 @@
 
 block discarded – undo
68 68 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('favourites') === false) {
69 69 
     // Not allowed page
70 70 
     $session->set('system-error_code', ERR_NOT_ALLOWED);
71 
-    include $SETTINGS['cpassman_dir'] . '/error.php';
71 
+    include $SETTINGS['cpassman_dir'].'/error.php';
72 72 
     exit;
73 73 
 }
74 74 
 ?>
Please login to merge, or discard this patch.
pages/ldap.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -66,7 +66,7 @@
 
 block discarded – undo
66 66 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('ldap') === false) {
67 67 
     // Not allowed page
68 68 
     $session->set('system-error_code', ERR_NOT_ALLOWED);
69 
-    include $SETTINGS['cpassman_dir'] . '/error.php';
69 
+    include $SETTINGS['cpassman_dir'].'/error.php';
70 70 
     exit;
71 71 
 }
72 72
Please login to merge, or discard this patch.
pages/api.js.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -68,7 +68,7 @@
 
 block discarded – undo
68 68 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('api') === false) {
69 69 
     // Not allowed page
70 70 
     $session->set('system-error_code', ERR_NOT_ALLOWED);
71 
-    include $SETTINGS['cpassman_dir'] . '/error.php';
71 
+    include $SETTINGS['cpassman_dir'].'/error.php';
72 72 
     exit;
73 73 
 }
74 74 
 ?>
Please login to merge, or discard this patch.
pages/utilities.deletion.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -65,7 +65,7 @@
 
 block discarded – undo
65 65 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('utilities.deletion') === false) {
66 66 
     // Not allowed page
67 67 
     $session->set('system-error_code', ERR_NOT_ALLOWED);
68 
-    include $SETTINGS['cpassman_dir'] . '/error.php';
68 
+    include $SETTINGS['cpassman_dir'].'/error.php';
69 69 
     exit;
70 70 
 }
71 71
Please login to merge, or discard this patch.
pages/ldap.js.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -68,7 +68,7 @@  discard block
 
 block discarded – undo
68 68 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('ldap') === false) {
69 69 
     // Not allowed page
70 70 
     $session->set('system-error_code', ERR_NOT_ALLOWED);
71 
-    include $SETTINGS['cpassman_dir'] . '/error.php';
71 
+    include $SETTINGS['cpassman_dir'].'/error.php';
72 72 
     exit;
73 73 
 }
74 74 
 ?>
 
@@ -159,7 +159,7 @@  discard block
 
 block discarded – undo
159 159 
                     if (data[i].selected_role === 1) {
160 160 
                         selected_role = data[i].id;
161 161 
                     }
162 
-                    html_admin_by += '<option value="' + data[i].id + '"><?php echo $lang->get('managers_of') . ' '; ?>' + data[i].title + '</option>';
162 
+                    html_admin_by += '<option value="' + data[i].id + '"><?php echo $lang->get('managers_of').' '; ?>' + data[i].title + '</option>';
163 163 
                     html_roles += '<option value="' + data[i].id + '">' + data[i].title + '</option>';
164 164 
                 }
165 165 
                 $("#ldap_new_user_is_administrated_by").append(html_admin_by);
Please login to merge, or discard this patch.
pages/2fa.js.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -69,7 +69,7 @@
 
 block discarded – undo
69 69 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('mfa') === false) {
70 70 
     // Not allowed page
71 71 
     $session->set('system-error_code', ERR_NOT_ALLOWED);
72 
-    include $SETTINGS['cpassman_dir'] . '/error.php';
72 
+    include $SETTINGS['cpassman_dir'].'/error.php';
73 73 
     exit;
74 74 
 }
75 75 
 ?>
Please login to merge, or discard this patch.