nilsteampassnet / TeamPass

api/Model/Operation.php

Braces +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
                 "error" => '',
             );
     
-        }catch (Exception $e) {    
+        } catch (Exception $e) {    
             return false;
         }
     }

sources/users.queries.php

Braces +3 added lines, -1 removed lines

@@ -2603,7 +2603,9 @@
             }
             
             foreach ($results as $adUser) {
-                if (isset($adUser[$SETTINGS['ldap_user_attribute']][0]) === false) continue;
+                if (isset($adUser[$SETTINGS['ldap_user_attribute']][0]) === false) {
+                    continue;
+                }
                 // Build the list of all groups in AD
                 if (isset($adUser['memberof']) === true) {
                     foreach($adUser['memberof'] as $j => $adUserGroup) {

pages/tasks.php

Braces +1 added lines, -2 removed lines

@@ -146,8 +146,7 @@
                                             </div>
         <?php
     }
-}
-catch (Exception $e) {
+} catch (Exception $e) {
     error_log('TEAMPASS Error - tasks page - '.$e->getMessage());
     // deepcode ignore ServerLeak: no critical information is provided
     echo "An error occurred.";

sources/backups.queries.php

Braces +3 added lines, -1 removed lines

@@ -282,7 +282,9 @@
             $post_totalSize = (int) filter_var($dataReceived['post_totalSize'], FILTER_SANITIZE_NUMBER_INT);
             $batchSize = 500;
 
-            if (WIP === true) error_log('DEBUG: Offset -> '.$post_offset.' | File -> '.$post_clearFilename.' | key -> '.$post_key);
+            if (WIP === true) {
+                error_log('DEBUG: Offset -> '.$post_offset.' | File -> '.$post_clearFilename.' | key -> '.$post_key);
+            }
 
             include_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
 

sources/main.functions.php

Braces +12 added lines, -4 removed lines

@@ -2621,7 +2621,9 @@ 
     $safeFilePath = realpath($filePath . '/' . TP_FILE_PREFIX . $safeFileName);
     $ciphertext = file_get_contents(filter_var($safeFilePath, FILTER_SANITIZE_URL));
 
-    if (WIP) error_log('DEBUG: File image url -> '.filter_var($safeFilePath, FILTER_SANITIZE_URL));
+    if (WIP) {
+        error_log('DEBUG: File image url -> '.filter_var($safeFilePath, FILTER_SANITIZE_URL));
+    }
 
     // Decrypt file content and return
     return base64_encode($cipher->decrypt($ciphertext));
@@ -2749,7 +2751,9 @@ 
         foreach ($users as $user) {
             // Insert in DB the new object key for this item by user
             if (count($objectKeyArray) === 0) {
-                if (WIP === true) error_log('TEAMPASS Debug - storeUsersShareKey case1 - ' . $object_name . ' - ' . $post_object_id . ' - ' . $user['id'] . ' - ' . $objectKey);
+                if (WIP === true) {
+                    error_log('TEAMPASS Debug - storeUsersShareKey case1 - ' . $object_name . ' - ' . $post_object_id . ' - ' . $user['id'] . ' - ' . $objectKey);
+                }
                 DB::insert(
                     $object_name,
                     [
@@ -2763,7 +2767,9 @@ 
                 );
             } else {
                 foreach ($objectKeyArray as $object) {
-                    if (WIP === true) error_log('TEAMPASS Debug - storeUsersShareKey case2 - ' . $object_name . ' - ' . $object['objectId'] . ' - ' . $user['id'] . ' - ' . $object['objectKey']);
+                    if (WIP === true) {
+                        error_log('TEAMPASS Debug - storeUsersShareKey case2 - ' . $object_name . ' - ' . $object['objectId'] . ' - ' . $user['id'] . ' - ' . $object['objectKey']);
+                    }
                     DB::insert(
                         $object_name,
                         [
@@ -3608,7 +3614,9 @@ 
     );
     
     // if not exists then error
-    if (is_null($val) === true || count($val) === 0 || defined('UPGRADE_MIN_DATE') === false) return true;
+    if (is_null($val) === true || count($val) === 0 || defined('UPGRADE_MIN_DATE') === false) {
+        return true;
+    }
 
     // if empty or too old then error
     if (empty($val['valeur']) === true || (int) $val['valeur'] < (int) UPGRADE_MIN_DATE) {

sources/items.queries.php

Braces +21 added lines, -7 removed lines

@@ -1045,7 +1045,9 @@ 
             $session->get('user-id')
         );
         if (DB::count() === 0) {
-            if (LOG_TO_SERVER === true) error_log('TEAMPASS | user '.$session->get('user-id').' has no sharekey for item '.$inputData['itemId']);
+            if (LOG_TO_SERVER === true) {
+                error_log('TEAMPASS | user '.$session->get('user-id').' has no sharekey for item '.$inputData['itemId']);
+            }
             echo (string) prepareExchangedData(
                 array(
                     'error' => true,
@@ -1164,7 +1166,9 @@ 
                 );
 
                 // Create a task to create sharekeys for users
-                if (WIP=== true) error_log('createTaskForItem - new password for this item - '.$post_password ." -- ". $pw);
+                if (WIP=== true) {
+                    error_log('createTaskForItem - new password for this item - '.$post_password ." -- ". $pw);
+                }
                 $tasksToBePerformed = ['item_password'];
                 /*createTaskForItem(
                     'item_update_create_keys',
@@ -1489,7 +1493,9 @@ 
 
             // create a task for all fields updated
             if ($encryptionTaskIsRequested === true) {
-                if (WIP === true) error_log('createTaskForItem - '.print_r($tasksToBePerformed, true));
+                if (WIP === true) {
+                    error_log('createTaskForItem - '.print_r($tasksToBePerformed, true));
+                }
                 createTaskForItem(
                     'item_update_create_keys',
                     $tasksToBePerformed,
@@ -1996,7 +2002,9 @@ 
                 $inputData['itemId']
             );
             foreach ($rows as $record) {
-                if ($record['raison'] === NULL) continue;
+                if ($record['raison'] === NULL) {
+                    continue;
+                }
                 $reason = explode(':', $record['raison']);
                 if (count($reason) > 0) {
                     $sentence = date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['date']) . ' - '
@@ -4586,7 +4594,9 @@ 
                 $inputData['itemId']
             );
             
-            if (WIP === true) error_log('Existing edition locks: '.DB::count());
+            if (WIP === true) {
+                error_log('Existing edition locks: '.DB::count());
+            }
 
             // Check if item has no edition lock
             if ((int) DB::count() > 0 ) {
@@ -4599,7 +4609,9 @@ 
                 } else {
                     $delay = EDITION_LOCK_PERIOD; // One day delay
                 }
-                if (WIP === true) error_log('delay: ' . $delay);
+                if (WIP === true) {
+                    error_log('delay: ' . $delay);
+                }
 
                 // We remove old edition locks if delay is expired meaning more than 1 day long
                 if (round(abs(time() - $dataTmp['timestamp']),0) > $delay) {
@@ -4607,7 +4619,9 @@ 
                     // In this case, delete edition lock and possible ongoing processes
                     // and continue editing this time
                     // We coonsidere if the most recent item is still locked then all other locks can be removed
-                    if (WIP === true)  error_log('Delay is expired, removing old locks');
+                    if (WIP === true) {
+                        error_log('Delay is expired, removing old locks');
+                    }
                     foreach ($dataItemEditionLocks as $itemEditionLock) {
                         // delete lock
                         DB::delete(

scripts/background_tasks___items_handler_subtask.php

Braces +6 added lines, -2 removed lines

@@ -74,7 +74,9 @@ 
 if ($args['step'] === 'create_users_files_key') {
     // Loop on all files for this item
     // and encrypt them for each user
-    if (WIP === true) provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+    if (WIP === true) {
+        provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+    }
     foreach($args['files_keys'] as $file) {
         storeUsersShareKey(
             prefixTable('sharekeys_items'),
@@ -91,7 +93,9 @@ 
 } elseif ($args['step'] === 'create_users_fields_key') {
     // Loop on all encrypted fields for this item
     // and encrypt them for each user
-    if (WIP === true) provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+    if (WIP === true) {
+        provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+    }
     foreach($args['fields_keys'] as $field) {
         storeUsersShareKey(
             prefixTable('sharekeys_fields'),

sources/downloadFile.php

Braces +3 added lines, -1 removed lines

@@ -149,7 +149,9 @@
     }
     $filePath = realpath($filePath);
 
-    if (WIP === true) error_log('downloadFile.php: filePath: ' . $filePath." - ");
+    if (WIP === true) {
+        error_log('downloadFile.php: filePath: ' . $filePath." - ");
+    }
 
     if ($filePath && is_readable($filePath) && strpos($filePath, realpath($SETTINGS['path_to_upload_folder'])) === 0) {
         header('Content-Description: File Transfer');

scripts/background_tasks___items_handler.php

Braces +12 added lines, -4 removed lines

@@ -86,7 +86,9 @@ 
 
 if (DB::count() > 0) {
     // handle tasks inside this process
-    if (WIP === true) error_log("Process in progress: ".$process_to_perform['increment_id']);
+    if (WIP === true) {
+        error_log("Process in progress: ".$process_to_perform['increment_id']);
+    }
     handleTask(
         $process_to_perform['increment_id'],
         json_decode($process_to_perform['arguments'], true),
@@ -103,7 +105,9 @@ 
     );
     
     if (DB::count() > 0) {
-        if (WIP === true) error_log("New process ta start: ".$process_to_perform['increment_id']);
+        if (WIP === true) {
+            error_log("New process ta start: ".$process_to_perform['increment_id']);
+        }
         // update DB - started_at
         DB::update(
             prefixTable('background_tasks'),
@@ -306,7 +310,9 @@ 
     if ($args['step'] === 'create_users_files_key') {
         // Loop on all files for this item
         // and encrypt them for each user
-        if (WIP === true) provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+        if (WIP === true) {
+            provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+        }
         foreach($args['files_keys'] as $file) {
             storeUsersShareKey(
                 prefixTable('sharekeys_items'),
@@ -323,7 +329,9 @@ 
     } elseif ($args['step'] === 'create_users_fields_key') {
         // Loop on all encrypted fields for this item
         // and encrypt them for each user
-        if (WIP === true) provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+        if (WIP === true) {
+            provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+        }
         foreach($args['fields_keys'] as $field) {
             storeUsersShareKey(
                 prefixTable('sharekeys_fields'),