nilsteampassnet / TeamPass

api/Model/Operation.php

Braces +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
                 "error" => '',
             );
     
-        }catch (Exception $e) {    
+        } catch (Exception $e) {    
             return false;
         }
     }

sources/users.queries.php

Braces +3 added lines, -1 removed lines

@@ -2603,7 +2603,9 @@
             }
             
             foreach ($results as $adUser) {
-                if (isset($adUser[$SETTINGS['ldap_user_attribute']][0]) === false) continue;
+                if (isset($adUser[$SETTINGS['ldap_user_attribute']][0]) === false) {
+                    continue;
+                }
                 // Build the list of all groups in AD
                 if (isset($adUser['memberof']) === true) {
                     foreach($adUser['memberof'] as $j => $adUserGroup) {

includes/core/login.php

Braces +3 added lines, -1 removed lines

@@ -58,7 +58,9 @@
     $get['state'] = filter_var($_GET['state'], FILTER_SANITIZE_SPECIAL_CHARS);
     $get['session_state'] = filter_var($_GET['session_state'], FILTER_SANITIZE_SPECIAL_CHARS);
 
-    if (WIP === true) error_log('---- OAUTH2 START ----');
+    if (WIP === true) {
+        error_log('---- OAUTH2 START ----');
+    }
 
     // Création d'une instance du contrôleur
     $OAuth2 = new OAuth2Controller($SETTINGS);

pages/profile.php

Braces +5 added lines, -4 removed lines

@@ -401,12 +401,13 @@
                                             <select class="form-control" id="profile-user-timezone">
                                                 <?php foreach ($zones as $key => $zone): ?>
                                                     <option value="<?php echo $key; ?>"<?php 
-                                                        if ($session->has('user-timezone'))
-                                                            if($session->get('user-timezone') === $key)
+                                                        if ($session->has('user-timezone')) {
+                                                                                                                    if($session->get('user-timezone') === $key)
                                                                 echo ' selected';
-                                                            elseif ($session->get('user-timezone') === 'not_defined')
-                                                                if (isset($SETTINGS['timezone']) && $SETTINGS['timezone'] === $key)
+                                                        } elseif ($session->get('user-timezone') === 'not_defined') {
+                                                                                                                            if (isset($SETTINGS['timezone']) && $SETTINGS['timezone'] === $key)
                                                                     echo ' selected';
+                                                            }
                                                     ?>><?php echo $zone; ?></option>
                                                 <?php endforeach; ?>
                                             </select>

pages/tasks.php

Braces +1 added lines, -2 removed lines

@@ -149,8 +149,7 @@
                                             </div>
         <?php
     }
-}
-catch (Exception $e) {
+} catch (Exception $e) {
     if (defined('LOG_TO_SERVER') && LOG_TO_SERVER === true) {
         error_log('TEAMPASS Error - tasks page - '.$e->getMessage());
     }

sources/identify.php

Braces +9 added lines, -4 removed lines

@@ -2401,7 +2401,9 @@ 
         // Complete $userInfo
         $userInfo['has_been_created'] = 1;
 
-        if (WIP === true) error_log("--- USER CREATED ---");
+        if (WIP === true) {
+            error_log("--- USER CREATED ---");
+        }
 
         return [
             'error' => false,
@@ -2437,7 +2439,9 @@ 
         }
 
         // Oauth2 user already exists and authenticated
-        if (WIP === true) error_log("--- USER AUTHENTICATED ---");
+        if (WIP === true) {
+            error_log("--- USER AUTHENTICATED ---");
+        }
         $userInfo['has_been_created'] = 0;
 
         $passwordManager = new PasswordManager();
@@ -2667,8 +2671,9 @@ 
         );
 
         // No valid email address for user
-        if (!$userInfos || !filter_var($userInfos['email'], FILTER_VALIDATE_EMAIL))
-            return;
+        if (!$userInfos || !filter_var($userInfos['email'], FILTER_VALIDATE_EMAIL)) {
+                    return;
+        }
 
         $unlock_url = $SETTINGS['cpassman_url'].'/self-unlock.php?login='.$value.'&otp='.$unlock_code;
 

sources/tools.queries.php

Switch Indentation +171 added lines, -171 removed lines

@@ -91,215 +91,215 @@
 switch ($post_type) {
 //##########################################################
 //CASE for creating a DB backup
-case 'perform_fix_pf_items-step1':
-    // Check KEY
-    if (!hash_equals((string) $session->get('key'), (string) $post_key)) {
-        echo prepareExchangedData(
-            array(
-                'error' => true,
-                'message' => $lang->get('key_is_not_correct'),
-            ),
-            'encode'
-        );
-        break;
-    }
-    // Is admin?
-    if ((int) $session->get('user-admin') !== 1) {
-        echo prepareExchangedData(
-            array(
-                'error' => true,
-                'message' => $lang->get('error_not_allowed_to'),
-            ),
-            'encode'
-        );
-        break;
-    }
+    case 'perform_fix_pf_items-step1':
+        // Check KEY
+        if (!hash_equals((string) $session->get('key'), (string) $post_key)) {
+            echo prepareExchangedData(
+                array(
+                    'error' => true,
+                    'message' => $lang->get('key_is_not_correct'),
+                ),
+                'encode'
+            );
+            break;
+        }
+        // Is admin?
+        if ((int) $session->get('user-admin') !== 1) {
+            echo prepareExchangedData(
+                array(
+                    'error' => true,
+                    'message' => $lang->get('error_not_allowed_to'),
+                ),
+                'encode'
+            );
+            break;
+        }
 
-    // decrypt and retrieve data in JSON format
-    $dataReceived = prepareExchangedData(
-        $post_data,
-        'decode'
-    );
+        // decrypt and retrieve data in JSON format
+        $dataReceived = prepareExchangedData(
+            $post_data,
+            'decode'
+        );
 
-    $userId = filter_var($dataReceived['userId'], FILTER_SANITIZE_NUMBER_INT);
+        $userId = filter_var($dataReceived['userId'], FILTER_SANITIZE_NUMBER_INT);
 
-    // Get user info
-    $userInfo = DB::queryFirstRow(
-        'SELECT private_key, public_key, psk, encrypted_psk
+        // Get user info
+        $userInfo = DB::queryFirstRow(
+            'SELECT private_key, public_key, psk, encrypted_psk
         FROM teampass_users
         WHERE id = %i',
-        $userId
-    );
+            $userId
+        );
 
-    // Get user's private folders
-    $userPFRoot = DB::queryFirstRow(
-        'SELECT id
+        // Get user's private folders
+        $userPFRoot = DB::queryFirstRow(
+            'SELECT id
         FROM teampass_nested_tree
         WHERE title = %i',
-        $userId
-    );
-    if (DB::count() === 0) {
-        echo prepareExchangedData(
-            array(
-                'error' => true,
-                'message' => 'User has no personal folders',
-            ),
-            'encode'
-        );
-        break;
-    }
-    $personalFolders = [];
-    $tree = new NestedTree(prefixTable('nested_tree'), 'id', 'parent_id', 'title');
-    $tree->rebuild();
-    $folders = $tree->getDescendants($userPFRoot['id'], true);
-    foreach ($folders as $folder) {
-        array_push($personalFolders, $folder->id);
-    }
-
-    //Show done
-    echo prepareExchangedData(
-        array(
-            'error' => false,
-            'message' => 'Personal Folders found: ',
-            'personalFolders' => json_encode($personalFolders),
-        ),
-        'encode'
-    );
-    break;
-
-case 'perform_fix_pf_items-step2':
-    // Check KEY
-    if (!hash_equals((string) $session->get('key'), (string) $post_key)) {
-        echo prepareExchangedData(
-            array(
-                'error' => true,
-                'message' => $lang->get('key_is_not_correct'),
-            ),
-            'encode'
+            $userId
         );
-        break;
-    }
-    // Is admin?
-    if ((int) $session->get('user-admin') !== 1) {
+        if (DB::count() === 0) {
+            echo prepareExchangedData(
+                array(
+                    'error' => true,
+                    'message' => 'User has no personal folders',
+                ),
+                'encode'
+            );
+            break;
+        }
+        $personalFolders = [];
+        $tree = new NestedTree(prefixTable('nested_tree'), 'id', 'parent_id', 'title');
+        $tree->rebuild();
+        $folders = $tree->getDescendants($userPFRoot['id'], true);
+        foreach ($folders as $folder) {
+            array_push($personalFolders, $folder->id);
+        }
+
+        //Show done
         echo prepareExchangedData(
             array(
-                'error' => true,
-                'message' => $lang->get('error_not_allowed_to'),
+                'error' => false,
+                'message' => 'Personal Folders found: ',
+                'personalFolders' => json_encode($personalFolders),
             ),
             'encode'
         );
         break;
-    }
 
-    // decrypt and retrieve data in JSON format
-    $dataReceived = prepareExchangedData(
-        $post_data,
-        'decode'
-    );
+    case 'perform_fix_pf_items-step2':
+        // Check KEY
+        if (!hash_equals((string) $session->get('key'), (string) $post_key)) {
+            echo prepareExchangedData(
+                array(
+                    'error' => true,
+                    'message' => $lang->get('key_is_not_correct'),
+                ),
+                'encode'
+            );
+            break;
+        }
+        // Is admin?
+        if ((int) $session->get('user-admin') !== 1) {
+            echo prepareExchangedData(
+                array(
+                    'error' => true,
+                    'message' => $lang->get('error_not_allowed_to'),
+                ),
+                'encode'
+            );
+            break;
+        }
 
-    $userId = filter_var($dataReceived['userId'], FILTER_SANITIZE_NUMBER_INT);
-    $personalFolders = filter_var($dataReceived['personalFolders'], FILTER_SANITIZE_FULL_SPECIAL_CHARS);
+        // decrypt and retrieve data in JSON format
+        $dataReceived = prepareExchangedData(
+            $post_data,
+            'decode'
+        );
+
+        $userId = filter_var($dataReceived['userId'], FILTER_SANITIZE_NUMBER_INT);
+        $personalFolders = filter_var($dataReceived['personalFolders'], FILTER_SANITIZE_FULL_SPECIAL_CHARS);
 
-    // Delete all private items with sharekeys
-    $pfiSharekeys = DB::queryFirstColumn(
-        'select s.increment_id
+        // Delete all private items with sharekeys
+        $pfiSharekeys = DB::queryFirstColumn(
+            'select s.increment_id
         from teampass_sharekeys_items as s
         INNER JOIN teampass_items AS i ON (i.id = s.object_id)
         WHERE s.user_id = %i AND i.perso = 1 AND i.id_tree IN %ls',
-        $userId,
-        $personalFolders
-    );
-    $pfiSharekeysCount = DB::count();
-    if ($pfiSharekeysCount > 0) {
-        DB::delete(
-            "teampass_sharekeys_items",
-            "increment_id IN %ls",
-            $pfiSharekeys
+            $userId,
+            $personalFolders
         );
-    }
+        $pfiSharekeysCount = DB::count();
+        if ($pfiSharekeysCount > 0) {
+            DB::delete(
+                "teampass_sharekeys_items",
+                "increment_id IN %ls",
+                $pfiSharekeys
+            );
+        }
 
     
-    //Show done
-    echo prepareExchangedData(
-        array(
-            'error' => false,
-            'message' => '<br>Number of Sharekeys for private items DELETED: ',
-            'nbDeleted' => $pfiSharekeysCount,
-            'personalFolders' => json_encode($personalFolders),
-        ),
-        'encode'
-    );
-    break;
-
-case 'perform_fix_pf_items-step3':
-    // Check KEY
-    if (!hash_equals((string) $session->get('key'), (string) $post_key)) {
-        echo prepareExchangedData(
-            array(
-                'error' => true,
-                'message' => $lang->get('key_is_not_correct'),
-            ),
-            'encode'
-        );
-        break;
-    }
-    // Is admin?
-    if ((int) $session->get('user-admin') !== 1) {
+        //Show done
         echo prepareExchangedData(
             array(
-                'error' => true,
-                'message' => $lang->get('error_not_allowed_to'),
+                'error' => false,
+                'message' => '<br>Number of Sharekeys for private items DELETED: ',
+                'nbDeleted' => $pfiSharekeysCount,
+                'personalFolders' => json_encode($personalFolders),
             ),
             'encode'
         );
         break;
-    }
 
-    // decrypt and retrieve data in JSON format
-    $dataReceived = prepareExchangedData(
-        $post_data,
-        'decode'
-    );
+    case 'perform_fix_pf_items-step3':
+        // Check KEY
+        if (!hash_equals((string) $session->get('key'), (string) $post_key)) {
+            echo prepareExchangedData(
+                array(
+                    'error' => true,
+                    'message' => $lang->get('key_is_not_correct'),
+                ),
+                'encode'
+            );
+            break;
+        }
+        // Is admin?
+        if ((int) $session->get('user-admin') !== 1) {
+            echo prepareExchangedData(
+                array(
+                    'error' => true,
+                    'message' => $lang->get('error_not_allowed_to'),
+                ),
+                'encode'
+            );
+            break;
+        }
+
+        // decrypt and retrieve data in JSON format
+        $dataReceived = prepareExchangedData(
+            $post_data,
+            'decode'
+        );
 
-    $userId = filter_var($dataReceived['userId'], FILTER_SANITIZE_NUMBER_INT);
-    $personalFolders = filter_var($dataReceived['personalFolders'], FILTER_SANITIZE_FULL_SPECIAL_CHARS);
+        $userId = filter_var($dataReceived['userId'], FILTER_SANITIZE_NUMBER_INT);
+        $personalFolders = filter_var($dataReceived['personalFolders'], FILTER_SANITIZE_FULL_SPECIAL_CHARS);
 
-    // Update from items_old to items all the private itemsitems that have been converted to teampass_aes
-    // Get all key back
-    $items = DB::query(
-        "SELECT id
+        // Update from items_old to items all the private itemsitems that have been converted to teampass_aes
+        // Get all key back
+        $items = DB::query(
+            "SELECT id
         FROM teampass_items
         WHERE id_tree IN %ls AND encryption_type = %s",
-        $personalFolders,
-        "teampass_aes"
-    );
-    //DB::debugMode(false);
-    $nbItems = DB::count();
-    foreach ($items as $item) {
-        $defusePwd = DB::queryFirstField("SELECT pw FROM teampass_items_old WHERE id = %i", $item['id']);
-        DB::update(
-            "teampass_items",
-            ['pw' => $defusePwd, "encryption_type" => "defuse"],
-            "id = %i",
-            $item['id']
+            $personalFolders,
+            "teampass_aes"
         );
-    }
+        //DB::debugMode(false);
+        $nbItems = DB::count();
+        foreach ($items as $item) {
+            $defusePwd = DB::queryFirstField("SELECT pw FROM teampass_items_old WHERE id = %i", $item['id']);
+            DB::update(
+                "teampass_items",
+                ['pw' => $defusePwd, "encryption_type" => "defuse"],
+                "id = %i",
+                $item['id']
+            );
+        }
 
     
-    //Show done
-    echo prepareExchangedData(
-        array(
-            'error' => false,
-            'message' => '<br>Number of items reseted to Defuse: ',
-            'nbItems' => $nbItems,
-            'personalFolders' => json_encode($personalFolders),
-        ),
-        'encode'
-    );
-    break;
-
-    /* TOOL #2 - Fixing items master keys */
-    /*
+        //Show done
+        echo prepareExchangedData(
+            array(
+                'error' => false,
+                'message' => '<br>Number of items reseted to Defuse: ',
+                'nbItems' => $nbItems,
+                'personalFolders' => json_encode($personalFolders),
+            ),
+            'encode'
+        );
+        break;
+
+        /* TOOL #2 - Fixing items master keys */
+        /*
     * STEP 1 - Check if we have the correct pwd for TP_USER
     */
     case 'perform_fix_items_master_keys-step1':

sources/folders.class.php

Braces +6 added lines, -4 removed lines

@@ -112,8 +112,9 @@ 
      */
     private function isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin, $user_can_create_root_folder)
     {
-        if ($parent_id == 0 && $user_can_create_root_folder == true)
-	    return true;
+        if ($parent_id == 0 && $user_can_create_root_folder == true) {
+        	    return true;
+        }
 
         if (in_array($parent_id, $user_accessible_folders) === false
             && (int) $user_is_admin !== 1
@@ -438,8 +439,9 @@ 
             )['count'];
 
             // Don't insert duplicates
-            if ($count > 0)
-                continue;
+            if ($count > 0) {
+                            continue;
+            }
 
             // Insert new background task
             DB::insert(

scripts/background_tasks___handler.php

Braces +21 added lines, -7 removed lines

@@ -55,7 +55,9 @@ 
     public function processBackgroundTasks() {
         // Prevent multiple concurrent executions
         if (!$this->acquireProcessLock()) {
-            if (LOG_TASKS=== true) $this->logger->log('Process already running', 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Process already running', 'INFO');
+            }
             return false;
         }
 
@@ -64,7 +66,9 @@ 
             $this->processTaskBatches();
             $this->performMaintenanceTasks();
         } catch (Exception $e) {
-            if (LOG_TASKS=== true) $this->logger->log('Task processing error: ' . $e->getMessage(), 'ERROR');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Task processing error: ' . $e->getMessage(), 'ERROR');
+            }
         } finally {
             $this->releaseProcessLock();
         }
@@ -131,7 +135,9 @@ 
         
         // Check if the maximum number of parallel tasks is reached
         if ($runningTasks >= $this->maxParallelTasks) {
-            if (LOG_TASKS=== true) $this->logger->log('Wait ... '.$runningTasks.' out of '.$this->maxParallelTasks.' are already running ', 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Wait ... '.$runningTasks.' out of '.$this->maxParallelTasks.' are already running ', 'INFO');
+            }
             return;
         }
 
@@ -149,7 +155,9 @@ 
         );
 
         foreach ($tasks as $task) {
-            if (LOG_TASKS=== true) $this->logger->log('Launching '.$task['increment_id'], 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Launching '.$task['increment_id'], 'INFO');
+            }
             $this->processIndividualTask($task);
         }
     }
@@ -160,7 +168,9 @@ 
      * @param array $task The task to process.
      */
     private function processIndividualTask(array $task) {
-        if (LOG_TASKS=== true)  $this->logger->log('Starting task: ' . print_r($task, true), 'INFO');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Starting task: ' . print_r($task, true), 'INFO');
+        }
 
         // Store progress in the database        
         DB::update(
@@ -188,7 +198,9 @@ 
             $process->mustRun();
 
         } catch (Exception $e) {
-            if (LOG_TASKS=== true) $this->logger->log('Error launching task: ' . $e->getMessage(), 'ERROR');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Error launching task: ' . $e->getMessage(), 'ERROR');
+            }
             DB::update(
                 prefixTable('background_tasks'),
                 [
@@ -290,7 +302,9 @@ 
             $taskIds
         );
     
-        if (LOG_TASKS=== true) $this->logger->log('Old finished tasks cleaned: ' . count($taskIds), 'INFO');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Old finished tasks cleaned: ' . count($taskIds), 'INFO');
+        }
     }
 }