nilsteampassnet / TeamPass

scripts/background_tasks___worker.php

Braces +18 added lines, -6 removed lines

@@ -64,7 +64,9 @@ 
      */
     public function execute() {
         try {
-            if (LOG_TASKS=== true) $this->logger->log('Processing task: ' . print_r($this->taskData, true), 'DEBUG');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('Processing task: ' . print_r($this->taskData, true), 'DEBUG');
+            }
             // Dispatch selon le type de processus
             switch ($this->processType) {
                 case 'item_copy':
@@ -136,7 +138,9 @@ 
             $arguments = '';
         }
 
-        if (LOG_TASKS=== true) $this->logger->log('Process: '.$this->processType.' -- '.print_r($arguments, true), 'DEBUG');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Process: '.$this->processType.' -- '.print_r($arguments, true), 'DEBUG');
+        }
 
         // Add 'arguments' only if not empty
         if (!empty($arguments)) {
@@ -150,7 +154,9 @@ 
             'increment_id = %i',
             $this->taskId
         );
-        if (LOG_TASKS=== true) $this->logger->log('Finishing task: ' . $this->taskId, 'DEBUG');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Finishing task: ' . $this->taskId, 'DEBUG');
+        }
     }
 
     /**
@@ -185,7 +191,9 @@ 
      * @return void
      */
     private function processSubTasks($arguments) {
-        if (LOG_TASKS=== true) $this->logger->log('processSubTasks: '.print_r($arguments, true), 'DEBUG');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('processSubTasks: '.print_r($arguments, true), 'DEBUG');
+        }
         // Get all subtasks related to this task
         $subtasks = DB::query(
             'SELECT * FROM ' . prefixTable('background_subtasks') . ' WHERE task_id = %i AND is_in_progress = 0 ORDER BY `task` ASC',
@@ -194,7 +202,9 @@ 
     
         // Check if there are any subtasks to process
         if (empty($subtasks)) {
-            if (LOG_TASKS=== true) $this->logger->log('No subtask was found for task: ' . $this->taskId, 'DEBUG');
+            if (LOG_TASKS=== true) {
+                $this->logger->log('No subtask was found for task: ' . $this->taskId, 'DEBUG');
+            }
             return;
         }
     
@@ -204,7 +214,9 @@ 
                 // Get the subtask data
                 $subtaskData = json_decode($subtask['task'], true);
 
-                if (LOG_TASKS=== true) $this->logger->log('Processing subtask: ' . $subtaskData['step'], 'DEBUG');
+                if (LOG_TASKS=== true) {
+                    $this->logger->log('Processing subtask: ' . $subtaskData['step'], 'DEBUG');
+                }
 
                 // Mark subtask as in progress
                 DB::update(

sources/items.queries.php

Braces +12 added lines, -5 removed lines

@@ -1228,7 +1228,9 @@ 
                 );
 
                 // Create a task to create sharekeys for users
-                if (WIP=== true) error_log('createTaskForItem - new password for this item - '.$post_password ." -- ". $pw);
+                if (WIP=== true) {
+                    error_log('createTaskForItem - new password for this item - '.$post_password ." -- ". $pw);
+                }
                 $tasksToBePerformed = ['item_password'];
                 $encryptionTaskIsRequested = true;
             } else {
@@ -1553,7 +1555,9 @@ 
 
             // create a task for all fields updated
             if ($encryptionTaskIsRequested === true && (int) $dataItem['perso'] !== 1) {
-                if (WIP === true) error_log('createTaskForItem - '.print_r($tasksToBePerformed, true));
+                if (WIP === true) {
+                    error_log('createTaskForItem - '.print_r($tasksToBePerformed, true));
+                }
                 createTaskForItem(
                     'item_update_create_keys',
                     array_unique($tasksToBePerformed),
@@ -2103,7 +2107,9 @@ 
                 $inputData['itemId']
             );
             foreach ($rows as $record) {
-                if ($record['raison'] === NULL) continue;
+                if ($record['raison'] === NULL) {
+                    continue;
+                }
                 $reason = explode(':', $record['raison']);
                 if (count($reason) > 0) {
                     $sentence = date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['date']) . ' - '
@@ -4819,8 +4825,9 @@ 
                 $ids = $tree->getDescendants($folder['id'], true, false, true);
 
                 // This folder is owned by user
-                if (in_array($inputData['folderId'], $ids))
-                    $accessLevel = 30;
+                if (in_array($inputData['folderId'], $ids)) {
+                                    $accessLevel = 30;
+                }
             }
         }
 

scripts/traits/MigrateUserHandlerTrait.php

Braces +9 added lines, -3 removed lines

@@ -45,13 +45,17 @@ 
         );
     
         if (empty($subtasks)) {
-            if (LOG_TASKS=== true) $this->logger->log("No subtask was found for task {$this->taskId}");
+            if (LOG_TASKS=== true) {
+                $this->logger->log("No subtask was found for task {$this->taskId}");
+            }
             return;
         }
     
         // Process each subtask
         foreach ($subtasks as $subtask) {
-            if (LOG_TASKS=== true) $this->logger->log("Processing subtask {$subtask['increment_id']} for task {$this->taskId}");
+            if (LOG_TASKS=== true) {
+                $this->logger->log("Processing subtask {$subtask['increment_id']} for task {$this->taskId}");
+            }
             $this->processMigratePersonalItemsSubtask($subtask, $arguments);
         }
     
@@ -88,7 +92,9 @@ 
                 $subtask['increment_id']
             );
             
-            if (LOG_TASKS=== true) $this->logger->log("Subtask is in progress: ".$taskData['step'], 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log("Subtask is in progress: ".$taskData['step'], 'INFO');
+            }
             switch ($taskData['step'] ?? '') {
                 case 'user-personal-items-migration-step10':
                     $this->migratePersonalItemsStep10($taskData, $arguments);

scripts/traits/UserHandlerTrait.php

Braces +13 added lines, -5 removed lines

@@ -55,13 +55,17 @@ 
         );
     
         if (empty($subtasks)) {
-            if (LOG_TASKS=== true) $this->logger->log("No subtask was found for task {$this->taskId}");
+            if (LOG_TASKS=== true) {
+                $this->logger->log("No subtask was found for task {$this->taskId}");
+            }
             return;
         }
     
         // Process each subtask
         foreach ($subtasks as $subtask) {
-            if (LOG_TASKS=== true) $this->logger->log("Processing subtask {$subtask['increment_id']} for task {$this->taskId}");
+            if (LOG_TASKS=== true) {
+                $this->logger->log("Processing subtask {$subtask['increment_id']} for task {$this->taskId}");
+            }
             $this->processGenerateUserKeysSubtask($subtask, $arguments);
         }
     
@@ -98,7 +102,9 @@ 
                 $subtask['increment_id']
             );
             
-            if (LOG_TASKS=== true) $this->logger->log("Subtask is in progress: ".$taskData['step'], 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log("Subtask is in progress: ".$taskData['step'], 'INFO');
+            }
             switch ($taskData['step'] ?? '') {
                 case 'step0':
                     $this->generateNewUserStep0($arguments);
@@ -165,7 +171,9 @@ 
     private function generateNewUserStep0($arguments) {
         // CLear old sharekeys
         if ($arguments['user_self_change'] === 0) {
-            if (LOG_TASKS=== true) $this->logger->log("Deleting old sharekeys for user {$arguments['new_user_id']}", 'INFO');
+            if (LOG_TASKS=== true) {
+                $this->logger->log("Deleting old sharekeys for user {$arguments['new_user_id']}", 'INFO');
+            }
             deleteUserObjetsKeys($arguments['new_user_id'], $this->settings);
         }
     }
@@ -780,7 +788,7 @@ 
                 'login' => $userInfo['login'],
                 'name' => $userInfo['name'],
             ];
-        }else {
+        } else {
             // Normal case
             return [
                 'private_key' => decryptPrivateKey($pwd, $userInfo['private_key']),

pages/admin.php

Braces +1 added lines, -2 removed lines

@@ -490,8 +490,7 @@
                                         </div>
         <?php
     }
-}
-catch (Exception $e) {
+} catch (Exception $e) {
     if (defined('LOG_TO_SERVER') && LOG_TO_SERVER === true) {
         error_log('TEAMPASS Error - admin page - '.$e->getMessage());
     }

scripts/traits/ItemHandlerTrait.php

Braces +9 added lines, -3 removed lines

@@ -29,7 +29,9 @@ 
 trait ItemHandlerTrait {    
 
     private function generateUserPasswordKeys($arguments) {
-        if (LOG_TASKS=== true) $this->logger->log('Processing generateUserPasswordKeys : '.print_r($arguments, true), 'DEBUG');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Processing generateUserPasswordKeys : '.print_r($arguments, true), 'DEBUG');
+        }
         // Generate keys for user passwords   
         storeUsersShareKey(
             'sharekeys_items',
@@ -49,7 +51,9 @@ 
      * @param array $taskData
      */
     private function generateUserFileKeys($taskData) {    
-        if (LOG_TASKS=== true) $this->logger->log('Processing generateUserFileKeys : '.print_r($taskData, true), 'DEBUG');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Processing generateUserFileKeys : '.print_r($taskData, true), 'DEBUG');
+        }
         foreach($taskData['files_keys'] as $file) {
             storeUsersShareKey(
                 'sharekeys_files',
@@ -70,7 +74,9 @@ 
      * @param array $arguments
      */
     private function generateUserFieldKeys($arguments) {
-        if (LOG_TASKS=== true) $this->logger->log('Processing generateUserFieldKeys : '.print_r($arguments, true), 'DEBUG');
+        if (LOG_TASKS=== true) {
+            $this->logger->log('Processing generateUserFieldKeys : '.print_r($arguments, true), 'DEBUG');
+        }
         foreach($arguments['fields_keys'] as $field) {
             $this->logger->log('Processing generateUserFieldKeys for: ' . $field['object_id'], 'DEBUG');
             storeUsersShareKey(

sources/main.functions.php

Braces +18 added lines, -9 removed lines

@@ -2604,7 +2604,9 @@ 
 function encryptUserObjectKey(string $key, string $publicKey): string
 {
     // Empty password
-    if (empty($key)) return '';
+    if (empty($key)) {
+        return '';
+    }
 
     // Sanitize
     $antiXss = new AntiXSS();
@@ -2753,7 +2755,9 @@ 
         ];
     }
 
-    if (WIP) error_log('DEBUG: File image url -> '.filter_var($safeFilePath, FILTER_SANITIZE_URL));
+    if (WIP) {
+        error_log('DEBUG: File image url -> '.filter_var($safeFilePath, FILTER_SANITIZE_URL));
+    }
 
     // Decrypt file content and return
     return base64_encode($cipher->decrypt($ciphertext));
@@ -4232,7 +4236,9 @@ 
         $taskName = [$taskName];
     }
     foreach($taskName as $task) {
-        if (WIP === true) error_log('createTaskForItem - task: '.$task);
+        if (WIP === true) {
+            error_log('createTaskForItem - task: '.$task);
+        }
         switch ($task) {
             case 'item_password':
                 
@@ -4665,19 +4671,22 @@ 
 
             // Organisation name (removed username@ and .tld)
             $domain = explode('.', $emailParts[1]);
-            if (count($domain) > 1)
-                $forbiddenWords[] = $domain[0];
+            if (count($domain) > 1) {
+                            $forbiddenWords[] = $domain[0];
+            }
         }
     }
 
     // Search forbidden words in password
     foreach ($forbiddenWords as $word) {
-        if (empty($word))
-            continue;
+        if (empty($word)) {
+                    continue;
+        }
 
         // Stop if forbidden word found in password
-        if (stripos($password, $word) !== false)
-            return false;
+        if (stripos($password, $word) !== false) {
+                    return false;
+        }
     }
 
     // Get password complexity