Passed
Push — dev ( 3ad29f...97f4bd )
by Nils
08:12
created
sources/upload.files.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 ) {
69 69
     // Not allowed page
70 70
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
71
-    include $SETTINGS['cpassman_dir'] . '/error.php';
71
+    include $SETTINGS['cpassman_dir'].'/error.php';
72 72
     exit;
73 73
 }
74 74
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     } else {
119 119
         // check if token is expired
120 120
         $data = DB::queryFirstRow(
121
-            'SELECT end_timestamp FROM ' . prefixTable('tokens') . ' WHERE user_id = %i AND token = %s',
121
+            'SELECT end_timestamp FROM '.prefixTable('tokens').' WHERE user_id = %i AND token = %s',
122 122
             $_SESSION['user_id'],
123 123
             $post_user_token
124 124
         );
@@ -142,12 +142,12 @@  discard block
 block discarded – undo
142 142
 
143 143
 // HTTP headers for no cache etc
144 144
 header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
145
-header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
145
+header('Last-Modified: '.gmdate('D, d M Y H:i:s').' GMT');
146 146
 header('Cache-Control: no-store, no-cache, must-revalidate');
147 147
 header('Cache-Control: post-check=0, pre-check=0', false);
148 148
 
149 149
 if (null !== $post_type_upload && $post_type_upload === 'upload_profile_photo') {
150
-    $targetDir = $SETTINGS['cpassman_dir'] . '/includes/avatars';
150
+    $targetDir = $SETTINGS['cpassman_dir'].'/includes/avatars';
151 151
 } else {
152 152
     $targetDir = $SETTINGS['path_to_files_folder'];
153 153
 }
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 
209 209
 // Validate file name (for our purposes we'll just remove invalid characters)
210 210
 $file_name = preg_replace(
211
-    '/[^' . $valid_chars_regex . '\.]/',
211
+    '/[^'.$valid_chars_regex.'\.]/',
212 212
     '',
213 213
     filter_var(
214 214
         strtolower(basename($_FILES['file']['name'])),
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
     )
217 217
 );
218 218
 if (strlen($file_name) == 0 || strlen($file_name) > $MAX_FILENAME_LENGTH) {
219
-    handleUploadError('Invalid file name: ' . $file_name . '.');
219
+    handleUploadError('Invalid file name: '.$file_name.'.');
220 220
     return false;
221 221
 }
222 222
 
@@ -231,8 +231,8 @@  discard block
 block discarded – undo
231 231
         $ext,
232 232
         explode(
233 233
             ',',
234
-            $SETTINGS['upload_docext'] . ',' . $SETTINGS['upload_imagesext'] .
235
-                ',' . $SETTINGS['upload_pkgext'] . ',' . $SETTINGS['upload_otherext']
234
+            $SETTINGS['upload_docext'].','.$SETTINGS['upload_imagesext'].
235
+                ','.$SETTINGS['upload_pkgext'].','.$SETTINGS['upload_otherext']
236 236
         )
237 237
     ) === false
238 238
     && $post_type_upload !== 'import_items_from_keepass'
@@ -245,28 +245,28 @@  discard block
 block discarded – undo
245 245
 
246 246
 // is destination folder writable
247 247
 if (is_writable($SETTINGS['path_to_files_folder']) === false) {
248
-    handleUploadError('Not enough permissions on folder ' . $SETTINGS['path_to_files_folder'] . '.');
248
+    handleUploadError('Not enough permissions on folder '.$SETTINGS['path_to_files_folder'].'.');
249 249
     return false;
250 250
 }
251 251
 
252 252
 // Clean the fileName for security reasons
253 253
 $fileName = preg_replace('/[^\w\.]+/', '_', $fileName);
254
-$fileName = preg_replace('/[^' . $valid_chars_regex . '\.]/', '', strtolower(basename($fileName)));
254
+$fileName = preg_replace('/[^'.$valid_chars_regex.'\.]/', '', strtolower(basename($fileName)));
255 255
 
256 256
 // Make sure the fileName is unique but only if chunking is disabled
257
-if ($chunks < 2 && file_exists($targetDir . DIRECTORY_SEPARATOR . $fileName)) {
257
+if ($chunks < 2 && file_exists($targetDir.DIRECTORY_SEPARATOR.$fileName)) {
258 258
     $fileNameA = substr($fileName, 0, strlen($ext));
259 259
     $fileNameB = substr($fileName, strlen($ext));
260 260
 
261 261
     $count = 1;
262
-    while (file_exists($targetDir . DIRECTORY_SEPARATOR . $fileNameA . '_' . $count . $fileNameB)) {
262
+    while (file_exists($targetDir.DIRECTORY_SEPARATOR.$fileNameA.'_'.$count.$fileNameB)) {
263 263
         ++$count;
264 264
     }
265 265
 
266
-    $fileName = $fileNameA . '_' . $count . $fileNameB;
266
+    $fileName = $fileNameA.'_'.$count.$fileNameB;
267 267
 }
268 268
 
269
-$filePath = $targetDir . DIRECTORY_SEPARATOR . $fileName;
269
+$filePath = $targetDir.DIRECTORY_SEPARATOR.$fileName;
270 270
 
271 271
 // Create target dir
272 272
 if (!file_exists($targetDir)) {
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 // Remove old temp files
281 281
 if ($cleanupTargetDir && is_dir($targetDir) && ($dir = opendir($targetDir))) {
282 282
     while (($file = readdir($dir)) !== false) {
283
-        $tmpfilePath = $targetDir . DIRECTORY_SEPARATOR . $file;
283
+        $tmpfilePath = $targetDir.DIRECTORY_SEPARATOR.$file;
284 284
 
285 285
         // Remove temp file if it is older than the max age and is not the current file
286 286
         if (
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
 ) {
377 377
     rename(
378 378
         $filePath,
379
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName
379
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName
380 380
     );
381 381
 
382 382
     // Add in DB
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
 ) {
406 406
     rename(
407 407
         $filePath,
408
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName
408
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName
409 409
     );
410 410
 
411 411
     // Add in DB
@@ -438,13 +438,13 @@  discard block
 block discarded – undo
438 438
     // rename the file
439 439
     rename(
440 440
         $filePath,
441
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName . '.' . $ext
441
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName.'.'.$ext
442 442
     );
443 443
 
444 444
     // make thumbnail
445 445
     $ret = makeThumbnail(
446
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName . '.' . $ext,
447
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName . '_thumb' . '.' . $ext,
446
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName.'.'.$ext,
447
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName.'_thumb'.'.'.$ext,
448 448
         40
449 449
     );
450 450
 
@@ -455,21 +455,21 @@  discard block
 block discarded – undo
455 455
     }
456 456
 
457 457
     // get current avatar and delete it
458
-    $data = DB::queryFirstRow('SELECT avatar, avatar_thumb FROM ' . prefixTable('users') . ' WHERE id=%i', $_SESSION['user_id']);
459
-    fileDelete($targetDir . DIRECTORY_SEPARATOR . $data['avatar'], $SETTINGS);
460
-    fileDelete($targetDir . DIRECTORY_SEPARATOR . $data['avatar_thumb'], $SETTINGS);
458
+    $data = DB::queryFirstRow('SELECT avatar, avatar_thumb FROM '.prefixTable('users').' WHERE id=%i', $_SESSION['user_id']);
459
+    fileDelete($targetDir.DIRECTORY_SEPARATOR.$data['avatar'], $SETTINGS);
460
+    fileDelete($targetDir.DIRECTORY_SEPARATOR.$data['avatar_thumb'], $SETTINGS);
461 461
 
462 462
     // store in DB the new avatar
463 463
     DB::query(
464
-        'UPDATE ' . prefixTable('users') . "
465
-        SET avatar='" . $newFileName . '.' . $ext . "', avatar_thumb='" . $newFileName . '_thumb' . '.' . $ext . "'
464
+        'UPDATE '.prefixTable('users')."
465
+        SET avatar='" . $newFileName.'.'.$ext."', avatar_thumb='".$newFileName.'_thumb'.'.'.$ext."'
466 466
         WHERE id=%i",
467 467
         $_SESSION['user_id']
468 468
     );
469 469
 
470 470
     // store in session
471
-    $_SESSION['user_avatar'] = $newFileName . '.' . $ext;
472
-    $_SESSION['user_avatar_thumb'] = $newFileName . '_thumb' . '.' . $ext;
471
+    $_SESSION['user_avatar'] = $newFileName.'.'.$ext;
472
+    $_SESSION['user_avatar_thumb'] = $newFileName.'_thumb'.'.'.$ext;
473 473
 
474 474
     // return info
475 475
     echo prepareExchangedData(
@@ -488,7 +488,7 @@  discard block
 block discarded – undo
488 488
 ) {
489 489
     rename(
490 490
         $filePath,
491
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName
491
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName
492 492
     );
493 493
 
494 494
     // Add in DB
Please login to merge, or discard this patch.
sources/roles.queries.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 ) {
69 69
     // Not allowed page
70 70
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
71
-    include $SETTINGS['cpassman_dir'] . '/error.php';
71
+    include $SETTINGS['cpassman_dir'].'/error.php';
72 72
     exit;
73 73
 }
74 74
 
@@ -739,7 +739,7 @@  discard block
 block discarded – undo
739 739
                 echo prepareExchangedData(
740 740
                     array(
741 741
                         'error' => true,
742
-                        'message' => "Error : ".$error->getErrorCode()." - ".$error->getErrorMessage(). "<br>".$error->getDiagnosticMessage(),
742
+                        'message' => "Error : ".$error->getErrorCode()." - ".$error->getErrorMessage()."<br>".$error->getDiagnosticMessage(),
743 743
                     ),
744 744
                     'encode'
745 745
                 );
@@ -755,7 +755,7 @@  discard block
 block discarded – undo
755 755
                 $matches
756 756
             );
757 757
             $searchCriteria = [];
758
-            foreach($matches[0] as $match) {
758
+            foreach ($matches[0] as $match) {
759 759
                 $parts = [];
760 760
                 if (!str_contains($match, ',')) {
761 761
                     $tmp = explode("=", trim($match, '()'));
@@ -770,14 +770,14 @@  discard block
 block discarded – undo
770 770
 
771 771
             // check if synched with roles in Teampass
772 772
             $retAD = [];
773
-            foreach($retGroups as $key => $group) {
773
+            foreach ($retGroups as $key => $group) {
774 774
                 // exists in Teampass
775 775
                 $role_detail = DB::queryfirstrow(
776 776
                     'SELECT a.increment_id, a.role_id, r.title
777 777
                     FROM '.prefixTable('ldap_groups_roles').' AS a
778 778
                     INNER JOIN '.prefixTable('roles_title').' AS r ON r.id = a.role_id
779 779
                     WHERE ldap_group_id = %i',
780
-                    $group[(isset($SETTINGS['ldap_guid_attibute']) === true && empty($SETTINGS['ldap_guid_attibute']) === false ? $SETTINGS['ldap_guid_attibute']: 'gidnumber')][0]
780
+                    $group[(isset($SETTINGS['ldap_guid_attibute']) === true && empty($SETTINGS['ldap_guid_attibute']) === false ? $SETTINGS['ldap_guid_attibute'] : 'gidnumber')][0]
781 781
                 );
782 782
                 $counter = DB::count();
783 783
 
@@ -792,7 +792,7 @@  discard block
 block discarded – undo
792 792
                     [
793 793
                         'ad_group_id' => (int) $group[(isset($SETTINGS['ldap_guid_attibute']) === true && empty($SETTINGS['ldap_guid_attibute']) === false ? $SETTINGS['ldap_guid_attibute'] : 'gidnumber')][0],
794 794
                         'ad_group_title' => $group['cn'][0],
795
-                        'role_id' => $counter> 0 ? (int) $role_detail['role_id'] : -1,
795
+                        'role_id' => $counter > 0 ? (int) $role_detail['role_id'] : -1,
796 796
                         'id' => $counter > 0 ? (int) $role_detail['increment_id'] : -1,
797 797
                         'role_title' => $counter > 0 ? $role_detail['title'] : '',
798 798
                     ]
@@ -802,7 +802,7 @@  discard block
 block discarded – undo
802 802
             
803 803
             // Get all groups in Teampass
804 804
             $teampassRoles = array();
805
-            $rows = DB::query('SELECT id,title FROM ' . prefixTable('roles_title'));
805
+            $rows = DB::query('SELECT id,title FROM '.prefixTable('roles_title'));
806 806
             foreach ($rows as $record) {
807 807
                 array_push(
808 808
                     $teampassRoles,
Please login to merge, or discard this patch.
sources/users.queries.php 1 patch
Spacing   +116 added lines, -116 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('users') === false) {
65 65
     // Not allowed page
66 66
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
67
-    include $SETTINGS['cpassman_dir'] . '/error.php';
67
+    include $SETTINGS['cpassman_dir'].'/error.php';
68 68
     exit;
69 69
 }
70 70
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
             // Prepare variables
128 128
             $login = filter_var($dataReceived['login'], FILTER_SANITIZE_FULL_SPECIAL_CHARS);
129 129
             $email = filter_var($dataReceived['email'], FILTER_SANITIZE_EMAIL);
130
-            $password = '';//filter_var($dataReceived['pw'], FILTER_SANITIZE_FULL_SPECIAL_CHARS);
130
+            $password = ''; //filter_var($dataReceived['pw'], FILTER_SANITIZE_FULL_SPECIAL_CHARS);
131 131
             $lastname = filter_var($dataReceived['lastname'], FILTER_SANITIZE_FULL_SPECIAL_CHARS);
132 132
             $name = filter_var($dataReceived['name'], FILTER_SANITIZE_FULL_SPECIAL_CHARS);
133 133
             $is_admin = filter_var($dataReceived['admin'], FILTER_SANITIZE_NUMBER_INT);
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
             // Check if user already exists
159 159
             $data = DB::query(
160 160
                 'SELECT id, fonction_id, groupes_interdits, groupes_visibles
161
-                FROM ' . prefixTable('users') . '
161
+                FROM ' . prefixTable('users').'
162 162
                 WHERE login = %s
163 163
                 AND deleted_at IS NULL',
164 164
                 $login
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
 
396 396
             // Get info about user to delete
397 397
             $data_user = DB::queryfirstrow(
398
-                'SELECT login, admin, isAdministratedByRole FROM ' . prefixTable('users') . '
398
+                'SELECT login, admin, isAdministratedByRole FROM '.prefixTable('users').'
399 399
                 WHERE id = %i',
400 400
                 $post_id
401 401
             );
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
                 );
430 430
                 // delete personal folder and subfolders
431 431
                 $data = DB::queryfirstrow(
432
-                    'SELECT id FROM ' . prefixTable('nested_tree') . '
432
+                    'SELECT id FROM '.prefixTable('nested_tree').'
433 433
                     WHERE title = %s AND personal_folder = %i',
434 434
                     $post_id,
435 435
                     '1'
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
442 442
                         DB::delete(prefixTable('nested_tree'), 'id = %i AND personal_folder = %i', $folder->id, '1');
443 443
                         // delete items & logs
444 444
                         $items = DB::query(
445
-                            'SELECT id FROM ' . prefixTable('items') . '
445
+                            'SELECT id FROM '.prefixTable('items').'
446 446
                             WHERE id_tree=%i AND perso = %i',
447 447
                             $folder->id,
448 448
                             '1'
@@ -466,7 +466,7 @@  discard block
 block discarded – undo
466 466
                 // Delete any process related to user
467 467
                 $processes = DB::query(
468 468
                     'SELECT increment_id
469
-                    FROM ' . prefixTable('processes') . '
469
+                    FROM ' . prefixTable('processes').'
470 470
                     WHERE JSON_EXTRACT(arguments, "$.new_user_id") = %i',
471 471
                     $post_id
472 472
                 );
@@ -526,7 +526,7 @@  discard block
 block discarded – undo
526 526
 
527 527
             // Get info about user to delete
528 528
             $data_user = DB::queryfirstrow(
529
-                'SELECT admin, isAdministratedByRole FROM ' . prefixTable('users') . '
529
+                'SELECT admin, isAdministratedByRole FROM '.prefixTable('users').'
530 530
                 WHERE id = %i',
531 531
                 $post_id
532 532
             );
@@ -568,7 +568,7 @@  discard block
 block discarded – undo
568 568
 
569 569
             // Get info about user to delete
570 570
             $data_user = DB::queryfirstrow(
571
-                'SELECT admin, isAdministratedByRole FROM ' . prefixTable('users') . '
571
+                'SELECT admin, isAdministratedByRole FROM '.prefixTable('users').'
572 572
                 WHERE id = %i',
573 573
                 $post_id
574 574
             );
@@ -611,7 +611,7 @@  discard block
 block discarded – undo
611 611
             // Get info about user to delete
612 612
             $data_user = DB::queryfirstrow(
613 613
                 'SELECT admin, isAdministratedByRole, can_manage_all_users, gestionnaire
614
-                FROM ' . prefixTable('users') . '
614
+                FROM ' . prefixTable('users').'
615 615
                 WHERE id = %i',
616 616
                 $post_id
617 617
             );
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
 
656 656
             // Get info about user to delete
657 657
             $data_user = DB::queryfirstrow(
658
-                'SELECT admin, isAdministratedByRole FROM ' . prefixTable('users') . '
658
+                'SELECT admin, isAdministratedByRole FROM '.prefixTable('users').'
659 659
                 WHERE id = %i',
660 660
                 $post_id
661 661
             );
@@ -698,7 +698,7 @@  discard block
 block discarded – undo
698 698
             // Get info about user to delete
699 699
             $data_user = DB::queryfirstrow(
700 700
                 'SELECT admin, isAdministratedByRole, gestionnaire
701
-                FROM ' . prefixTable('users') . '
701
+                FROM ' . prefixTable('users').'
702 702
                 WHERE id = %i',
703 703
                 $post_id
704 704
             );
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
             // Get info about user to delete
742 742
             $data_user = DB::queryfirstrow(
743 743
                 'SELECT admin, isAdministratedByRole, gestionnaire
744
-                FROM ' . prefixTable('users') . '
744
+                FROM ' . prefixTable('users').'
745 745
                 WHERE id = %i',
746 746
                 $post_id
747 747
             );
@@ -781,7 +781,7 @@  discard block
 block discarded – undo
781 781
             // Get info about user to delete
782 782
             $data_user = DB::queryfirstrow(
783 783
                 'SELECT admin, isAdministratedByRole, gestionnaire
784
-                FROM ' . prefixTable('users') . '
784
+                FROM ' . prefixTable('users').'
785 785
                 WHERE id = %i',
786 786
                 $post_id
787 787
             );
@@ -820,7 +820,7 @@  discard block
 block discarded – undo
820 820
             $return = array();
821 821
             // Check if folder exists
822 822
             $data = DB::query(
823
-                'SELECT * FROM ' . prefixTable('nested_tree') . '
823
+                'SELECT * FROM '.prefixTable('nested_tree').'
824 824
                 WHERE title = %s AND parent_id = %i',
825 825
                 filter_input(INPUT_POST, 'domain', FILTER_SANITIZE_FULL_SPECIAL_CHARS),
826 826
                 '0'
@@ -833,7 +833,7 @@  discard block
 block discarded – undo
833 833
             }
834 834
             // Check if role exists
835 835
             $data = DB::query(
836
-                'SELECT * FROM ' . prefixTable('roles_title') . '
836
+                'SELECT * FROM '.prefixTable('roles_title').'
837 837
                 WHERE title = %s',
838 838
                 filter_input(INPUT_POST, 'domain', FILTER_SANITIZE_FULL_SPECIAL_CHARS)
839 839
             );
@@ -853,7 +853,7 @@  discard block
 block discarded – undo
853 853
         case 'user_log_items':
854 854
             $nb_pages = 1;
855 855
             $logs = $sql_filter = '';
856
-            $pages = '<table style=\'border-top:1px solid #969696;\'><tr><td>' . langHdl('pages') . '&nbsp;:&nbsp;</td>';
856
+            $pages = '<table style=\'border-top:1px solid #969696;\'><tr><td>'.langHdl('pages').'&nbsp;:&nbsp;</td>';
857 857
 
858 858
             // Prepare POST variables
859 859
             $post_nb_items_by_page = filter_input(INPUT_POST, 'nb_items_by_page', FILTER_SANITIZE_NUMBER_INT);
@@ -865,14 +865,14 @@  discard block
 block discarded – undo
865 865
                     && !empty(filter_input(INPUT_POST, 'filter', FILTER_SANITIZE_FULL_SPECIAL_CHARS))
866 866
                     && filter_input(INPUT_POST, 'filter', FILTER_SANITIZE_FULL_SPECIAL_CHARS) !== 'all'
867 867
                 ) {
868
-                    $sql_filter = " AND l.action = '" . filter_input(INPUT_POST, 'filter', FILTER_SANITIZE_FULL_SPECIAL_CHARS) . "'";
868
+                    $sql_filter = " AND l.action = '".filter_input(INPUT_POST, 'filter', FILTER_SANITIZE_FULL_SPECIAL_CHARS)."'";
869 869
                 }
870 870
                 // get number of pages
871 871
                 DB::query(
872 872
                     'SELECT *
873
-                    FROM ' . prefixTable('log_items') . ' as l
874
-                    INNER JOIN ' . prefixTable('items') . ' as i ON (l.id_item=i.id)
875
-                    INNER JOIN ' . prefixTable('users') . ' as u ON (l.id_user=u.id)
873
+                    FROM ' . prefixTable('log_items').' as l
874
+                    INNER JOIN ' . prefixTable('items').' as i ON (l.id_item=i.id)
875
+                    INNER JOIN ' . prefixTable('users').' as u ON (l.id_user=u.id)
876 876
                     WHERE l.id_user = %i ' . $sql_filter,
877 877
                     filter_input(INPUT_POST, 'id', FILTER_SANITIZE_NUMBER_INT)
878 878
                 );
@@ -890,19 +890,19 @@  discard block
 block discarded – undo
890 890
                 // launch query
891 891
                 $rows = DB::query(
892 892
                     'SELECT l.date as date, u.login as login, i.label as label, l.action as action
893
-                    FROM ' . prefixTable('log_items') . ' as l
894
-                    INNER JOIN ' . prefixTable('items') . ' as i ON (l.id_item=i.id)
895
-                    INNER JOIN ' . prefixTable('users') . ' as u ON (l.id_user=u.id)
896
-                    WHERE l.id_user = %i ' . $sql_filter . '
893
+                    FROM ' . prefixTable('log_items').' as l
894
+                    INNER JOIN ' . prefixTable('items').' as i ON (l.id_item=i.id)
895
+                    INNER JOIN ' . prefixTable('users').' as u ON (l.id_user=u.id)
896
+                    WHERE l.id_user = %i ' . $sql_filter.'
897 897
                     ORDER BY date DESC
898
-                    LIMIT ' . intval($start) . ',' . intval($post_nb_items_by_page),
898
+                    LIMIT ' . intval($start).','.intval($post_nb_items_by_page),
899 899
                     filter_input(INPUT_POST, 'id', FILTER_SANITIZE_NUMBER_INT)
900 900
                 );
901 901
             } else {
902 902
                 // get number of pages
903 903
                 DB::query(
904 904
                     'SELECT *
905
-                    FROM ' . prefixTable('log_system') . '
905
+                    FROM ' . prefixTable('log_system').'
906 906
                     WHERE type = %s AND field_1=%i',
907 907
                     'user_mngt',
908 908
                     filter_input(INPUT_POST, 'id', FILTER_SANITIZE_NUMBER_INT)
@@ -921,7 +921,7 @@  discard block
 block discarded – undo
921 921
                 // launch query
922 922
                 $rows = DB::query(
923 923
                     'SELECT *
924
-                    FROM ' . prefixTable('log_system') . '
924
+                    FROM ' . prefixTable('log_system').'
925 925
                     WHERE type = %s AND field_1 = %i
926 926
                     ORDER BY date DESC
927 927
                     LIMIT %i, %i',
@@ -935,7 +935,7 @@  discard block
 block discarded – undo
935 935
             if (isset($counter) && $counter != 0) {
936 936
                 $nb_pages = ceil($counter / intval($post_nb_items_by_page));
937 937
                 for ($i = 1; $i <= $nb_pages; ++$i) {
938
-                    $pages .= '<td onclick=\'displayLogs(' . $i . ',\"' . $post_scope . '\")\'><span style=\'cursor:pointer;' . (filter_input(INPUT_POST, 'page', FILTER_SANITIZE_NUMBER_INT) === $i ? 'font-weight:bold;font-size:18px;\'>' . $i : '\'>' . $i) . '</span></td>';
938
+                    $pages .= '<td onclick=\'displayLogs('.$i.',\"'.$post_scope.'\")\'><span style=\'cursor:pointer;'.(filter_input(INPUT_POST, 'page', FILTER_SANITIZE_NUMBER_INT) === $i ? 'font-weight:bold;font-size:18px;\'>'.$i : '\'>'.$i).'</span></td>';
939 939
                 }
940 940
             }
941 941
             $pages .= '</tr></table>';
@@ -944,7 +944,7 @@  discard block
 block discarded – undo
944 944
                     if ($post_scope === 'user_mngt') {
945 945
                         $user = DB::queryfirstrow(
946 946
                             'SELECT login
947
-                            from ' . prefixTable('users') . '
947
+                            from ' . prefixTable('users').'
948 948
                             WHERE id=%i',
949 949
                             $record['qui']
950 950
                         );
@@ -954,7 +954,7 @@  discard block
 block discarded – undo
954 954
                         if ($tmp[0] == 'at_user_initial_pwd_changed') {
955 955
                             $label = langHdl('log_user_initial_pwd_changed');
956 956
                         } elseif ($tmp[0] == 'at_user_email_changed') {
957
-                            $label = langHdl('log_user_email_changed') . $tmp[1];
957
+                            $label = langHdl('log_user_email_changed').$tmp[1];
958 958
                         } elseif ($tmp[0] == 'at_user_added') {
959 959
                             $label = langHdl('log_user_created');
960 960
                         } elseif ($tmp[0] == 'at_user_locked') {
@@ -965,14 +965,14 @@  discard block
 block discarded – undo
965 965
                             $label = langHdl('log_user_pwd_changed');
966 966
                         }
967 967
                         // prepare log
968
-                        $logs .= '<tr><td>' . date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['date']) . '</td><td align=\"center\">' . $label . '</td><td align=\"center\">' . $user['login'] . '</td><td align=\"center\"></td></tr>';
968
+                        $logs .= '<tr><td>'.date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $record['date']).'</td><td align=\"center\">'.$label.'</td><td align=\"center\">'.$user['login'].'</td><td align=\"center\"></td></tr>';
969 969
                     } else {
970
-                        $logs .= '<tr><td>' . date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['date']) . '</td><td align=\"center\">' . str_replace('"', '\"', $record['label']) . '</td><td align=\"center\">' . $record['login'] . '</td><td align=\"center\">' . langHdl($record['action']) . '</td></tr>';
970
+                        $logs .= '<tr><td>'.date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $record['date']).'</td><td align=\"center\">'.str_replace('"', '\"', $record['label']).'</td><td align=\"center\">'.$record['login'].'</td><td align=\"center\">'.langHdl($record['action']).'</td></tr>';
971 971
                     }
972 972
                 }
973 973
             }
974 974
 
975
-            echo '[ { "table_logs": "' . ($logs) . '", "pages": "' . ($pages) . '", "error" : "no" } ]';
975
+            echo '[ { "table_logs": "'.($logs).'", "pages": "'.($pages).'", "error" : "no" } ]';
976 976
             break;
977 977
 
978 978
             /*
@@ -997,7 +997,7 @@  discard block
 block discarded – undo
997 997
             } else {
998 998
                 // Get folder id for Admin
999 999
                 $admin_folder = DB::queryFirstRow(
1000
-                    'SELECT id FROM ' . prefixTable('nested_tree') . '
1000
+                    'SELECT id FROM '.prefixTable('nested_tree').'
1001 1001
                     WHERE title = %i AND personal_folder = %i',
1002 1002
                     intval($_SESSION['user_id']),
1003 1003
                     '1'
@@ -1008,15 +1008,15 @@  discard block
 block discarded – undo
1008 1008
                     // Get each Items in PF
1009 1009
                     $rows = DB::query(
1010 1010
                         'SELECT i.pw, i.label, l.id_user
1011
-                        FROM ' . prefixTable('items') . ' as i
1012
-                        LEFT JOIN ' . prefixTable('log_items') . ' as l ON (l.id_item=i.id)
1011
+                        FROM ' . prefixTable('items').' as i
1012
+                        LEFT JOIN ' . prefixTable('log_items').' as l ON (l.id_item=i.id)
1013 1013
                         WHERE l.action = %s AND i.perso=%i AND i.id_tree=%i',
1014 1014
                         'at_creation',
1015 1015
                         '1',
1016 1016
                         intval($folder->id)
1017 1017
                     );
1018 1018
                     foreach ($rows as $record) {
1019
-                        echo $record['label'] . ' - ';
1019
+                        echo $record['label'].' - ';
1020 1020
                         // Change user
1021 1021
                         DB::update(
1022 1022
                             prefixTable('log_items'),
@@ -1051,7 +1051,7 @@  discard block
 block discarded – undo
1051 1051
             // Get info about user to delete
1052 1052
             $data_user = DB::queryfirstrow(
1053 1053
                 'SELECT admin, isAdministratedByRole, gestionnaire
1054
-                FROM ' . prefixTable('users') . '
1054
+                FROM ' . prefixTable('users').'
1055 1055
                 WHERE id = %i',
1056 1056
                 $post_user_id
1057 1057
             );
@@ -1088,7 +1088,7 @@  discard block
 block discarded – undo
1088 1088
 
1089 1089
             // Do
1090 1090
             $rows = DB::query(
1091
-                'SELECT id FROM ' . prefixTable('users') . '
1091
+                'SELECT id FROM '.prefixTable('users').'
1092 1092
                 WHERE timestamp != %s AND admin != %i',
1093 1093
                 '',
1094 1094
                 '1'
@@ -1097,7 +1097,7 @@  discard block
 block discarded – undo
1097 1097
                 // Get info about user to delete
1098 1098
                 $data_user = DB::queryfirstrow(
1099 1099
                     'SELECT admin, isAdministratedByRole, gestionnaire
1100
-                    FROM ' . prefixTable('users') . '
1100
+                    FROM ' . prefixTable('users').'
1101 1101
                     WHERE id = %i',
1102 1102
                     $record['id']
1103 1103
                 );
@@ -1158,7 +1158,7 @@  discard block
 block discarded – undo
1158 1158
             // Get info about user
1159 1159
             $rowUser = DB::queryfirstrow(
1160 1160
                 'SELECT *
1161
-                FROM ' . prefixTable('users') . '
1161
+                FROM ' . prefixTable('users').'
1162 1162
                 WHERE id = %i',
1163 1163
                 $post_id
1164 1164
             );
@@ -1185,7 +1185,7 @@  discard block
 block discarded – undo
1185 1185
                 // array of roles for actual user
1186 1186
                 //$my_functions = explode(';', $rowUser['fonction_id']);
1187 1187
 
1188
-                $rows = DB::query('SELECT id,title,creator_id FROM ' . prefixTable('roles_title'));
1188
+                $rows = DB::query('SELECT id,title,creator_id FROM '.prefixTable('roles_title'));
1189 1189
                 foreach ($rows as $record) {
1190 1190
                     if (
1191 1191
                         (int) $_SESSION['is_admin'] === 1
@@ -1222,7 +1222,7 @@  discard block
 block discarded – undo
1222 1222
                 $rolesList = array();
1223 1223
                 $managedBy = array();
1224 1224
                 $selected = '';
1225
-                $rows = DB::query('SELECT id,title FROM ' . prefixTable('roles_title') . ' ORDER BY title ASC');
1225
+                $rows = DB::query('SELECT id,title FROM '.prefixTable('roles_title').' ORDER BY title ASC');
1226 1226
                 foreach ($rows as $reccord) {
1227 1227
                     $rolesList[$reccord['id']] = array('id' => $reccord['id'], 'title' => $reccord['title']);
1228 1228
                 }
@@ -1253,7 +1253,7 @@  discard block
 block discarded – undo
1253 1253
                         array_push(
1254 1254
                             $managedBy,
1255 1255
                             array(
1256
-                                'title' => langHdl('managers_of') . ' ' . $fonction['title'],
1256
+                                'title' => langHdl('managers_of').' '.$fonction['title'],
1257 1257
                                 'id' => $fonction['id'],
1258 1258
                                 'selected' => $selected,
1259 1259
                             )
@@ -1335,9 +1335,9 @@  discard block
 block discarded – undo
1335 1335
 
1336 1336
                 // get USER STATUS
1337 1337
                 if ($rowUser['disabled'] == 1) {
1338
-                    $arrData['info'] = langHdl('user_info_locked') . '<br><input type="checkbox" value="unlock" name="1" class="chk">&nbsp;<label for="1">' . langHdl('user_info_unlock_question') . '</label><br><input type="checkbox"  value="delete" id="account_delete" class="chk mr-2" name="2" onclick="confirmDeletion()">label for="2">' . langHdl('user_info_delete_question') . '</label>';
1338
+                    $arrData['info'] = langHdl('user_info_locked').'<br><input type="checkbox" value="unlock" name="1" class="chk">&nbsp;<label for="1">'.langHdl('user_info_unlock_question').'</label><br><input type="checkbox"  value="delete" id="account_delete" class="chk mr-2" name="2" onclick="confirmDeletion()">label for="2">'.langHdl('user_info_delete_question').'</label>';
1339 1339
                 } else {
1340
-                    $arrData['info'] = langHdl('user_info_active') . '<br><input type="checkbox" value="lock" class="chk">&nbsp;' . langHdl('user_info_lock_question');
1340
+                    $arrData['info'] = langHdl('user_info_active').'<br><input type="checkbox" value="lock" class="chk">&nbsp;'.langHdl('user_info_lock_question');
1341 1341
                 }
1342 1342
 
1343 1343
                 $arrData['error'] = false;
@@ -1434,7 +1434,7 @@  discard block
 block discarded – undo
1434 1434
                 // count number of admins
1435 1435
                 $users = DB::query(
1436 1436
                     'SELECT id
1437
-                    FROM ' . prefixTable('users') . '
1437
+                    FROM ' . prefixTable('users').'
1438 1438
                     WHERE admin = 1 AND email != "" AND pw != "" AND id != %i',
1439 1439
                     $post_id
1440 1440
                 );
@@ -1457,7 +1457,7 @@  discard block
 block discarded – undo
1457 1457
             // Exclude roles from AD - PR #3635
1458 1458
             $adRoles = DB::query(
1459 1459
                 'SELECT roles_from_ad_groups
1460
-                FROM ' . prefixTable('users') . '
1460
+                FROM ' . prefixTable('users').'
1461 1461
                 WHERE id = '. $dataReceived['user_id']
1462 1462
             )[0]['roles_from_ad_groups'];
1463 1463
             $fonctions = [];
@@ -1536,7 +1536,7 @@  discard block
 block discarded – undo
1536 1536
 
1537 1537
             // Get info about user to delete
1538 1538
             $data_user = DB::queryfirstrow(
1539
-                'SELECT admin, isAdministratedByRole FROM ' . prefixTable('users') . '
1539
+                'SELECT admin, isAdministratedByRole FROM '.prefixTable('users').'
1540 1540
                 WHERE id = %i',
1541 1541
                 $post_id
1542 1542
             );
@@ -1557,7 +1557,7 @@  discard block
 block discarded – undo
1557 1557
                     );
1558 1558
                     // delete personal folder and subfolders
1559 1559
                     $data = DB::queryfirstrow(
1560
-                        'SELECT id FROM ' . prefixTable('nested_tree') . '
1560
+                        'SELECT id FROM '.prefixTable('nested_tree').'
1561 1561
                         WHERE title = %s AND personal_folder = %i',
1562 1562
                         $post_id,
1563 1563
                         '1'
@@ -1570,7 +1570,7 @@  discard block
 block discarded – undo
1570 1570
                             DB::delete(prefixTable('nested_tree'), 'id = %i AND personal_folder = %i', $folder->id, '1');
1571 1571
                             // delete items & logs
1572 1572
                             $items = DB::query(
1573
-                                'SELECT id FROM ' . prefixTable('items') . '
1573
+                                'SELECT id FROM '.prefixTable('items').'
1574 1574
                                 WHERE id_tree=%i AND perso = %i',
1575 1575
                                 $folder->id,
1576 1576
                                 '1'
@@ -1591,7 +1591,7 @@  discard block
 block discarded – undo
1591 1591
                 } else {
1592 1592
                     // Get old data about user
1593 1593
                     $oldData = DB::queryfirstrow(
1594
-                        'SELECT * FROM ' . prefixTable('users') . '
1594
+                        'SELECT * FROM '.prefixTable('users').'
1595 1595
                         WHERE id = %i',
1596 1596
                         $post_id
1597 1597
                     );
@@ -1628,7 +1628,7 @@  discard block
 block discarded – undo
1628 1628
 
1629 1629
                     // update LOG
1630 1630
                     if ($oldData['email'] !== $post_email) {
1631
-                        logEvents($SETTINGS, 'user_mngt', 'at_user_email_changed:' . $oldData['email'], (string) $_SESSION['user_id'], $_SESSION['login'], $post_id);
1631
+                        logEvents($SETTINGS, 'user_mngt', 'at_user_email_changed:'.$oldData['email'], (string) $_SESSION['user_id'], $_SESSION['login'], $post_id);
1632 1632
                     }
1633 1633
                 }
1634 1634
                 echo prepareExchangedData(
@@ -1686,7 +1686,7 @@  discard block
 block discarded – undo
1686 1686
 
1687 1687
             // Get info about user to delete
1688 1688
             $data_user = DB::queryfirstrow(
1689
-                'SELECT admin, isAdministratedByRole FROM ' . prefixTable('users') . '
1689
+                'SELECT admin, isAdministratedByRole FROM '.prefixTable('users').'
1690 1690
                 WHERE id = %i',
1691 1691
                 $post_id
1692 1692
             );
@@ -1736,7 +1736,7 @@  discard block
 block discarded – undo
1736 1736
             }
1737 1737
 
1738 1738
             DB::queryfirstrow(
1739
-                'SELECT * FROM ' . prefixTable('users') . '
1739
+                'SELECT * FROM '.prefixTable('users').'
1740 1740
                 WHERE login = %s
1741 1741
                 AND deleted_at IS NULL',
1742 1742
                 filter_input(INPUT_POST, 'login', FILTER_SANITIZE_FULL_SPECIAL_CHARS)
@@ -1788,7 +1788,7 @@  discard block
 block discarded – undo
1788 1788
             // get User info
1789 1789
             $rowUser = DB::queryFirstRow(
1790 1790
                 'SELECT login, name, lastname, email, disabled, fonction_id, groupes_interdits, groupes_visibles, isAdministratedByRole, avatar_thumb, roles_from_ad_groups
1791
-                FROM ' . prefixTable('users') . '
1791
+                FROM ' . prefixTable('users').'
1792 1792
                 WHERE id = %i',
1793 1793
                 $post_id
1794 1794
             );
@@ -1798,7 +1798,7 @@  discard block
 block discarded – undo
1798 1798
             $html = '';
1799 1799
 
1800 1800
             if (isset($SETTINGS['ldap_mode']) === true && (int) $SETTINGS['ldap_mode'] === 1 && isset($SETTINGS['enable_ad_users_with_ad_groups']) === true && (int) $SETTINGS['enable_ad_users_with_ad_groups'] === 1) {
1801
-                $rowUser['fonction_id'] = empty($rowUser['fonction_id'])  === true ? $rowUser['roles_from_ad_groups'] : $rowUser['fonction_id']. ';' . $rowUser['roles_from_ad_groups'];
1801
+                $rowUser['fonction_id'] = empty($rowUser['fonction_id']) === true ? $rowUser['roles_from_ad_groups'] : $rowUser['fonction_id'].';'.$rowUser['roles_from_ad_groups'];
1802 1802
             }
1803 1803
             $arrData['functions'] = array_filter(explode(';', $rowUser['fonction_id']));
1804 1804
             $arrData['allowed_folders'] = array_filter(explode(';', $rowUser['groupes_visibles']));
@@ -1809,7 +1809,7 @@  discard block
 block discarded – undo
1809 1809
                 // refine folders based upon roles
1810 1810
                 $rows = DB::query(
1811 1811
                     'SELECT folder_id, type
1812
-                    FROM ' . prefixTable('roles_values') . '
1812
+                    FROM ' . prefixTable('roles_values').'
1813 1813
                     WHERE role_id IN %ls
1814 1814
                     ORDER BY folder_id ASC',
1815 1815
                     $arrData['functions']
@@ -1832,7 +1832,7 @@  discard block
 block discarded – undo
1832 1832
                 }
1833 1833
 
1834 1834
                 // add allowed folders
1835
-                foreach($arrData['allowed_folders'] as $Fld) {
1835
+                foreach ($arrData['allowed_folders'] as $Fld) {
1836 1836
                     array_push($arrFolders, array('id' => $Fld, 'type' => 'W', 'special' => true));
1837 1837
                 }
1838 1838
                 
@@ -1843,7 +1843,7 @@  discard block
 block discarded – undo
1843 1843
                             // get folder name
1844 1844
                             $row = DB::queryFirstRow(
1845 1845
                                 'SELECT title, nlevel, id
1846
-                                FROM ' . prefixTable('nested_tree') . '
1846
+                                FROM ' . prefixTable('nested_tree').'
1847 1847
                                 WHERE id = %i',
1848 1848
                                 $fld['id']
1849 1849
                             );
@@ -1856,38 +1856,38 @@  discard block
 block discarded – undo
1856 1856
 
1857 1857
                             // manage right icon
1858 1858
                             if ($fld['type'] == 'W') {
1859
-                                $label = '<i class="fas fa-indent infotip text-success mr-2" title="' . langHdl('write') . '"></i>' .
1860
-                                    '<i class="fas fa-edit infotip text-success mr-2" title="' . langHdl('edit') . '"></i>' .
1861
-                                    '<i class="fas fa-eraser infotip text-success" title="' . langHdl('delete') . '"></i>';
1859
+                                $label = '<i class="fas fa-indent infotip text-success mr-2" title="'.langHdl('write').'"></i>'.
1860
+                                    '<i class="fas fa-edit infotip text-success mr-2" title="'.langHdl('edit').'"></i>'.
1861
+                                    '<i class="fas fa-eraser infotip text-success" title="'.langHdl('delete').'"></i>';
1862 1862
                             } elseif ($fld['type'] == 'ND') {
1863
-                                $label = '<i class="fas fa-indent infotip text-warning mr-2" title="' . langHdl('write') . '"></i>' .
1864
-                                    '<i class="fas fa-edit infotip text-success mr-2" title="' . langHdl('edit') . '"></i>' .
1865
-                                    '<i class="fas fa-eraser infotip text-danger" title="' . langHdl('no_delete') . '"></i>';
1863
+                                $label = '<i class="fas fa-indent infotip text-warning mr-2" title="'.langHdl('write').'"></i>'.
1864
+                                    '<i class="fas fa-edit infotip text-success mr-2" title="'.langHdl('edit').'"></i>'.
1865
+                                    '<i class="fas fa-eraser infotip text-danger" title="'.langHdl('no_delete').'"></i>';
1866 1866
                             } elseif ($fld['type'] == 'NE') {
1867
-                                $label = '<i class="fas fa-indent infotip text-warning mr-2" title="' . langHdl('write') . '"></i>' .
1868
-                                    '<i class="fas fa-edit infotip text-danger mr-2" title="' . langHdl('no_edit') . '"></i>' .
1869
-                                    '<i class="fas fa-eraser infotip text-success" title="' . langHdl('delete') . '"></i>';
1867
+                                $label = '<i class="fas fa-indent infotip text-warning mr-2" title="'.langHdl('write').'"></i>'.
1868
+                                    '<i class="fas fa-edit infotip text-danger mr-2" title="'.langHdl('no_edit').'"></i>'.
1869
+                                    '<i class="fas fa-eraser infotip text-success" title="'.langHdl('delete').'"></i>';
1870 1870
                             } elseif ($fld['type'] == 'NDNE') {
1871
-                                $label = '<i class="fas fa-indent infotip text-warning mr-2" title="' . langHdl('write') . '"></i>' .
1872
-                                    '<i class="fas fa-edit infotip text-danger mr-2" title="' . langHdl('no_edit') . '"></i>' .
1873
-                                    '<i class="fas fa-eraser infotip text-danger" title="' . langHdl('no_delete') . '"></i>';
1871
+                                $label = '<i class="fas fa-indent infotip text-warning mr-2" title="'.langHdl('write').'"></i>'.
1872
+                                    '<i class="fas fa-edit infotip text-danger mr-2" title="'.langHdl('no_edit').'"></i>'.
1873
+                                    '<i class="fas fa-eraser infotip text-danger" title="'.langHdl('no_delete').'"></i>';
1874 1874
                             } elseif ($fld['type'] == '') {
1875
-                                $label = '<i class="fas fa-eye-slash infotip text-danger mr-2" title="' . langHdl('no_access') . '"></i>';
1875
+                                $label = '<i class="fas fa-eye-slash infotip text-danger mr-2" title="'.langHdl('no_access').'"></i>';
1876 1876
                             } else {
1877
-                                $label = '<i class="fas fa-eye infotip text-info mr-2" title="' . langHdl('read') . '"></i>';
1877
+                                $label = '<i class="fas fa-eye infotip text-info mr-2" title="'.langHdl('read').'"></i>';
1878 1878
                             }
1879 1879
 
1880
-                            $html .= '<tr><td>' . $ident . $row['title'] .
1881
-                                ' <small class="text-info">[' . $row['id'] . ']</small>'.
1882
-                                ($fld['special'] === true ? '<i class="fas fa-user-tag infotip text-primary ml-5" title="' . langHdl('user_specific_right') . '"></i>' : '').
1883
-                                '</td><td>' . $label . '</td></tr>';
1880
+                            $html .= '<tr><td>'.$ident.$row['title'].
1881
+                                ' <small class="text-info">['.$row['id'].']</small>'.
1882
+                                ($fld['special'] === true ? '<i class="fas fa-user-tag infotip text-primary ml-5" title="'.langHdl('user_specific_right').'"></i>' : '').
1883
+                                '</td><td>'.$label.'</td></tr>';
1884 1884
                             break;
1885 1885
                         }
1886 1886
                     }
1887 1887
                 }
1888 1888
 
1889
-                $html_full = '<table id="table-folders" class="table table-bordered table-striped dt-responsive nowrap" style="width:100%"><tbody>' .
1890
-                    $html . '</tbody></table>';
1889
+                $html_full = '<table id="table-folders" class="table table-bordered table-striped dt-responsive nowrap" style="width:100%"><tbody>'.
1890
+                    $html.'</tbody></table>';
1891 1891
             } else {
1892 1892
                 $html_full = '';
1893 1893
             }
@@ -1933,7 +1933,7 @@  discard block
 block discarded – undo
1933 1933
             if ((int) $_SESSION['is_admin'] === 0 && (int) $_SESSION['user_can_manage_all_users'] === 0) {
1934 1934
                 $rows = DB::query(
1935 1935
                     'SELECT *
1936
-                    FROM ' . prefixTable('users') . '
1936
+                    FROM ' . prefixTable('users').'
1937 1937
                     WHERE admin = %i AND isAdministratedByRole IN %ls',
1938 1938
                     '0',
1939 1939
                     array_filter($_SESSION['user_roles'])
@@ -1941,7 +1941,7 @@  discard block
 block discarded – undo
1941 1941
             } else {
1942 1942
                 $rows = DB::query(
1943 1943
                     'SELECT *
1944
-                    FROM ' . prefixTable('users') . '
1944
+                    FROM ' . prefixTable('users').'
1945 1945
                     WHERE admin = %i',
1946 1946
                     '0'
1947 1947
                 );
@@ -1953,7 +1953,7 @@  discard block
 block discarded – undo
1953 1953
                 $groupIds = [];
1954 1954
                 foreach (explode(';', $record['fonction_id']) as $group) {
1955 1955
                     $tmp = DB::queryfirstrow(
1956
-                        'SELECT id, title FROM ' . prefixTable('roles_title') . '
1956
+                        'SELECT id, title FROM '.prefixTable('roles_title').'
1957 1957
                         WHERE id = %i',
1958 1958
                         $group
1959 1959
                     );
@@ -1965,7 +1965,7 @@  discard block
 block discarded – undo
1965 1965
 
1966 1966
                 // Get managed_by
1967 1967
                 $managedBy = DB::queryfirstrow(
1968
-                    'SELECT id, title FROM ' . prefixTable('roles_title') . '
1968
+                    'SELECT id, title FROM '.prefixTable('roles_title').'
1969 1969
                     WHERE id = %i',
1970 1970
                     $record['isAdministratedByRole']
1971 1971
                 );
@@ -1975,7 +1975,7 @@  discard block
 block discarded – undo
1975 1975
                 $foldersAllowedIds = [];
1976 1976
                 foreach (explode(';', $record['groupes_visibles']) as $role) {
1977 1977
                     $tmp = DB::queryfirstrow(
1978
-                        'SELECT id, title FROM ' . prefixTable('nested_tree') . '
1978
+                        'SELECT id, title FROM '.prefixTable('nested_tree').'
1979 1979
                         WHERE id = %i',
1980 1980
                         $role
1981 1981
                     );
@@ -1988,7 +1988,7 @@  discard block
 block discarded – undo
1988 1988
                 $foldersForbiddenIds = [];
1989 1989
                 foreach (explode(';', $record['groupes_interdits']) as $role) {
1990 1990
                     $tmp = DB::queryfirstrow(
1991
-                        'SELECT id, title FROM ' . prefixTable('nested_tree') . '
1991
+                        'SELECT id, title FROM '.prefixTable('nested_tree').'
1992 1992
                         WHERE id = %i',
1993 1993
                         $role
1994 1994
                     );
@@ -2006,7 +2006,7 @@  discard block
 block discarded – undo
2006 2006
                         'login' => $record['login'],
2007 2007
                         'groups' => implode(', ', $groups),
2008 2008
                         'groupIds' => $groupIds,
2009
-                        'managedBy' => $managedBy=== null ? langHdl('administrator') : $managedBy['title'],
2009
+                        'managedBy' => $managedBy === null ? langHdl('administrator') : $managedBy['title'],
2010 2010
                         'managedById' => $managedBy === null ? 0 : $managedBy['id'],
2011 2011
                         'foldersAllowed' => implode(', ', $foldersAllowed),
2012 2012
                         'foldersAllowedIds' => $foldersAllowedIds,
@@ -2087,7 +2087,7 @@  discard block
 block discarded – undo
2087 2087
 
2088 2088
             // Get info about user
2089 2089
             $data_user = DB::queryfirstrow(
2090
-                'SELECT admin, isAdministratedByRole FROM ' . prefixTable('users') . '
2090
+                'SELECT admin, isAdministratedByRole FROM '.prefixTable('users').'
2091 2091
                 WHERE id = %i',
2092 2092
                 $post_source_id
2093 2093
             );
@@ -2279,14 +2279,14 @@  discard block
 block discarded – undo
2279 2279
             if (empty($post_context) === false && $post_context === 'add_one_role_to_user') {
2280 2280
                 $data_user = DB::queryfirstrow(
2281 2281
                     'SELECT fonction_id, public_key
2282
-                    FROM ' . prefixTable('users') . '
2282
+                    FROM ' . prefixTable('users').'
2283 2283
                     WHERE id = %i',
2284 2284
                     $post_user_id
2285 2285
                 );
2286 2286
 
2287 2287
                 if ($data_user) {
2288 2288
                     // Ensure array is unique
2289
-                    $post_new_value = str_replace(',', ';', $data_user['fonction_id']) . ';' . $post_new_value;
2289
+                    $post_new_value = str_replace(',', ';', $data_user['fonction_id']).';'.$post_new_value;
2290 2290
                     $post_new_value = implode(';', array_unique(explode(';', $post_new_value)));
2291 2291
                 } else {
2292 2292
                     // User not found
@@ -2302,7 +2302,7 @@  discard block
 block discarded – undo
2302 2302
             }
2303 2303
 
2304 2304
             // Manage specific case of api key
2305
-            if($post_field === 'user_api_key') {
2305
+            if ($post_field === 'user_api_key') {
2306 2306
                 $encrypted_key = encryptUserObjectKey(base64_encode($post_new_value), $_SESSION['user']['public_key']);
2307 2307
                 $_SESSION['user']['api-key'] = $post_new_value;
2308 2308
 
@@ -2411,7 +2411,7 @@  discard block
 block discarded – undo
2411 2411
                 echo prepareExchangedData(
2412 2412
                     array(
2413 2413
                         'error' => true,
2414
-                        'message' => "Error : ".$error->getErrorCode()." - ".$error->getErrorMessage(). "<br>".$error->getDiagnosticMessage(),
2414
+                        'message' => "Error : ".$error->getErrorCode()." - ".$error->getErrorMessage()."<br>".$error->getDiagnosticMessage(),
2415 2415
                     ),
2416 2416
                     'encode'
2417 2417
                 );
@@ -2438,7 +2438,7 @@  discard block
 block discarded – undo
2438 2438
                 echo prepareExchangedData(
2439 2439
                     array(
2440 2440
                         'error' => true,
2441
-                        'message' => "Error : ".$error->getErrorCode()." - ".$error->getErrorMessage(). "<br>".$error->getDiagnosticMessage(),
2441
+                        'message' => "Error : ".$error->getErrorCode()." - ".$error->getErrorMessage()."<br>".$error->getDiagnosticMessage(),
2442 2442
                     ),
2443 2443
                     'encode'
2444 2444
                 );
@@ -2449,7 +2449,7 @@  discard block
 block discarded – undo
2449 2449
                 if (isset($adUser[$SETTINGS['ldap_user_attribute']][0]) === false) continue;
2450 2450
                 // Build the list of all groups in AD
2451 2451
                 if (isset($adUser['memberof']) === true) {
2452
-                    foreach($adUser['memberof'] as $j => $adUserGroup) {
2452
+                    foreach ($adUser['memberof'] as $j => $adUserGroup) {
2453 2453
                         if (empty($adUserGroup) === false && $j !== "count") {
2454 2454
                             $adGroup = substr($adUserGroup, 3, strpos($adUserGroup, ',') - 3);
2455 2455
                             if (in_array($adGroup, $adRoles) === false && empty($adGroup) === false) {
@@ -2465,7 +2465,7 @@  discard block
 block discarded – undo
2465 2465
                     // Get his ID
2466 2466
                     $userInfo = DB::queryfirstrow(
2467 2467
                         'SELECT id, login, fonction_id, auth_type
2468
-                        FROM ' . prefixTable('users') . '
2468
+                        FROM ' . prefixTable('users').'
2469 2469
                         WHERE login = %s',
2470 2470
                         $userLogin
2471 2471
                     );
@@ -2501,7 +2501,7 @@  discard block
 block discarded – undo
2501 2501
 
2502 2502
             // Get all groups in Teampass
2503 2503
             $teampassRoles = array();
2504
-            $rows = DB::query('SELECT id,title FROM ' . prefixTable('roles_title'));
2504
+            $rows = DB::query('SELECT id,title FROM '.prefixTable('roles_title'));
2505 2505
             foreach ($rows as $record) {
2506 2506
                 array_push(
2507 2507
                     $teampassRoles,
@@ -2571,7 +2571,7 @@  discard block
 block discarded – undo
2571 2571
             // Check if user already exists
2572 2572
             $data = DB::query(
2573 2573
                 'SELECT id, fonction_id, groupes_interdits, groupes_visibles
2574
-                FROM ' . prefixTable('users') . '
2574
+                FROM ' . prefixTable('users').'
2575 2575
                 WHERE login = %s',
2576 2576
                 $post_login
2577 2577
             );
@@ -2751,12 +2751,12 @@  discard block
 block discarded – undo
2751 2751
             // Send mail to user with new OTP
2752 2752
             $userInfo = DB::queryFirstRow(
2753 2753
                 'SELECT email
2754
-                FROM ' . prefixTable('users') . '
2754
+                FROM ' . prefixTable('users').'
2755 2755
                 WHERE id = %i',
2756 2756
                 $post_userId
2757 2757
             );
2758 2758
             sendEmail(
2759
-                'TEAMPASS - ' . langHdl('temporary_encryption_code'),
2759
+                'TEAMPASS - '.langHdl('temporary_encryption_code'),
2760 2760
                 str_replace(
2761 2761
                     array('#enc_code#'),
2762 2762
                     array($post_otp),
@@ -2818,7 +2818,7 @@  discard block
 block discarded – undo
2818 2818
             // Check if user already exists
2819 2819
             DB::query(
2820 2820
                 'SELECT id
2821
-                FROM ' . prefixTable('users') . '
2821
+                FROM ' . prefixTable('users').'
2822 2822
                 WHERE id = %i',
2823 2823
                 $post_id
2824 2824
             );
@@ -2897,7 +2897,7 @@  discard block
 block discarded – undo
2897 2897
             // Check if user already exists
2898 2898
             $userInfo = DB::queryfirstrow(
2899 2899
                 'SELECT id, private_key, public_key
2900
-                FROM ' . prefixTable('users') . '
2900
+                FROM ' . prefixTable('users').'
2901 2901
                 WHERE id = %i',
2902 2902
                 $post_userid
2903 2903
             );
@@ -2944,7 +2944,7 @@  discard block
 block discarded – undo
2944 2944
             if (count($_SESSION['personal_folders']) > 0) {
2945 2945
                 DB::query(
2946 2946
                     'SELECT id
2947
-                    FROM ' . prefixTable('items') . '
2947
+                    FROM ' . prefixTable('items').'
2948 2948
                     WHERE id_tree IN %ls',
2949 2949
                     $_SESSION['personal_folders']
2950 2950
                 );
@@ -3025,7 +3025,7 @@  discard block
 block discarded – undo
3025 3025
             // Check if user already exists
3026 3026
             DB::query(
3027 3027
                 'SELECT id
3028
-                FROM ' . prefixTable('users') . '
3028
+                FROM ' . prefixTable('users').'
3029 3029
                 WHERE id = %i',
3030 3030
                 $post_id
3031 3031
             );
@@ -3103,10 +3103,10 @@  discard block
 block discarded – undo
3103 3103
                     'process_type' => 'create_user_keys',
3104 3104
                     'arguments' => json_encode([
3105 3105
                         'new_user_id' => (int) $post_user_id,
3106
-                        'new_user_pwd' => empty($post_user_pwd) === true ? '' : cryption($post_user_pwd, '','encrypt', $SETTINGS)['string'],
3107
-                        'new_user_code' => cryption($post_user_code, '','encrypt', $SETTINGS)['string'],
3106
+                        'new_user_pwd' => empty($post_user_pwd) === true ? '' : cryption($post_user_pwd, '', 'encrypt', $SETTINGS)['string'],
3107
+                        'new_user_code' => cryption($post_user_code, '', 'encrypt', $SETTINGS)['string'],
3108 3108
                         'owner_id' => (int) $_SESSION['user_id'],
3109
-                        'creator_pwd' => cryption($_SESSION['user_pwd'], '','encrypt', $SETTINGS)['string'],
3109
+                        'creator_pwd' => cryption($_SESSION['user_pwd'], '', 'encrypt', $SETTINGS)['string'],
3110 3110
                         'email_body' => langHdl('email_body_user_config_5'),
3111 3111
                         'send_email' => 1,
3112 3112
                     ]),
@@ -3269,7 +3269,7 @@  discard block
 block discarded – undo
3269 3269
             // get user info
3270 3270
             $userInfo = DB::queryFirstRow(
3271 3271
                 'SELECT *
3272
-                FROM ' . prefixTable('users') . '
3272
+                FROM ' . prefixTable('users').'
3273 3273
                 WHERE id = %i',
3274 3274
                 $user_id
3275 3275
             );
@@ -3362,8 +3362,8 @@  discard block
 block discarded – undo
3362 3362
             // get user info
3363 3363
             $processesProgress = DB::query(
3364 3364
                 'SELECT u.ongoing_process_id, pt.task, pt.updated_at, pt.finished_at, pt.is_in_progress
3365
-                FROM ' . prefixTable('users') . ' AS u
3366
-                INNER JOIN ' . prefixTable('processes_tasks') . ' AS pt ON (pt.process_id = u.ongoing_process_id)
3365
+                FROM ' . prefixTable('users').' AS u
3366
+                INNER JOIN ' . prefixTable('processes_tasks').' AS pt ON (pt.process_id = u.ongoing_process_id)
3367 3367
                 WHERE u.id = %i',
3368 3368
                 $user_id
3369 3369
             );
@@ -3371,9 +3371,9 @@  discard block
 block discarded – undo
3371 3371
             //print_r($processesProgress);
3372 3372
             $finished_steps = 0;
3373 3373
             $nb_steps = count($processesProgress);
3374
-            foreach($processesProgress as $process) {
3374
+            foreach ($processesProgress as $process) {
3375 3375
                 if ((int) $process['is_in_progress'] === -1) {
3376
-                    $finished_steps ++;
3376
+                    $finished_steps++;
3377 3377
                 }
3378 3378
             }
3379 3379
 
@@ -3382,7 +3382,7 @@  discard block
 block discarded – undo
3382 3382
                     'error' => false,
3383 3383
                     'message' => '',
3384 3384
                     'user_id' => $user_id,
3385
-                    'status' => $finished_steps === $nb_steps ? 'finished' : number_format($finished_steps/$nb_steps*100, 0).'%',
3385
+                    'status' => $finished_steps === $nb_steps ? 'finished' : number_format($finished_steps / $nb_steps * 100, 0).'%',
3386 3386
                     'debug' => $finished_steps.",".$nb_steps,
3387 3387
                 ),
3388 3388
                 'encode'
@@ -3447,7 +3447,7 @@  discard block
 block discarded – undo
3447 3447
 
3448 3448
     // Get info about user
3449 3449
     $data_user = DB::queryfirstrow(
3450
-        'SELECT admin, isAdministratedByRole FROM ' . prefixTable('users') . '
3450
+        'SELECT admin, isAdministratedByRole FROM '.prefixTable('users').'
3451 3451
         WHERE id = %i',
3452 3452
         $value[1]
3453 3453
     );
@@ -3480,7 +3480,7 @@  discard block
 block discarded – undo
3480 3480
             logEvents(
3481 3481
                 $SETTINGS,
3482 3482
                 'user_mngt',
3483
-                'at_user_new_' . $value[0] . ':' . $value[1],
3483
+                'at_user_new_'.$value[0].':'.$value[1],
3484 3484
                 (string) $_SESSION['user_id'],
3485 3485
                 $_SESSION['login'],
3486 3486
                 filter_input(INPUT_POST, 'id', FILTER_SANITIZE_FULL_SPECIAL_CHARS)
@@ -3511,7 +3511,7 @@  discard block
 block discarded – undo
3511 3511
 
3512 3512
     // Get info about user
3513 3513
     $data_user = DB::queryfirstrow(
3514
-        'SELECT admin, isAdministratedByRole FROM ' . prefixTable('users') . '
3514
+        'SELECT admin, isAdministratedByRole FROM '.prefixTable('users').'
3515 3515
         WHERE id = %i',
3516 3516
         $value[1]
3517 3517
     );
Please login to merge, or discard this patch.
sources/users.datatable.php 1 patch
Spacing   +5 added lines, -7 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 ) {
72 72
     // Not allowed page
73 73
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
74
-    include $SETTINGS['cpassman_dir'] . '/error.php';
74
+    include $SETTINGS['cpassman_dir'].'/error.php';
75 75
     exit;
76 76
 }
77 77
 
@@ -232,22 +232,20 @@  discard block
 block discarded – undo
232 232
 
233 233
         // Get some infos about user
234 234
         $userDisplayInfos = 
235
-            (isset($userDate['date']) ? '<i class=\"fas fa-calendar-day infotip text-info ml-2\" title=\"'.langHdl('creation_date').': '.date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $userDate['date']).'\"></i>' : '')
235
+            (isset($userDate['date']) ? '<i class=\"fas fa-calendar-day infotip text-info ml-2\" title=\"'.langHdl('creation_date').': '.date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $userDate['date']).'\"></i>' : '')
236 236
             .
237 237
             ((int) $record['last_connexion'] > 0 ? '<i class=\"far fa-clock infotip text-info ml-2\" title=\"'.langHdl('index_last_seen').": ".
238
-            date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['last_connexion']).'\"></i>' : '')
238
+            date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $record['last_connexion']).'\"></i>' : '')
239 239
             .
240 240
             ((int) $record['user_ip'] > 0 ? '<i class=\"fas fa-street-view infotip text-info ml-1\" title=\"'.langHdl('ip').": ".($record['user_ip']).'\"></i>' : '')
241 241
             .
242 242
             ($record['auth_type'] === 'ldap' ? '<i class=\"far fa-address-book infotip text-warning ml-1\" title=\"'.langHdl('managed_through_ad').'\"></i>' : '')
243 243
             .
244 244
             ((in_array($record['id'], [OTV_USER_ID, TP_USER_ID, SSH_USER_ID, API_USER_ID]) === false && (int) $record['admin'] !== 1 && ((int) $SETTINGS['duo'] === 1 || (int) $SETTINGS['google_authentication'] === 1)) ?
245
-                ((int) $record['mfa_enabled'] === 1 ? '' : '<i class=\"fa-solid fa-fingerprint infotip ml-1\" style=\"color:Tomato\" title=\"'.langHdl('mfa_disabled_for_user').'\"></i>') :
246
-                ''
245
+                ((int) $record['mfa_enabled'] === 1 ? '' : '<i class=\"fa-solid fa-fingerprint infotip ml-1\" style=\"color:Tomato\" title=\"'.langHdl('mfa_disabled_for_user').'\"></i>') : ''
247 246
             ).
248 247
             ((in_array($record['id'], [OTV_USER_ID, TP_USER_ID, SSH_USER_ID, API_USER_ID]) === false && (int) $record['admin'] !== 1 && is_null($record['keys_recovery_time']) === true) ? 
249
-                '<i class=\"fa-solid fa-download infotip ml-1\" style=\"color:Tomato\" title=\"'.langHdl('recovery_keys_not_downloaded').'\"></i>' :
250
-                ''
248
+                '<i class=\"fa-solid fa-download infotip ml-1\" style=\"color:Tomato\" title=\"'.langHdl('recovery_keys_not_downloaded').'\"></i>' : ''
251 249
             );
252 250
         
253 251
         $sOutput .= '["<span data-id=\"'.$record['id'].'\" data-fullname=\"'.
Please login to merge, or discard this patch.
sources/ldap.activedirectory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
     try {
48 48
         Container::addConnection($connection);
49 49
         // get id attribute
50
-        if (isset($SETTINGS['ldap_guid_attibute']) ===true && empty($SETTINGS['ldap_guid_attibute']) === false) {
50
+        if (isset($SETTINGS['ldap_guid_attibute']) === true && empty($SETTINGS['ldap_guid_attibute']) === false) {
51 51
             $idAttribute = $SETTINGS['ldap_guid_attibute'];
52 52
         } else {
53 53
             $idAttribute = 'objectguid';
Please login to merge, or discard this patch.
sources/folders.datatable.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 ) {
71 71
     // Not allowed page
72 72
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
73
-    include $SETTINGS['cpassman_dir'] . '/error.php';
73
+    include $SETTINGS['cpassman_dir'].'/error.php';
74 74
     exit;
75 75
 }
76 76
 
Please login to merge, or discard this patch.
sources/user.logs.datatables.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 ) {
71 71
     // Not allowed page
72 72
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
73
-    include $SETTINGS['cpassman_dir'] . '/error.php';
73
+    include $SETTINGS['cpassman_dir'].'/error.php';
74 74
     exit;
75 75
 }
76 76
 
Please login to merge, or discard this patch.
sources/find.queries.php 1 patch
Spacing   +44 added lines, -44 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 ) {
73 73
     // Not allowed page
74 74
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
75
-    include $SETTINGS['cpassman_dir'] . '/error.php';
75
+    include $SETTINGS['cpassman_dir'].'/error.php';
76 76
     exit;
77 77
 }
78 78
 
@@ -94,12 +94,12 @@  discard block
 block discarded – undo
94 94
 if (isset($_SESSION['groupes_visibles']) === false
95 95
     || empty($_SESSION['groupes_visibles']) === true
96 96
 ) {
97
-    echo '{"sEcho": ' . intval($_GET['sEcho']) . ' ,"iTotalRecords": "0", "iTotalDisplayRecords": "0", "aaData": [] }';
97
+    echo '{"sEcho": '.intval($_GET['sEcho']).' ,"iTotalRecords": "0", "iTotalDisplayRecords": "0", "aaData": [] }';
98 98
     exit;
99 99
 }
100 100
 
101 101
 //Columns name
102
-$aColumns = ['c.id', 'c.label', 'c.login', 'c.description', 'c.tags', 'c.id_tree', 'c.folder', 'c.login', 'c.url', 'ci.data'];//
102
+$aColumns = ['c.id', 'c.label', 'c.login', 'c.description', 'c.tags', 'c.id_tree', 'c.folder', 'c.login', 'c.url', 'ci.data']; //
103 103
 $aSortTypes = ['ASC', 'DESC'];
104 104
 //init SQL variables
105 105
 $sOrder = $sLimit = $sWhere = '';
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 
120 120
 //Get current user "personal folder" ID
121 121
 $row = DB::query(
122
-    'SELECT id FROM ' . prefixTable('nested_tree') . ' WHERE title = %i',
122
+    'SELECT id FROM '.prefixTable('nested_tree').' WHERE title = %i',
123 123
     intval($_SESSION['user_id'])
124 124
 );
125 125
 //get list of personal folders
@@ -128,20 +128,20 @@  discard block
 block discarded – undo
128 128
 $listPf = '';
129 129
 if (empty($row['id']) === false) {
130 130
     $rows = DB::query(
131
-        'SELECT id FROM ' . prefixTable('nested_tree') . '
131
+        'SELECT id FROM '.prefixTable('nested_tree').'
132 132
         WHERE personal_folder = 1 AND NOT parent_id = %i AND NOT title = %i',
133 133
         filter_var($row['id'], FILTER_SANITIZE_NUMBER_INT),
134 134
         filter_var($_SESSION['user_id'], FILTER_SANITIZE_NUMBER_INT)
135 135
     );
136 136
     foreach ($rows as $record) {
137
-        if (! in_array($record['id'], $arrayPf)) {
137
+        if (!in_array($record['id'], $arrayPf)) {
138 138
             //build an array of personal folders ids
139 139
             array_push($arrayPf, $record['id']);
140 140
             //build also a string with those ids
141 141
             if (empty($listPf)) {
142 142
                 $listPf = $record['id'];
143 143
             } else {
144
-                $listPf .= ', ' . $record['id'];
144
+                $listPf .= ', '.$record['id'];
145 145
             }
146 146
         }
147 147
     }
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 //Paging
152 152
 $sLimit = '';
153 153
 if (isset($_GET['start']) === true && $_GET['length'] !== '-1') {
154
-    $sLimit = 'LIMIT ' . filter_var($_GET['start'], FILTER_SANITIZE_NUMBER_INT) . ', ' . filter_var($_GET['length'], FILTER_SANITIZE_NUMBER_INT) . '';
154
+    $sLimit = 'LIMIT '.filter_var($_GET['start'], FILTER_SANITIZE_NUMBER_INT).', '.filter_var($_GET['length'], FILTER_SANITIZE_NUMBER_INT).'';
155 155
 }
156 156
 
157 157
 //Ordering
@@ -164,8 +164,8 @@  discard block
 block discarded – undo
164 164
     }
165 165
     $sOrder = 'ORDER BY  ';
166 166
     if ($_GET['order'][0]['column'] >= 0) {
167
-        $sOrder .= '' . $aColumns[filter_var($_GET['order'][0]['column'], FILTER_SANITIZE_NUMBER_INT)] . ' '
168
-                . filter_var($_GET['order'][0]['dir'], FILTER_SANITIZE_FULL_SPECIAL_CHARS) . ', ';
167
+        $sOrder .= ''.$aColumns[filter_var($_GET['order'][0]['column'], FILTER_SANITIZE_NUMBER_INT)].' '
168
+                . filter_var($_GET['order'][0]['dir'], FILTER_SANITIZE_FULL_SPECIAL_CHARS).', ';
169 169
     }
170 170
 
171 171
     $sOrder = substr_replace($sOrder, '', -2);
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
         $sOrder = '';
174 174
     }
175 175
 } else {
176
-    $sOrder = 'ORDER BY ' . $aColumns[1] . ' ASC';
176
+    $sOrder = 'ORDER BY '.$aColumns[1].' ASC';
177 177
 }
178 178
 
179 179
 // Define criteria
@@ -195,9 +195,9 @@  discard block
 block discarded – undo
195 195
 if (empty($search_criteria) === false) {
196 196
     $sWhere .= ' AND (';
197 197
     for ($i = 0; $i < count($aColumns); ++$i) {
198
-        $sWhere .= $aColumns[$i] . ' LIKE %ss_' . $i . ' OR ';
198
+        $sWhere .= $aColumns[$i].' LIKE %ss_'.$i.' OR ';
199 199
     }
200
-    $sWhere = substr_replace((string) $sWhere, '', -3) . ') ';
200
+    $sWhere = substr_replace((string) $sWhere, '', -3).') ';
201 201
     $crit = [
202 202
         'idtree' => array_unique($folders),
203 203
         '0' => $search_criteria,
@@ -237,16 +237,16 @@  discard block
 block discarded – undo
237 237
     if (empty($sWhere) === false) {
238 238
         $sWhere .= ' AND ';
239 239
     }
240
-    $sWhere = 'WHERE ' . $sWhere . 'c.id_tree NOT IN %ls_pf ';
240
+    $sWhere = 'WHERE '.$sWhere.'c.id_tree NOT IN %ls_pf ';
241 241
 } else {
242
-    $sWhere = 'WHERE ' . $sWhere;
242
+    $sWhere = 'WHERE '.$sWhere;
243 243
 }
244 244
 
245 245
 // Do queries
246 246
 DB::query(
247 247
     "SELECT c.id
248
-    FROM " . prefixTable('cache') . " AS c
249
-    LEFT JOIN " . prefixTable('categories_items') . " AS ci ON (ci.item_id = c.id)
248
+    FROM " . prefixTable('cache')." AS c
249
+    LEFT JOIN " . prefixTable('categories_items')." AS ci ON (ci.item_id = c.id)
250 250
     ${sWhere}
251 251
     ${sOrder}",
252 252
     $crit
@@ -254,9 +254,9 @@  discard block
 block discarded – undo
254 254
 $iTotal = DB::count();
255 255
 $rows = DB::query(
256 256
     "SELECT c.*, ci.data, i.item_key
257
-    FROM " . prefixTable('cache') . " AS c
258
-    LEFT JOIN " . prefixTable('categories_items') . " AS ci ON (ci.item_id = c.id)
259
-    INNER JOIN " . prefixTable('items') . " AS i ON (i.id = c.id)
257
+    FROM " . prefixTable('cache')." AS c
258
+    LEFT JOIN " . prefixTable('categories_items')." AS ci ON (ci.item_id = c.id)
259
+    INNER JOIN " . prefixTable('items')." AS i ON (i.id = c.id)
260 260
     ${sWhere}
261 261
     ${sOrder}
262 262
     ${sLimit}",
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 if (isset($_GET['type']) === false) {
281 281
     $sOutput = '{';
282 282
     if (isset($_GET['draw']) === true) {
283
-        $sOutput .= '"draw": ' . intval($_GET['draw']) . ', ';
283
+        $sOutput .= '"draw": '.intval($_GET['draw']).', ';
284 284
     }
285 285
     $sOutput .= '"data": [';
286 286
     $sOutputConst = '';
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
             foreach (explode(';', $_SESSION['fonction_id']) as $role) {
298 298
                 //db::debugmode(true);
299 299
                 $access = DB::queryFirstRow(
300
-                    'SELECT type FROM ' . prefixTable('roles_values') . ' WHERE role_id = %i AND folder_id = %i',
300
+                    'SELECT type FROM '.prefixTable('roles_values').' WHERE role_id = %i AND folder_id = %i',
301 301
                     $role,
302 302
                     $record['id_tree']
303 303
                 );
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
             }
318 318
             $accessLevel = count($arrTmp) > 0 ? min($arrTmp) : $accessLevel;
319 319
             if ($accessLevel === 0) {
320
-                $checkbox = '<input type=\"checkbox\" value=\"0\" class=\"mass_op_cb\" data-id=\"' . $record['id'] . '\">';
320
+                $checkbox = '<input type=\"checkbox\" value=\"0\" class=\"mass_op_cb\" data-id=\"'.$record['id'].'\">';
321 321
             }
322 322
 
323 323
             if ((int) $accessLevel === 0) {
@@ -357,22 +357,22 @@  discard block
 block discarded – undo
357 357
             if (empty($restrictedTo)) {
358 358
                 $restrictedTo = $_SESSION['user_id'];
359 359
             } else {
360
-                $restrictedTo .= ',' . $_SESSION['user_id'];
360
+                $restrictedTo .= ','.$_SESSION['user_id'];
361 361
             }
362 362
         }
363 363
         
364 364
         //col1
365
-        $sOutputItem .= '"<i class=\"fa fa-external-link-alt infotip mr-2\" title=\"' . langHdl('open_url_link') . '\" onClick=\"window.location.href=&#039;index.php?page=items&amp;group=' . $record['id_tree'] . '&amp;id=' . $record['id'] . '&#039;\" style=\"cursor:pointer;\"></i>' .
366
-        '<i class=\"fa fa-eye infotip mr-2 item-detail\" title=\"' . stripslashes(langHdl('see_item_title')) . '\" data-id=\"' . $record['id'] . '\" data-perso=\"' . $record['perso'] . '\" data-tree-id=\"' . $record['id_tree'] . '\" data-expired=\"' . $expired . '\" data-restricted-to=\"' . $restrictedTo . '\" data-rights=\"' . $right . '\" style=\"cursor:pointer;\"></i>' . $checkbox . '",' ;
365
+        $sOutputItem .= '"<i class=\"fa fa-external-link-alt infotip mr-2\" title=\"'.langHdl('open_url_link').'\" onClick=\"window.location.href=&#039;index.php?page=items&amp;group='.$record['id_tree'].'&amp;id='.$record['id'].'&#039;\" style=\"cursor:pointer;\"></i>'.
366
+        '<i class=\"fa fa-eye infotip mr-2 item-detail\" title=\"'.stripslashes(langHdl('see_item_title')).'\" data-id=\"'.$record['id'].'\" data-perso=\"'.$record['perso'].'\" data-tree-id=\"'.$record['id_tree'].'\" data-expired=\"'.$expired.'\" data-restricted-to=\"'.$restrictedTo.'\" data-rights=\"'.$right.'\" style=\"cursor:pointer;\"></i>'.$checkbox.'",';
367 367
         //col2
368
-        $sOutputItem .= '"'.base64_encode('<span id=\"item_label-' . $record['id'] . '\">' . (str_replace("\\", "&#92;", (string) $record['label'])) . '</span>').'", ';   // replace backslash #3015
368
+        $sOutputItem .= '"'.base64_encode('<span id=\"item_label-'.$record['id'].'\">'.(str_replace("\\", "&#92;", (string) $record['label'])).'</span>').'", '; // replace backslash #3015
369 369
         //col3
370
-        $sOutputItem .= '"' . base64_encode(str_replace('&amp;', '&', htmlspecialchars(stripslashes((string) $record['login']), ENT_QUOTES))) . '", ';
370
+        $sOutputItem .= '"'.base64_encode(str_replace('&amp;', '&', htmlspecialchars(stripslashes((string) $record['login']), ENT_QUOTES))).'", ';
371 371
         //col4
372 372
         //get restriction from ROles
373 373
         $restrictedToRole = false;
374 374
         $rTmp = DB::queryFirstColumn(
375
-            'SELECT role_id FROM ' . prefixTable('restriction_to_roles') . ' WHERE item_id = %i',
375
+            'SELECT role_id FROM '.prefixTable('restriction_to_roles').' WHERE item_id = %i',
376 376
             $record['id']
377 377
         );
378 378
         // We considere here that if user has at least one group similar to the object ones
@@ -390,14 +390,14 @@  discard block
 block discarded – undo
390 390
         } else {
391 391
             $txt = str_replace(['\n', '<br />', '\\'], [' ', ' ', '', ' '], strip_tags($record['description']));
392 392
             if (strlen($txt) > 50) {
393
-                $sOutputItem .= '"' . base64_encode(substr(stripslashes(preg_replace('~/<[\/]{0,1}[^>]*>\//|[ \t]/~', '', $txt)), 0, 50)) . '", ';
393
+                $sOutputItem .= '"'.base64_encode(substr(stripslashes(preg_replace('~/<[\/]{0,1}[^>]*>\//|[ \t]/~', '', $txt)), 0, 50)).'", ';
394 394
             } else {
395
-                $sOutputItem .= '"' . base64_encode(stripslashes(preg_replace('~/<[^>]*>|[ \t]/~', '', $txt))) . '", ';
395
+                $sOutputItem .= '"'.base64_encode(stripslashes(preg_replace('~/<[^>]*>|[ \t]/~', '', $txt))).'", ';
396 396
             }
397 397
         }
398 398
 
399 399
         //col5 - TAGS
400
-        $sOutputItem .= '"' . base64_encode(htmlspecialchars(stripslashes((string) $record['tags']), ENT_QUOTES)) . '", ';
400
+        $sOutputItem .= '"'.base64_encode(htmlspecialchars(stripslashes((string) $record['tags']), ENT_QUOTES)).'", ';
401 401
         // col6 - URL
402 402
         if ($record['url'] !== '0') {
403 403
             $sOutputItem .= '"'.filter_var($record['url'], FILTER_SANITIZE_URL).'", ';
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
         }
407 407
 
408 408
         //col7 - Prepare the Treegrid
409
-        $sOutputItem .= '"' . base64_encode(htmlspecialchars(stripslashes((string) $record['folder']), ENT_QUOTES)) . '"';
409
+        $sOutputItem .= '"'.base64_encode(htmlspecialchars(stripslashes((string) $record['folder']), ENT_QUOTES)).'"';
410 410
         //Finish the line
411 411
         //$sOutputItem .= '], ';
412 412
         if ($getItemInList === true) {
@@ -415,16 +415,16 @@  discard block
 block discarded – undo
415 415
             --$iTotal;
416 416
         }
417 417
     }
418
-    if (! empty($sOutputConst)) {
418
+    if (!empty($sOutputConst)) {
419 419
         $sOutput .= substr_replace($sOutputConst, '', -2);
420 420
     }
421 421
     $sOutput .= '], ';
422
-    $sOutput .= '"recordsTotal": ' . $iTotal . ', ';
423
-    $sOutput .= '"recordsFiltered": ' . $iTotal . ' }';
422
+    $sOutput .= '"recordsTotal": '.$iTotal.', ';
423
+    $sOutput .= '"recordsFiltered": '.$iTotal.' }';
424 424
     echo ($sOutput);
425 425
 } elseif (isset($_GET['type']) && ($_GET['type'] === 'search_for_items' || $_GET['type'] === 'search_for_items_with_tags')) {
426 426
     include_once 'main.functions.php';
427
-    include_once $SETTINGS['cpassman_dir'] . '/includes/language/' . $_SESSION['user']['user_language'] . '.php';
427
+    include_once $SETTINGS['cpassman_dir'].'/includes/language/'.$_SESSION['user']['user_language'].'.php';
428 428
 
429 429
     $arr_data = [];
430 430
     foreach ($rows as $record) {
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
         $arr_data[$record['id']]['tree_id'] = (int) $record['id_tree'];
434 434
         $arr_data[$record['id']]['label'] = (string) $record['label'];
435 435
         $arr_data[$record['id']]['desc'] = (string) strip_tags(explode('<br>', $record['description'])[0]);
436
-        $arr_data[$record['id']]['folder'] = (string)$record['folder'];
436
+        $arr_data[$record['id']]['folder'] = (string) $record['folder'];
437 437
         $arr_data[$record['id']]['login'] = (string) strtr($record['login'], '"', '&quot;');
438 438
         $arr_data[$record['id']]['item_key'] = (string) $record['item_key'];
439 439
         $arr_data[$record['id']]['link'] = (string) $record['url'] !== '0' && empty($record['url']) === false ? filter_var($record['url'], FILTER_SANITIZE_URL) : '';
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
 
447 447
         // Anyone can modify?
448 448
         $tmp = DB::queryfirstrow(
449
-            'SELECT anyone_can_modify FROM ' . prefixTable('items') . ' WHERE id = %i',
449
+            'SELECT anyone_can_modify FROM '.prefixTable('items').' WHERE id = %i',
450 450
             $record['id']
451 451
         );
452 452
         if (count($tmp) > 0) {
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
477 477
         // => récupérer un tableau contenant les roles associés à cet ID (a partir table restriction_to_roles)
478 478
         $user_is_included_in_role = 0;
479 479
         $roles = DB::query(
480
-            'SELECT role_id FROM ' . prefixTable('restriction_to_roles') . ' WHERE item_id=%i',
480
+            'SELECT role_id FROM '.prefixTable('restriction_to_roles').' WHERE item_id=%i',
481 481
             $record['id']
482 482
         );
483 483
         if (count($roles) > 0) {
@@ -500,7 +500,7 @@  discard block
 block discarded – undo
500 500
             if (empty($restrictedTo)) {
501 501
                 $restrictedTo = $_SESSION['user_id'];
502 502
             } else {
503
-                $restrictedTo .= ',' . $_SESSION['user_id'];
503
+                $restrictedTo .= ','.$_SESSION['user_id'];
504 504
             }
505 505
         }
506 506
 
@@ -598,7 +598,7 @@  discard block
 block discarded – undo
598 598
             $arrTmp = [];
599 599
             foreach (explode(';', $_SESSION['fonction_id']) as $role) {
600 600
                 $access = DB::queryFirstRow(
601
-                    'SELECT type FROM ' . prefixTable('roles_values') . ' WHERE role_id = %i AND folder_id = %i',
601
+                    'SELECT type FROM '.prefixTable('roles_values').' WHERE role_id = %i AND folder_id = %i',
602 602
                     $role,
603 603
                     $record['id_tree']
604 604
                 );
@@ -649,8 +649,8 @@  discard block
 block discarded – undo
649 649
         ) {
650 650
             $data_item = DB::queryFirstRow(
651 651
                 'SELECT i.pw AS pw, s.share_key AS share_key
652
-                FROM ' . prefixTable('items') . ' AS i
653
-                INNER JOIN ' . prefixTable('sharekeys_items') . ' AS s ON (s.object_id = i.id)
652
+                FROM ' . prefixTable('items').' AS i
653
+                INNER JOIN ' . prefixTable('sharekeys_items').' AS s ON (s.object_id = i.id)
654 654
                 WHERE i.id = %i AND s.user_id = %i',
655 655
                 $record['id'],
656 656
                 $_SESSION['user_id']
Please login to merge, or discard this patch.
sources/del_SecureHandler.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -25,13 +25,13 @@  discard block
 block discarded – undo
25 25
      */
26 26
     public function __construct()
27 27
     {
28
-        if (! extension_loaded('openssl')) {
28
+        if (!extension_loaded('openssl')) {
29 29
             throw new \RuntimeException(sprintf(
30 30
                 "You need the OpenSSL extension to use %s",
31 31
                 __CLASS__
32 32
             ));
33 33
         }
34
-        if (! extension_loaded('mbstring')) {
34
+        if (!extension_loaded('mbstring')) {
35 35
             throw new \RuntimeException(sprintf(
36 36
                 "You need the Multibytes extension to use %s",
37 37
                 __CLASS__
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function open($save_path, $session_name): bool
49 49
     {
50
-        $this->key = $this->getKey('KEY_' . $session_name);
50
+        $this->key = $this->getKey('KEY_'.$session_name);
51 51
         return parent::open($save_path, $session_name);
52 52
     }
53 53
 
@@ -94,11 +94,11 @@  discard block
 block discarded – undo
94 94
         // Authentication
95 95
         $hmac = hash_hmac(
96 96
             'SHA256',
97
-            $iv . $ciphertext,
97
+            $iv.$ciphertext,
98 98
             mb_substr($key, 32, null, '8bit'),
99 99
             true
100 100
         );
101
-        return $hmac . $iv . $ciphertext;
101
+        return $hmac.$iv.$ciphertext;
102 102
     }
103 103
 
104 104
     /**
@@ -116,11 +116,11 @@  discard block
 block discarded – undo
116 116
         // Authentication
117 117
         $hmacNew = hash_hmac(
118 118
             'SHA256',
119
-            $iv . $ciphertext,
119
+            $iv.$ciphertext,
120 120
             mb_substr($key, 32, null, '8bit'),
121 121
             true
122 122
         );
123
-        if (! hash_equals($hmac, $hmacNew)) {
123
+        if (!hash_equals($hmac, $hmacNew)) {
124 124
             throw new Exception\AuthenticationFailedException('Authentication failed');
125 125
         }
126 126
         // Decrypt
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
             // if session cookie lifetime > 0 then add to current time
149 149
             // otherwise leave it as zero, honoring zero's special meaning
150 150
             // expire at browser close.
151
-            $arr_cookie_options = array (
151
+            $arr_cookie_options = array(
152 152
                 'expires' => ($cookieParam['lifetime'] > 0) ? time() + $cookieParam['lifetime'] : 0,
153 153
                 'path' => '/',
154 154
                 'secure' => true,
Please login to merge, or discard this patch.