Passed
Pull Request — master (#4676)
by Nils
05:33
created
scripts/task_maintenance_clean_orphan_objects.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -73,64 +73,64 @@
 block discarded – undo
73 73
 {
74 74
     // Delete all item keys for which no user exist
75 75
     DB::query(
76
-        'DELETE k FROM ' . prefixTable('sharekeys_items') . ' k
77
-        LEFT JOIN ' . prefixTable('users') . ' u ON k.user_id = u.id
76
+        'DELETE k FROM '.prefixTable('sharekeys_items').' k
77
+        LEFT JOIN ' . prefixTable('users').' u ON k.user_id = u.id
78 78
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
79 79
     );
80 80
 
81 81
     // Delete all files keys for which no user exist
82 82
     DB::query(
83
-        'DELETE k FROM ' . prefixTable('sharekeys_files') . ' k
84
-        LEFT JOIN ' . prefixTable('users') . ' u ON k.user_id = u.id
83
+        'DELETE k FROM '.prefixTable('sharekeys_files').' k
84
+        LEFT JOIN ' . prefixTable('users').' u ON k.user_id = u.id
85 85
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
86 86
     );
87 87
 
88 88
     // Delete all fields keys for which no user exist
89 89
     DB::query(
90
-        'DELETE k FROM ' . prefixTable('sharekeys_fields') . ' k
91
-        LEFT JOIN ' . prefixTable('users') . ' u ON k.user_id = u.id
90
+        'DELETE k FROM '.prefixTable('sharekeys_fields').' k
91
+        LEFT JOIN ' . prefixTable('users').' u ON k.user_id = u.id
92 92
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
93 93
     );
94 94
 
95 95
     // Delete all item logs for which no user exist
96 96
     DB::query(
97
-        'DELETE l FROM ' . prefixTable('log_items') . ' l
98
-        LEFT JOIN ' . prefixTable('users') . ' u ON l.id_user = u.id
97
+        'DELETE l FROM '.prefixTable('log_items').' l
98
+        LEFT JOIN ' . prefixTable('users').' u ON l.id_user = u.id
99 99
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
100 100
     );
101 101
 
102 102
     // Delete all system logs for which no user exist
103 103
     DB::query(
104
-        'DELETE l FROM ' . prefixTable('log_system') . ' l
105
-        LEFT JOIN ' . prefixTable('users') . ' u ON l.qui = u.id
104
+        'DELETE l FROM '.prefixTable('log_system').' l
105
+        LEFT JOIN ' . prefixTable('users').' u ON l.qui = u.id
106 106
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
107 107
     );
108 108
 
109 109
     // Delete all item keys for which no object exist
110 110
     DB::query(
111
-        'DELETE k FROM ' . prefixTable('sharekeys_items') . ' k
112
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.object_id = i.id
111
+        'DELETE k FROM '.prefixTable('sharekeys_items').' k
112
+        LEFT JOIN ' . prefixTable('items').' i ON k.object_id = i.id
113 113
         WHERE i.id IS NULL'
114 114
     );
115 115
 
116 116
     // Delete all files keys for which no object exist
117 117
     DB::query(
118
-        'DELETE k FROM ' . prefixTable('sharekeys_files') . ' k
119
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.object_id = i.id
118
+        'DELETE k FROM '.prefixTable('sharekeys_files').' k
119
+        LEFT JOIN ' . prefixTable('items').' i ON k.object_id = i.id
120 120
         WHERE i.id IS NULL'
121 121
     );
122 122
 
123 123
     // Delete all fields keys for which no object exist
124 124
     DB::query(
125
-        'DELETE k FROM ' . prefixTable('sharekeys_fields') . ' k
126
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.object_id = i.id
125
+        'DELETE k FROM '.prefixTable('sharekeys_fields').' k
126
+        LEFT JOIN ' . prefixTable('items').' i ON k.object_id = i.id
127 127
         WHERE i.id IS NULL'
128 128
     );
129 129
 
130 130
     // Delete all item logs for which no object exist
131 131
     DB::query(
132
-        'DELETE l FROM ' . prefixTable('log_items') . ' l
133
-        LEFT JOIN ' . prefixTable('items') . ' i ON l.id_item = i.id
132
+        'DELETE l FROM '.prefixTable('log_items').' l
133
+        LEFT JOIN ' . prefixTable('items').' i ON l.id_item = i.id
134 134
         WHERE i.id IS NULL'
135 135
     );
136 136
 
Please login to merge, or discard this patch.
scripts/TaskLogger.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,8 +47,8 @@
 block discarded – undo
47 47
      */
48 48
     public function log(string $message, string $level = 'INFO') {
49 49
         if (!empty($this->settings['enable_tasks_log'])) {
50
-            $formattedMessage = date($this->settings['date_format'] . ' ' . $this->settings['time_format']) . 
51
-                                " - [$level] $message" . PHP_EOL;
50
+            $formattedMessage = date($this->settings['date_format'].' '.$this->settings['time_format']). 
51
+                                " - [$level] $message".PHP_EOL;
52 52
 
53 53
             if (!empty($this->logFile)) {
54 54
                 // WWrite to the specified log file
Please login to merge, or discard this patch.
sources/logs.datatables.php 1 patch
Spacing   +24 added lines, -26 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 ) {
77 77
     // Not allowed page
78 78
     $session->set('system-error_code', ERR_NOT_ALLOWED);
79
-    include $SETTINGS['cpassman_dir'] . '/error.php';
79
+    include $SETTINGS['cpassman_dir'].'/error.php';
80 80
     exit;
81 81
 }
82 82
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
     
169 169
     // Output
170 170
     $sOutput = '{';
171
-    $sOutput .= '"sEcho": '. $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
171
+    $sOutput .= '"sEcho": '.$request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
172 172
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
173 173
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
174 174
     $sOutput .= '"aaData": ';
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 
242 242
     // Output
243 243
     $sOutput = '{';
244
-    $sOutput .= '"sEcho": '. $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
244
+    $sOutput .= '"sEcho": '.$request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
245 245
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
246 246
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
247 247
     $sOutput .= '"aaData": ';
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
 
315 315
     // Output
316 316
     $sOutput = '{';
317
-    $sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
317
+    $sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
318 318
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
319 319
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
320 320
     $sOutput .= '"aaData": ';
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 
388 388
     // Output
389 389
     $sOutput = '{';
390
-    $sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
390
+    $sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
391 391
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
392 392
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
393 393
     $sOutput .= '"aaData": [ ';
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
 
491 491
     // Output
492 492
     $sOutput = '{';
493
-    $sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
493
+    $sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
494 494
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
495 495
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
496 496
     $sOutput .= '"aaData": [ ';
@@ -572,7 +572,7 @@  discard block
 block discarded – undo
572 572
         $iTotal = 0;
573 573
     }
574 574
     $sOutput = '{';
575
-    $sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
575
+    $sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
576 576
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
577 577
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
578 578
     $sOutput .= '"aaData": ';
@@ -648,7 +648,7 @@  discard block
 block discarded – undo
648 648
 
649 649
     // Output
650 650
     $sOutput = '{';
651
-    $sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
651
+    $sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
652 652
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
653 653
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
654 654
     $sOutput .= '"aaData": ';
@@ -717,7 +717,7 @@  discard block
 block discarded – undo
717 717
 
718 718
     // Output
719 719
     $sOutput = '{';
720
-    $sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
720
+    $sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
721 721
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
722 722
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
723 723
     $sOutput .= '"aaData": ';
@@ -790,7 +790,7 @@  discard block
 block discarded – undo
790 790
 
791 791
     // Output
792 792
     $sOutput = '{';
793
-    $sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
793
+    $sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
794 794
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
795 795
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
796 796
     $sOutput .= '"aaData": ';
@@ -867,7 +867,7 @@  discard block
 block discarded – undo
867 867
             FROM '.prefixTable('background_tasks').' AS p 
868 868
             LEFT JOIN '.prefixTable('users').' AS u ON %l
869 869
             WHERE %l ORDER BY %l %l LIMIT %i, %i';
870
-    $params = ['u.id = json_extract(p.arguments, "$[0]")',$sWhere, $orderColumn, $orderDirection, $sLimitStart, $sLimitLength];
870
+    $params = ['u.id = json_extract(p.arguments, "$[0]")', $sWhere, $orderColumn, $orderDirection, $sLimitStart, $sLimitLength];
871 871
 
872 872
     // Get the records
873 873
     $rows = DB::query($sql, ...$params);
@@ -875,7 +875,7 @@  discard block
 block discarded – undo
875 875
 
876 876
     // Output
877 877
     $sOutput = '{';
878
-    $sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
878
+    $sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
879 879
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
880 880
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
881 881
     $sOutput .= '"aaData": ';
@@ -890,7 +890,7 @@  discard block
 block discarded – undo
890 890
         //col1
891 891
         $sOutput .= '"<span data-done=\"'.$record['is_in_progress'].'\" data-type=\"'.$record['process_type'].'\" data-process-id=\"'.$record['increment_id'].'\"></span>", ';
892 892
         //col2
893
-        $sOutput .= '"'.date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['created_at']).'", ';
893
+        $sOutput .= '"'.date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $record['created_at']).'", ';
894 894
         //col3
895 895
         //$sOutput .= '"'.($record['updated_at'] === '' ? '-' : date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['updated_at'])).'", ';
896 896
         $sOutput .= '"<div class=\"progress mt-2\"><div class=\"progress-bar\" style=\"width: '.$subtaskProgress.'\">'.$subtaskProgress.'</div></div>", ';
@@ -900,7 +900,7 @@  discard block
 block discarded – undo
900 900
         // col5
901 901
         if (in_array($record['process_type'], array('create_user_keys', 'item_copy')) === true) {
902 902
             $data_user = DB::queryFirstRow(
903
-                'SELECT name, lastname FROM ' . prefixTable('users') . '
903
+                'SELECT name, lastname FROM '.prefixTable('users').'
904 904
                 WHERE id = %i',
905 905
                 json_decode($record['arguments'], true)['new_user_id']
906 906
             );
@@ -956,7 +956,7 @@  discard block
 block discarded – undo
956 956
     FROM '.prefixTable('background_tasks').' AS p 
957 957
     LEFT JOIN '.prefixTable('users').' AS u ON %l
958 958
     WHERE %l ORDER BY %l %l LIMIT %i, %i';
959
-    $params = ['u.id = json_extract(p.arguments, "$[0]")',$sWhere, $orderColumn, $orderDirection, $sLimitStart, $sLimitLength];
959
+    $params = ['u.id = json_extract(p.arguments, "$[0]")', $sWhere, $orderColumn, $orderDirection, $sLimitStart, $sLimitLength];
960 960
 
961 961
     // Get the records
962 962
     $rows = DB::query($sql, ...$params);
@@ -964,7 +964,7 @@  discard block
 block discarded – undo
964 964
 
965 965
     // Output
966 966
     $sOutput = '{';
967
-    $sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
967
+    $sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
968 968
     $sOutput .= '"iTotalRecords": '.$iTotal.', ';
969 969
     $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
970 970
     $sOutput .= '"aaData": ';
@@ -980,13 +980,12 @@  discard block
 block discarded – undo
980 980
         //col1
981 981
         $sOutput .= '"'.(is_null($record['error_message']) ? '' : addslashes($record['error_message'])).'", ';
982 982
         //col2
983
-        $sOutput .= '"'.date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['created_at']).'", ';
983
+        $sOutput .= '"'.date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $record['created_at']).'", ';
984 984
         //col3
985 985
         $sOutput .= is_null($record['started_at']) === false ?
986
-            ('"'.date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['started_at']).'", ') :
987
-                ('"'.date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['created_at']).'", ');
986
+            ('"'.date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $record['started_at']).'", ') : ('"'.date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $record['created_at']).'", ');
988 987
         //col4
989
-        $sOutput .= '"'.date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['finished_at']).'", '; 
988
+        $sOutput .= '"'.date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $record['finished_at']).'", '; 
990 989
         // col7
991 990
         $sOutput .= '"'.gmdate('H:i:s', (int) $record['finished_at'] - (is_null($record['started_at']) === false ? (int) $record['started_at'] : (int) $record['created_at'])).'",';
992 991
         //col5
@@ -1009,11 +1008,10 @@  discard block
 block discarded – undo
1009 1008
         // col6
1010 1009
         $arguments = json_decode($record['arguments'], true);
1011 1010
         $newUserId = array_key_exists('new_user_id', $arguments) ? 
1012
-            $arguments['new_user_id'] : 
1013
-            (array_key_exists('user_id', $arguments) ? $arguments['user_id'] : null);
1011
+            $arguments['new_user_id'] : (array_key_exists('user_id', $arguments) ? $arguments['user_id'] : null);
1014 1012
         if ($record['process_type'] === 'create_user_keys' && is_null($newUserId) === false && empty($newUserId) === false) {
1015 1013
             $data_user = DB::queryFirstRow(
1016
-                'SELECT name, lastname, login FROM ' . prefixTable('users') . '
1014
+                'SELECT name, lastname, login FROM '.prefixTable('users').'
1017 1015
                 WHERE id = %i',
1018 1016
                 $newUserId
1019 1017
             );
@@ -1029,7 +1027,7 @@  discard block
 block discarded – undo
1029 1027
         } elseif ($record['process_type'] === 'user_build_cache_tree') {
1030 1028
             $user = json_decode($record['arguments'], true)['user_id'];
1031 1029
             $data_user = DB::queryFirstRow(
1032
-                'SELECT name, lastname, login FROM ' . prefixTable('users') . '
1030
+                'SELECT name, lastname, login FROM '.prefixTable('users').'
1033 1031
                 WHERE id = %i',
1034 1032
                 $user
1035 1033
             );
@@ -1063,7 +1061,7 @@  discard block
 block discarded – undo
1063 1061
 {
1064 1062
     $subtasks = DB::query(
1065 1063
         'SELECT *
1066
-        FROM ' . prefixTable('background_subtasks') . '
1064
+        FROM ' . prefixTable('background_subtasks').'
1067 1065
         WHERE task_id = %i',
1068 1066
         $id
1069 1067
     );
@@ -1079,5 +1077,5 @@  discard block
 block discarded – undo
1079 1077
         $i++;
1080 1078
     }
1081 1079
 
1082
-    return ($finished_nb !== 0 ? pourcentage($finished_nb, $nb, 100) : 0) .'%';
1080
+    return ($finished_nb !== 0 ? pourcentage($finished_nb, $nb, 100) : 0).'%';
1083 1081
 }
1084 1082
\ No newline at end of file
Please login to merge, or discard this patch.