Passed
Pull Request — master (#4672)
by
unknown
07:58
created
sources/folders.class.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@
 block discarded – undo
113 113
     private function isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin, $user_can_create_root_folder)
114 114
     {
115 115
         if ($parent_id == 0 && $user_can_create_root_folder == true)
116
-	    return true;
116
+        return true;
117 117
 
118 118
         if (in_array($parent_id, $user_accessible_folders) === false
119 119
             && (int) $user_is_admin !== 1
Please login to merge, or discard this patch.
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -112,8 +112,9 @@  discard block
 block discarded – undo
112 112
      */
113 113
     private function isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin, $user_can_create_root_folder)
114 114
     {
115
-        if ($parent_id == 0 && $user_can_create_root_folder == true)
116
-	    return true;
115
+        if ($parent_id == 0 && $user_can_create_root_folder == true) {
116
+        	    return true;
117
+        }
117 118
 
118 119
         if (in_array($parent_id, $user_accessible_folders) === false
119 120
             && (int) $user_is_admin !== 1
@@ -438,8 +439,9 @@  discard block
 block discarded – undo
438 439
             )['count'];
439 440
 
440 441
             // Don't insert duplicates
441
-            if ($count > 0)
442
-                continue;
442
+            if ($count > 0) {
443
+                            continue;
444
+            }
443 445
 
444 446
             // Insert new background task
445 447
             DB::insert(
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
         $parentComplexity = $this->checkComplexityLevel($parentFolderData, $complexity, $parent_id);
87 87
         if (isset($parentComplexity ['error']) && $parentComplexity['error'] === true) {
88
-            return $this->errorResponse($this->lang->get('error_folder_complexity_lower_than_top_folder') . " [<b>{$this->settings['TP_PW_COMPLEXITY'][$parentComplexity['valeur']][1]}</b>]");
88
+            return $this->errorResponse($this->lang->get('error_folder_complexity_lower_than_top_folder')." [<b>{$this->settings['TP_PW_COMPLEXITY'][$parentComplexity['valeur']][1]}</b>]");
89 89
         }
90 90
 
91 91
         return $this->createFolder($params, array_merge($parentFolderData, $parentComplexity), $options);
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
         ) {
139 139
             DB::query(
140 140
                 'SELECT *
141
-                FROM ' . prefixTable('nested_tree') . '
141
+                FROM ' . prefixTable('nested_tree').'
142 142
                 WHERE title = %s AND personal_folder = 0',
143 143
                 $title
144 144
             );
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
         //check if parent folder is personal
163 163
         $data = DB::queryfirstrow(
164 164
             'SELECT personal_folder, bloquer_creation, bloquer_modification
165
-            FROM ' . prefixTable('nested_tree') . '
165
+            FROM ' . prefixTable('nested_tree').'
166 166
             WHERE id = %i',
167 167
             $parent_id
168 168
         );
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
             // get complexity level for this folder
202 202
             $data = DB::queryfirstrow(
203 203
                 'SELECT valeur
204
-                FROM ' . prefixTable('misc') . '
204
+                FROM ' . prefixTable('misc').'
205 205
                 WHERE intitule = %i AND type = %s',
206 206
                 $parent_id,
207 207
                 'complex'
@@ -262,11 +262,11 @@  discard block
 block discarded – undo
262 262
      */
263 263
     private function canCreateFolder($isPersonal, $user_is_admin, $user_is_manager, $user_can_manage_all_users, $user_can_create_root_folder)
264 264
     {
265
-        return (int)$isPersonal === 1 ||
266
-            (int)$user_is_admin === 1 ||
267
-            ((int)$user_is_manager === 1 || (int)$user_can_manage_all_users === 1) ||
265
+        return (int) $isPersonal === 1 ||
266
+            (int) $user_is_admin === 1 ||
267
+            ((int) $user_is_manager === 1 || (int) $user_can_manage_all_users === 1) ||
268 268
             ($this->settings['enable_user_can_create_folders'] ?? false) ||
269
-            ((int)$user_can_create_root_folder === 1);
269
+            ((int) $user_can_create_root_folder === 1);
270 270
     }
271 271
 
272 272
     /**
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
         $path = '';
347 347
         $tree_path = $tree->getPath(0, false);
348 348
         foreach ($tree_path as $fld) {
349
-            $path .= empty($path) ? $fld->title : '/' . $fld->title;
349
+            $path .= empty($path) ? $fld->title : '/'.$fld->title;
350 350
         }
351 351
 
352 352
         $new_json = [
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
             "is_visible_active" => 0,
361 361
         ];
362 362
 
363
-        $cache_tree = DB::queryFirstRow('SELECT increment_id, folders, visible_folders FROM ' . prefixTable('cache_tree') . ' WHERE user_id = %i', (int)$user_id);
363
+        $cache_tree = DB::queryFirstRow('SELECT increment_id, folders, visible_folders FROM '.prefixTable('cache_tree').' WHERE user_id = %i', (int) $user_id);
364 364
 
365 365
         if (empty($cache_tree)) {
366 366
             DB::insert(prefixTable('cache_tree'), [
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
                 'folders' => json_encode($folders),
381 381
                 'visible_folders' => json_encode($visible_folders),
382 382
                 'timestamp' => time(),
383
-            ], 'increment_id = %i', (int)$cache_tree['increment_id']);
383
+            ], 'increment_id = %i', (int) $cache_tree['increment_id']);
384 384
         }
385 385
     }
386 386
 
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
     private function manageFolderPermissions($parent_id, $newId, $user_roles, $access_rights, $user_is_admin)
391 391
     {
392 392
         if ($parent_id !== 0 && $this->settings['subfolder_rights_as_parent'] ?? false) {
393
-            $rows = DB::query('SELECT role_id, type FROM ' . prefixTable('roles_values') . ' WHERE folder_id = %i', $parent_id);
393
+            $rows = DB::query('SELECT role_id, type FROM '.prefixTable('roles_values').' WHERE folder_id = %i', $parent_id);
394 394
             foreach ($rows as $record) {
395 395
                 DB::insert(prefixTable('roles_values'), [
396 396
                     'role_id' => $record['role_id'],
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
                     'type' => $record['type'],
399 399
                 ]);
400 400
             }
401
-        } elseif ((int)$user_is_admin !== 1) {
401
+        } elseif ((int) $user_is_admin !== 1) {
402 402
             foreach (array_unique(explode(';', $user_roles)) as $role) {
403 403
                 if (!empty($role)) {
404 404
                     DB::insert(prefixTable('roles_values'), [
@@ -416,7 +416,7 @@  discard block
 block discarded – undo
416 416
      */
417 417
     private function copyCustomFieldsCategories($parent_id, $newId)
418 418
     {
419
-        $rows = DB::query('SELECT id_category FROM ' . prefixTable('categories_folders') . ' WHERE id_folder = %i', $parent_id);
419
+        $rows = DB::query('SELECT id_category FROM '.prefixTable('categories_folders').' WHERE id_folder = %i', $parent_id);
420 420
         foreach ($rows as $record) {
421 421
             DB::insert(prefixTable('categories_folders'), [
422 422
                 'id_category' => $record['id_category'],
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
             // Search for existing job
442 442
             $count = DB::queryFirstRow(
443 443
                 'SELECT COUNT(*) AS count
444
-                FROM ' . prefixTable('background_tasks') . '
444
+                FROM ' . prefixTable('background_tasks').'
445 445
                 WHERE is_in_progress = %i AND process_type = %s AND arguments = %s',
446 446
                 0,
447 447
                 'user_build_cache_tree',
@@ -475,7 +475,7 @@  discard block
 block discarded – undo
475 475
         return [
476 476
             'error' => true,
477 477
             'message' => $message,
478
-            'newId' => '' . $newIdSuffix,
478
+            'newId' => ''.$newIdSuffix,
479 479
         ];
480 480
     }
481 481
 }
Please login to merge, or discard this patch.
sources/import.queries.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 ) {
80 80
     // Not allowed page
81 81
     $session->set('system-error_code', ERR_NOT_ALLOWED);
82
-    include $SETTINGS['cpassman_dir'] . '/error.php';
82
+    include $SETTINGS['cpassman_dir'].'/error.php';
83 83
     exit;
84 84
 }
85 85
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
         );
168 168
 
169 169
         // Initialisation
170
-        $file = $SETTINGS['path_to_files_folder'] . '/' . $data['valeur'];
170
+        $file = $SETTINGS['path_to_files_folder'].'/'.$data['valeur'];
171 171
         $importation_possible = true;
172 172
         $valuesToImport = [];
173 173
         $items_number = 0;
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 
210 210
         // Observer pour récupérer les données et respecter l'ordre des colonnes
211 211
         $interpreter = new Interpreter();
212
-        $interpreter->addObserver(function (array $row) use (&$valuesToImport, $header) {
212
+        $interpreter->addObserver(function(array $row) use (&$valuesToImport, $header) {
213 213
             $rowData = array_combine($header, $row);
214 214
 
215 215
             if ($rowData !== false) {
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
             // Handle multiple lignes description
261 261
             if (strpos($comments, '<br>') !== false || strpos($label, '<br>') !== false) {
262 262
                 $continue_on_next_line = true;
263
-                $comment .= " " . $label;
263
+                $comment .= " ".$label;
264 264
             } else {
265 265
                 // Insert previous line if changing line
266 266
                 if (!empty($account)) {
@@ -324,10 +324,10 @@  discard block
 block discarded – undo
324 324
             $values = [];
325 325
         
326 326
             foreach ($batchInsert as $data) {
327
-                $values[] = "('" . implode("','", array_map('addslashes', $data)) . "')";
327
+                $values[] = "('".implode("','", array_map('addslashes', $data))."')";
328 328
             }
329 329
         
330
-            $sql = "INSERT INTO `$tableName` (`label`, `description`, `pwd`, `url`, `folder`, `login`, `operation_id`) VALUES " . implode(',', $values);
330
+            $sql = "INSERT INTO `$tableName` (`label`, `description`, `pwd`, `url`, `folder`, `login`, `operation_id`) VALUES ".implode(',', $values);
331 331
             
332 332
             DB::query($sql);
333 333
         }
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
             $parentId = $dataReceived['folderId']; // Strating with provided folder
411 411
 
412 412
             foreach ($parts as $part) {
413
-                $currentPath = trim($currentPath . "/" . $part, "/");
413
+                $currentPath = trim($currentPath."/".$part, "/");
414 414
                 $currentFolder = $part;
415 415
 
416 416
                 // Check if this folder has already been created
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
                         // Get ID of existing folder
472 472
                         $ret = DB::queryFirstRow(
473 473
                             'SELECT *
474
-                            FROM ' . prefixTable('nested_tree') . '
474
+                            FROM ' . prefixTable('nested_tree').'
475 475
                             WHERE title = %s',
476 476
                             $currentFolder
477 477
                         );
@@ -963,7 +963,7 @@  discard block
 block discarded – undo
963 963
         ];
964 964
         $startPathLevel = 1;
965 965
 
966
-        foreach($post_folders as $folder) {
966
+        foreach ($post_folders as $folder) {
967 967
             // get parent id
968 968
             $parentId = $arrFolders[$folder['parentFolderId']];
969 969
 
@@ -1034,7 +1034,7 @@  discard block
 block discarded – undo
1034 1034
         DB::startTransaction();
1035 1035
 
1036 1036
         // Import all items
1037
-        foreach($post_items as $item) {
1037
+        foreach ($post_items as $item) {
1038 1038
             // get info about this folder
1039 1039
             $destinationFolderMore = DB::queryFirstRow(
1040 1040
                 'SELECT title FROM '.prefixTable('nested_tree').' WHERE id = %i',
@@ -1276,7 +1276,7 @@  discard block
 block discarded – undo
1276 1276
     ];
1277 1277
 }
1278 1278
 
1279
-spl_autoload_register(function ($class) {
1279
+spl_autoload_register(function($class) {
1280 1280
     $prefix = 'League\\Csv\\';
1281 1281
     $base_dir = __DIR__.'/src/';
1282 1282
     $len = strlen($prefix);
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1364,4 +1364,4 @@
 block discarded – undo
1364 1364
     $string = str_replace("{%}", "?", $string);
1365 1365
     // Trim and return.
1366 1366
     return trim($string);
1367
-  }
1367
+    }
Please login to merge, or discard this patch.
pages/import.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
     || isset($SETTINGS['allow_import']) === false || (int) $SETTINGS['allow_import'] !== 1) {
72 72
     // Not allowed page
73 73
     $session->set('system-error_code', ERR_NOT_ALLOWED);
74
-    include $SETTINGS['cpassman_dir'] . '/error.php';
74
+    include $SETTINGS['cpassman_dir'].'/error.php';
75 75
     exit;
76 76
 }
77 77
 
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
                                         <?php
184 184
 $complexitySelect = '';
185 185
 foreach (TP_PW_COMPLEXITY as $level) {
186
-    $complexitySelect .= '<option value="' . $level[0] . '">' . $level[1] . '</option>';
186
+    $complexitySelect .= '<option value="'.$level[0].'">'.$level[1].'</option>';
187 187
 }
188 188
 echo $complexitySelect;
189 189
                                         ?>
Please login to merge, or discard this patch.
pages/import.js.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('import') === false) {
73 73
     // Not allowed page
74 74
     $session->set('system-error_code', ERR_NOT_ALLOWED);
75
-    include $SETTINGS['cpassman_dir'] . '/error.php';
75
+    include $SETTINGS['cpassman_dir'].'/error.php';
76 76
     exit;
77 77
 }
78 78
 ?>
@@ -1043,7 +1043,7 @@  discard block
 block discarded – undo
1043 1043
                                     // Isolate first item
1044 1044
                                     if (itemsList.length > 0) {
1045 1045
                                         $('#import-feedback-progress-text')
1046
-                                            .html('<i class="fa-solid fa-cog fa-spin ml-4 mr-2"></i><?php echo $lang->get('operation_progress');?> ('+((counter*100)/itemsNumber).toFixed(2)+'%) - <i id="item-title"></i>');
1046
+                                            .html('<i class="fa-solid fa-cog fa-spin ml-4 mr-2"></i><?php echo $lang->get('operation_progress'); ?> ('+((counter*100)/itemsNumber).toFixed(2)+'%) - <i id="item-title"></i>');
1047 1047
 
1048 1048
                                         // XSS Filtering :
1049 1049
                                         $('#import-feedback-progress-text').text(itemsList[0].Title);
Please login to merge, or discard this patch.
includes/language/english.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,8 +28,8 @@
 block discarded – undo
28 28
  * @see       https://www.teampass.net
29 29
  */
30 30
 
31
- // TO REMOVE
32
- // - selected_items_to_be_imported
31
+    // TO REMOVE
32
+    // - selected_items_to_be_imported
33 33
 
34 34
 return array(
35 35
     'import_csv_keys_generation_strategy' => 'Keys generation strategy',
Please login to merge, or discard this patch.