nilsteampassnet / TeamPass

index.php

Braces +6 added lines, -2 removed lines

@@ -81,8 +81,9 @@ 
 $session = SessionManager::getSession();
 
 // Random encryption key
-if ($session->get('key') === null)
+if ($session->get('key') === null) {
     $session->set('key', generateQuickPassword(30, false));
+}
 
 $request = SymfonyRequest::createFromGlobals();
 $configManager = new ConfigManager(__DIR__, $request->getRequestUri());
@@ -943,7 +944,10 @@ 
                                     <input type="password" class="form-control" id="dialog-ldap-user-build-keys-database-code">
                                     <br/>
                                 </div>
-                                <div class="input-group mb-3<?php if ($session_auth_type === 'oauth2') echo ' hidden'; ?>">
+                                <div class="input-group mb-3<?php if ($session_auth_type === 'oauth2') {
+    echo ' hidden';
+}
+?>">
                                     <div class="input-group-prepend">
                                         <span class="input-group-text"><?php echo $lang->get('provide_your_current_password'); ?></span>
                                     </div>

sources/backups.queries.php

Braces +3 added lines, -1 removed lines

@@ -301,7 +301,9 @@
                 break;
             }
             
-            if (WIP === true) error_log('DEBUG: Offset -> '.$post_offset.'/'.$post_totalSize.' | File -> '.$post_clearFilename.' | key -> '.$post_key);
+            if (WIP === true) {
+                error_log('DEBUG: Offset -> '.$post_offset.'/'.$post_totalSize.' | File -> '.$post_clearFilename.' | key -> '.$post_key);
+            }
 
             include_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
 

sources/items.queries.php

Braces +21 added lines, -8 removed lines

@@ -1223,7 +1223,9 @@ 
                 );
 
                 // Create a task to create sharekeys for users
-                if (WIP=== true) error_log('createTaskForItem - new password for this item - '.$post_password ." -- ". $pw);
+                if (WIP=== true) {
+                    error_log('createTaskForItem - new password for this item - '.$post_password ." -- ". $pw);
+                }
                 $tasksToBePerformed = ['item_password'];
                 $encryptionTaskIsRequested = true;
             } else {
@@ -1539,7 +1541,9 @@ 
 
             // create a task for all fields updated
             if ($encryptionTaskIsRequested === true) {
-                if (WIP === true) error_log('createTaskForItem - '.print_r($tasksToBePerformed, true));
+                if (WIP === true) {
+                    error_log('createTaskForItem - '.print_r($tasksToBePerformed, true));
+                }
                 createTaskForItem(
                     'item_update_create_keys',
                     $tasksToBePerformed,
@@ -2046,7 +2050,9 @@ 
                 $inputData['itemId']
             );
             foreach ($rows as $record) {
-                if ($record['raison'] === NULL) continue;
+                if ($record['raison'] === NULL) {
+                    continue;
+                }
                 $reason = explode(':', $record['raison']);
                 if (count($reason) > 0) {
                     $sentence = date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['date']) . ' - '
@@ -4559,7 +4565,9 @@ 
                 $inputData['itemId']
             );
             
-            if (WIP === true) error_log('Existing edition locks: '.DB::count());
+            if (WIP === true) {
+                error_log('Existing edition locks: '.DB::count());
+            }
 
             // Check if item has no edition lock
             if ((int) DB::count() > 0 ) {
@@ -4572,7 +4580,9 @@ 
                 } else {
                     $delay = EDITION_LOCK_PERIOD; // One day delay
                 }
-                if (WIP === true) error_log('delay: ' . $delay);
+                if (WIP === true) {
+                    error_log('delay: ' . $delay);
+                }
 
                 // We remove old edition locks if delay is expired meaning more than 1 day long
                 if (round(abs(time() - $dataTmp['timestamp']),0) > $delay) {
@@ -4580,7 +4590,9 @@ 
                     // In this case, delete edition lock and possible ongoing processes
                     // and continue editing this time
                     // We coonsidere if the most recent item is still locked then all other locks can be removed
-                    if (WIP === true)  error_log('Delay is expired, removing old locks');
+                    if (WIP === true) {
+                        error_log('Delay is expired, removing old locks');
+                    }
                     foreach ($dataItemEditionLocks as $itemEditionLock) {
                         // delete lock
                         DB::delete(
@@ -4847,8 +4859,9 @@ 
                 $ids = $tree->getDescendants($folder['id'], true, false, true);
 
                 // This folder is owned by user
-                if (in_array($inputData['folderId'], $ids))
-                    $accessLevel = 30;
+                if (in_array($inputData['folderId'], $ids)) {
+                                    $accessLevel = 30;
+                }
             }
         }
 

sources/identify.php

Braces +9 added lines, -4 removed lines

@@ -2401,7 +2401,9 @@ 
         // Complete $userInfo
         $userInfo['has_been_created'] = 1;
 
-        if (WIP === true) error_log("--- USER CREATED ---");
+        if (WIP === true) {
+            error_log("--- USER CREATED ---");
+        }
 
         return [
             'error' => false,
@@ -2437,7 +2439,9 @@ 
         }
 
         // Oauth2 user already exists and authenticated
-        if (WIP === true) error_log("--- USER AUTHENTICATED ---");
+        if (WIP === true) {
+            error_log("--- USER AUTHENTICATED ---");
+        }
         $userInfo['has_been_created'] = 0;
 
         $passwordManager = new PasswordManager();
@@ -2667,8 +2671,9 @@ 
         );
 
         // No valid email address for user
-        if (!$userInfos || !filter_var($userInfos['email'], FILTER_VALIDATE_EMAIL))
-            return;
+        if (!$userInfos || !filter_var($userInfos['email'], FILTER_VALIDATE_EMAIL)) {
+                    return;
+        }
 
         $unlock_url = $SETTINGS['cpassman_url'].'/self-unlock.php?login='.$value.'&otp='.$unlock_code;
 

scripts/background_tasks___items_handler.php

Braces +15 added lines, -6 removed lines

@@ -83,7 +83,9 @@ 
 
 if (DB::count() > 0) {
     // handle tasks inside this process
-    if (WIP === true) error_log("Process in progress: ".$process_to_perform['increment_id']);
+    if (WIP === true) {
+        error_log("Process in progress: ".$process_to_perform['increment_id']);
+    }
     handleTask(
         $process_to_perform['increment_id'],
         json_decode($process_to_perform['arguments'], true),
@@ -100,7 +102,9 @@ 
     );
     
     if (DB::count() > 0) {
-        if (WIP === true) error_log("New process ta start: ".$process_to_perform['increment_id']);
+        if (WIP === true) {
+            error_log("New process ta start: ".$process_to_perform['increment_id']);
+        }
         // update DB - started_at
         DB::update(
             prefixTable('background_tasks'),
@@ -153,8 +157,9 @@ 
         );
 
         // No more tasks, exit
-        if ($process_to_perform !== 1)
-            break;
+        if ($process_to_perform !== 1) {
+                    break;
+        }
 
         // Run next task
         $process = new Symfony\Component\Process\Process([
@@ -331,7 +336,9 @@ 
     if ($args['step'] === 'create_users_files_key') {
         // Loop on all files for this item
         // and encrypt them for each user
-        if (WIP === true) provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+        if (WIP === true) {
+            provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+        }
         foreach($args['files_keys'] as $file) {
             storeUsersShareKey(
                 prefixTable('sharekeys_items'),
@@ -347,7 +354,9 @@ 
     } elseif ($args['step'] === 'create_users_fields_key') {
         // Loop on all encrypted fields for this item
         // and encrypt them for each user
-        if (WIP === true) provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+        if (WIP === true) {
+            provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+        }
         foreach($args['fields_keys'] as $field) {
             storeUsersShareKey(
                 prefixTable('sharekeys_fields'),

sources/main.functions.php

Braces +24 added lines, -11 removed lines

@@ -2366,7 +2366,9 @@ 
 function encryptUserObjectKey(string $key, string $publicKey): string
 {
     // Empty password
-    if (empty($key)) return '';
+    if (empty($key)) {
+        return '';
+    }
 
     // Sanitize
     $antiXss = new AntiXSS();
@@ -2515,7 +2517,9 @@ 
         ];
     }
 
-    if (WIP) error_log('DEBUG: File image url -> '.filter_var($safeFilePath, FILTER_SANITIZE_URL));
+    if (WIP) {
+        error_log('DEBUG: File image url -> '.filter_var($safeFilePath, FILTER_SANITIZE_URL));
+    }
 
     // Decrypt file content and return
     return base64_encode($cipher->decrypt($ciphertext));
@@ -2650,7 +2654,9 @@ 
         foreach ($users as $user) {
             // Insert in DB the new object key for this item by user
             if (count($objectKeyArray) === 0) {
-                if (WIP === true) error_log('TEAMPASS Debug - storeUsersShareKey case1 - ' . $object_name . ' - ' . $post_object_id . ' - ' . $user['id'] . ' - ' . $objectKey);
+                if (WIP === true) {
+                    error_log('TEAMPASS Debug - storeUsersShareKey case1 - ' . $object_name . ' - ' . $post_object_id . ' - ' . $user['id'] . ' - ' . $objectKey);
+                }
                 DB::insert(
                     $object_name,
                     [
@@ -2664,7 +2670,9 @@ 
                 );
             } else {
                 foreach ($objectKeyArray as $object) {
-                    if (WIP === true) error_log('TEAMPASS Debug - storeUsersShareKey case2 - ' . $object_name . ' - ' . $object['objectId'] . ' - ' . $user['id'] . ' - ' . $object['objectKey']);
+                    if (WIP === true) {
+                        error_log('TEAMPASS Debug - storeUsersShareKey case2 - ' . $object_name . ' - ' . $object['objectId'] . ' - ' . $user['id'] . ' - ' . $object['objectKey']);
+                    }
                     DB::insert(
                         $object_name,
                         [
@@ -3990,7 +3998,9 @@ 
         $taskName = [$taskName];
     }
     foreach($taskName as $task) {
-        if (WIP === true) error_log('createTaskForItem - task: '.$task);
+        if (WIP === true) {
+            error_log('createTaskForItem - task: '.$task);
+        }
         switch ($task) {
             case 'item_password':
                 
@@ -4421,19 +4431,22 @@ 
 
             // Organisation name (removed username@ and .tld)
             $domain = explode('.', $emailParts[1]);
-            if (count($domain) > 1)
-                $forbiddenWords[] = $domain[0];
+            if (count($domain) > 1) {
+                            $forbiddenWords[] = $domain[0];
+            }
         }
     }
 
     // Search forbidden words in password
     foreach ($forbiddenWords as $word) {
-        if (empty($word))
-            continue;
+        if (empty($word)) {
+                    continue;
+        }
 
         // Stop if forbidden word found in password
-        if (stripos($password, $word) !== false)
-            return false;
+        if (stripos($password, $word) !== false) {
+                    return false;
+        }
     }
 
     // Get password complexity