Inspection of "3.0.0.8" - nilsteampassnet/TeamPass - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — teampass_3.0 ( 5f487b...4dfe05 )

by Nils

created 2021-04-19 17:08 UTC

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,15 +36,15 @@
 block discarded – undo
 }
 
 /* do checks */
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
 if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'backups', $SETTINGS) === false) {
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit();
 }
 
 // Load template
-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
 
 // Decrypt key
 $localEncryptionKey = isset($SETTINGS['bck_script_passkey']) === true ?

Please login to merge, or discard this patch.

pages/statistics.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,10 +36,10 @@  discard block
 block discarded – undo
 }
 
 /* do checks */
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
 if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'statistics', $SETTINGS) === false) {
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit();
 }
 
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
     $statistics_items = array_filter(explode(';', $SETTINGS['send_statistics_items']));
 }
 
-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
 
 ?>
 

Please login to merge, or discard this patch.

pages/export.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,15 +36,15 @@
 block discarded – undo
 }
 
 /* do checks */
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
 if (checkUser($_SESSION['user_id'], $_SESSION['key'], curPage($SETTINGS), $SETTINGS) === false) {
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED; //not allowed page
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit();
 }
 
 // Load
-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
 
 ?>
 

Please login to merge, or discard this patch.

pages/utilities.database.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,15 +36,15 @@
 block discarded – undo
 }
 
 /* do checks */
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
 if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'utilities.database', $SETTINGS) === false) {
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit();
 }
 
 // Load template
-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
 
 ?>
 <!-- Content Header (Page header) -->

Please login to merge, or discard this patch.

pages/fields.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -36,15 +36,15 @@  discard block
 block discarded – undo
 }
 
 /* do checks */
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
 if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'fields', $SETTINGS) === false) {
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit();
 }
 
 // Load template
-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
 
 //Build tree
 $tree = new SplClassLoader('Tree\NestedTree', './includes/libraries');
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
                                         $folders = $tree->getDescendants();
                                         foreach ($folders as $folder) {
                                             DB::query(
-                                                'SELECT * FROM ' . prefixTable('nested_tree') . '
+                                                'SELECT * FROM '.prefixTable('nested_tree').'
                                         WHERE personal_folder = %i AND id = %i',
                                                 '0',
                                                 $folder->id
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
                                                     $ident .= '-';
                                                 }
                                                 echo '
-                                        <option value="' . $folder->id . '">' . $ident . '&nbsp;' . str_replace('&', '&amp;', $folder->title) . '</option>';
+                                        <option value="' . $folder->id.'">'.$ident.'&nbsp;'.str_replace('&', '&amp;', $folder->title).'</option>';
                                             }
                                         }
                                         ?>
@@ -190,9 +190,9 @@  discard block
 block discarded – undo
                                     <select class="form-control form-item-control select2" style="width:100%;" id="form-field-type">
                                         <?php
                                         // Build list of Types
-                                        echo '<option value="">-- ' . langHdl('select') . ' --</option>' .
-                                            '<option value="text">' . langHdl('text') . '</option>' .
-                                            '<option value="textarea">' . langHdl('textarea') . '</option>';
+                                        echo '<option value="">-- '.langHdl('select').' --</option>'.
+                                            '<option value="text">'.langHdl('text').'</option>'.
+                                            '<option value="textarea">'.langHdl('textarea').'</option>';
                                         ?>
                                     </select>
                                 </div>
@@ -220,14 +220,14 @@  discard block
 block discarded – undo
                                     <select class="form-control form-item-control select2" multiple="multiple" style="width:100%;" id="form-field-roles">
                                         <?php
                                         // Build list of Roles
-                                        echo '<option value="all">' . langHdl('every_roles') . '</option>';
+                                        echo '<option value="all">'.langHdl('every_roles').'</option>';
                                         $rows = DB::query(
                                             'SELECT id, title
-                                    FROM ' . prefixTable('roles_title') . '
+                                    FROM ' . prefixTable('roles_title').'
                                     ORDER BY title ASC'
                                         );
                                         foreach ($rows as $record) {
-                                            echo '<option value="' . $record['id'] . '">' . addslashes($record['title']) . '</option>';
+                                            echo '<option value="'.$record['id'].'">'.addslashes($record['title']).'</option>';
                                         }
                                         ?>
                                     </select>

Please login to merge, or discard this patch.

pages/suggestion.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -32,15 +32,15 @@
 block discarded – undo
 }
 
 /* do checks */
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
 if (!checkUser($_SESSION['user_id'], $_SESSION['key'], curPage($SETTINGS), $SETTINGS)) {
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED; //not allowed page
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit();
 }
 
 // Load
-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
 
 ?>
 

Please login to merge, or discard this patch.

pages/utilities.renewal.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,15 +36,15 @@
 block discarded – undo
 }
 
 /* do checks */
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
 if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'utilities.renewal', $SETTINGS) === false) {
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit();
 }
 
 // Load template
-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
 
 ?>
 

Please login to merge, or discard this patch.

pages/import.js.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -35,10 +35,10 @@
 block discarded – undo
 }
 
 /* do checks */
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
 if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'profile', $SETTINGS) === false) {
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED; //not allowed page
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit();
 }
 ?>

Please login to merge, or discard this patch.

pages/special.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -19,28 +19,28 @@
 block discarded – undo
 
 
 if (
-  isset($_SESSION['CPM']) === false || $_SESSION['CPM'] !== 1
+    isset($_SESSION['CPM']) === false || $_SESSION['CPM'] !== 1
   || isset($_SESSION['user_id']) === false || empty($_SESSION['user_id']) === true
   || isset($_SESSION['key']) === false || empty($_SESSION['key']) === true
 ) {
-  die('Hacking attempt...');
+    die('Hacking attempt...');
 }
 
 // Load config
 if (file_exists('../includes/config/tp.config.php') === true) {
-  include_once '../includes/config/tp.config.php';
+    include_once '../includes/config/tp.config.php';
 } elseif (file_exists('./includes/config/tp.config.php') === true) {
-  include_once './includes/config/tp.config.php';
+    include_once './includes/config/tp.config.php';
 } else {
-  throw new Exception("Error file '/includes/config/tp.config.php' not exists", 1);
+    throw new Exception("Error file '/includes/config/tp.config.php' not exists", 1);
 }
 
 /* do checks */
 require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
 if (checkUser($_SESSION['user_id'], $_SESSION['key'], "special", $SETTINGS) === false) {
-  $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
-  include $SETTINGS['cpassman_dir'] . '/error.php';
-  exit();
+    $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
+    include $SETTINGS['cpassman_dir'] . '/error.php';
+    exit();
 }
 
 // Load template

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,15 +36,15 @@
 block discarded – undo
 }
 
 /* do checks */
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
 if (checkUser($_SESSION['user_id'], $_SESSION['key'], "special", $SETTINGS) === false) {
   $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
-  include $SETTINGS['cpassman_dir'] . '/error.php';
+  include $SETTINGS['cpassman_dir'].'/error.php';
   exit();
 }
 
 // Load template
-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
 
 ?>
 

Please login to merge, or discard this patch.

		@@ -36,10 +36,10 @@ discard block
		block discarded – undo
36	36	}
37	37
38	38	/* do checks */
39		-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
	39	+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
40	40	if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'statistics', $SETTINGS) === false) {
41	41	$_SESSION['error']['code'] = ERR_NOT_ALLOWED;
42		- include $SETTINGS['cpassman_dir'] . '/error.php';
	42	+ include $SETTINGS['cpassman_dir'].'/error.php';
43	43	exit();
44	44	}
45	45
		@@ -49,7 +49,7 @@ discard block
		block discarded – undo
49	49	$statistics_items = array_filter(explode(';', $SETTINGS['send_statistics_items']));
50	50	}
51	51
52		-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
	52	+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
53	53
54	54	?>
55	55

		@@ -36,15 +36,15 @@ discard block
		block discarded – undo
36	36	}
37	37
38	38	/* do checks */
39		-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
	39	+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
40	40	if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'fields', $SETTINGS) === false) {
41	41	$_SESSION['error']['code'] = ERR_NOT_ALLOWED;
42		- include $SETTINGS['cpassman_dir'] . '/error.php';
	42	+ include $SETTINGS['cpassman_dir'].'/error.php';
43	43	exit();
44	44	}
45	45
46	46	// Load template
47		-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
	47	+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
48	48
49	49	//Build tree
50	50	$tree = new SplClassLoader('Tree\NestedTree', './includes/libraries');
		@@ -147,7 +147,7 @@ discard block
		block discarded – undo
147	147	$folders = $tree->getDescendants();
148	148	foreach ($folders as $folder) {
149	149	DB::query(
150		- 'SELECT * FROM ' . prefixTable('nested_tree') . '
	150	+ 'SELECT * FROM '.prefixTable('nested_tree').'
151	151	WHERE personal_folder = %i AND id = %i',
152	152	'0',
153	153	$folder->id
		@@ -159,7 +159,7 @@ discard block
		block discarded – undo
159	159	$ident .= '-';
160	160	}
161	161	echo '
162		- <option value="' . $folder->id . '">' . $ident . ' ' . str_replace('&', '&', $folder->title) . '</option>';
	162	+ <option value="' . $folder->id.'">'.$ident.' '.str_replace('&', '&', $folder->title).'</option>';
163	163	}
164	164	}
165	165	?>
		@@ -190,9 +190,9 @@ discard block
		block discarded – undo
190	190	<select class="form-control form-item-control select2" style="width:100%;" id="form-field-type">
191	191	<?php
192	192	// Build list of Types
193		- echo '<option value="">-- ' . langHdl('select') . ' --</option>' .
194		- '<option value="text">' . langHdl('text') . '</option>' .
195		- '<option value="textarea">' . langHdl('textarea') . '</option>';
	193	+ echo '<option value="">-- '.langHdl('select').' --</option>'.
	194	+ '<option value="text">'.langHdl('text').'</option>'.
	195	+ '<option value="textarea">'.langHdl('textarea').'</option>';
196	196	?>
197	197	</select>
198	198	</div>
		@@ -220,14 +220,14 @@ discard block
		block discarded – undo
220	220	<select class="form-control form-item-control select2" multiple="multiple" style="width:100%;" id="form-field-roles">
221	221	<?php
222	222	// Build list of Roles
223		- echo '<option value="all">' . langHdl('every_roles') . '</option>';
	223	+ echo '<option value="all">'.langHdl('every_roles').'</option>';
224	224	$rows = DB::query(
225	225	'SELECT id, title
226		- FROM ' . prefixTable('roles_title') . '
	226	+ FROM ' . prefixTable('roles_title').'
227	227	ORDER BY title ASC'
228	228	);
229	229	foreach ($rows as $record) {
230		- echo '<option value="' . $record['id'] . '">' . addslashes($record['title']) . '</option>';
	230	+ echo '<option value="'.$record['id'].'">'.addslashes($record['title']).'</option>';
231	231	}
232	232	?>
233	233	</select>

		@@ -32,15 +32,15 @@
		block discarded – undo
32	32	}
33	33
34	34	/* do checks */
35		-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
	35	+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
36	36	if (!checkUser($_SESSION['user_id'], $_SESSION['key'], curPage($SETTINGS), $SETTINGS)) {
37	37	$_SESSION['error']['code'] = ERR_NOT_ALLOWED; //not allowed page
38		- include $SETTINGS['cpassman_dir'] . '/error.php';
	38	+ include $SETTINGS['cpassman_dir'].'/error.php';
39	39	exit();
40	40	}
41	41
42	42	// Load
43		-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
	43	+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
44	44
45	45	?>
46	46

		@@ -35,10 +35,10 @@
		block discarded – undo
35	35	}
36	36
37	37	/* do checks */
38		-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
	38	+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
39	39	if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'profile', $SETTINGS) === false) {
40	40	$_SESSION['error']['code'] = ERR_NOT_ALLOWED; //not allowed page
41		- include $SETTINGS['cpassman_dir'] . '/error.php';
	41	+ include $SETTINGS['cpassman_dir'].'/error.php';
42	42	exit();
43	43	}
44	44	?>

		@@ -36,15 +36,15 @@
		block discarded – undo
36	36	}
37	37
38	38	/* do checks */
39		-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
	39	+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
40	40	if (checkUser($_SESSION['user_id'], $_SESSION['key'], 'backups', $SETTINGS) === false) {
41	41	$_SESSION['error']['code'] = ERR_NOT_ALLOWED;
42		- include $SETTINGS['cpassman_dir'] . '/error.php';
	42	+ include $SETTINGS['cpassman_dir'].'/error.php';
43	43	exit();
44	44	}
45	45
46	46	// Load template
47		-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
	47	+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
48	48
49	49	// Decrypt key
50	50	$localEncryptionKey = isset($SETTINGS['bck_script_passkey']) === true ?

		@@ -19,28 +19,28 @@
		block discarded – undo
19	19
20	20
21	21	if (
22		- isset($_SESSION['CPM']) === false \|\| $_SESSION['CPM'] !== 1
	22	+ isset($_SESSION['CPM']) === false \|\| $_SESSION['CPM'] !== 1
23	23	\|\| isset($_SESSION['user_id']) === false \|\| empty($_SESSION['user_id']) === true
24	24	\|\| isset($_SESSION['key']) === false \|\| empty($_SESSION['key']) === true
25	25	) {
26		- die('Hacking attempt...');
	26	+ die('Hacking attempt...');
27	27	}
28	28
29	29	// Load config
30	30	if (file_exists('../includes/config/tp.config.php') === true) {
31		- include_once '../includes/config/tp.config.php';
	31	+ include_once '../includes/config/tp.config.php';
32	32	} elseif (file_exists('./includes/config/tp.config.php') === true) {
33		- include_once './includes/config/tp.config.php';
	33	+ include_once './includes/config/tp.config.php';
34	34	} else {
35		- throw new Exception("Error file '/includes/config/tp.config.php' not exists", 1);
	35	+ throw new Exception("Error file '/includes/config/tp.config.php' not exists", 1);
36	36	}
37	37
38	38	/* do checks */
39	39	require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
40	40	if (checkUser($_SESSION['user_id'], $_SESSION['key'], "special", $SETTINGS) === false) {
41		- $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
42		- include $SETTINGS['cpassman_dir'] . '/error.php';
43		- exit();
	41	+ $_SESSION['error']['code'] = ERR_NOT_ALLOWED;
	42	+ include $SETTINGS['cpassman_dir'] . '/error.php';
	43	+ exit();
44	44	}
45	45
46	46	// Load template

nilsteampassnet / TeamPass

Push — teampass_3.0 ( 5f487b...4dfe05 )

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch