UserValidator

Complexity

Total Complexity

12

Size/Duplication

Total Lines	127
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	validate()	0	9	1
A	getErrors()	0	4	1
A	validateGender()	0	13	2
A	validateEmail()	0	12	2
A	validatePassword()	0	13	2
A	validateUsername()	0	13	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 6 and the first side effect is on line 4.

use NilPortugues\Validator\Validator;

include realpath(dirname(__FILE__)).'/../vendor/autoload.php';

class Request

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var string
     */
    public $username;

    /**
     * @var string
     */
    public $password;

    /**
     * @var string
     */
    public $email;

    /**
     * @var int
     */
    public $gender;

    /**
     * @param string $username
     * @param string $password
     * @param string $email
     * @param string $gender
     */
    public function __construct($username, $password, $email, $gender)
    {
        settype($username, 'string');
        settype($password, 'string');
        settype($email, 'string');
        settype($gender, 'int');

        $this->username = $username;
        $this->password = $password;
        $this->email    = $email;
        $this->gender   = $gender;
    }
}

class UserValidator

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var NilPortugues\Validator\Validator
     */
    private static $validator;

    /**
     * @var array
     */
    private $errors = [];

    /**
     * @var bool
     */
    private $isValid = true;

    /**
     * 
     */
    public function __construct()
    {
        if(!isset(self::$validator)) {
            self::$validator = Validator::create();
        }
    }

    /**
     * @param Request $request
     *
     * @return bool
     */
    public function validate(Request $request)
    {
        $this->validateUsername($request);
        $this->validatePassword($request);
        $this->validateEmail($request);
        $this->validateGender($request);

        return $this->isValid;
    }

    /**
     * @return array
     */
    public function getErrors()
    {
        return $this->errors;
    }

    /**
     * @param Request $request
     *
     * @return boolean|null
     */
    private function validateGender(Request $request)
    {
        $gender = self::$validator->isInteger('gender');

        $result = $gender
            ->isRequired()
            ->isPositive()
            ->isBetween(0, 2, true)
            ->validate($request->gender);

        $this->isValid = $this->isValid && $result;
        $this->errors  = array_merge($this->errors, $gender->getErrors());
    }

    /**
     * @param Request $request
     *
     * @return boolean|null
     */
    private function validateEmail(Request $request)
    {
        $email = self::$validator->isString('email');

        $result = $email
            ->isRequired()
            ->isEmail()
            ->validate($request->email);

        $this->isValid = $this->isValid && $result;
        $this->errors  = array_merge($this->errors, $email->getErrors());
    }

    /**
     * @param Request $request
     *
     * @return boolean|null
     */
    private function validatePassword(Request $request)
    {
        $password = self::$validator->isString('password');

        $result = $password
            ->isRequired()
            ->isBetween(5, 72, true)
            ->isAlphanumeric()
            ->validate($request->password);

        $this->isValid = $this->isValid && $result;
        $this->errors  = array_merge($this->errors, $password->getErrors());
    }

    /**
     * Validates is a username has alphanumeric values and is between 3 to 12 characters long.
     *
     * @param Request $request
     *
     * @return boolean|null
     */
    private function validateUsername(Request $request)
    {
        $username = self::$validator->isString('username');

        $result = $username
            ->isRequired()
            ->isAlpha()
            ->isBetween(4, 12, true)
            ->validate($request->username);

        $this->isValid = $this->isValid && $result;
        $this->errors  = array_merge($this->errors, $username->getErrors());
    }
}



$userValidator = new UserValidator();

$request1 = new Request('nilportugues', 'password', 'hello@world.com', '1');
$request2 = new Request('nil', 'password', 'not-an-email.com', '');

var_dump($userValidator->validate($request1)); //true

var_dump($userValidator->validate($request1)); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

print_r($userValidator->getErrors()); //no errors

var_dump($userValidator->validate($request2)); //false
print_r($userValidator->getErrors()); //array with errors