NilPortugues\Serializer\Drivers\Eloquent\Driver

Complexity

Total Complexity

12

Size/Duplication

Total Lines	100
Duplicated Lines	18 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	serialize()	0	6	1
A	serializeObject()	0	16	4
A	serializeEloquentCollection()	9	9	2
A	serializeEloquentPaginatedResource()	9	9	2
A	serializeEloquentModel()	0	19	2

<?php

namespace NilPortugues\Serializer\Drivers\Eloquent;

use Illuminate\Contracts\Pagination\Paginator;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;
use NilPortugues\Serializer\Drivers\Eloquent\Helper\RelationshipPropertyExtractor;
use NilPortugues\Serializer\Serializer;
use ReflectionClass;

class Driver extends Serializer
{
    /**
     *
     */
    public function __construct()
    {
    }

    /**
     * @param mixed $value
     *
     * @return mixed|string
     */
    public function serialize($value)
    {
        $this->reset();

        return $this->serializeObject($value);

The return type of return $this->serializeObject($value); (array) is incompatible with the return type of the parent method NilPortugues\Serializer\Serializer::serialize of type string.

    }

    /**
     * Extract the data from an object.
     *
     * @param mixed $value
     *
     * @return array
     */
    protected function serializeObject($value)
    {
        if ($value instanceof Collection) {
            return $this->serializeEloquentCollection($value);
        }

        if ($value instanceof Paginator) {
            return $this->serializeEloquentPaginatedResource($value);
        }

        if (\is_subclass_of($value, Model::class, true)) {

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \Illuminate\Database\Eloquent\Model::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            return $this->serializeEloquentModel($value);
        }

        return parent::serializeObject($value);
    }

    /**
     * @param Collection $value
     *
     * @return array
     */
    protected function serializeEloquentCollection(Collection $value)

This method seems to be duplicated in your project.

    {
        $items = [];
        foreach ($value as $v) {
            $items[] = $this->serializeObject($v);
        }

        return [self::MAP_TYPE => 'array', self::SCALAR_VALUE => $items];
    }

    /**
     * @param Paginator $value
     *
     * @return array
     */
    protected function serializeEloquentPaginatedResource(Paginator $value)

This method seems to be duplicated in your project.

    {
        $items = [];
        foreach ($value->items() as $v) {
            $items[] = $this->serializeObject($v);
        }

        return [self::MAP_TYPE => 'array', self::SCALAR_VALUE => $items];
    }

    /**
     * @param Model $value
     *
     * @return array
     */
    protected function serializeEloquentModel(Model $value)
    {
        $stdClass = (object) $value->attributesToArray();
        $data = $this->serializeData($stdClass);
        $data[self::CLASS_IDENTIFIER_KEY] = get_class($value);

        $methods = RelationshipPropertyExtractor::getRelationshipAsPropertyName(
            $value,
            get_class($value),
            new ReflectionClass($value),
            $this
        );

        if (!empty($methods)) {
            $data = array_merge($data, $methods);
        }

        return $data;
    }
}