JsonApiControllerTest - Code Metrics - Inspection of "Got testing env working. Time to write tests" - nilportugues/laravel5-jsonapi-transformer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 106059...d7714e )

by Nil

created 2015-12-12 12:17 UTC

JsonApiControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	24.56 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	8
c	3
b	0
f	0
lcom	1
cbo	2
dl	14
loc	57
rs	10

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	serverEnvironment()	0	6	1
A	testListAction()	7	7	1
A	testGetAction()	7	7	1
A	testPostAction()	0	3	1
A	testPatchAction()	0	3	1
A	testPutAction()	0	3	1
A	testDeleteAction()	0	3	1

How to fix Duplicated Code

<?php
/**
 * Author: Nil Portugués Calderó <[email protected]>
 * Date: 12/9/15
 * Time: 3:05 PM.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace NilPortugues\Tests\Laravel5\JsonApi;

/**
 * Class JsonApiControllerTest.
 */
class JsonApiControllerTest extends LaravelTestCase
{
    /**
     * Setup DB before each test.
     */
    public function setUp()
    {
        parent::setUp();
    }

    /**
     * This is required for \Symfony\Bridge\PsrHttpMessage\Factory to work.
     * This comes as a trade-off of building the underlying package as framework-agnostic.
     *
     * @param string $method
     * @param string $server
     * @param string $uri
     */
    protected function serverEnvironment($method, $server, $uri)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = strtoupper($method);
        $_SERVER['SERVER_NAME'] = str_replace(['http://', 'https://'], '', $server);
        $_SERVER['REQUEST_URI'] = $uri;
    }

    public function testListAction()

    {
        $this->serverEnvironment('GET', 'example.com', '/api/v1/employees');
        $response = $this->call('GET', 'http://example.com/api/v1/employees');

        $this->assertEquals(200, $response->getStatusCode());
    }

    public function testGetAction()

    {
        $this->serverEnvironment('GET', 'example.com', '/api/v1/employees/1');
        $response = $this->call('GET', 'http://example.com/api/v1/employees/1');

        $this->assertEquals(200, $response->getStatusCode());
    }

    public function testPostAction()
    {
    }

    public function testPatchAction()
    {
    }

    public function testPutAction()
    {
    }

    public function testDeleteAction()
    {
    }
}


1		<?php
2		/**
3		* Author: Nil Portugués Calderó <[email protected]>
4		* Date: 12/9/15
5		* Time: 3:05 PM.
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace NilPortugues\Tests\Laravel5\JsonApi;
12
13		/**
14		* Class JsonApiControllerTest.
15		*/
16		class JsonApiControllerTest extends LaravelTestCase
17		{
18		/**
19		* Setup DB before each test.
20		*/
21		public function setUp()
22		{
23		parent::setUp();
24		}
25
26		/**
27		* This is required for \Symfony\Bridge\PsrHttpMessage\Factory to work.
28		* This comes as a trade-off of building the underlying package as framework-agnostic.
29		*
30		* @param string $method
31		* @param string $server
32		* @param string $uri
33		*/
34		protected function serverEnvironment($method, $server, $uri)
		0 ignored issues – show Coding Style introduced 2015-12-12 12:25 UTC by Report Bug Copy Issue Report `serverEnvironment` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
35		{
36		$_SERVER['REQUEST_METHOD'] = strtoupper($method);
37		$_SERVER['SERVER_NAME'] = str_replace(['http://', 'https://'], '', $server);
38		$_SERVER['REQUEST_URI'] = $uri;
39		}
40
41	View Code Duplication	public function testListAction()
		0 ignored issues – show Duplication introduced 2015-12-12 12:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		{
43		$this->serverEnvironment('GET', 'example.com', '/api/v1/employees');
44		$response = $this->call('GET', 'http://example.com/api/v1/employees');
45
46		$this->assertEquals(200, $response->getStatusCode());
47		}
48
49	View Code Duplication	public function testGetAction()
		0 ignored issues – show Duplication introduced 2015-12-12 12:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		{
51		$this->serverEnvironment('GET', 'example.com', '/api/v1/employees/1');
52		$response = $this->call('GET', 'http://example.com/api/v1/employees/1');
53
54		$this->assertEquals(200, $response->getStatusCode());
55		}
56
57		public function testPostAction()
58		{
59		}
60
61		public function testPatchAction()
62		{
63		}
64
65		public function testPutAction()
66		{
67		}
68
69		public function testDeleteAction()
70		{
71		}
72		}
73

nilportugues / laravel5-jsonapi-transformer

Push — master ( 106059...d7714e )

JsonApiControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like