Employees - Code Metrics - Inspection of "Missing routes to be read by LaravelTestCase and t..." - nilportugues/laravel5-jsonapi-transformer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1a65d7...018a8e )

by Nil

created 2015-12-11 18:25 UTC

Employees A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
c	1
b	0
f	0
lcom	0
cbo	1
dl	0
loc	61
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	latestOrders()	0	4	1
A	getFullNameAttribute()	0	4	1

<?php

namespace NilPortugues\Tests\App\Models;

use Illuminate\Database\Eloquent\Model;

class Employees extends Model
{
    /**
     * @var bool
     */
    public $timestamps = false;

    /**
     * @var string
     */
    protected $table = 'employees';

    /**
     * @var string
     */
    protected $primaryKey = 'id';

    /**
     * @var array
     */
    protected $appends = ['full_name'];

    /**
     * @var array
     */
    protected $fillable = [
        'company',
        'last_name',
        'first_name',
        'email_address',
        'job_title',
        'business_phone',
        'home_phone',
        'mobile_phone',
        'fax_number',
        'address',
        'city',
        'state_province',
        'zip_postal_code',
        'country_region',
        'web_page',
        'notes',
        'attachments',
    ];

    /**
     * @return \Illuminate\Database\Eloquent\Relations\HasOne
     */
    public function latestOrders()
    {
        return $this->hasMany(Orders::class, 'employee_id')->limit(10);
    }

    /**
     * @return string
     */
    public function getFullNameAttribute()
    {
        return $this->first_name.' '.$this->last_name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			namespace NilPortugues\Tests\App\Models;
4
5			use Illuminate\Database\Eloquent\Model;
6
7			class Employees extends Model
8			{
9			/**
10			* @var bool
11			*/
12			public $timestamps = false;
13
14			/**
15			* @var string
16			*/
17			protected $table = 'employees';
18
19			/**
20			* @var string
21			*/
22			protected $primaryKey = 'id';
23
24			/**
25			* @var array
26			*/
27			protected $appends = ['full_name'];
28
29			/**
30			* @var array
31			*/
32			protected $fillable = [
33			'company',
34			'last_name',
35			'first_name',
36			'email_address',
37			'job_title',
38			'business_phone',
39			'home_phone',
40			'mobile_phone',
41			'fax_number',
42			'address',
43			'city',
44			'state_province',
45			'zip_postal_code',
46			'country_region',
47			'web_page',
48			'notes',
49			'attachments',
50			];
51
52			/**
53			* @return \Illuminate\Database\Eloquent\Relations\HasOne
54			*/
55			public function latestOrders()
56			{
57			return $this->hasMany(Orders::class, 'employee_id')->limit(10);
58			}
59
60			/**
61			* @return string
62			*/
63			public function getFullNameAttribute()
64			{
65			return $this->first_name.' '.$this->last_name;
			0 ignored issues – show Documentation introduced 2015-12-11 18:29 UTC by Report Bug Copy Issue Report The property `first_name` does not exist on `object<NilPortugues\Tests\App\Models\Employees>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2015-12-11 18:29 UTC by Report Bug Copy Issue Report The property `last_name` does not exist on `object<NilPortugues\Tests\App\Models\Employees>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
66			}
67			}
68

nilportugues / laravel5-jsonapi-transformer

Push — master ( 1a65d7...018a8e )

Employees A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like