LaravelTestCase::call() - Code Metrics - Inspection of "Update .travis.yml" - nilportugues/laravel5-jsonapi-transformer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c62eb4...9318b0 )

by Nil

created 2015-12-14 14:31 UTC

LaravelTestCase::call() A

↳ Parent: LaravelTestCase

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	9
rs	9.6667
cc	1
eloc	6
nc	1
nop	7

<?php
/**
 * Author: Nil Portugués Calderó <[email protected]>
 * Date: 12/9/15
 * Time: 5:24 PM.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace NilPortugues\Tests\Laravel5\JsonApi;

use Illuminate\Events\Dispatcher;
use Illuminate\Filesystem\ClassFinder;
use Illuminate\Filesystem\Filesystem;
use Illuminate\Foundation\Testing\WithoutMiddleware;
use Illuminate\Routing\Router;
use NilPortugues\Tests\App\Transformers\EmployeesTransformer;
use NilPortugues\Tests\App\Transformers\OrdersTransformer;

/**
 * Class LaravelTestCase.
 */
class LaravelTestCase extends \Illuminate\Foundation\Testing\TestCase
{
    use WithoutMiddleware;
    /**
     * Setup DB before each test.
     */
    public function setUp()
    {
        parent::setUp();

        $this->app['config']->set('database.default', 'sqlite');
        $this->app['config']->set('database.connections.sqlite.database', ':memory:');
        $this->app['config']->set('jsonapi', [EmployeesTransformer::class, OrdersTransformer::class]);
        $this->app['config']->set('app.url', 'http://localhost/');
        $this->app['config']->set('app.debug', true);
        $this->app['config']->set('app.key', \env('APP_KEY', '1234567890123456'));
        $this->app['config']->set('app.cipher', 'AES-128-CBC');

        $this->app->boot();

        $this->migrate();
    }

    /**
     * run package database migrations.
     */
    public function migrate()
    {
        $fileSystem = new Filesystem();
        $classFinder = new ClassFinder();

        foreach ($fileSystem->files(__DIR__.'/../../../../tests/NilPortugues/App/Migrations') as $file) {
            $fileSystem->requireOnce($file);
            $migrationClass = $classFinder->findClass($file);
            (new $migrationClass())->down();
            (new $migrationClass())->up();
        }
    }

    /**
     * Boots the application.
     *
     * @return \Illuminate\Foundation\Application
     */
    public function createApplication()
    {
        /** @var $app \Illuminate\Foundation\Application */
        $app = require __DIR__.'/../../../../vendor/laravel/laravel/bootstrap/app.php';

        $this->setUpHttpKernel($app);
        $app->register(\Illuminate\Database\DatabaseServiceProvider::class);
        $app->register(\NilPortugues\Tests\App\Providers\RouteServiceProvider::class);
        $app->register(\NilPortugues\Laravel5\JsonApi\Laravel5JsonApiServiceProvider::class);

        return $app;
    }

    /**
     * @return Router
     */
    protected function getRouter()
    {
        $router = new Router(new Dispatcher());

        return $router;
    }

    /**
     * @param \Illuminate\Foundation\Application $app
     */
    private function setUpHttpKernel($app)
    {
        $app->instance('request', \Illuminate\Http\Request::capture());
        $app->make('Illuminate\Foundation\Http\Kernel', [$app, $this->getRouter()])->bootstrap();
    }

    /**
     * This is required for \Symfony\Bridge\PsrHttpMessage\Factory to work.
     * This comes as a trade-off of building the underlying package as framework-agnostic.
     *
     * @param string $method
     * @param string $uri
     * @param array  $parameters
     * @param array  $cookies
     * @param array  $files
     * @param array  $server
     * @param string $content
     *
     * @return \Illuminate\Http\Response
     */
    public function call($method, $uri, $parameters = [], $cookies = [], $files = [], $server = [], $content = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = strtoupper($method);
        $_SERVER['SERVER_NAME'] = parse_url($uri, PHP_URL_HOST);
        $_SERVER['REQUEST_URI'] = $uri;
        $_SERVER['CONTENT_TYPE'] = 'application/json';

        return parent::call($method, $uri, $parameters, $cookies, $files, $server, $content);
    }
}


1			<?php
2			/**
3			* Author: Nil Portugués Calderó <[email protected]>
4			* Date: 12/9/15
5			* Time: 5:24 PM.
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace NilPortugues\Tests\Laravel5\JsonApi;
12
13			use Illuminate\Events\Dispatcher;
14			use Illuminate\Filesystem\ClassFinder;
15			use Illuminate\Filesystem\Filesystem;
16			use Illuminate\Foundation\Testing\WithoutMiddleware;
17			use Illuminate\Routing\Router;
18			use NilPortugues\Tests\App\Transformers\EmployeesTransformer;
19			use NilPortugues\Tests\App\Transformers\OrdersTransformer;
20
21			/**
22			* Class LaravelTestCase.
23			*/
24			class LaravelTestCase extends \Illuminate\Foundation\Testing\TestCase
25			{
26			use WithoutMiddleware;
27			/**
28			* Setup DB before each test.
29			*/
30			public function setUp()
31			{
32			parent::setUp();
33
34			$this->app['config']->set('database.default', 'sqlite');
35			$this->app['config']->set('database.connections.sqlite.database', ':memory:');
36			$this->app['config']->set('jsonapi', [EmployeesTransformer::class, OrdersTransformer::class]);
37			$this->app['config']->set('app.url', 'http://localhost/');
38			$this->app['config']->set('app.debug', true);
39			$this->app['config']->set('app.key', \env('APP_KEY', '1234567890123456'));
40			$this->app['config']->set('app.cipher', 'AES-128-CBC');
41
42			$this->app->boot();
43
44			$this->migrate();
45			}
46
47			/**
48			* run package database migrations.
49			*/
50			public function migrate()
51			{
52			$fileSystem = new Filesystem();
53			$classFinder = new ClassFinder();
54
55			foreach ($fileSystem->files(__DIR__.'/../../../../tests/NilPortugues/App/Migrations') as $file) {
56			$fileSystem->requireOnce($file);
57			$migrationClass = $classFinder->findClass($file);
58			(new $migrationClass())->down();
59			(new $migrationClass())->up();
60			}
61			}
62
63			/**
64			* Boots the application.
65			*
66			* @return \Illuminate\Foundation\Application
67			*/
68			public function createApplication()
69			{
70			/** @var $app \Illuminate\Foundation\Application */
71			$app = require __DIR__.'/../../../../vendor/laravel/laravel/bootstrap/app.php';
72
73			$this->setUpHttpKernel($app);
74			$app->register(\Illuminate\Database\DatabaseServiceProvider::class);
75			$app->register(\NilPortugues\Tests\App\Providers\RouteServiceProvider::class);
76			$app->register(\NilPortugues\Laravel5\JsonApi\Laravel5JsonApiServiceProvider::class);
77
78			return $app;
79			}
80
81			/**
82			* @return Router
83			*/
84			protected function getRouter()
85			{
86			$router = new Router(new Dispatcher());
87
88			return $router;
89			}
90
91			/**
92			* @param \Illuminate\Foundation\Application $app
93			*/
94			private function setUpHttpKernel($app)
95			{
96			$app->instance('request', \Illuminate\Http\Request::capture());
97			$app->make('Illuminate\Foundation\Http\Kernel', [$app, $this->getRouter()])->bootstrap();
98			}
99
100			/**
101			* This is required for \Symfony\Bridge\PsrHttpMessage\Factory to work.
102			* This comes as a trade-off of building the underlying package as framework-agnostic.
103			*
104			* @param string $method
105			* @param string $uri
106			* @param array $parameters
107			* @param array $cookies
108			* @param array $files
109			* @param array $server
110			* @param string $content
111			*
112			* @return \Illuminate\Http\Response
113			*/
114			public function call($method, $uri, $parameters = [], $cookies = [], $files = [], $server = [], $content = null)
			0 ignored issues – show Coding Style introduced 2015-12-14 14:34 UTC by Report Bug Copy Issue Report `call` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
115			{
116			$_SERVER['REQUEST_METHOD'] = strtoupper($method);
117			$_SERVER['SERVER_NAME'] = parse_url($uri, PHP_URL_HOST);
118			$_SERVER['REQUEST_URI'] = $uri;
119			$_SERVER['CONTENT_TYPE'] = 'application/json';
120
121			return parent::call($method, $uri, $parameters, $cookies, $files, $server, $content);
122			}
123			}
124

nilportugues / laravel5-jsonapi-transformer

Push — master ( c62eb4...9318b0 )

LaravelTestCase::call() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like