Issues in SphinxAdapter.php (master) - Issues in master - nilportugues/cache - Measure and Improve Code Quality continuously with Scrutinizer

Issues (12)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Adapter/SphinxAdapter.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace NilPortugues\Cache\Adapter;

use DateTime;
use NilPortugues\Cache\Adapter\SQL\AbstractAdapter;
use PDO;
use PDOException;

/**
 * Class SphinxAdapter
 * @package NilPortugues\Cache\Adapter
 */
class SphinxAdapter extends AbstractAdapter
{
    const SPHINX_ID_PLACEHOLDER = ':sphinx_id';

    /**
     * @var string
     */
    protected $connectionClass = 'NilPortugues\Cache\Adapter\SQL\Connection\SphinxPDOConnection';

    /**
     * @var array
     */
    protected $requiredKeys = [];


    /**
     * @param     $key
     * @param     $value
     * @param int $ttl
     *
     * @return $this
     */
    protected function insertToDatabase($key, $value, $ttl = 0)
    {
        $value = $this->storageDataStructure($value);

        $calculatedTtl = $this->fromDefaultTtl($ttl);
        $calculatedTtl = new DateTime(\date('Y-m-d H:i:s', $this->getCalculatedTtl($calculatedTtl)));

        $databaseValue = $this->getFromDatabase($key);
        if (false === empty($databaseValue)) {
            $databaseValue[self::CACHE_VALUE] = $value;
            $this->updateToDatabase($key, $databaseValue, $calculatedTtl);
            return $this;
        }

        $stmt = $this->connection->prepare(
            \sprintf(
                'INSERT INTO %s(id,%s,%s,%s) VALUES(%s,%s,%s,%s)',
                $this->cacheTableName,
                self::TABLE_CACHE_ID,
                self::TABLE_CACHE_VALUE,
                self::TABLE_CACHE_TTL,
                self::SPHINX_ID_PLACEHOLDER,
                self::QUERY_ID_PLACEHOLDER,
                self::QUERY_VALUE_PLACEHOLDER,
                self::QUERY_TTL_PLACEHOLDER
            )
        );

        $sphinxId = (int) $this->connection->lastInsertId()+1;

        $stmt->bindParam(self::SPHINX_ID_PLACEHOLDER, $sphinxId, PDO::PARAM_STR);
        $stmt->bindParam(self::QUERY_ID_PLACEHOLDER, $key, PDO::PARAM_STR);
        $stmt->bindParam(self::QUERY_VALUE_PLACEHOLDER, $value, PDO::PARAM_STR);
        $calculatedTtl = $calculatedTtl->format('Y-m-d H:i:s');
        $stmt->bindParam(self::QUERY_TTL_PLACEHOLDER, $calculatedTtl, PDO::PARAM_STR);
        $stmt->execute();

        return $this;
    }


    /**
     * @param $key
     * @param $value
     * @param DateTime $ttl
     * @return $this
     */
    protected function updateToDatabase($key, $value, DateTime $ttl)
    {
        $stmt = $this->connection->prepare(
            \sprintf(
                'REPLACE INTO %s(id, %s, %s, %s) VALUES(%s, %s, %s, %s)',
                $this->cacheTableName,
                self::TABLE_CACHE_ID,
                self::TABLE_CACHE_VALUE,
                self::TABLE_CACHE_TTL,
                self::SPHINX_ID_PLACEHOLDER,
                self::QUERY_ID_PLACEHOLDER,
                self::QUERY_VALUE_PLACEHOLDER,
                self::QUERY_TTL_PLACEHOLDER
            )
        );

        $stmt->bindParam(self::SPHINX_ID_PLACEHOLDER, $value['id'], PDO::PARAM_STR);
        $stmt->bindParam(self::QUERY_ID_PLACEHOLDER, $key, PDO::PARAM_STR);
        $stmt->bindParam(self::QUERY_VALUE_PLACEHOLDER, $value[self::CACHE_VALUE], PDO::PARAM_STR);
        $calculatedTtl = $ttl->format('Y-m-d H:i:s');
        $stmt->bindParam(self::QUERY_TTL_PLACEHOLDER, $calculatedTtl, PDO::PARAM_STR);
        $stmt->execute();

        return $this;
    }


    /**
     * @param string $key
     *
     * @return array
     */
    protected function getFromDatabase($key)

    {
        try {
            $stmt = $this->connection->prepare(
                \sprintf(
                    'SELECT id, %s, %s FROM %s WHERE %s = %s',
                    self::TABLE_CACHE_VALUE,
                    self::TABLE_CACHE_TTL,
                    $this->cacheTableName,
                    self::TABLE_CACHE_ID,
                    self::QUERY_ID_PLACEHOLDER
                )
            );

            $stmt->bindParam(self::QUERY_ID_PLACEHOLDER, $key, PDO::PARAM_STR);
            $stmt->execute();

            $result = $stmt->fetch(PDO::FETCH_ASSOC);
            return (\is_bool($result)) ? [] : $result;
        } catch (PDOException $e) {
            return [];
        }
    }
}


1		<?php
2
3		namespace NilPortugues\Cache\Adapter;
4
5		use DateTime;
6		use NilPortugues\Cache\Adapter\SQL\AbstractAdapter;
7		use PDO;
8		use PDOException;
9
10		/**
11		* Class SphinxAdapter
12		* @package NilPortugues\Cache\Adapter
13		*/
14		class SphinxAdapter extends AbstractAdapter
15		{
16		const SPHINX_ID_PLACEHOLDER = ':sphinx_id';
17
18		/**
19		* @var string
20		*/
21		protected $connectionClass = 'NilPortugues\Cache\Adapter\SQL\Connection\SphinxPDOConnection';
22
23		/**
24		* @var array
25		*/
26		protected $requiredKeys = [];
27
28
29		/**
30		* @param $key
31		* @param $value
32		* @param int $ttl
33		*
34		* @return $this
35		*/
36		protected function insertToDatabase($key, $value, $ttl = 0)
37		{
38		$value = $this->storageDataStructure($value);
39
40		$calculatedTtl = $this->fromDefaultTtl($ttl);
41		$calculatedTtl = new DateTime(\date('Y-m-d H:i:s', $this->getCalculatedTtl($calculatedTtl)));
42
43		$databaseValue = $this->getFromDatabase($key);
44		if (false === empty($databaseValue)) {
45		$databaseValue[self::CACHE_VALUE] = $value;
46		$this->updateToDatabase($key, $databaseValue, $calculatedTtl);
47		return $this;
48		}
49
50		$stmt = $this->connection->prepare(
51		\sprintf(
52		'INSERT INTO %s(id,%s,%s,%s) VALUES(%s,%s,%s,%s)',
53		$this->cacheTableName,
54		self::TABLE_CACHE_ID,
55		self::TABLE_CACHE_VALUE,
56		self::TABLE_CACHE_TTL,
57		self::SPHINX_ID_PLACEHOLDER,
58		self::QUERY_ID_PLACEHOLDER,
59		self::QUERY_VALUE_PLACEHOLDER,
60		self::QUERY_TTL_PLACEHOLDER
61		)
62		);
63
64		$sphinxId = (int) $this->connection->lastInsertId()+1;
65
66		$stmt->bindParam(self::SPHINX_ID_PLACEHOLDER, $sphinxId, PDO::PARAM_STR);
67		$stmt->bindParam(self::QUERY_ID_PLACEHOLDER, $key, PDO::PARAM_STR);
68		$stmt->bindParam(self::QUERY_VALUE_PLACEHOLDER, $value, PDO::PARAM_STR);
69		$calculatedTtl = $calculatedTtl->format('Y-m-d H:i:s');
70		$stmt->bindParam(self::QUERY_TTL_PLACEHOLDER, $calculatedTtl, PDO::PARAM_STR);
71		$stmt->execute();
72
73		return $this;
74		}
75
76
77		/**
78		* @param $key
79		* @param $value
80		* @param DateTime $ttl
81		* @return $this
82		*/
83		protected function updateToDatabase($key, $value, DateTime $ttl)
84		{
85		$stmt = $this->connection->prepare(
86		\sprintf(
87		'REPLACE INTO %s(id, %s, %s, %s) VALUES(%s, %s, %s, %s)',
88		$this->cacheTableName,
89		self::TABLE_CACHE_ID,
90		self::TABLE_CACHE_VALUE,
91		self::TABLE_CACHE_TTL,
92		self::SPHINX_ID_PLACEHOLDER,
93		self::QUERY_ID_PLACEHOLDER,
94		self::QUERY_VALUE_PLACEHOLDER,
95		self::QUERY_TTL_PLACEHOLDER
96		)
97		);
98
99		$stmt->bindParam(self::SPHINX_ID_PLACEHOLDER, $value['id'], PDO::PARAM_STR);
100		$stmt->bindParam(self::QUERY_ID_PLACEHOLDER, $key, PDO::PARAM_STR);
101		$stmt->bindParam(self::QUERY_VALUE_PLACEHOLDER, $value[self::CACHE_VALUE], PDO::PARAM_STR);
102		$calculatedTtl = $ttl->format('Y-m-d H:i:s');
103		$stmt->bindParam(self::QUERY_TTL_PLACEHOLDER, $calculatedTtl, PDO::PARAM_STR);
104		$stmt->execute();
105
106		return $this;
107		}
108
109
110		/**
111		* @param string $key
112		*
113		* @return array
114		*/
115	View Code Duplication	protected function getFromDatabase($key)
		0 ignored issues – show Duplication introduced 2015-12-09 15:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116		{
117		try {
118		$stmt = $this->connection->prepare(
119		\sprintf(
120		'SELECT id, %s, %s FROM %s WHERE %s = %s',
121		self::TABLE_CACHE_VALUE,
122		self::TABLE_CACHE_TTL,
123		$this->cacheTableName,
124		self::TABLE_CACHE_ID,
125		self::QUERY_ID_PLACEHOLDER
126		)
127		);
128
129		$stmt->bindParam(self::QUERY_ID_PLACEHOLDER, $key, PDO::PARAM_STR);
130		$stmt->execute();
131
132		$result = $stmt->fetch(PDO::FETCH_ASSOC);
133		return (\is_bool($result)) ? [] : $result;
134		} catch (PDOException $e) {
135		return [];
136		}
137		}
138		}
139

nilportugues / cache

Issues (12)

Security Analysis no request data

src/Adapter/SphinxAdapter.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like