Issues (9)

src/Wechat/ScanPayment.php (1 issue)

Severity
1
<?php
2
3
namespace Nilnice\Payment\Wechat;
4
5
use Illuminate\Support\Collection;
6
use Nilnice\Payment\Constant;
7
use Nilnice\Payment\Log;
8
9
class ScanPayment extends AbstractWechat
10
{
11
    /**
12
     * Use scan to pay for order.
13
     *
14
     * @param string $gateway
15
     * @param array  $payload
16
     *
17
     * @return \Illuminate\Support\Collection
18
     *
19
     * @throws \InvalidArgumentException
20
     * @throws \Nilnice\Payment\Exception\GatewayException
21
     * @throws \Nilnice\Payment\Exception\InvalidKeyException
22
     * @throws \Nilnice\Payment\Exception\InvalidSignException
23
     */
24
    public function toPay(string $gateway, array $payload) : Collection
25
    {
26
        $payload['spbill_create_ip'] = $this->getClientIp();
27
        $payload['trade_type'] = Constant::WX_PAY_SCAN_TYPE;
28
        $gateway .= Constant::WX_PAY_PREPARE;
29
30
        Log::debug('Scan order:', [$gateway, $payload]);
31
32
        return $this->prepare($gateway, $payload, 'scan');
0 ignored issues
show
The call to Nilnice\Payment\Wechat\AbstractWechat::prepare() has too many arguments starting with 'scan'. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

32
        return $this->/** @scrutinizer ignore-call */ prepare($gateway, $payload, 'scan');

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
33
    }
34
}
35