SemverComparator::compareNumberPart() - Code Metrics - Inspection of "Rename Comparator namespace to Comparison" - nikolaposa/version - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02e5ec...79e89c )

by Nikola

created 2019-12-08 10:59 UTC

SemverComparator::compareNumberPart() A

↳ Parent: SemverComparator

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	14
c	0
b	0
f	0
ccs	7
cts	7
cp	1
rs	9.7998
cc	3
nc	3
nop	2
crap	3

<?php

declare(strict_types=1);

namespace Version\Comparison;

use Version\Version;

final class SemverComparator implements Comparator
{
    public function compare(Version $version1, Version $version2): int
    {
        if (0 !== ($majorCompareResult = $this->compareNumberPart($version1->getMajor(), $version2->getMajor()))) {
            return $majorCompareResult;
        }

        if (0 !== ($minorCompareResult = $this->compareNumberPart($version1->getMinor(), $version2->getMinor()))) {
            return $minorCompareResult;
        }

        if (0 !== ($patchCompareResult = $this->compareNumberPart($version1->getPatch(), $version2->getPatch()))) {
            return $patchCompareResult;
        }

        return $this->compareMeta($version1, $version2);
    }

    private function compareNumberPart(int $number1, int $number2): int
    {
        $diff = $number1 - $number2;

        if ($diff > 0) {
            return 1;
        }

        if ($diff < 0) {
            return -1;
        }

        return 0;
    }

    private function compareMeta(Version $version1, Version $version2): int
    {
        $v1IsPreRelease = $version1->isPreRelease();
        $v2IsPreRelease = $version2->isPreRelease();

        if ($v1IsPreRelease xor $v2IsPreRelease) {
            return !$v1IsPreRelease
                ? 1 // normal version has greater precedence than a pre-release version version
                : -1; // pre-release version has lower precedence than a normal version
        }

        $result = $version1->getPreRelease()->compareTo($version2->getPreRelease());

        if ($result > 0) {
            return 1;
        }

        if ($result < 0) {
            return -1;
        }

        return 0;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Version\Comparison;
6
7		use Version\Version;
8
9		final class SemverComparator implements Comparator
10		{
11	39	public function compare(Version $version1, Version $version2): int
12		{
13	39	if (0 !== ($majorCompareResult = $this->compareNumberPart($version1->getMajor(), $version2->getMajor()))) {
14	13	return $majorCompareResult;
15		}
16
17	33	if (0 !== ($minorCompareResult = $this->compareNumberPart($version1->getMinor(), $version2->getMinor()))) {
18	7	return $minorCompareResult;
19		}
20
21	29	if (0 !== ($patchCompareResult = $this->compareNumberPart($version1->getPatch(), $version2->getPatch()))) {
22	7	return $patchCompareResult;
23		}
24
25	25	return $this->compareMeta($version1, $version2);
26		}
27
28	39	private function compareNumberPart(int $number1, int $number2): int
29		{
30	39	$diff = $number1 - $number2;
31
32	39	if ($diff > 0) {
33	14	return 1;
34		}
35
36	38	if ($diff < 0) {
37	14	return -1;
38		}
39
40	33	return 0;
41		}
42
43	25	private function compareMeta(Version $version1, Version $version2): int
44		{
45	25	$v1IsPreRelease = $version1->isPreRelease();
46	25	$v2IsPreRelease = $version2->isPreRelease();
47
48	25	if ($v1IsPreRelease xor $v2IsPreRelease) {
49	3	return !$v1IsPreRelease
50	3	? 1 // normal version has greater precedence than a pre-release version version
51	3	: -1; // pre-release version has lower precedence than a normal version
52		}
53
54	22	$result = $version1->getPreRelease()->compareTo($version2->getPreRelease());
55
56	22	if ($result > 0) {
57	6	return 1;
58		}
59
60	16	if ($result < 0) {
61	2	return -1;
62		}
63
64	14	return 0;
65		}
66		}
67

nikolaposa / version

Push — master ( 02e5ec...79e89c )

SemverComparator::compareNumberPart() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like