SemverComparator::compare() - Code Metrics - Inspection of "Use spaceship operator for comparision logic" - nikolaposa/version - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 614e1d...9c0277 )

by Nikola

created 2019-12-22 16:57 UTC

SemverComparator::compare() A

↳ Parent: SemverComparator

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	16
c	0
b	0
f	0
ccs	8
cts	8
cp	1
rs	9.7333
cc	4
nc	4
nop	2
crap	4

<?php

declare(strict_types=1);

namespace Version\Comparison;

use Version\Version;

final class SemverComparator implements Comparator
{
    public function compare(Version $version1, Version $version2): int
    {
        if (0 !== ($majorCompareResult = ($version1->getMajor() <=> $version2->getMajor()))) {
            return $majorCompareResult;
        }

        if (0 !== ($minorCompareResult = ($version1->getMinor() <=> $version2->getMinor()))) {
            return $minorCompareResult;
        }

        if (0 !== ($patchCompareResult = ($version1->getPatch() <=> $version2->getPatch()))) {
            return $patchCompareResult;
        }

        return $this->compareMeta($version1, $version2);
    }

    private function compareMeta(Version $version1, Version $version2): int
    {
        $v1IsPreRelease = $version1->isPreRelease();
        $v2IsPreRelease = $version2->isPreRelease();

        if ($v1IsPreRelease xor $v2IsPreRelease) {
            return !$v1IsPreRelease
                ? 1 // normal version has greater precedence than a pre-release version version
                : -1; // pre-release version has lower precedence than a normal version
        }

        return $version1->getPreRelease()->compareTo($version2->getPreRelease());
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Version\Comparison;
6
7		use Version\Version;
8
9		final class SemverComparator implements Comparator
10		{
11	36	public function compare(Version $version1, Version $version2): int
12		{
13	36	if (0 !== ($majorCompareResult = ($version1->getMajor() <=> $version2->getMajor()))) {
14	10	return $majorCompareResult;
15		}
16
17	31	if (0 !== ($minorCompareResult = ($version1->getMinor() <=> $version2->getMinor()))) {
18	6	return $minorCompareResult;
19		}
20
21	27	if (0 !== ($patchCompareResult = ($version1->getPatch() <=> $version2->getPatch()))) {
22	6	return $patchCompareResult;
23		}
24
25	23	return $this->compareMeta($version1, $version2);
26		}
27
28	23	private function compareMeta(Version $version1, Version $version2): int
29		{
30	23	$v1IsPreRelease = $version1->isPreRelease();
31	23	$v2IsPreRelease = $version2->isPreRelease();
32
33	23	if ($v1IsPreRelease xor $v2IsPreRelease) {
34	2	return !$v1IsPreRelease
35	2	? 1 // normal version has greater precedence than a pre-release version version
36	2	: -1; // pre-release version has lower precedence than a normal version
37		}
38
39	21	return $version1->getPreRelease()->compareTo($version2->getPreRelease());
40		}
41		}
42

nikolaposa / version

Push — master ( 614e1d...9c0277 )

SemverComparator::compare() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like