RateLimit\MemcachedRateLimiter

Complexity

Total Complexity

10

Size/Duplication

Total Lines	74
Duplicated Lines	39.19 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	limit()	12	12	2
A	limitSilently()	17	17	2
A	key()	0	4	1
A	getCurrent()	0	4	1
A	updateCounter()	0	11	2
A	ttl()	0	6	1

<?php

declare(strict_types=1);

namespace RateLimit;

use RateLimit\Exception\LimitExceeded;
use Memcached;

final class MemcachedRateLimiter implements RateLimiter, SilentRateLimiter
{
    /** @var Memcached */
    private $memcached;

    /** @var string */
    private $keyPrefix;

    public function __construct(Memcached $memcached, string $keyPrefix = '')
    {
        $this->memcached = $memcached;
        $this->keyPrefix = $keyPrefix;
    }

    public function limit(string $identifier, Rate $rate): void

This method seems to be duplicated in your project.

    {
        $key = $this->key($identifier, $rate->getInterval());

        $current = $this->getCurrent($key);

        if ($current >= $rate->getOperations()) {
            throw LimitExceeded::for($identifier, $rate);
        }

        $this->updateCounter($key, $rate->getInterval());
    }

    public function limitSilently(string $identifier, Rate $rate): Status

This method seems to be duplicated in your project.

    {
        $key = $this->key($identifier, $rate->getInterval());

        $current = $this->getCurrent($key);

        if ($current <= $rate->getOperations()) {
            $current = $this->updateCounter($key, $rate->getInterval());
        }

        return Status::from(
            $identifier,
            $current,
            $rate->getOperations(),
            time() + $this->ttl($key)
        );
    }

    private function key(string $identifier, int $interval): string
    {
        return "{$this->keyPrefix}{$identifier}:$interval";
    }

    private function getCurrent(string $key): int
    {
        return (int) $this->memcached->get($key);
    }

    private function updateCounter(string $key, int $interval): int
    {
        $this->memcached->increment($key, 1, 1);
        $current = $this->getCurrent($key);

        if ($current === 1) {
            $this->memcached->touch($key, $interval);
        }

        return $current;
    }

    private function ttl(string $key): int

The parameter $key is not used and could be removed.

    {
        // memcached doesn't support retrieving TTL by key
        // of course there are crutches, but we are normal developers
        return 0;
    }
}