MemcachedRateLimiter::updateCounter() - Code Metrics - Inspection of "new limiters" - nikolaposa/rate-limit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#24)

by Julián

created 2020-04-28 20:42 UTC

MemcachedRateLimiter::updateCounter() A

↳ Parent: MemcachedRateLimiter

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	5
cp	1
rs	9.9332
c	0
b	0
f	0
cc	3
nc	4
nop	3
crap	3

<?php

declare(strict_types=1);

namespace RateLimit;

use Memcached;

final class MemcachedRateLimiter extends AbstractElapsedTimeRateLimiter
{
    /** @var Memcached */
    private $memcached;

    public function __construct(Memcached $memcached, string $keyPrefix = '')
    {
        if ($memcached->getOption(Memcached::OPT_BINARY_PROTOCOL) !== 1) {
            throw new \RuntimeException('Memcached "OPT_BINARY_PROTOCOL" option should be set to "true".');
        }

        parent::__construct($keyPrefix);

        $this->memcached = $memcached;
    }

    protected function getCurrent(string $valueKey): int
    {
        return (int) $this->memcached->get($valueKey);
    }

    protected function updateCounter(string $valueKey, string $timeKey, int $interval): int
    {
        $current = $this->memcached->increment($valueKey, 1, 1, $interval);

        if ($current === 1) {
            $this->memcached->add($timeKey, \time(), $interval);
        }

        return $current === false ? 1 : $current;
    }

    protected function getElapsedTime(string $timeKey): int
    {
        return \time() - (int) $this->memcached->get($timeKey);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace RateLimit;
6
7		use Memcached;
8
9		final class MemcachedRateLimiter extends AbstractElapsedTimeRateLimiter
10		{
11		/** @var Memcached */
12		private $memcached;
13
14	5	public function __construct(Memcached $memcached, string $keyPrefix = '')
15		{
16	5	if ($memcached->getOption(Memcached::OPT_BINARY_PROTOCOL) !== 1) {
17		throw new \RuntimeException('Memcached "OPT_BINARY_PROTOCOL" option should be set to "true".');
18		}
19
20	5	parent::__construct($keyPrefix);
21
22	5	$this->memcached = $memcached;
23	5	}
24
25	5	protected function getCurrent(string $valueKey): int
26		{
27	5	return (int) $this->memcached->get($valueKey);
28		}
29
30	5	protected function updateCounter(string $valueKey, string $timeKey, int $interval): int
31		{
32	5	$current = $this->memcached->increment($valueKey, 1, 1, $interval);
33
34	5	if ($current === 1) {
35	5	$this->memcached->add($timeKey, \time(), $interval);
36		}
37
38	5	return $current === false ? 1 : $current;
39		}
40
41	3	protected function getElapsedTime(string $timeKey): int
42		{
43	3	return \time() - (int) $this->memcached->get($timeKey);
44		}
45		}
46

nikolaposa / rate-limit

Pull Request — master (#24)

MemcachedRateLimiter::updateCounter() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like