Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | class ParserFactory { |
||
| 6 | const PREFER_PHP7 = 1; |
||
| 7 | const PREFER_PHP5 = 2; |
||
| 8 | const ONLY_PHP7 = 3; |
||
| 9 | const ONLY_PHP5 = 4; |
||
| 10 | |||
| 11 | /** |
||
| 12 | * Creates a Parser instance, according to the provided kind. |
||
| 13 | * |
||
| 14 | * @param int $kind One of ::PREFER_PHP7, ::PREFER_PHP5, ::ONLY_PHP7 or ::ONLY_PHP5 |
||
| 15 | * @param Lexer|null $lexer Lexer to use. Defaults to emulative lexer when not specified |
||
| 16 | * @param array $parserOptions Parser options. See ParserAbstract::__construct() argument |
||
| 17 | * |
||
| 18 | * @return Parser The parser instance |
||
| 19 | */ |
||
| 20 | public function create($kind, Lexer $lexer = null, array $parserOptions = array()) { |
||
| 43 | } |
||
| 44 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.