nikic /
PHP-Parser
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | View Code Duplication | class Include_ extends Expr |
|
|
|
|||
| 8 | { |
||
| 9 | const TYPE_INCLUDE = 1; |
||
| 10 | const TYPE_INCLUDE_ONCE = 2; |
||
| 11 | const TYPE_REQUIRE = 3; |
||
| 12 | const TYPE_REQUIRE_ONCE = 4; |
||
| 13 | |||
| 14 | /** @var Expr Expression */ |
||
| 15 | public $expr; |
||
| 16 | /** @var int Type of include */ |
||
| 17 | public $type; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * Constructs an include node. |
||
| 21 | * |
||
| 22 | * @param Expr $expr Expression |
||
| 23 | * @param int $type Type of include |
||
| 24 | * @param array $attributes Additional attributes |
||
| 25 | */ |
||
| 26 | public function __construct(Expr $expr, $type, array $attributes = array()) { |
||
| 27 | parent::__construct($attributes); |
||
| 28 | $this->expr = $expr; |
||
| 29 | $this->type = $type; |
||
| 30 | } |
||
| 31 | |||
| 32 | public function getSubNodeNames() { |
||
| 35 | } |
||
| 36 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.