Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | View Code Duplication | class Arg extends NodeAbstract |
|
|
|
|||
| 8 | { |
||
| 9 | /** @var Expr Value to pass */ |
||
| 10 | public $value; |
||
| 11 | /** @var bool Whether to pass by ref */ |
||
| 12 | public $byRef; |
||
| 13 | /** @var bool Whether to unpack the argument */ |
||
| 14 | public $unpack; |
||
| 15 | |||
| 16 | /** |
||
| 17 | * Constructs a function call argument node. |
||
| 18 | * |
||
| 19 | * @param Expr $value Value to pass |
||
| 20 | * @param bool $byRef Whether to pass by ref |
||
| 21 | * @param bool $unpack Whether to unpack the argument |
||
| 22 | * @param array $attributes Additional attributes |
||
| 23 | */ |
||
| 24 | public function __construct(Expr $value, $byRef = false, $unpack = false, array $attributes = array()) { |
||
| 25 | parent::__construct($attributes); |
||
| 26 | $this->value = $value; |
||
| 27 | $this->byRef = $byRef; |
||
| 28 | $this->unpack = $unpack; |
||
| 29 | } |
||
| 30 | |||
| 31 | public function getSubNodeNames() { |
||
| 34 | } |
||
| 35 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.