Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | class Function_ extends FunctionLike |
||
| 10 | { |
||
| 11 | protected $name; |
||
| 12 | protected $stmts = array(); |
||
| 13 | |||
| 14 | /** |
||
| 15 | * Creates a function builder. |
||
| 16 | * |
||
| 17 | * @param string $name Name of the function |
||
| 18 | */ |
||
| 19 | public function __construct($name) { |
||
| 22 | |||
| 23 | /** |
||
| 24 | * Adds a statement. |
||
| 25 | * |
||
| 26 | * @param Node|PhpParser\Builder $stmt The statement to add |
||
| 27 | * |
||
| 28 | * @return $this The builder instance (for fluid interface) |
||
| 29 | */ |
||
| 30 | public function addStmt($stmt) { |
||
| 35 | |||
| 36 | /** |
||
| 37 | * Returns the built function node. |
||
| 38 | * |
||
| 39 | * @return Stmt\Function_ The built function node |
||
| 40 | */ |
||
| 41 | View Code Duplication | public function getNode() { |
|
| 48 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.