SaleTableSeeder::run() - Code Metrics - Inspection of "Scrutinizer setup" - nikhil-pandey/guitar-shop - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9dca68...baaa35 )

by Nikhil

created 2016-03-24 13:15 UTC

SaleTableSeeder::run() A

↳ Parent: SaleTableSeeder

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
c	3
b	1
f	1
dl	0
loc	10
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php

use App\Guitar;
use App\Sale;
use Illuminate\Database\Seeder;

class SaleTableSeeder extends Seeder
namespace YourVendor;

class YourClass { }
{
    /**
     * Run the database seeds.
     *
     * @return void
     */
    public function run()
    {
        factory(Sale::class, 5)->make()->each(function (Sale $sale) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            Guitar::unsold()->first()->sale()->save($sale);

        });

        factory(Sale::class, 'shop', 5)->make()->each(function (Sale $sale) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            Guitar::unsold()->first()->sale()->save($sale);

        });
    }
}


GitHub Access Token became invalid

Push — master ( 9dca68...baaa35 )

SaleTableSeeder::run() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			use App\Guitar;
4			use App\Sale;
5			use Illuminate\Database\Seeder;
6
7			class SaleTableSeeder extends Seeder
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8			{
9			/**
10			* Run the database seeds.
11			*
12			* @return void
13			*/
14			public function run()
15			{
16			factory(Sale::class, 5)->make()->each(function (Sale $sale) {
			0 ignored issues – show Bug introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The method `each` does only exist in `Illuminate\Database\Eloquent\Collection`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
17			Guitar::unsold()->first()->sale()->save($sale);
			0 ignored issues – show Bug introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The method `unsold()` does not exist on `App\Guitar`. Did you maybe mean `scopeUnsold()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
18			});
19
20			factory(Sale::class, 'shop', 5)->make()->each(function (Sale $sale) {
			0 ignored issues – show Bug introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The method `each` does only exist in `Illuminate\Database\Eloquent\Collection`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
21			Guitar::unsold()->first()->sale()->save($sale);
			0 ignored issues – show Bug introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The method `unsold()` does not exist on `App\Guitar`. Did you maybe mean `scopeUnsold()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
22			});
23			}
24			}
25

nikhil-pandey / guitar-shop

GitHub Access Token became invalid

Push — master ( 9dca68...baaa35 )

SaleTableSeeder::run() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like