PurchaseTableSeeder::run() - Code Metrics - Inspection of "Scrutinizer setup" - nikhil-pandey/guitar-shop - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9dca68...baaa35 )

by Nikhil

created 2016-03-24 13:15 UTC

PurchaseTableSeeder::run() A

↳ Parent: PurchaseTableSeeder

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	13
rs	9.4285
cc	1
eloc	9
nc	1
nop	0

<?php

use App\Make;
use App\Purchase;
use App\Supplier;
use Illuminate\Database\Seeder;

class PurchaseTableSeeder extends Seeder
namespace YourVendor;

class YourClass { }
{
    /**
     * Run the database seeds.
     *
     * @return void
     */
    public function run()
    {
        $supplier = Supplier::first();
        Make::all()->each(function (Make $make) use ($supplier) {
            factory(Purchase::class, 2)->create(['make_id' => $make->id, 'supplier_id' => $supplier->id]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            factory(Purchase::class, 'delivered', 5)
                ->create([
                    'make_id'     => $make->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'supplier_id' => $supplier->id,
                    'quantity'    => rand(20, 100)
                ]);
        });
    }
}


1			<?php
2
3			use App\Make;
4			use App\Purchase;
5			use App\Supplier;
6			use Illuminate\Database\Seeder;
7
8			class PurchaseTableSeeder extends Seeder
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10			/**
11			* Run the database seeds.
12			*
13			* @return void
14			*/
15			public function run()
16			{
17			$supplier = Supplier::first();
18			Make::all()->each(function (Make $make) use ($supplier) {
19			factory(Purchase::class, 2)->create(['make_id' => $make->id, 'supplier_id' => $supplier->id]);
			0 ignored issues – show Documentation introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Make>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
20			factory(Purchase::class, 'delivered', 5)
21			->create([
22			'make_id' => $make->id,
			0 ignored issues – show Documentation introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Make>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
23			'supplier_id' => $supplier->id,
24			'quantity' => rand(20, 100)
25			]);
26			});
27			}
28			}
29

nikhil-pandey / guitar-shop

GitHub Access Token became invalid

Push — master ( 9dca68...baaa35 )

PurchaseTableSeeder::run() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like