GuitarTableSeeder::run() - Code Metrics - Inspection of "Scrutinizer setup" - nikhil-pandey/guitar-shop - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9dca68...baaa35 )

by Nikhil

created 2016-03-24 13:15 UTC

GuitarTableSeeder::run() A

↳ Parent: GuitarTableSeeder

Complexity

Conditions	2
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
c	3
b	1
f	1
dl	0
loc	12
rs	9.4285
cc	2
eloc	8
nc	1
nop	0

<?php

use App\Purchase;
use Illuminate\Database\Seeder;

class GuitarTableSeeder extends Seeder
namespace YourVendor;

class YourClass { }
{
    /**
     * Run the database seeds.
     *
     * @return void
     */
    public function run()
    {
        Purchase::delivered()->get()->each(function (Purchase $purchase) {

            while ($purchase->isPendingStorage()) {
                $guitar           = factory(App\Guitar::class)->make();
                $guitar->rack_id  = $purchase->make->racks->first()->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $guitar->make_id  = $purchase->make_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $guitar->model_id = $purchase->make->models->first()->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $purchase->guitars()->save($guitar);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            }
        });
    }
}


1			<?php
2
3			use App\Purchase;
4			use Illuminate\Database\Seeder;
5
6			class GuitarTableSeeder extends Seeder
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			/**
9			* Run the database seeds.
10			*
11			* @return void
12			*/
13			public function run()
14			{
15			Purchase::delivered()->get()->each(function (Purchase $purchase) {
			0 ignored issues – show Bug introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The method `delivered()` does not exist on `App\Purchase`. Did you maybe mean `scopeDelivered()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
16			while ($purchase->isPendingStorage()) {
17			$guitar = factory(App\Guitar::class)->make();
18			$guitar->rack_id = $purchase->make->racks->first()->id;
			0 ignored issues – show Documentation introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The property `make` does not exist on `object<App\Purchase>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
19			$guitar->make_id = $purchase->make_id;
			0 ignored issues – show Documentation introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The property `make_id` does not exist on `object<App\Purchase>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
20			$guitar->model_id = $purchase->make->models->first()->id;
			0 ignored issues – show Documentation introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report The property `make` does not exist on `object<App\Purchase>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
21			$purchase->guitars()->save($guitar);
			0 ignored issues – show Bug introduced 2016-03-24 13:25 UTC by Report Bug Copy Issue Report It seems like `$guitar` defined by `factory(\App\Guitar::class)->make()` on line `17` can also be of type `object<Illuminate\Database\Eloquent\Collection>`; however, `Illuminate\Database\Eloq...ns\HasOneOrMany::save()` does only seem to accept `object<Illuminate\Database\Eloquent\Model>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
22			}
23			});
24			}
25			}
26

nikhil-pandey / guitar-shop

GitHub Access Token became invalid

Push — master ( 9dca68...baaa35 )

GuitarTableSeeder::run() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like