App\Http\Controllers\WarehouseController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

100%

Importance

Changes	10
Bugs	1	Features	6

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	4	1
A	store()	0	14	1
A	update()	0	18	1
A	destroy()	0	6	1
A	getIdsFrom()	0	4	1

<?php

namespace App\Http\Controllers;

use App\Events\WarehouseWasCreated;
use App\Events\WarehouseWasDeleted;
use App\Events\WarehouseWasUpdated;
use App\Warehouse;
use Illuminate\Http\Request;
use Illuminate\Http\Response;

class WarehouseController extends Controller
{
    /**
     * New instance of warehouse controller.
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * List the warehouses.
     * @return Response
     */
    public function index()
    {
        return view('warehouses.index');
    }

    /**
     * Create a new warehouse.
     *
     * @param Request $request
     */
    public function store(Request $request)
    {
        $this->validate($request, [
            'name'             => 'required|string|max:255',
            'racks.*.name'     => 'required|string|max:255',
            'racks.*.make_id'  => 'required|exists:makes,id',
            'racks.*.capacity' => 'required|integer|min:1',
        ]);

        $warehouse = Warehouse::create($request->only(['name']));
        $racks     = $request->input('racks', []);
        $warehouse->addRacks($racks);

It seems like $racks defined by $request->input('racks', array()) on line 46 can also be of type string; however, App\Warehouse::addRacks() does only seem to accept object<Illuminate\Database\Eloquent\Collection>|array, maybe add an additional type check?

        event(new WarehouseWasCreated($warehouse));

The call to WarehouseWasCreated::__construct() has too many arguments starting with $warehouse.

    }

    /**
     * Update the warehouse.
     *
     * @param $id
     * @param Request $request
     */
    public function update(Request $request, $id)
    {
        $this->validate($request, [
            'name'             => 'required|string|max:255',
            'racks.*.id'       => 'exists:racks,id',
            'racks.*.name'     => 'required|string|max:255',
            'racks.*.make_id'  => 'required|exists:makes,id',
            'racks.*.capacity' => 'required|integer|min:1',
        ]);

        $warehouse = Warehouse::findOrFail($id);
        $warehouse->update($request->only(['name']));

        $racks = $request->input('racks', []);
        $warehouse->removeRacksNotIn($this->getIdsFrom($racks));
        $warehouse->addOrUpdateRacks($racks);
        event(new WarehouseWasUpdated($warehouse));

The call to WarehouseWasUpdated::__construct() has too many arguments starting with $warehouse.

    }

    /**
     * Delete the warehouse.
     *
     * @param $id
     */
    public function destroy($id)
    {
        $warehouse = Warehouse::findOrFail($id);
        $warehouse->delete();
        event(new WarehouseWasDeleted($warehouse));

The call to WarehouseWasDeleted::__construct() has too many arguments starting with $warehouse.

    }

    /**
     * @param $racks
     *
     * @return array
     */
    private function getIdsFrom($racks)
    {
        return array_filter(array_pluck($racks, 'id'));
    }
}