SupplierTransformer - Code Metrics - Inspection of "Update readme" - nikhil-pandey/guitar-shop - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 14aa9d...8c82e7 )

by Nikhil

created 2016-03-29 11:13 UTC

SupplierTransformer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
wmc	2
c	4
b	1
f	1
lcom	0
cbo	2
dl	0
loc	37
ccs	4
cts	4
cp	1
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	transform()	0	8	1
A	includePurchases()	0	4	1

<?php

namespace App\Transformers;

use App\Supplier;
use League\Fractal\TransformerAbstract;

class SupplierTransformer extends TransformerAbstract
{
    /**
     * List of resources possible to include.
     *
     * @var array
     */
    protected $availableIncludes = ['purchases'];

    /**
     * Turn this item object into a generic array.
     *
     * @param Supplier $supplier
     *
     * @return array
     */
    public function transform(Supplier $supplier)
    {
        return [
            'id'       => (int)$supplier->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'name'     => (string)$supplier->name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'location' => (string)$supplier->location,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        ];
    }

    /**
     * Includes purchases.
     *
     * @param Supplier $supplier
     *
     * @return \League\Fractal\Resource\Collection
     */
    public function includePurchases(Supplier $supplier)
    {
        return $this->collection($supplier->purchases, new PurchaseTransformer);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1		<?php
2
3		namespace App\Transformers;
4
5		use App\Supplier;
6		use League\Fractal\TransformerAbstract;
7
8		class SupplierTransformer extends TransformerAbstract
9		{
10		/**
11		* List of resources possible to include.
12		*
13		* @var array
14		*/
15		protected $availableIncludes = ['purchases'];
16
17		/**
18		* Turn this item object into a generic array.
19		*
20		* @param Supplier $supplier
21		*
22		* @return array
23		*/
24	1	public function transform(Supplier $supplier)
25		{
26		return [
27	1	'id' => (int)$supplier->id,
		0 ignored issues – show Documentation introduced 2016-03-20 02:32 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Supplier>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
28	1	'name' => (string)$supplier->name,
		0 ignored issues – show Documentation introduced 2016-03-20 02:32 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Supplier>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29	1	'location' => (string)$supplier->location,
		0 ignored issues – show Documentation introduced 2016-03-20 02:32 UTC by Report Bug Copy Issue Report The property `location` does not exist on `object<App\Supplier>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
30		];
31		}
32
33		/**
34		* Includes purchases.
35		*
36		* @param Supplier $supplier
37		*
38		* @return \League\Fractal\Resource\Collection
39		*/
40		public function includePurchases(Supplier $supplier)
41		{
42		return $this->collection($supplier->purchases, new PurchaseTransformer);
		0 ignored issues – show Documentation introduced 2016-03-20 02:32 UTC by Report Bug Copy Issue Report The property `purchases` does not exist on `object<App\Supplier>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-03-20 02:32 UTC by Report Bug Copy Issue Report `new \App\Transformers\PurchaseTransformer()` is of type `object<App\Transformers\PurchaseTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43		}
44		}
45

nikhil-pandey / guitar-shop

GitHub Access Token became invalid

Push — master ( 14aa9d...8c82e7 )

SupplierTransformer A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like