PurchaseTransformer::includeSupplier() - Code Metrics - Inspection of "Merge pull request #5 from nikhil-pandey/analysis-..." - nikhil-pandey/guitar-shop - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 273301...d40dfb )

by Nikhil

created 2016-04-24 04:04 UTC

PurchaseTransformer::includeSupplier() A

↳ Parent: PurchaseTransformer

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace App\Transformers;

use App\Purchase;
use League\Fractal\TransformerAbstract;

class PurchaseTransformer extends TransformerAbstract
{
    /**
     * List of resources possible to include.
     *
     * @var array
     */
    protected $availableIncludes = ['supplier', 'guitars'];

    /**
     * Turn this item object into a generic array.
     *
     * @param Purchase $purchase
     *
     * @return array
     */
    public function transform(Purchase $purchase)
    {
        return [
            'id'          => (int) $purchase->id,
            'supplier_id' => (int) $purchase->supplier_id,
            'quantity'    => (int) $purchase->quantity,
            'price'       => (float) $purchase->price,
            'stored'      => (int) $purchase->stored,
            'sold'        => (int) $purchase->sold,
            'make'        => [
                'id'   => (int) $purchase->make->id,
                'name' => (string) $purchase->make->name,
            ],
            'purchased'   => [
                'timestamp' => $purchase->date_purchased->getTimestamp(),
                'date'      => (string) $purchase->date_purchased->toFormattedDateString(),
                'readable'  => (string) $purchase->date_purchased->diffForHumans(),
            ],
            'delivery'    => [
                'timestamp' => $purchase->delivery_date->getTimestamp(),
                'date'      => (string) $purchase->delivery_date->toFormattedDateString(),
                'readable'  => (string) $purchase->delivery_date->diffForHumans(),
            ],
            'status'      => (string) $purchase->status,
        ];
    }

    /**
     * Include supplier.
     *
     * @param Purchase $purchase
     *
     * @return \League\Fractal\Resource\Collection
     */
    public function includeSupplier(Purchase $purchase)
    {
        return $this->item($purchase->supplier, new SupplierTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Include guitars.
     *
     * @param Purchase $purchase
     *
     * @return \League\Fractal\Resource\Collection
     */
    public function includeGuitars(Purchase $purchase)
    {
        return $this->collection($purchase->guitars, new GuitarTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace App\Transformers;
4
5		use App\Purchase;
6		use League\Fractal\TransformerAbstract;
7
8		class PurchaseTransformer extends TransformerAbstract
9		{
10		/**
11		* List of resources possible to include.
12		*
13		* @var array
14		*/
15		protected $availableIncludes = ['supplier', 'guitars'];
16
17		/**
18		* Turn this item object into a generic array.
19		*
20		* @param Purchase $purchase
21		*
22		* @return array
23		*/
24	1	public function transform(Purchase $purchase)
25		{
26		return [
27	1	'id' => (int) $purchase->id,
28	1	'supplier_id' => (int) $purchase->supplier_id,
29	1	'quantity' => (int) $purchase->quantity,
30	1	'price' => (float) $purchase->price,
31	1	'stored' => (int) $purchase->stored,
32	1	'sold' => (int) $purchase->sold,
33		'make' => [
34	1	'id' => (int) $purchase->make->id,
35	1	'name' => (string) $purchase->make->name,
36	1	],
37		'purchased' => [
38	1	'timestamp' => $purchase->date_purchased->getTimestamp(),
39	1	'date' => (string) $purchase->date_purchased->toFormattedDateString(),
40	1	'readable' => (string) $purchase->date_purchased->diffForHumans(),
41	1	],
42		'delivery' => [
43	1	'timestamp' => $purchase->delivery_date->getTimestamp(),
44	1	'date' => (string) $purchase->delivery_date->toFormattedDateString(),
45	1	'readable' => (string) $purchase->delivery_date->diffForHumans(),
46	1	],
47	1	'status' => (string) $purchase->status,
48	1	];
49		}
50
51		/**
52		* Include supplier.
53		*
54		* @param Purchase $purchase
55		*
56		* @return \League\Fractal\Resource\Collection
57		*/
58		public function includeSupplier(Purchase $purchase)
59		{
60		return $this->item($purchase->supplier, new SupplierTransformer);
		0 ignored issues – show Documentation introduced 2016-03-20 02:32 UTC by Report Bug Copy Issue Report `new \App\Transformers\SupplierTransformer()` is of type `object<App\Transformers\SupplierTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61		}
62
63		/**
64		* Include guitars.
65		*
66		* @param Purchase $purchase
67		*
68		* @return \League\Fractal\Resource\Collection
69		*/
70		public function includeGuitars(Purchase $purchase)
71		{
72		return $this->collection($purchase->guitars, new GuitarTransformer);
		0 ignored issues – show Documentation introduced 2016-03-27 17:05 UTC by Report Bug Copy Issue Report `new \App\Transformers\GuitarTransformer()` is of type `object<App\Transformers\GuitarTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73		}
74		}
75

nikhil-pandey / guitar-shop

GitHub Access Token became invalid

Push — master ( 273301...d40dfb )

PurchaseTransformer::includeSupplier() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like