Conditions | 1 |
Paths | 1 |
Total Lines | 488 |
Code Lines | 447 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
13 | public function run() |
||
14 | { |
||
15 | \DB::table('guitars')->delete(); |
||
16 | |||
17 | \DB::table('guitars')->insert(array( |
||
18 | 0 => |
||
19 | array( |
||
20 | 'id' => 1, |
||
21 | 'purchase_id' => 1, |
||
22 | 'rack_id' => 1, |
||
23 | 'make_id' => 2, |
||
24 | 'model_id' => 5, |
||
25 | 'colour' => 'Red', |
||
26 | 'damaged' => 0, |
||
27 | 'condition' => null, |
||
28 | 'price' => 1500.0, |
||
29 | 'deleted_at' => null, |
||
30 | ), |
||
31 | 1 => |
||
32 | array( |
||
33 | 'id' => 2, |
||
34 | 'purchase_id' => 1, |
||
35 | 'rack_id' => 1, |
||
36 | 'make_id' => 2, |
||
37 | 'model_id' => 4, |
||
38 | 'colour' => 'Black', |
||
39 | 'damaged' => 0, |
||
40 | 'condition' => null, |
||
41 | 'price' => 1500.0, |
||
42 | 'deleted_at' => null, |
||
43 | ), |
||
44 | 2 => |
||
45 | array( |
||
46 | 'id' => 3, |
||
47 | 'purchase_id' => 1, |
||
48 | 'rack_id' => 3, |
||
49 | 'make_id' => 2, |
||
50 | 'model_id' => 3, |
||
51 | 'colour' => 'Black', |
||
52 | 'damaged' => 0, |
||
53 | 'condition' => null, |
||
54 | 'price' => 2000.0, |
||
55 | 'deleted_at' => null, |
||
56 | ), |
||
57 | 3 => |
||
58 | array( |
||
59 | 'id' => 4, |
||
60 | 'purchase_id' => 1, |
||
61 | 'rack_id' => 1, |
||
62 | 'make_id' => 2, |
||
63 | 'model_id' => 2, |
||
64 | 'colour' => 'Red', |
||
65 | 'damaged' => 0, |
||
66 | 'condition' => null, |
||
67 | 'price' => 1000.0, |
||
68 | 'deleted_at' => null, |
||
69 | ), |
||
70 | 4 => |
||
71 | array( |
||
72 | 'id' => 5, |
||
73 | 'purchase_id' => 1, |
||
74 | 'rack_id' => 2, |
||
75 | 'make_id' => 2, |
||
76 | 'model_id' => 5, |
||
77 | 'colour' => 'Black', |
||
78 | 'damaged' => 0, |
||
79 | 'condition' => null, |
||
80 | 'price' => 1500.0, |
||
81 | 'deleted_at' => null, |
||
82 | ), |
||
83 | 5 => |
||
84 | array( |
||
85 | 'id' => 6, |
||
86 | 'purchase_id' => 1, |
||
87 | 'rack_id' => 3, |
||
88 | 'make_id' => 2, |
||
89 | 'model_id' => 1, |
||
90 | 'colour' => 'Black', |
||
91 | 'damaged' => 0, |
||
92 | 'condition' => null, |
||
93 | 'price' => 1500.0, |
||
94 | 'deleted_at' => null, |
||
95 | ), |
||
96 | 6 => |
||
97 | array( |
||
98 | 'id' => 7, |
||
99 | 'purchase_id' => 1, |
||
100 | 'rack_id' => 1, |
||
101 | 'make_id' => 2, |
||
102 | 'model_id' => 3, |
||
103 | 'colour' => 'Black', |
||
104 | 'damaged' => 0, |
||
105 | 'condition' => null, |
||
106 | 'price' => 1500.0, |
||
107 | 'deleted_at' => null, |
||
108 | ), |
||
109 | 7 => |
||
110 | array( |
||
111 | 'id' => 8, |
||
112 | 'purchase_id' => 1, |
||
113 | 'rack_id' => 3, |
||
114 | 'make_id' => 2, |
||
115 | 'model_id' => 1, |
||
116 | 'colour' => 'Purple', |
||
117 | 'damaged' => 0, |
||
118 | 'condition' => null, |
||
119 | 'price' => 3000.0, |
||
120 | 'deleted_at' => null, |
||
121 | ), |
||
122 | 8 => |
||
123 | array( |
||
124 | 'id' => 9, |
||
125 | 'purchase_id' => 1, |
||
126 | 'rack_id' => 1, |
||
127 | 'make_id' => 2, |
||
128 | 'model_id' => 3, |
||
129 | 'colour' => 'Black', |
||
130 | 'damaged' => 0, |
||
131 | 'condition' => null, |
||
132 | 'price' => 2000.0, |
||
133 | 'deleted_at' => null, |
||
134 | ), |
||
135 | 9 => |
||
136 | array( |
||
137 | 'id' => 10, |
||
138 | 'purchase_id' => 1, |
||
139 | 'rack_id' => 3, |
||
140 | 'make_id' => 2, |
||
141 | 'model_id' => 1, |
||
142 | 'colour' => 'Green', |
||
143 | 'damaged' => 0, |
||
144 | 'condition' => null, |
||
145 | 'price' => 2000.0, |
||
146 | 'deleted_at' => null, |
||
147 | ), |
||
148 | 10 => |
||
149 | array( |
||
150 | 'id' => 11, |
||
151 | 'purchase_id' => 3, |
||
152 | 'rack_id' => 1, |
||
153 | 'make_id' => 2, |
||
154 | 'model_id' => 5, |
||
155 | 'colour' => 'Black', |
||
156 | 'damaged' => 0, |
||
157 | 'condition' => null, |
||
158 | 'price' => 1500.0, |
||
159 | 'deleted_at' => null, |
||
160 | ), |
||
161 | 11 => |
||
162 | array( |
||
163 | 'id' => 12, |
||
164 | 'purchase_id' => 3, |
||
165 | 'rack_id' => 3, |
||
166 | 'make_id' => 2, |
||
167 | 'model_id' => 5, |
||
168 | 'colour' => 'Black', |
||
169 | 'damaged' => 0, |
||
170 | 'condition' => null, |
||
171 | 'price' => 2000.0, |
||
172 | 'deleted_at' => null, |
||
173 | ), |
||
174 | 12 => |
||
175 | array( |
||
176 | 'id' => 13, |
||
177 | 'purchase_id' => 3, |
||
178 | 'rack_id' => 1, |
||
179 | 'make_id' => 2, |
||
180 | 'model_id' => 2, |
||
181 | 'colour' => 'Red', |
||
182 | 'damaged' => 1, |
||
183 | 'condition' => 'Broken Strings', |
||
184 | 'price' => 1500.0, |
||
185 | 'deleted_at' => null, |
||
186 | ), |
||
187 | 13 => |
||
188 | array( |
||
189 | 'id' => 14, |
||
190 | 'purchase_id' => 3, |
||
191 | 'rack_id' => 2, |
||
192 | 'make_id' => 2, |
||
193 | 'model_id' => 3, |
||
194 | 'colour' => 'Red', |
||
195 | 'damaged' => 0, |
||
196 | 'condition' => null, |
||
197 | 'price' => 2000.0, |
||
198 | 'deleted_at' => null, |
||
199 | ), |
||
200 | 14 => |
||
201 | array( |
||
202 | 'id' => 15, |
||
203 | 'purchase_id' => 3, |
||
204 | 'rack_id' => 1, |
||
205 | 'make_id' => 2, |
||
206 | 'model_id' => 3, |
||
207 | 'colour' => 'Black', |
||
208 | 'damaged' => 0, |
||
209 | 'condition' => null, |
||
210 | 'price' => 2000.0, |
||
211 | 'deleted_at' => null, |
||
212 | ), |
||
213 | 15 => |
||
214 | array( |
||
215 | 'id' => 16, |
||
216 | 'purchase_id' => 3, |
||
217 | 'rack_id' => 1, |
||
218 | 'make_id' => 2, |
||
219 | 'model_id' => 4, |
||
220 | 'colour' => 'Black', |
||
221 | 'damaged' => 0, |
||
222 | 'condition' => null, |
||
223 | 'price' => 1200.0, |
||
224 | 'deleted_at' => null, |
||
225 | ), |
||
226 | 16 => |
||
227 | array( |
||
228 | 'id' => 17, |
||
229 | 'purchase_id' => 3, |
||
230 | 'rack_id' => 1, |
||
231 | 'make_id' => 2, |
||
232 | 'model_id' => 4, |
||
233 | 'colour' => 'Black', |
||
234 | 'damaged' => 0, |
||
235 | 'condition' => null, |
||
236 | 'price' => 2000.0, |
||
237 | 'deleted_at' => null, |
||
238 | ), |
||
239 | 17 => |
||
240 | array( |
||
241 | 'id' => 18, |
||
242 | 'purchase_id' => 3, |
||
243 | 'rack_id' => 1, |
||
244 | 'make_id' => 2, |
||
245 | 'model_id' => 3, |
||
246 | 'colour' => 'Black', |
||
247 | 'damaged' => 0, |
||
248 | 'condition' => null, |
||
249 | 'price' => 1200.0, |
||
250 | 'deleted_at' => null, |
||
251 | ), |
||
252 | 18 => |
||
253 | array( |
||
254 | 'id' => 19, |
||
255 | 'purchase_id' => 3, |
||
256 | 'rack_id' => 2, |
||
257 | 'make_id' => 2, |
||
258 | 'model_id' => 4, |
||
259 | 'colour' => 'Black', |
||
260 | 'damaged' => 0, |
||
261 | 'condition' => null, |
||
262 | 'price' => 1200.0, |
||
263 | 'deleted_at' => null, |
||
264 | ), |
||
265 | 19 => |
||
266 | array( |
||
267 | 'id' => 20, |
||
268 | 'purchase_id' => 3, |
||
269 | 'rack_id' => 3, |
||
270 | 'make_id' => 2, |
||
271 | 'model_id' => 1, |
||
272 | 'colour' => 'Black', |
||
273 | 'damaged' => 0, |
||
274 | 'condition' => null, |
||
275 | 'price' => 5000.0, |
||
276 | 'deleted_at' => null, |
||
277 | ), |
||
278 | 20 => |
||
279 | array( |
||
280 | 'id' => 21, |
||
281 | 'purchase_id' => 4, |
||
282 | 'rack_id' => 4, |
||
283 | 'make_id' => 1, |
||
284 | 'model_id' => 10, |
||
285 | 'colour' => 'Black', |
||
286 | 'damaged' => 0, |
||
287 | 'condition' => null, |
||
288 | 'price' => 1000.0, |
||
289 | 'deleted_at' => null, |
||
290 | ), |
||
291 | 21 => |
||
292 | array( |
||
293 | 'id' => 22, |
||
294 | 'purchase_id' => 4, |
||
295 | 'rack_id' => 5, |
||
296 | 'make_id' => 1, |
||
297 | 'model_id' => 10, |
||
298 | 'colour' => 'Red', |
||
299 | 'damaged' => 0, |
||
300 | 'condition' => null, |
||
301 | 'price' => 1000.0, |
||
302 | 'deleted_at' => null, |
||
303 | ), |
||
304 | 22 => |
||
305 | array( |
||
306 | 'id' => 23, |
||
307 | 'purchase_id' => 4, |
||
308 | 'rack_id' => 6, |
||
309 | 'make_id' => 1, |
||
310 | 'model_id' => 9, |
||
311 | 'colour' => 'Black', |
||
312 | 'damaged' => 0, |
||
313 | 'condition' => null, |
||
314 | 'price' => 1200.0, |
||
315 | 'deleted_at' => null, |
||
316 | ), |
||
317 | 23 => |
||
318 | array( |
||
319 | 'id' => 24, |
||
320 | 'purchase_id' => 4, |
||
321 | 'rack_id' => 5, |
||
322 | 'make_id' => 1, |
||
323 | 'model_id' => 10, |
||
324 | 'colour' => 'Black', |
||
325 | 'damaged' => 0, |
||
326 | 'condition' => null, |
||
327 | 'price' => 1200.0, |
||
328 | 'deleted_at' => null, |
||
329 | ), |
||
330 | 24 => |
||
331 | array( |
||
332 | 'id' => 25, |
||
333 | 'purchase_id' => 4, |
||
334 | 'rack_id' => 4, |
||
335 | 'make_id' => 1, |
||
336 | 'model_id' => 9, |
||
337 | 'colour' => 'Red', |
||
338 | 'damaged' => 0, |
||
339 | 'condition' => null, |
||
340 | 'price' => 2000.0, |
||
341 | 'deleted_at' => null, |
||
342 | ), |
||
343 | 25 => |
||
344 | array( |
||
345 | 'id' => 26, |
||
346 | 'purchase_id' => 4, |
||
347 | 'rack_id' => 5, |
||
348 | 'make_id' => 1, |
||
349 | 'model_id' => 10, |
||
350 | 'colour' => 'Black', |
||
351 | 'damaged' => 0, |
||
352 | 'condition' => null, |
||
353 | 'price' => 1000.0, |
||
354 | 'deleted_at' => null, |
||
355 | ), |
||
356 | 26 => |
||
357 | array( |
||
358 | 'id' => 27, |
||
359 | 'purchase_id' => 4, |
||
360 | 'rack_id' => 4, |
||
361 | 'make_id' => 1, |
||
362 | 'model_id' => 9, |
||
363 | 'colour' => 'Black', |
||
364 | 'damaged' => 0, |
||
365 | 'condition' => null, |
||
366 | 'price' => 1200.0, |
||
367 | 'deleted_at' => null, |
||
368 | ), |
||
369 | 27 => |
||
370 | array( |
||
371 | 'id' => 28, |
||
372 | 'purchase_id' => 4, |
||
373 | 'rack_id' => 6, |
||
374 | 'make_id' => 1, |
||
375 | 'model_id' => 10, |
||
376 | 'colour' => 'Black', |
||
377 | 'damaged' => 0, |
||
378 | 'condition' => null, |
||
379 | 'price' => 1200.0, |
||
380 | 'deleted_at' => null, |
||
381 | ), |
||
382 | 28 => |
||
383 | array( |
||
384 | 'id' => 29, |
||
385 | 'purchase_id' => 4, |
||
386 | 'rack_id' => 6, |
||
387 | 'make_id' => 1, |
||
388 | 'model_id' => 9, |
||
389 | 'colour' => 'Black', |
||
390 | 'damaged' => 0, |
||
391 | 'condition' => null, |
||
392 | 'price' => 4000.0, |
||
393 | 'deleted_at' => null, |
||
394 | ), |
||
395 | 29 => |
||
396 | array( |
||
397 | 'id' => 30, |
||
398 | 'purchase_id' => 4, |
||
399 | 'rack_id' => 5, |
||
400 | 'make_id' => 1, |
||
401 | 'model_id' => 9, |
||
402 | 'colour' => 'Black', |
||
403 | 'damaged' => 0, |
||
404 | 'condition' => null, |
||
405 | 'price' => 3000.0, |
||
406 | 'deleted_at' => null, |
||
407 | ), |
||
408 | 30 => |
||
409 | array( |
||
410 | 'id' => 31, |
||
411 | 'purchase_id' => 4, |
||
412 | 'rack_id' => 5, |
||
413 | 'make_id' => 1, |
||
414 | 'model_id' => 9, |
||
415 | 'colour' => 'Red', |
||
416 | 'damaged' => 0, |
||
417 | 'condition' => null, |
||
418 | 'price' => 1000.0, |
||
419 | 'deleted_at' => null, |
||
420 | ), |
||
421 | 31 => |
||
422 | array( |
||
423 | 'id' => 32, |
||
424 | 'purchase_id' => 4, |
||
425 | 'rack_id' => 5, |
||
426 | 'make_id' => 1, |
||
427 | 'model_id' => 9, |
||
428 | 'colour' => 'Black', |
||
429 | 'damaged' => 0, |
||
430 | 'condition' => null, |
||
431 | 'price' => 1000.0, |
||
432 | 'deleted_at' => null, |
||
433 | ), |
||
434 | 32 => |
||
435 | array( |
||
436 | 'id' => 33, |
||
437 | 'purchase_id' => 4, |
||
438 | 'rack_id' => 6, |
||
439 | 'make_id' => 1, |
||
440 | 'model_id' => 9, |
||
441 | 'colour' => 'Black', |
||
442 | 'damaged' => 0, |
||
443 | 'condition' => null, |
||
444 | 'price' => 1000.0, |
||
445 | 'deleted_at' => null, |
||
446 | ), |
||
447 | 33 => |
||
448 | array( |
||
449 | 'id' => 34, |
||
450 | 'purchase_id' => 4, |
||
451 | 'rack_id' => 5, |
||
452 | 'make_id' => 1, |
||
453 | 'model_id' => 7, |
||
454 | 'colour' => 'Black', |
||
455 | 'damaged' => 0, |
||
456 | 'condition' => null, |
||
457 | 'price' => 1000.0, |
||
458 | 'deleted_at' => null, |
||
459 | ), |
||
460 | 34 => |
||
461 | array( |
||
462 | 'id' => 35, |
||
463 | 'purchase_id' => 4, |
||
464 | 'rack_id' => 6, |
||
465 | 'make_id' => 1, |
||
466 | 'model_id' => 9, |
||
467 | 'colour' => 'Black', |
||
468 | 'damaged' => 0, |
||
469 | 'condition' => null, |
||
470 | 'price' => 2000.0, |
||
471 | 'deleted_at' => null, |
||
472 | ), |
||
473 | 35 => |
||
474 | array( |
||
475 | 'id' => 36, |
||
476 | 'purchase_id' => 4, |
||
477 | 'rack_id' => 4, |
||
478 | 'make_id' => 1, |
||
479 | 'model_id' => 9, |
||
480 | 'colour' => 'Black', |
||
481 | 'damaged' => 0, |
||
482 | 'condition' => null, |
||
483 | 'price' => 1000.0, |
||
484 | 'deleted_at' => null, |
||
485 | ), |
||
486 | 36 => |
||
487 | array( |
||
488 | 'id' => 37, |
||
489 | 'purchase_id' => 4, |
||
490 | 'rack_id' => 4, |
||
491 | 'make_id' => 1, |
||
492 | 'model_id' => 9, |
||
493 | 'colour' => 'Black', |
||
494 | 'damaged' => 1, |
||
495 | 'condition' => 'Minor Scratches', |
||
496 | 'price' => 2000.0, |
||
497 | 'deleted_at' => null, |
||
498 | ), |
||
499 | )); |
||
500 | } |
||
501 | } |
||
502 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.