App\Http\Controllers\PurchaseController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

83.33%

Importance

Changes	5
Bugs	1	Features	3

7 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	8	1
A	__construct()	0	4	1
A	index()	0	4	1
A	show()	0	6	1
A	destroy()	0	6	1
A	rules()	0	18	2
A	getSupplier()	0	13	3

<?php

namespace App\Http\Controllers;

use App\Events\PurchaseWasCreated;
use App\Events\PurchaseWasDeleted;
use App\Events\SupplierWasCreated;
use App\Purchase;
use App\Supplier;
use Illuminate\Http\Request;

class PurchaseController extends Controller
{
    /**
     * PurchaseController constructor.
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        return view('purchases.index');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     */
    public function store(Request $request)
    {
        $this->validate($request, $this->rules($request->input('supplier_id')));
        $purchase = $this->getSupplier($request)->makePurchase(
            $request->only(['id', 'make_id', 'quantity', 'price', 'date_purchased', 'delivery_date'])
        );
        event(new PurchaseWasCreated($purchase));
    }

    /**
     * Show the specified resource.
     *
     * @param $id
     *
     * @return mixed
     */
    public function show($id)
    {
        $purchase = Purchase::findOrFail($id);

        return view('purchases.show')->withPurchase($purchase);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     */
    public function destroy($id)
    {
        $purchase = Purchase::findOrFail($id);
        $purchase->delete();
        event(new PurchaseWasDeleted($purchase));

The call to PurchaseWasDeleted::__construct() has too many arguments starting with $purchase.

    }

    /**
     * Rules for validation depending whether or not supplier has been provided.
     *
     * @param $supplierId
     *
     * @return array
     */
    private function rules($supplierId)
    {
        $rules = [
            'id'                => 'integer|min:1|unique:suppliers,id',
            'make_id'           => 'required|exists:makes,id',
            'quantity'          => 'required|integer|min:1',
            'price'             => 'required|numeric|min:1',
            'date_purchased'    => 'required|date_format:Y-m-d|before:tomorrow',
            'delivery_date'     => 'required|date_format:Y-m-d|after:date_purchased',
            'supplier.name'     => 'required_if:supplier_id,new|string|max:255',
            'supplier.location' => 'required_if:supplier_id,new|string|max:255'
        ];
        if ($supplierId != 'new') {
            $rules += ['supplier_id' => 'required|integer|exists:suppliers,id'];
        }

        return $rules;
    }

    /**
     * Get the supplier depending on the request.
     *
     * @param $request
     *
     * @return Supplier
     */
    private function getSupplier($request)
    {
        $supplier = Supplier::find($request->input('supplier_id')) ?: Supplier::create([
            'name'     => $request->input('supplier.name'),
            'location' => $request->input('supplier.location'),
        ]);

        if ($supplier->wasRecentlyCreated) {
            event(new SupplierWasCreated($supplier));

The call to SupplierWasCreated::__construct() has too many arguments starting with $supplier.

        }

        return $supplier;
    }
}