SaleTransformer::transform() - Code Metrics - nikhil-pandey/guitar-shop - Measure and Improve Code Quality continuously with Scrutinizer

SaleTransformer::transform() A
last analyzed 2016-04-24 04:31 UTC

↳ Parent: SaleTransformer

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
ccs	0
cts	18
cp	0
rs	9.4285
cc	1
eloc	13
nc	1
nop	1
crap	2

<?php

namespace App\Transformers;

use App\Sale;
use League\Fractal\TransformerAbstract;

class SaleTransformer extends TransformerAbstract
{
    /**
     * Turn this item object into a generic array.
     *
     * @param Sale $sale
     *
     * @return array
     */
    public function transform(Sale $sale)
    {
        return [
            'id'      => $sale->id,
            'name'    => $sale->name,
            'address' => $sale->address,
            'isShop'  => is_null($this->shop_id),
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'make'    => [
                'id'   => $sale->make->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'name' => $sale->make->name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ],
            'bought'  => [
                'timestamp' => $sale->created_at->getTimestamp(),
                'date'      => $sale->created_at->toFormattedDateString(),
                'readable'  => $sale->created_at->diffForHumans(),
            ],
        ];
    }
}


1			<?php
2
3			namespace App\Transformers;
4
5			use App\Sale;
6			use League\Fractal\TransformerAbstract;
7
8			class SaleTransformer extends TransformerAbstract
9			{
10			/**
11			* Turn this item object into a generic array.
12			*
13			* @param Sale $sale
14			*
15			* @return array
16			*/
17			public function transform(Sale $sale)
18			{
19			return [
20			'id' => $sale->id,
21			'name' => $sale->name,
22			'address' => $sale->address,
23			'isShop' => is_null($this->shop_id),
			0 ignored issues – show Bug introduced 2016-03-20 02:32 UTC by Report Bug Copy Issue Report The property `shop_id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			'make' => [
25			'id' => $sale->make->id,
			0 ignored issues – show Documentation introduced 2016-03-20 02:32 UTC by Report Bug Copy Issue Report The property `make` does not exist on `object<App\Sale>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
26			'name' => $sale->make->name,
			0 ignored issues – show Documentation introduced 2016-03-20 02:32 UTC by Report Bug Copy Issue Report The property `make` does not exist on `object<App\Sale>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
27			],
28			'bought' => [
29			'timestamp' => $sale->created_at->getTimestamp(),
30			'date' => $sale->created_at->toFormattedDateString(),
31			'readable' => $sale->created_at->diffForHumans(),
32			],
33			];
34			}
35			}
36

nikhil-pandey / guitar-shop

GitHub Access Token became invalid

SaleTransformer::transform() A last analyzed 2016-04-24 04:31 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

SaleTransformer::transform() A
last analyzed 2016-04-24 04:31 UTC