It seems like $loaders can also be of type iterable. However, the property $loaders is declared as type Nijens\OpenapiBundle\Json\Loader\LoaderInterface[]. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
Loading history...
39
}
40
41
/**
42
* {@inheritdoc}
43
*/
44
public function supports(string $file): bool
45
{
46
foreach ($this->loaders as $loader) {
47
if ($loader->supports($file)) {
48
return true;
49
}
50
}
51
52
return false;
53
}
54
55
/**
56
* {@inheritdoc}
57
*/
58
public function load(string $file): stdClass
59
{
60
foreach ($this->loaders as $loader) {
61
if ($loader->supports($file)) {
62
return $loader->load($file);
63
}
64
}
65
66
throw new LoaderLoadException(sprintf('No loader available to load "%s".', $file));
nijens /
openapi-bundle
Niels Nijens
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.