Imei::__construct() - Code Metrics - Inspection of "new imei value object" - nicolopignatelli/valueobjects - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#70)

unknown

created 2016-09-19 07:00 UTC

Imei::__construct() A

↳ Parent: Imei

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	1

<?php

namespace ValueObjects\Identity;

use ValueObjects\Exception\InvalidNativeArgumentException;
use ValueObjects\Number\Natural;

class Imei extends Natural
{
    /**
     * Returns an Imei number
     *
     * @param int $value
     */
    public function __construct($value)
    {
        $options = array(
            'options' => array(
                'min_range' => 100000000000000,
                'max_range' => 999999999999999
            )
        );

        $value = filter_var($value, FILTER_VALIDATE_INT, $options);

        if (false === $value) {
            throw new InvalidNativeArgumentException($value, array('int (15 digits)'));
        }

        $value = $this->validateLuhnAlgorithm($value);

        $this->value = $value;
    }

    /**
     * Checks the validity of the Imei using the Luhn algorithm
     *
     * @param int $value
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return int
     * @throws \ValueObjects\Exception\InvalidNativeArgumentException
     */
    private function validateLuhnAlgorithm($imei)
    {
        $str = '';

        foreach (str_split(strrev((string) $imei)) as $i => $d) {
            $str .= $i %2 !== 0 ? $d * 2 : $d;
        }

        if (array_sum(str_split($str)) % 10 !== 0) {
            throw new InvalidNativeArgumentException($imei, array('int (valid Imei code)'));
        }

        return $imei;
    }
}


1			<?php
2
3			namespace ValueObjects\Identity;
4
5			use ValueObjects\Exception\InvalidNativeArgumentException;
6			use ValueObjects\Number\Natural;
7
8			class Imei extends Natural
9			{
10			/**
11			* Returns an Imei number
12			*
13			* @param int $value
14			*/
15			public function __construct($value)
16			{
17			$options = array(
18			'options' => array(
19			'min_range' => 100000000000000,
20			'max_range' => 999999999999999
21			)
22			);
23
24			$value = filter_var($value, FILTER_VALIDATE_INT, $options);
25
26			if (false === $value) {
27			throw new InvalidNativeArgumentException($value, array('int (15 digits)'));
28			}
29
30			$value = $this->validateLuhnAlgorithm($value);
31
32			$this->value = $value;
33			}
34
35			/**
36			* Checks the validity of the Imei using the Luhn algorithm
37			*
38			* @param int $value
			0 ignored issues – show Bug introduced 2016-09-19 07:08 UTC by Report Bug Copy Issue Report There is no parameter named `$value`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
39			* @return int
40			* @throws \ValueObjects\Exception\InvalidNativeArgumentException
41			*/
42			private function validateLuhnAlgorithm($imei)
43			{
44			$str = '';
45
46			foreach (str_split(strrev((string) $imei)) as $i => $d) {
47			$str .= $i %2 !== 0 ? $d * 2 : $d;
48			}
49
50			if (array_sum(str_split($str)) % 10 !== 0) {
51			throw new InvalidNativeArgumentException($imei, array('int (valid Imei code)'));
52			}
53
54			return $imei;
55			}
56			}
57

nicolopignatelli / valueobjects

Pull Request — master (#70)

Imei::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like