ValueObjects\Structure\KeyValuePair

Complexity

Total Complexity

10

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

92.31%

Importance

Changes	6
Bugs	1	Features	2

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getKey()	0	4	1
A	getValue()	0	4	1
A	fromNative()	0	15	2
A	__construct()	0	5	1
A	sameValueAs()	0	8	3
A	__toString()	0	6	1
A	jsonSerialize()	0	4	1

<?php

namespace ValueObjects\Structure;

use ValueObjects\StringLiteral\StringLiteral;
use ValueObjects\Util\Util;
use ValueObjects\ValueObjectInterface;

class KeyValuePair implements ValueObjectInterface
{
    /** @var ValueObjectInterface */
    protected $key;

    /** @var ValueObjectInterface */
    protected $value;

    /**
     * Returns a KeyValuePair from native PHP arguments evaluated as strings
     *
     * @param string $key

There is no parameter named $key. Was it maybe removed?

     * @param string $value

There is no parameter named $value. Was it maybe removed?

     * @return self
     * @throws \InvalidArgumentException
     */
    public static function fromNative()
    {
        $args = func_get_args();

        if (count($args) != 2) {
            throw new \BadMethodCallException('This methods expects two arguments. One for the key and one for the value.');
        }

        $keyString   = \strval($args[0]);
        $valueString = \strval($args[1]);
        $key   = new StringLiteral($keyString);
        $value = new StringLiteral($valueString);

        return new self($key, $value);
    }

    /**
     * Returns a KeyValuePair
     *
     * @param ValueObjectInterface $key
     * @param ValueObjectInterface $value
     */
    public function __construct(ValueObjectInterface $key, ValueObjectInterface $value)
    {
        $this->key   = $key;
        $this->value = $value;
    }

    /**
     * Tells whether two KeyValuePair are equal
     *
     * @param  ValueObjectInterface $keyValuePair
     * @return bool
     */
    public function sameValueAs(ValueObjectInterface $keyValuePair)
    {
        if (false === Util::classEquals($this, $keyValuePair)) {
            return false;
        }

        return $this->getKey()->sameValueAs($keyValuePair->getKey()) && $this->getValue()->sameValueAs($keyValuePair->getValue());

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getKey() does only exist in the following implementations of said interface: ValueObjects\Structure\KeyValuePair.

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getValue() does only exist in the following implementations of said interface: ValueObjects\DateTime\Month, ValueObjects\DateTime\WeekDay, ValueObjects\Enum\Enum, ValueObjects\Geography\Continent, ValueObjects\Geography\CountryCode, ValueObjects\Geography\DistanceFormula, ValueObjects\Geography\DistanceUnit, ValueObjects\Geography\Ellipsoid, ValueObjects\Money\CurrencyCode, ValueObjects\Number\RoundingMode, ValueObjects\Person\Gender, ValueObjects\Structure\KeyValuePair, ValueObjects\Web\IPAddressVersion.

    }

    /**
     * Returns key
     *
     * @return ValueObjectInterface
     */
    public function getKey()
    {
        return clone $this->key;
    }

    /**
     * Returns value
     *
     * @return ValueObjectInterface
     */
    public function getValue()
    {
        return clone $this->value;
    }

    /**
     * Returns a string representation of the KeyValuePair in format "$key => $value"
     *
     * @return string
     */
    public function __toString()
    {
        $string = sprintf('%s => %s', $this->getKey(), $this->getValue());

        return $string;
    }

    function jsonSerialize()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for jsonSerialize.

    {
        return [$this->getKey(), $this->getValue()];
    }


}