ValueObjects\Person\Name

Complexity

Total Complexity

12

Size/Duplication

Total Lines	141
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

85.29%

Importance

Changes	9
Bugs	2	Features	3

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getFirstName()	0	4	1
A	getMiddleName()	0	4	1
A	getLastName()	0	4	1
A	__toString()	0	4	1
A	fromNative()	0	10	1
A	__construct()	0	6	1
A	getFullName()	0	10	3
A	sameValueAs()	0	8	2
A	jsonSerialize()	0	11	1

<?php

namespace ValueObjects\Person;

use ValueObjects\StringLiteral\StringLiteral;
use ValueObjects\Util\Util;
use ValueObjects\ValueObjectInterface;

class Name implements ValueObjectInterface
{
    /**
     * First name
     *
     * @var \ValueObjects\StringLiteral\StringLiteral
     */
    private $firstName;

    /**
     * Middle name
     *
     * @var \ValueObjects\StringLiteral\StringLiteral
     */
    private $middleName;

    /**
     * Last name
     *
     * @var \ValueObjects\StringLiteral\StringLiteral
     */
    private $lastName;

    /**
     * Returns a Name objects form PHP native values
     *
     * @param  string $first_name

There is no parameter named $first_name. Was it maybe removed?

     * @param  string $middle_name

There is no parameter named $middle_name. Was it maybe removed?

     * @param  string $last_name

There is no parameter named $last_name. Was it maybe removed?

     * @return Name
     */
    public static function fromNative()
    {
        $args = func_get_args();

        $firstName  = new StringLiteral($args[0]);
        $middleName = new StringLiteral($args[1]);
        $lastName   = new StringLiteral($args[2]);

        return new self($firstName, $middleName, $lastName);
    }

    /**
     * Returns a Name object
     *
     * @param String $first_name
     * @param String $middle_name
     * @param String $last_name
     */
    public function __construct(StringLiteral $first_name, StringLiteral $middle_name, StringLiteral $last_name)
    {
        $this->firstName  = $first_name;
        $this->middleName = $middle_name;
        $this->lastName   = $last_name;
    }

    /**
     * Returns the first name
     *
     * @return String
     */
    public function getFirstName()
    {
        return $this->firstName;
    }

    /**
     * Returns the middle name
     *
     * @return String
     */
    public function getMiddleName()
    {
        return $this->middleName;
    }

    /**
     * Returns the last name
     *
     * @return String
     */
    public function getLastName()
    {
        return $this->lastName;
    }

    /**
     * Returns the full name
     *
     * @return String
     */
    public function getFullName()
    {
        $fullNameString = $this->firstName .
            ($this->middleName->isEmpty() ? '' : ' ' . $this->middleName) .
            ($this->lastName->isEmpty() ? '' : ' ' . $this->lastName);

        $fullName = new StringLiteral($fullNameString);

        return $fullName;
    }

    /**
     * Tells whether two names are equal by comparing their values
     *
     * @param  ValueObjectInterface $name
     * @return bool
     */
    public function sameValueAs(ValueObjectInterface $name)
    {
        if (false === Util::classEquals($this, $name)) {
            return false;
        }

        return $this->getFullName() == $name->getFullName();

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getFullName() does only exist in the following implementations of said interface: ValueObjects\Person\Name.

    }

    /**
     * Returns the full name
     *
     * @return string
     */
    public function __toString()
    {
        return \strval($this->getFullName());
    }

    function jsonSerialize()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for jsonSerialize.

    {
        return [
            'parts' => [
                'first' => $this->getFirstName(),
                'middle' => $this->getMiddleName(),
                'last' => $this->getLastName()
            ],
            'full' => (string) $this
        ];
    }


}