ValueObjects\DateTime\DateTime

Complexity

Total Complexity

13

Size/Duplication

Total Lines	145
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	9

Test Coverage

Coverage

95.12%

Importance

Changes	13
Bugs	5	Features	3

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getDate()	0	4	1
A	getTime()	0	4	1
A	__toString()	0	4	1
A	fromNative()	0	9	1
A	fromNativeDateTime()	0	7	1
A	now()	0	6	1
A	sameValueAs()	0	8	3
A	toNativeDateTime()	0	15	1
A	__construct()	0	10	2
A	jsonSerialize()	0	4	1

<?php

namespace ValueObjects\DateTime;

use ValueObjects\Util\Util;
use ValueObjects\ValueObjectInterface;

class DateTime implements ValueObjectInterface
{
    /** @var Date */
    protected $date;

    /** @var Time */
    protected $time;

    /**
     * Returns a new DateTime object from native values
     *
     * @param  int      $year

There is no parameter named $year. Was it maybe removed?

     * @param  string   $month

There is no parameter named $month. Was it maybe removed?

     * @param  int      $day

There is no parameter named $day. Was it maybe removed?

     * @param  int      $hour

There is no parameter named $hour. Was it maybe removed?

     * @param  int      $minute

There is no parameter named $minute. Was it maybe removed?

     * @param  int      $second

There is no parameter named $second. Was it maybe removed?

     * @return DateTime
     */
    public static function fromNative()
    {
        $args = func_get_args();

        $date = Date::fromNative($args[0], $args[1], $args[2]);
        $time = Time::fromNative($args[3], $args[4], $args[5]);

        return new static($date, $time);
    }

    /**
     * Returns a new DateTime from a native PHP \DateTime
     *
     * @param  \DateTime $date_time
     * @return DateTime
     */
    public static function fromNativeDateTime(\DateTime $date_time)
    {
        $date = Date::fromNativeDateTime($date_time);
        $time = Time::fromNativeDateTime($date_time);

        return new static($date, $time);
    }

    /**
     * Returns current DateTime
     *
     * @return DateTime
     */
    public static function now()
    {
        $dateTime = new static(Date::now(), Time::now());

        return $dateTime;
    }

    /**
     * Returns a new DateTime object
     *
     * @param Date $date
     * @param Time $time
     */
    public function __construct(Date $date, Time $time = null)
    {
        $this->date = $date;

        if (null === $time) {
            $time = Time::zero();
        }

        $this->time = $time;
    }

    /**
     * Tells whether two DateTime are equal by comparing their values
     *
     * @param  ValueObjectInterface $date_time
     * @return bool
     */
    public function sameValueAs(ValueObjectInterface $date_time)
    {
        if (false === Util::classEquals($this, $date_time)) {
            return false;
        }

        return $this->getDate()->sameValueAs($date_time->getDate()) && $this->getTime()->sameValueAs($date_time->getTime());

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getDate() does only exist in the following implementations of said interface: ValueObjects\DateTime\DateTime.

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getTime() does only exist in the following implementations of said interface: ValueObjects\DateTime\DateTime.

    }

    /**
     * Returns date from current DateTime
     *
     * @return Date
     */
    public function getDate()
    {
        return clone $this->date;
    }

    /**
     * Returns time from current DateTime
     *
     * @return Time
     */
    public function getTime()
    {
        return clone $this->time;
    }

    /**
     * Returns a native PHP \DateTime version of the current DateTime.
     *
     * @return \DateTime
     */
    public function toNativeDateTime()
    {
        $year   = $this->getDate()->getYear()->toNative();
        $month  = $this->getDate()->getMonth()->getNumericValue();
        $day    = $this->getDate()->getDay()->toNative();
        $hour   = $this->getTime()->getHour()->toNative();
        $minute = $this->getTime()->getMinute()->toNative();
        $second = $this->getTime()->getSecond()->toNative();

        $dateTime = new \DateTime();
        $dateTime->setDate($year, $month, $day);
        $dateTime->setTime($hour, $minute, $second);

        return $dateTime;
    }

    /**
     * Returns DateTime as string in format "Y-n-j G:i:s"
     *
     * @return string
     */
    public function __toString()
    {
        return \sprintf('%s %s', $this->getDate(), $this->getTime());
    }

    function jsonSerialize()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for jsonSerialize.

    {
        return $this->toNativeDateTime();
    }


}