ValueObjects\Web\Url

Complexity

Total Complexity

29

Size/Duplication

Total Lines	225
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Test Coverage

Coverage

86.25%

Importance

Changes	9
Bugs	2	Features	3

13 Methods

Rating	Name	Duplication	Size	Complexity
A	getDomain()	0	4	1
A	getFragmentIdentifier()	0	4	1
A	getPassword()	0	4	1
A	getPath()	0	4	1
A	getPort()	0	4	1
A	getQueryString()	0	4	1
A	getScheme()	0	4	1
A	getUser()	0	4	1
A	__toString()	0	20	4
B	fromNative()	0	22	6
A	__construct()	0	11	1
B	sameValueAs()	0	16	9
A	jsonSerialize()	0	14	1

<?php

namespace ValueObjects\Web;

use ValueObjects\StringLiteral\StringLiteral;
use ValueObjects\Util\Util;
use ValueObjects\ValueObjectInterface;

class Url implements ValueObjectInterface
{
    /** @var SchemeName */
    protected $scheme;

    /** @var StringLiteral */
    protected $user;

    /** @var StringLiteral */
    protected $password;

    /** @var Domain */
    protected $domain;

    /** @var Path */
    protected $path;

    /** @var PortNumber */
    protected $port;

    /** @var QueryString */
    protected $queryString;

    /** @var FragmentIdentifier */
    protected $fragmentIdentifier;

    /**
     * Returns a new Url object from a native url string
     *
     * @param $url_string
     * @return Url
     */
    public static function fromNative()
    {
        $urlString = \func_get_arg(0);

        $user        = \parse_url($urlString, PHP_URL_USER);
        $pass        = \parse_url($urlString, PHP_URL_PASS);
        $host        = \parse_url($urlString, PHP_URL_HOST);
        $queryString = \parse_url($urlString, PHP_URL_QUERY);
        $fragmentId  = \parse_url($urlString, PHP_URL_FRAGMENT);
        $port        = \parse_url($urlString, PHP_URL_PORT);

        $scheme     = new SchemeName(\parse_url($urlString, PHP_URL_SCHEME));

It seems like \parse_url($urlString, PHP_URL_SCHEME) targeting parse_url() can also be of type false; however, ValueObjects\Web\SchemeName::__construct() does only seem to accept string, did you maybe forget to handle an error condition?

        $user       = $user ? new StringLiteral($user) : new StringLiteral('');
        $pass       = $pass ? new StringLiteral($pass) : new StringLiteral('');
        $domain     = Domain::specifyType($host);
        $path       = new Path(\parse_url($urlString, PHP_URL_PATH));
        $portNumber = $port ? new PortNumber($port) : new NullPortNumber();
        $query      = $queryString ? new QueryString(\sprintf('?%s', $queryString)) : new NullQueryString();
        $fragment   = $fragmentId ? new FragmentIdentifier(\sprintf('#%s', $fragmentId)) : new NullFragmentIdentifier();

        return new self($scheme, $user, $pass, $domain, $portNumber, $path, $query, $fragment);
    }

    /**
     * Returns a new Url object
     *
     * @param SchemeName          $scheme
     * @param String              $user
     * @param String              $password
     * @param Domain              $domain
     * @param Path                $path
     * @param PortNumberInterface $port
     * @param QueryString         $query
     * @param FragmentIdentifier  $fragment
     */
    public function __construct(SchemeName $scheme, StringLiteral $user, StringLiteral $password, Domain $domain, PortNumberInterface $port, Path $path, QueryString $query, FragmentIdentifier $fragment)
    {
        $this->scheme             = $scheme;
        $this->user               = $user;
        $this->password           = $password;
        $this->domain             = $domain;
        $this->path               = $path;
        $this->port               = $port;

$port is of type object<ValueObjects\Web\PortNumberInterface>, but the property $port was declared to be of type object<ValueObjects\Web\PortNumber>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->queryString        = $query;
        $this->fragmentIdentifier = $fragment;
    }

    /**
     * Tells whether two Url are sameValueAs by comparing their components
     *
     * @param  ValueObjectInterface $url
     * @return bool
     */
    public function sameValueAs(ValueObjectInterface $url)
    {
        if (false === Util::classEquals($this, $url)) {
            return false;
        }

        return $this->getScheme()->sameValueAs($url->getScheme()) &&

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getScheme() does only exist in the following implementations of said interface: ValueObjects\Web\Url.

               $this->getUser()->sameValueAs($url->getUser()) &&

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getUser() does only exist in the following implementations of said interface: ValueObjects\Web\Url.

               $this->getPassword()->sameValueAs($url->getPassword()) &&

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getPassword() does only exist in the following implementations of said interface: ValueObjects\Web\Url.

               $this->getDomain()->sameValueAs($url->getDomain()) &&

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getDomain() does only exist in the following implementations of said interface: ValueObjects\Web\Url.

               $this->getPath()->sameValueAs($url->getPath()) &&

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getPath() does only exist in the following implementations of said interface: ValueObjects\Web\Url.

               $this->getPort()->sameValueAs($url->getPort()) &&

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getPort() does only exist in the following implementations of said interface: ValueObjects\Web\Url.

               $this->getQueryString()->sameValueAs($url->getQueryString()) &&

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getQueryString() does only exist in the following implementations of said interface: ValueObjects\Web\Url.

               $this->getFragmentIdentifier()->sameValueAs($url->getFragmentIdentifier())

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getFragmentIdentifier() does only exist in the following implementations of said interface: ValueObjects\Web\Url.

        ;
    }

    /**
     * Returns the domain of the Url
     *
     * @return Hostname|IPAddress
     */
    public function getDomain()
    {
        return clone $this->domain;
    }

    /**
     * Returns the fragment identifier of the Url
     *
     * @return FragmentIdentifier
     */
    public function getFragmentIdentifier()
    {
        return clone $this->fragmentIdentifier;
    }

    /**
     * Returns the password part of the Url
     *
     * @return String
     */
    public function getPassword()
    {
        return clone $this->password;
    }

    /**
     * Returns the path of the Url
     *
     * @return Path
     */
    public function getPath()
    {
        return clone $this->path;
    }

    /**
     * Returns the port of the Url
     *
     * @return PortNumberInterface
     */
    public function getPort()
    {
        return clone $this->port;
    }

    /**
     * Returns the query string of the Url
     *
     * @return QueryString
     */
    public function getQueryString()
    {
        return clone $this->queryString;
    }

    /**
     * Returns the scheme of the Url
     *
     * @return SchemeName
     */
    public function getScheme()
    {
        return clone $this->scheme;
    }

    /**
     * Returns the user part of the Url
     *
     * @return String
     */
    public function getUser()
    {
        return clone $this->user;
    }

    /**
     * Returns a string representation of the url
     *
     * @return string
     */
    public function __toString()
    {
        $userPass = '';
        if (false === $this->getUser()->isEmpty()) {
            $userPass = \sprintf('%s@', $this->getUser());

            if (false === $this->getPassword()->isEmpty()) {
                $userPass = \sprintf('%s:%s@', $this->getUser(), $this->getPassword());
            }
        }

        $port = '';
        if (false === NullPortNumber::create()->sameValueAs($this->getPort())) {
            $port = \sprintf(':%d', $this->getPort()->toNative());
        }

        $urlString = \sprintf('%s://%s%s%s%s%s%s', $this->getScheme(), $userPass, $this->getDomain(), $port, $this->getPath(), $this->getQueryString(), $this->getFragmentIdentifier());

        return $urlString;
    }

    function jsonSerialize()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for jsonSerialize.

    {
        return [
            'url' => (string) $this,
            'scheme' => $this->getScheme(),
            'user' => $this->getUser(),
            'password' => $this->getPassword(),
            'domain' => $this->getDomain(),
            'port' => $this->getPort(),
            'path' => $this->getPath(),
            'query' => $this->getQueryString(),
            'fragment' => $this->getFragmentIdentifier()
        ];
    }


}