ValueObjects\Geography\Street

Complexity

Total Complexity

18

Size/Duplication

Total Lines	151
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

86.27%

Importance

Changes	7
Bugs	1	Features	3

8 Methods

Rating	Name	Duplication	Size	Complexity
B	fromNative()	0	20	6
A	sameValueAs()	0	10	4
A	getName()	0	4	1
A	getNumber()	0	4	1
A	getElements()	0	4	1
A	__construct()	0	15	3
A	__toString()	0	12	1
A	jsonSerialize()	0	12	1

<?php

namespace ValueObjects\Geography;

use ValueObjects\StringLiteral\StringLiteral;
use ValueObjects\Util\Util;
use ValueObjects\ValueObjectInterface;

class Street implements ValueObjectInterface
{
    /** @var StringLiteral */
    protected $name;

    /** @var StringLiteral */
    protected $number;

    /** @var String Building, floor and unit */
    protected $elements;

    /**
     * @var String __toString() format
     * Use properties corresponding placeholders: %name%, %number%, %elements%
     */
    protected $format;

    /**
     * Returns a new Street from native PHP string name and number.
     *
     * @param string $name

There is no parameter named $name. Was it maybe removed?

     * @param string $number

There is no parameter named $number. Was it maybe removed?

     * @param string $elements

There is no parameter named $elements. Was it maybe removed?

     *
     * @return Street
     * @throws \BadFunctionCallException
     */
    public static function fromNative()
    {
        $args = func_get_args();

        if (\count($args) < 2) {
            throw new \BadMethodCallException('You must provide from 2 to 4 arguments: 1) street name, 2) street number, 3) elements, 4) format (optional)');
        }

        $nameString = $args[0];
        $numberString = $args[1];
        $elementsString = isset($args[2]) ? $args[2] : NULL;
        $formatString = isset($args[3]) ? $args[3] : NULL;

        $name = new StringLiteral($nameString);
        $number = new StringLiteral($numberString);
        $elements = $elementsString ? new StringLiteral($elementsString) : NULL;
        $format = $formatString ? new StringLiteral($formatString) : NULL;

        return new self($name, $number, $elements, $format);
    }

    /**
     * Returns a new Street object
     *
     * @param String $name
     * @param String $number
     */
    public function __construct(StringLiteral $name, StringLiteral $number, StringLiteral $elements = NULL, StringLiteral $format = NULL)
    {
        $this->name = $name;
        $this->number = $number;

        if ($elements === NULL) {
            $elements = new StringLiteral('');
        }
        $this->elements = $elements;

It seems like $elements of type object<ValueObjects\StringLiteral\StringLiteral> is incompatible with the declared type string of property $elements.

        if ($format === NULL) {
            $format = new StringLiteral('%number% %name%');
        }
        $this->format = $format;

It seems like $format of type object<ValueObjects\StringLiteral\StringLiteral> is incompatible with the declared type string of property $format.

    }

    /**
     * Tells whether two Street objects are equal
     *
     * @param  ValueObjectInterface $street
     *
     * @return bool
     */
    public function sameValueAs(ValueObjectInterface $street)
    {
        if (FALSE === Util::classEquals($this, $street)) {
            return FALSE;
        }

        return $this->getName()->sameValueAs($street->getName()) &&

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getName() does only exist in the following implementations of said interface: ValueObjects\DateTime\Month, ValueObjects\DateTime\TimeZone, ValueObjects\DateTime\WeekDay, ValueObjects\Enum\Enum, ValueObjects\Geography\Address, ValueObjects\Geography\Continent, ValueObjects\Geography\Country, ValueObjects\Geography\CountryCode, ValueObjects\Geography\DistanceFormula, ValueObjects\Geography\DistanceUnit, ValueObjects\Geography\Ellipsoid, ValueObjects\Geography\Street, ValueObjects\Money\CurrencyCode, ValueObjects\Number\RoundingMode, ValueObjects\Person\Gender, ValueObjects\Web\IPAddressVersion.

        $this->getNumber()->sameValueAs($street->getNumber()) &&

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getNumber() does only exist in the following implementations of said interface: ValueObjects\Geography\Street.

        $this->getElements()->sameValueAs($street->getElements());;

It seems like you code against a concrete implementation and not the interface ValueObjects\ValueObjectInterface as the method getElements() does only exist in the following implementations of said interface: ValueObjects\Geography\Street.

    }

    /**
     * Returns street name
     *
     * @return String
     */
    public function getName()
    {
        return clone $this->name;
    }

    /**
     * Returns street number
     *
     * @return String
     */
    public function getNumber()
    {
        return clone $this->number;
    }

    /**
     * Returns street elements
     *
     * @return String
     */
    public function getElements()
    {
        return clone $this->elements;
    }

    /**
     * Returns a string representation of the StringLiteral in the format defined in the constructor
     *
     * @return string
     */
    public function __toString()
    {
        $replacements = [
            "%name%"     => $this->getName(),
            "%number%"   => $this->getNumber(),
            "%elements%" => $this->getElements(),
        ];

        $streetString = str_replace(array_keys($replacements), array_values($replacements), $this->format);

        return $streetString;
    }

    function jsonSerialize()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for jsonSerialize.

    {
        return [
            'parts'     => [
                'name'     => $this->getName(),
                'number'   => $this->getNumber(),
                'elements' => $this->getElements(),
            ],
            'formatted' => (string)$this,
        ];

    }


}