Issues in timer.py - All Issues - Inspection of "Merge branch 'issue1535' into develop" - nicolargo/glances - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( d7cf39...faa4bd )

by Nicolas

created 2019-09-11 19:22 UTC

glances/timer.py (15 issues)

Labels

Severity

# -*- coding: utf-8 -*-
#
# This file is part of Glances.
#
# Copyright (C) 2019 Nicolargo <[email protected]>
#
# Glances is free software; you can redistribute it and/or modify
# it under the terms of the GNU Lesser General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# Glances is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.

"""The timer manager."""

from time import time

from datetime import datetime


# Global list to manage the elapsed time
last_update_times = {}



def getTimeSinceLastUpdate(IOType):

    """Return the elapsed time since last update."""
    global last_update_times

    # assert(IOType in ['net', 'disk', 'process_disk'])
    current_time = time()
    last_time = last_update_times.get(IOType)
    if not last_time:
        time_since_update = 1
    else:
        time_since_update = current_time - last_time
    last_update_times[IOType] = current_time
    return time_since_update


class Timer(object):

    """The timer class. A simple chronometer."""

    def __init__(self, duration):
        self.duration = duration
        self.start()

    def start(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.target = time() + self.duration

    def reset(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.start()

    def get(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return self.duration - (self.target - time())

    def set(self, duration):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.duration = duration

    def finished(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return time() > self.target


class Counter(object):

    """The counter class."""

    def __init__(self):
        self.start()

    def start(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.target = datetime.now()

    def reset(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.start()

    def get(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return (datetime.now() - self.target).total_seconds()


1			# -- coding: utf-8 --
2			#
3			# This file is part of Glances.
4			#
5			# Copyright (C) 2019 Nicolargo <[email protected]>
6			#
7			# Glances is free software; you can redistribute it and/or modify
8			# it under the terms of the GNU Lesser General Public License as published by
9			# the Free Software Foundation, either version 3 of the License, or
10			# (at your option) any later version.
11			#
12			# Glances is distributed in the hope that it will be useful,
13			# but WITHOUT ANY WARRANTY; without even the implied warranty of
14			# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			# GNU Lesser General Public License for more details.
16			#
17			# You should have received a copy of the GNU Lesser General Public License
18			# along with this program. If not, see <http://www.gnu.org/licenses/>.
19
20			"""The timer manager."""
21
22			from time import time
			0 ignored issues – show introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this import missing `from __future__ import absolute_import` Loading history...
23			from datetime import datetime
			0 ignored issues – show introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this import missing `from __future__ import absolute_import` Loading history...
24
25			# Global list to manage the elapsed time
26			last_update_times = {}
			0 ignored issues – show Coding Style Naming introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `last_update_times` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
27
28
29			def getTimeSinceLastUpdate(IOType):
			0 ignored issues – show Coding Style Naming introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `getTimeSinceLastUpdate` does not conform to the function naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style Naming introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `IOType` does not conform to the argument naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
30			"""Return the elapsed time since last update."""
31			global last_update_times
			0 ignored issues – show Coding Style introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of the `global` statement should be avoided. Usage of `global` can make code hard to read and test, its usage is generally not recommended unless you are dealing with legacy code. Loading history... Coding Style Naming introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `last_update_times` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
32			# assert(IOType in ['net', 'disk', 'process_disk'])
33			current_time = time()
34			last_time = last_update_times.get(IOType)
35			if not last_time:
36			time_since_update = 1
37			else:
38			time_since_update = current_time - last_time
39			last_update_times[IOType] = current_time
40			return time_since_update
41
42
43			class Timer(object):
44
45			"""The timer class. A simple chronometer."""
46
47			def __init__(self, duration):
48			self.duration = duration
49			self.start()
50
51			def start(self):
			0 ignored issues – show Coding Style introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
52			self.target = time() + self.duration
53
54			def reset(self):
			0 ignored issues – show Coding Style introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
55			self.start()
56
57			def get(self):
			0 ignored issues – show Coding Style introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
58			return self.duration - (self.target - time())
59
60			def set(self, duration):
			0 ignored issues – show Coding Style introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
61			self.duration = duration
62
63			def finished(self):
			0 ignored issues – show Coding Style introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
64			return time() > self.target
65
66
67			class Counter(object):
68
69			"""The counter class."""
70
71			def __init__(self):
72			self.start()
73
74			def start(self):
			0 ignored issues – show Coding Style introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
75			self.target = datetime.now()
76
77			def reset(self):
			0 ignored issues – show Coding Style introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
78			self.start()
79
80			def get(self):
			0 ignored issues – show Coding Style introduced 2018-11-11 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
81			return (datetime.now() - self.target).total_seconds()
82

nicolargo / glances

Push — develop ( d7cf39...faa4bd )

glances/timer.py (15 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like