| Conditions | 2 |
| Total Lines | 77 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | # -*- coding: utf-8 -*- |
||
| 101 | def msg_curse(self, args=None): |
||
| 102 | """Return the list to display in the curse interface.""" |
||
| 103 | # Init the return message |
||
| 104 | ret = [] |
||
| 105 | |||
| 106 | # Build the string message |
||
| 107 | # Header |
||
| 108 | ret.append(self.curse_add_line(self.view_data['version'], 'TITLE')) |
||
| 109 | ret.append(self.curse_add_line(self.view_data['psutil_version'])) |
||
| 110 | ret.append(self.curse_new_line()) |
||
| 111 | |||
| 112 | # Configuration file path |
||
| 113 | if 'configuration_file' in self.view_data: |
||
| 114 | ret.append(self.curse_new_line()) |
||
| 115 | ret.append(self.curse_add_line(self.view_data['configuration_file'])) |
||
| 116 | ret.append(self.curse_new_line()) |
||
| 117 | |||
| 118 | # Keys |
||
| 119 | ret.append(self.curse_new_line()) |
||
| 120 | ret.append(self.curse_add_line(self.view_data['sort_auto'])) |
||
| 121 | ret.append(self.curse_add_line(self.view_data['sort_network'])) |
||
| 122 | ret.append(self.curse_new_line()) |
||
| 123 | ret.append(self.curse_add_line(self.view_data['sort_cpu'])) |
||
| 124 | ret.append(self.curse_add_line(self.view_data['show_hide_alert'])) |
||
| 125 | ret.append(self.curse_new_line()) |
||
| 126 | |||
| 127 | ret.append(self.curse_add_line(self.view_data['sort_mem'])) |
||
| 128 | ret.append(self.curse_add_line(self.view_data['delete_warning_alerts'])) |
||
| 129 | ret.append(self.curse_new_line()) |
||
| 130 | ret.append(self.curse_add_line(self.view_data['sort_user'])) |
||
| 131 | ret.append(self.curse_add_line(self.view_data['delete_warning_critical_alerts'])) |
||
| 132 | ret.append(self.curse_new_line()) |
||
| 133 | ret.append(self.curse_add_line(self.view_data['sort_proc'])) |
||
| 134 | ret.append(self.curse_add_line(self.view_data['percpu'])) |
||
| 135 | ret.append(self.curse_new_line()) |
||
| 136 | ret.append(self.curse_add_line(self.view_data['sort_io'])) |
||
| 137 | ret.append(self.curse_add_line(self.view_data['show_hide_ip'])) |
||
| 138 | ret.append(self.curse_new_line()) |
||
| 139 | ret.append(self.curse_add_line(self.view_data['sort_cpu_times'])) |
||
| 140 | ret.append(self.curse_add_line(self.view_data['enable_disable_docker'])) |
||
| 141 | ret.append(self.curse_new_line()) |
||
| 142 | ret.append(self.curse_add_line(self.view_data['show_hide_diskio'])) |
||
| 143 | ret.append(self.curse_add_line(self.view_data['view_network_io_combination'])) |
||
| 144 | ret.append(self.curse_new_line()) |
||
| 145 | ret.append(self.curse_add_line(self.view_data['show_hide_filesystem'])) |
||
| 146 | ret.append(self.curse_add_line(self.view_data['view_cumulative_network'])) |
||
| 147 | ret.append(self.curse_new_line()) |
||
| 148 | ret.append(self.curse_add_line(self.view_data['show_hide_network'])) |
||
| 149 | ret.append(self.curse_add_line(self.view_data['show_hide_filesytem_freespace'])) |
||
| 150 | ret.append(self.curse_new_line()) |
||
| 151 | ret.append(self.curse_add_line(self.view_data['show_hide_sensors'])) |
||
| 152 | ret.append(self.curse_add_line(self.view_data['generate_graphs'])) |
||
| 153 | ret.append(self.curse_new_line()) |
||
| 154 | ret.append(self.curse_add_line(self.view_data['show_hide_left_sidebar'])) |
||
| 155 | ret.append(self.curse_add_line(self.view_data['reset_history'])) |
||
| 156 | ret.append(self.curse_new_line()) |
||
| 157 | ret.append(self.curse_add_line(self.view_data['enable_disable_process_stats'])) |
||
| 158 | ret.append(self.curse_add_line(self.view_data['show_hide_help'])) |
||
| 159 | ret.append(self.curse_new_line()) |
||
| 160 | ret.append(self.curse_add_line(self.view_data['enable_disable_quick_look'])) |
||
| 161 | ret.append(self.curse_add_line(self.view_data['diskio_iops'])) |
||
| 162 | ret.append(self.curse_new_line()) |
||
| 163 | ret.append(self.curse_add_line(self.view_data['enable_disable_top_extends_stats'])) |
||
| 164 | ret.append(self.curse_add_line(self.view_data['show_hide_top_menu'])) |
||
| 165 | ret.append(self.curse_new_line()) |
||
| 166 | ret.append(self.curse_add_line(self.view_data['enable_disable_short_processname'])) |
||
| 167 | ret.append(self.curse_new_line()) |
||
| 168 | ret.append(self.curse_add_line(self.view_data['enable_disable_irix'])) |
||
| 169 | ret.append(self.curse_add_line(self.view_data['quit'])) |
||
| 170 | ret.append(self.curse_new_line()) |
||
| 171 | |||
| 172 | ret.append(self.curse_new_line()) |
||
| 173 | |||
| 174 | ret.append(self.curse_add_line(self.view_data['edit_pattern_filter'])) |
||
| 175 | |||
| 176 | # Return the message with decoration |
||
| 177 | return ret |
||
| 178 |