glances.exports.glances_elasticsearch

Complexity

Total Complexity

11

Size/Duplication

Total Lines	139
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	Export.__init__()	0	19	2
B	Export.init()	0	55	6
A	Export.export()	0	28	3

# -*- coding: utf-8 -*-
#
# This file is part of Glances.
#
# Copyright (C) 2019 Nicolargo <nicolas@nicolargo.com>
#
# Glances is free software; you can redistribute it and/or modify
# it under the terms of the GNU Lesser General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# Glances is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.

"""ElasticSearch interface class."""

import sys

import missing from __future__ import absolute_import

from datetime import datetime

import missing from __future__ import absolute_import

from glances.logger import logger

import missing from __future__ import absolute_import

from glances.exports.glances_export import GlancesExport

import missing from __future__ import absolute_import

from elasticsearch import Elasticsearch, helpers

import missing from __future__ import absolute_import

Unable to import 'elasticsearch'

class Export(GlancesExport):

    """This class manages the ElasticSearch (ES) export module."""

    def __init__(self, config=None, args=None):
        """Init the ES export IF."""
        super(Export, self).__init__(config=config, args=args)

        # Mandatories configuration keys (additional to host and port)
        self.index = None

        # Optionals configuration keys
        # N/A

        # Load the ES configuration file
        self.export_enable = self.load_conf('elasticsearch',
                                            mandatories=['host', 'port', 'index'],

This line is too long as per the coding-style (82/80).

                                            options=[])
        if not self.export_enable:
            sys.exit(2)

        # Init the ES client
        self.client = self.init()

    def init(self):
        """Init the connection to the ES server."""
        if not self.export_enable:
            return None

        self.index='{}-{}'.format(self.index, datetime.utcnow().strftime("%Y.%m.%d"))

This line is too long as per the coding-style (85/80).

Exactly one space required around assignment

        template_body =  {

Exactly one space required after assignment

          "mappings": {

Wrong hanging indentation (add 2 spaces).

            "glances": {

Wrong hanging indentation (add 2 spaces).

              "dynamic_templates": [

Wrong hanging indentation (add 2 spaces).

                {

Wrong hanging indentation (add 2 spaces).

                  "integers": {

Wrong hanging indentation (add 2 spaces).

                    "match_mapping_type": "long",

Wrong hanging indentation (add 2 spaces).

                    "mapping": {

Wrong hanging indentation (add 2 spaces).

                      "type": "integer"

Wrong hanging indentation (add 2 spaces).

                    }
                  }
                },
                {

Wrong hanging indentation (add 2 spaces).

                  "strings": {

Wrong hanging indentation (add 2 spaces).

                    "match_mapping_type": "string",

Wrong hanging indentation (add 2 spaces).

                    "mapping": {

Wrong hanging indentation (add 2 spaces).

                      "type": "text",

Wrong hanging indentation (add 2 spaces).

                      "fields": {

Wrong hanging indentation (add 2 spaces).

                        "raw": {

Wrong hanging indentation (add 2 spaces).

                          "type":  "keyword",

Wrong hanging indentation (add 2 spaces).

                          "ignore_above": 256

Wrong hanging indentation (add 2 spaces).

                        }
                      }
                    }
                  }
                }
              ]
            }
          }
        }

        try:
            es = Elasticsearch(hosts=['{}:{}'.format(self.host, self.port)])

The name es does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            logger.critical("Cannot connect to ElasticSearch server %s:%s (%s)" % (self.host, self.port, e))

This line is too long as per the coding-style (108/80).

Specify string format arguments as logging function parameters

            sys.exit(2)
        else:
            logger.info("Connected to the ElasticSearch server %s:%s" % (self.host, self.port))

This line is too long as per the coding-style (95/80).

Specify string format arguments as logging function parameters

        try:
            index_count = es.count(index=self.index)['count']
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            # Index did not exist, it will be created at the first write
            # Create it...
            es.indices.create(index=self.index,body=template_body)

Exactly one space required after comma

        else:
            logger.info("The index %s exists and holds %s entries." % (self.index, index_count))

This line is too long as per the coding-style (96/80).

Specify string format arguments as logging function parameters

        return es

    def export(self, name, columns, points):
        """Write the points to the ES server."""
        logger.debug("Export {} stats to ElasticSearch".format(name))

Use formatting in logging functions and pass the parameters as arguments

        # Create DB input
        # https://elasticsearch-py.readthedocs.io/en/master/helpers.html
        actions = []
        for c, p in zip(columns, points):

The name c does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name p does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            dtnow = datetime.utcnow()
            action = {
                "_index": self.index,
                "_id": '{}.{}'.format(name,c),

Exactly one space required after comma

                "_type": "glances",
                "_source": {
                    "plugin": name,
                    "metric": c,
                    "value": str(p),
                    "timestamp": dtnow.isoformat('T')
                }
            }
            logger.debug("Exporting the following object to elasticsearch: {}".format(action))

This line is too long as per the coding-style (94/80).

Use formatting in logging functions and pass the parameters as arguments

            actions.append(action)

        # Write input to the ES index
        try:
            helpers.bulk(self.client, actions)
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            logger.error("Cannot export {} stats to ElasticSearch ({})".format(name, e))

This line is too long as per the coding-style (88/80).

Use formatting in logging functions and pass the parameters as arguments