Issues in Training_Resource.php - New Issues - Inspection of "Update/Insert ... DB and news logos" - nicolaeturcan/trainingresourceapp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Paolo

created 2016-02-23 15:06 UTC

app/admin/Training_Resource.php (8 issues)

Labels

Severity

Minor 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

Admin::model('\App\Training_Resource')->title('Recursos de formació')->with()->filters(function ()
{

})->columns(function ()
{
    //Column::image('training_resource_thumbnail');

    Column::string('training_resource_id', 'ID');
	Column::string('training_resource_name', 'Nom');
	//Column::string('training_resource_short_name', 'Nom Curt');

	Column::string('training_resource_description', 'Descripció');
	//Column::string('training_resource_external_url', 'URL');

    //Column::string('training_resource_name', 'Pare')->append(Column::where('training_resource_id', '=', 'training_resource_parentResourceId'));

    Column::string('parent.training_resource_name', 'Pare');

})->form(function ()
{
	FormItem::text('training_resource_name', 'Nom')->required();
	FormItem::text('training_resource_short_name', 'Nom Curt');
	FormItem::image('training_resource_thumbnail', 'Imatge');
	FormItem::text('training_resource_external_url', 'URL Externa');
    FormItem::select('training_resource_parentResourceId', 'Pare')->list('\App\Training_Resource')->nullable();
	//FormItem::timestamp('training_resource_entryDate', 'Data Creació');//->seconds(true);

	//FormItem::timestamp('training_resource_last_update', 'Data de l\'última modificació');//->seconds(true);
    FormItem::checkbox('training_resource_softDeleted', 'SoftDeleted');
    FormItem::ckeditor('training_resource_description', 'Descripció');



	//FormItem::text('training_resource_creationUserId', 'Training Resource Creation User Id');

	//FormItem::text('training_resource_lastupdateUserId', 'Training Resource Lastupdate User Id');


    //FormItem::timestamp('training_resource_softDeletedDate', 'Training Resource Soft Deleted Date');//->seconds(true);

});

1			<?php
2
3			Admin::model('\App\Training_Resource')->title('Recursos de formació')->with()->filters(function ()
4			{
5
6			})->columns(function ()
7			{
8			//Column::image('training_resource_thumbnail');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-23 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
9			Column::string('training_resource_id', 'ID');
10			Column::string('training_resource_name', 'Nom');
11			//Column::string('training_resource_short_name', 'Nom Curt');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-23 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
12			Column::string('training_resource_description', 'Descripció');
13			//Column::string('training_resource_external_url', 'URL');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-23 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
14			//Column::string('training_resource_name', 'Pare')->append(Column::where('training_resource_id', '=', 'training_resource_parentResourceId'));
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-23 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
15			Column::string('parent.training_resource_name', 'Pare');
16
17			})->form(function ()
18			{
19			FormItem::text('training_resource_name', 'Nom')->required();
20			FormItem::text('training_resource_short_name', 'Nom Curt');
21			FormItem::image('training_resource_thumbnail', 'Imatge');
22			FormItem::text('training_resource_external_url', 'URL Externa');
23			FormItem::select('training_resource_parentResourceId', 'Pare')->list('\App\Training_Resource')->nullable();
24			//FormItem::timestamp('training_resource_entryDate', 'Data Creació');//->seconds(true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-23 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `80%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
25			//FormItem::timestamp('training_resource_last_update', 'Data de l\'última modificació');//->seconds(true);
26			FormItem::checkbox('training_resource_softDeleted', 'SoftDeleted');
27			FormItem::ckeditor('training_resource_description', 'Descripció');
28
29
30
31			//FormItem::text('training_resource_creationUserId', 'Training Resource Creation User Id');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-23 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
32			//FormItem::text('training_resource_lastupdateUserId', 'Training Resource Lastupdate User Id');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-23 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33
34			//FormItem::timestamp('training_resource_softDeletedDate', 'Training Resource Soft Deleted Date');//->seconds(true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-23 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `80%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
35			});

nicolaeturcan / trainingresourceapp

Pull Request — master (#4)

app/admin/Training_Resource.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like