Stichoza\GoogleTranslate\Tests\UtilityTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	testSetHttpOption()	0	24	1
A	testIsValidLocale()	0	18	2

<?php

namespace Stichoza\GoogleTranslate\Tests;

use ReflectionClass;
use Stichoza\GoogleTranslate\TranslateClient;

class UtilityTest extends \PHPUnit_Framework_TestCase

The type PHPUnit_Framework_TestCase was not found. Maybe you did not declare it correctly or list all dependencies?

{
    public function setUp()
    {
        $this->tr = new TranslateClient();

The property tr does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $reflection = new ReflectionClass(get_class($this->tr));
        $this->method = $reflection->getMethod('isValidLocale');

The property method does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->method->setAccessible(true);
    }

    public function testIsValidLocale()
    {
        $m = $this->method;
        $t = $this->tr;

        $booleanAssertions = [
            'ab'      => true,
            'ab-CD'   => true,
            'ab-CDE'  => false,
            'abc-DE'  => false,
            'abc-DEF' => false,
            'abc'     => false,
            'ab-'     => false,
            'a'       => false,
        ];

        foreach ($booleanAssertions as $key => $value) {
            $this->assertEquals($m->invokeArgs($t, [$key]), $value);
        }
    }

    public function testSetHttpOption()
    {
        $res = fopen('php://memory', 'r+');

        $this->tr->setHttpOption([
            'debug'   => $res,
            'headers' => [
                'User-Agent' => 'Foo',
            ],
        ])->translate('hello');
        rewind($res);

It seems like $res can also be of type false; however, parameter $handle of rewind() does only seem to accept resource, maybe add an additional type check?

        $output = str_replace("\r", '', stream_get_contents($res));

It seems like $res can also be of type false; however, parameter $handle of stream_get_contents() does only seem to accept resource, maybe add an additional type check?

        $this->assertContains('User-Agent: Foo', $output);

        $this->tr->setHttpOption([
            'debug'   => $res,
            'headers' => [
                'User-Agent' => 'Bar',
            ],
        ])->translate('world');
        rewind($res);
        $output = str_replace("\r", '', stream_get_contents($res));
        $this->assertContains('User-Agent: Bar', $output);
        fclose($res);

It seems like $res can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

    }
}